* [PATCH 01/14] mfd: 88pm800: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:46 ` Lee Jones
2019-07-22 17:26 ` [PATCH 02/14] mfd: 88pm860x-core: " Wolfram Sang
` (12 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/88pm800.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
index f2d9fb4c4e8e..4e8d0d6b9b5c 100644
--- a/drivers/mfd/88pm800.c
+++ b/drivers/mfd/88pm800.c
@@ -425,10 +425,10 @@ static int pm800_pages_init(struct pm80x_chip *chip)
return -ENODEV;
/* PM800 block power page */
- subchip->power_page = i2c_new_dummy(client->adapter,
+ subchip->power_page = i2c_new_dummy_device(client->adapter,
subchip->power_page_addr);
- if (subchip->power_page == NULL) {
- ret = -ENODEV;
+ if (IS_ERR(subchip->power_page)) {
+ ret = PTR_ERR(subchip->power_page);
goto out;
}
@@ -444,10 +444,10 @@ static int pm800_pages_init(struct pm80x_chip *chip)
i2c_set_clientdata(subchip->power_page, chip);
/* PM800 block GPADC */
- subchip->gpadc_page = i2c_new_dummy(client->adapter,
+ subchip->gpadc_page = i2c_new_dummy_device(client->adapter,
subchip->gpadc_page_addr);
- if (subchip->gpadc_page == NULL) {
- ret = -ENODEV;
+ if (IS_ERR(subchip->gpadc_page)) {
+ ret = PTR_ERR(subchip->gpadc_page);
goto out;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 01/14] mfd: 88pm800: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 01/14] mfd: 88pm800: convert to i2c_new_dummy_device Wolfram Sang
@ 2019-08-12 7:46 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:46 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/88pm800.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 02/14] mfd: 88pm860x-core: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
2019-07-22 17:26 ` [PATCH 01/14] mfd: 88pm800: convert to i2c_new_dummy_device Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:46 ` Lee Jones
2019-07-22 17:26 ` [PATCH 03/14] mfd: ab3100-core: " Wolfram Sang
` (11 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/88pm860x-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/88pm860x-core.c b/drivers/mfd/88pm860x-core.c
index 9e0bd135730f..c9bae71f643a 100644
--- a/drivers/mfd/88pm860x-core.c
+++ b/drivers/mfd/88pm860x-core.c
@@ -1178,12 +1178,12 @@ static int pm860x_probe(struct i2c_client *client)
*/
if (pdata->companion_addr && (pdata->companion_addr != client->addr)) {
chip->companion_addr = pdata->companion_addr;
- chip->companion = i2c_new_dummy(chip->client->adapter,
+ chip->companion = i2c_new_dummy_device(chip->client->adapter,
chip->companion_addr);
- if (!chip->companion) {
+ if (IS_ERR(chip->companion)) {
dev_err(&client->dev,
"Failed to allocate I2C companion device\n");
- return -ENODEV;
+ return PTR_ERR(chip->companion);
}
chip->regmap_companion = regmap_init_i2c(chip->companion,
&pm860x_regmap_config);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 02/14] mfd: 88pm860x-core: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 02/14] mfd: 88pm860x-core: " Wolfram Sang
@ 2019-08-12 7:46 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:46 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/88pm860x-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 03/14] mfd: ab3100-core: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
2019-07-22 17:26 ` [PATCH 01/14] mfd: 88pm800: convert to i2c_new_dummy_device Wolfram Sang
2019-07-22 17:26 ` [PATCH 02/14] mfd: 88pm860x-core: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-07-23 8:30 ` Linus Walleij
2019-08-12 7:46 ` Lee Jones
2019-07-22 17:26 ` [PATCH 04/14] mfd: bcm590xx: " Wolfram Sang
` (10 subsequent siblings)
13 siblings, 2 replies; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Linus Walleij, Lee Jones, linux-arm-kernel, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/ab3100-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/ab3100-core.c b/drivers/mfd/ab3100-core.c
index e350ab64238e..7e007df857b8 100644
--- a/drivers/mfd/ab3100-core.c
+++ b/drivers/mfd/ab3100-core.c
@@ -896,10 +896,10 @@ static int ab3100_probe(struct i2c_client *client,
&ab3100->chip_name[0]);
/* Attach a second dummy i2c_client to the test register address */
- ab3100->testreg_client = i2c_new_dummy(client->adapter,
+ ab3100->testreg_client = i2c_new_dummy_device(client->adapter,
client->addr + 1);
- if (!ab3100->testreg_client) {
- err = -ENOMEM;
+ if (IS_ERR(ab3100->testreg_client)) {
+ err = PTR_ERR(ab3100->testreg_client);
goto exit_no_testreg_client;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 03/14] mfd: ab3100-core: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 03/14] mfd: ab3100-core: " Wolfram Sang
@ 2019-07-23 8:30 ` Linus Walleij
2019-08-12 7:46 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Linus Walleij @ 2019-07-23 8:30 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Lee Jones, Linux ARM, linux-kernel
On Mon, Jul 22, 2019 at 7:26 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 03/14] mfd: ab3100-core: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 03/14] mfd: ab3100-core: " Wolfram Sang
2019-07-23 8:30 ` Linus Walleij
@ 2019-08-12 7:46 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:46 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Linus Walleij, linux-arm-kernel, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/ab3100-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 04/14] mfd: bcm590xx: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (2 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 03/14] mfd: ab3100-core: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 05/14] mfd: da9150-core: " Wolfram Sang
` (9 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/bcm590xx.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c
index 1aeb5e498d91..bfac5dc091ca 100644
--- a/drivers/mfd/bcm590xx.c
+++ b/drivers/mfd/bcm590xx.c
@@ -61,11 +61,11 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri,
}
/* Secondary I2C slave address is the base address with A(2) asserted */
- bcm590xx->i2c_sec = i2c_new_dummy(i2c_pri->adapter,
+ bcm590xx->i2c_sec = i2c_new_dummy_device(i2c_pri->adapter,
i2c_pri->addr | BIT(2));
- if (!bcm590xx->i2c_sec) {
+ if (IS_ERR(bcm590xx->i2c_sec)) {
dev_err(&i2c_pri->dev, "failed to add secondary I2C device\n");
- return -ENODEV;
+ return PTR_ERR(bcm590xx->i2c_sec);
}
i2c_set_clientdata(bcm590xx->i2c_sec, bcm590xx);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 04/14] mfd: bcm590xx: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 04/14] mfd: bcm590xx: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/bcm590xx.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 05/14] mfd: da9150-core: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (3 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 04/14] mfd: bcm590xx: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 06/14] mfd: max14577: " Wolfram Sang
` (8 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Support Opensource, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/da9150-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/da9150-core.c b/drivers/mfd/da9150-core.c
index 13033068721a..7f0aa1e8db96 100644
--- a/drivers/mfd/da9150-core.c
+++ b/drivers/mfd/da9150-core.c
@@ -420,10 +420,10 @@ static int da9150_probe(struct i2c_client *client,
qif_addr = da9150_reg_read(da9150, DA9150_CORE2WIRE_CTRL_A);
qif_addr = (qif_addr & DA9150_CORE_BASE_ADDR_MASK) >> 1;
qif_addr |= DA9150_QIF_I2C_ADDR_LSB;
- da9150->core_qif = i2c_new_dummy(client->adapter, qif_addr);
- if (!da9150->core_qif) {
+ da9150->core_qif = i2c_new_dummy_device(client->adapter, qif_addr);
+ if (IS_ERR(da9150->core_qif)) {
dev_err(da9150->dev, "Failed to attach QIF client\n");
- return -ENODEV;
+ return PTR_ERR(da9150->core_qif);
}
i2c_set_clientdata(da9150->core_qif, da9150);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 05/14] mfd: da9150-core: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 05/14] mfd: da9150-core: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Support Opensource, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/da9150-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 06/14] mfd: max14577: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (4 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 05/14] mfd: da9150-core: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-07-23 17:35 ` Krzysztof Kozlowski
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 07/14] mfd: max77693: " Wolfram Sang
` (7 subsequent siblings)
13 siblings, 2 replies; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Chanwoo Choi, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max14577.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index ebb13d5de530..fd8864cafd25 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -297,11 +297,11 @@ static int max77836_init(struct max14577 *max14577)
int ret;
u8 intsrc_mask;
- max14577->i2c_pmic = i2c_new_dummy(max14577->i2c->adapter,
+ max14577->i2c_pmic = i2c_new_dummy_device(max14577->i2c->adapter,
I2C_ADDR_PMIC);
- if (!max14577->i2c_pmic) {
+ if (IS_ERR(max14577->i2c_pmic)) {
dev_err(max14577->dev, "Failed to register PMIC I2C device\n");
- return -ENODEV;
+ return PTR_ERR(max14577->i2c_pmic);
}
i2c_set_clientdata(max14577->i2c_pmic, max14577);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 06/14] mfd: max14577: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 06/14] mfd: max14577: " Wolfram Sang
@ 2019-07-23 17:35 ` Krzysztof Kozlowski
2019-08-12 7:47 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-23 17:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Chanwoo Choi, Bartlomiej Zolnierkiewicz, Lee Jones,
linux-kernel
On Mon, Jul 22, 2019 at 07:26:13PM +0200, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
I do not have the HW for testing anymore but looks good:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 06/14] mfd: max14577: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 06/14] mfd: max14577: " Wolfram Sang
2019-07-23 17:35 ` Krzysztof Kozlowski
@ 2019-08-12 7:47 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Chanwoo Choi, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max14577.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 07/14] mfd: max77693: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (5 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 06/14] mfd: max14577: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-07-23 17:35 ` Krzysztof Kozlowski
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 08/14] mfd: max77843: " Wolfram Sang
` (6 subsequent siblings)
13 siblings, 2 replies; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Chanwoo Choi, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max77693.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c
index 901d99d65924..596ed85cab3b 100644
--- a/drivers/mfd/max77693.c
+++ b/drivers/mfd/max77693.c
@@ -183,17 +183,17 @@ static int max77693_i2c_probe(struct i2c_client *i2c,
} else
dev_info(max77693->dev, "device ID: 0x%x\n", reg_data);
- max77693->i2c_muic = i2c_new_dummy(i2c->adapter, I2C_ADDR_MUIC);
- if (!max77693->i2c_muic) {
+ max77693->i2c_muic = i2c_new_dummy_device(i2c->adapter, I2C_ADDR_MUIC);
+ if (IS_ERR(max77693->i2c_muic)) {
dev_err(max77693->dev, "Failed to allocate I2C device for MUIC\n");
- return -ENODEV;
+ return PTR_ERR(max77693->i2c_muic);
}
i2c_set_clientdata(max77693->i2c_muic, max77693);
- max77693->i2c_haptic = i2c_new_dummy(i2c->adapter, I2C_ADDR_HAPTIC);
- if (!max77693->i2c_haptic) {
+ max77693->i2c_haptic = i2c_new_dummy_device(i2c->adapter, I2C_ADDR_HAPTIC);
+ if (IS_ERR(max77693->i2c_haptic)) {
dev_err(max77693->dev, "Failed to allocate I2C device for Haptic\n");
- ret = -ENODEV;
+ ret = PTR_ERR(max77693->i2c_haptic);
goto err_i2c_haptic;
}
i2c_set_clientdata(max77693->i2c_haptic, max77693);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 07/14] mfd: max77693: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 07/14] mfd: max77693: " Wolfram Sang
@ 2019-07-23 17:35 ` Krzysztof Kozlowski
2019-08-12 7:47 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Krzysztof Kozlowski @ 2019-07-23 17:35 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Chanwoo Choi, Bartlomiej Zolnierkiewicz, Lee Jones,
linux-kernel
On Mon, Jul 22, 2019 at 07:26:14PM +0200, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max77693.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 32+ messages in thread
* Re: [PATCH 07/14] mfd: max77693: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 07/14] mfd: max77693: " Wolfram Sang
2019-07-23 17:35 ` Krzysztof Kozlowski
@ 2019-08-12 7:47 ` Lee Jones
1 sibling, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c, Chanwoo Choi, Krzysztof Kozlowski,
Bartlomiej Zolnierkiewicz, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max77693.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 08/14] mfd: max77843: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (6 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 07/14] mfd: max77693: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 09/14] mfd: max8907: " Wolfram Sang
` (5 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max77843.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/max77843.c b/drivers/mfd/max77843.c
index 25cbb2242b26..209ee24d9ce1 100644
--- a/drivers/mfd/max77843.c
+++ b/drivers/mfd/max77843.c
@@ -70,11 +70,11 @@ static int max77843_chg_init(struct max77693_dev *max77843)
{
int ret;
- max77843->i2c_chg = i2c_new_dummy(max77843->i2c->adapter, I2C_ADDR_CHG);
- if (!max77843->i2c_chg) {
+ max77843->i2c_chg = i2c_new_dummy_device(max77843->i2c->adapter, I2C_ADDR_CHG);
+ if (IS_ERR(max77843->i2c_chg)) {
dev_err(&max77843->i2c->dev,
"Cannot allocate I2C device for Charger\n");
- return -ENODEV;
+ return PTR_ERR(max77843->i2c_chg);
}
i2c_set_clientdata(max77843->i2c_chg, max77843);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 08/14] mfd: max77843: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 08/14] mfd: max77843: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max77843.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 09/14] mfd: max8907: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (7 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 08/14] mfd: max77843: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 10/14] mfd: max8925-i2c: " Wolfram Sang
` (4 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max8907.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/max8907.c b/drivers/mfd/max8907.c
index cc01f706cb32..d44baafd9d14 100644
--- a/drivers/mfd/max8907.c
+++ b/drivers/mfd/max8907.c
@@ -214,9 +214,9 @@ static int max8907_i2c_probe(struct i2c_client *i2c,
goto err_regmap_gen;
}
- max8907->i2c_rtc = i2c_new_dummy(i2c->adapter, MAX8907_RTC_I2C_ADDR);
- if (!max8907->i2c_rtc) {
- ret = -ENOMEM;
+ max8907->i2c_rtc = i2c_new_dummy_device(i2c->adapter, MAX8907_RTC_I2C_ADDR);
+ if (IS_ERR(max8907->i2c_rtc)) {
+ ret = PTR_ERR(max8907->i2c_rtc);
goto err_dummy_rtc;
}
i2c_set_clientdata(max8907->i2c_rtc, max8907);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 09/14] mfd: max8907: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 09/14] mfd: max8907: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max8907.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 10/14] mfd: max8925-i2c: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (8 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 09/14] mfd: max8907: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 11/14] mfd: max8997: " Wolfram Sang
` (3 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max8925-i2c.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/mfd/max8925-i2c.c b/drivers/mfd/max8925-i2c.c
index 20bb19b71109..114e905bef25 100644
--- a/drivers/mfd/max8925-i2c.c
+++ b/drivers/mfd/max8925-i2c.c
@@ -176,18 +176,18 @@ static int max8925_probe(struct i2c_client *client,
dev_set_drvdata(chip->dev, chip);
mutex_init(&chip->io_lock);
- chip->rtc = i2c_new_dummy(chip->i2c->adapter, RTC_I2C_ADDR);
- if (!chip->rtc) {
+ chip->rtc = i2c_new_dummy_device(chip->i2c->adapter, RTC_I2C_ADDR);
+ if (IS_ERR(chip->rtc)) {
dev_err(chip->dev, "Failed to allocate I2C device for RTC\n");
- return -ENODEV;
+ return PTR_ERR(chip->rtc);
}
i2c_set_clientdata(chip->rtc, chip);
- chip->adc = i2c_new_dummy(chip->i2c->adapter, ADC_I2C_ADDR);
- if (!chip->adc) {
+ chip->adc = i2c_new_dummy_device(chip->i2c->adapter, ADC_I2C_ADDR);
+ if (IS_ERR(chip->adc)) {
dev_err(chip->dev, "Failed to allocate I2C device for ADC\n");
i2c_unregister_device(chip->rtc);
- return -ENODEV;
+ return PTR_ERR(chip->adc);
}
i2c_set_clientdata(chip->adc, chip);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 10/14] mfd: max8925-i2c: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 10/14] mfd: max8925-i2c: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max8925-i2c.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 11/14] mfd: max8997: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (9 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 10/14] mfd: max8925-i2c: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:47 ` Lee Jones
2019-07-22 17:26 ` [PATCH 12/14] mfd: max8998: " Wolfram Sang
` (2 subsequent siblings)
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max8997.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/max8997.c b/drivers/mfd/max8997.c
index 8c06c09e36d1..68d8f2b95287 100644
--- a/drivers/mfd/max8997.c
+++ b/drivers/mfd/max8997.c
@@ -185,25 +185,25 @@ static int max8997_i2c_probe(struct i2c_client *i2c,
mutex_init(&max8997->iolock);
- max8997->rtc = i2c_new_dummy(i2c->adapter, I2C_ADDR_RTC);
- if (!max8997->rtc) {
+ max8997->rtc = i2c_new_dummy_device(i2c->adapter, I2C_ADDR_RTC);
+ if (IS_ERR(max8997->rtc)) {
dev_err(max8997->dev, "Failed to allocate I2C device for RTC\n");
- return -ENODEV;
+ return PTR_ERR(max8997->rtc);
}
i2c_set_clientdata(max8997->rtc, max8997);
- max8997->haptic = i2c_new_dummy(i2c->adapter, I2C_ADDR_HAPTIC);
- if (!max8997->haptic) {
+ max8997->haptic = i2c_new_dummy_device(i2c->adapter, I2C_ADDR_HAPTIC);
+ if (IS_ERR(max8997->haptic)) {
dev_err(max8997->dev, "Failed to allocate I2C device for Haptic\n");
- ret = -ENODEV;
+ ret = PTR_ERR(max8997->haptic);
goto err_i2c_haptic;
}
i2c_set_clientdata(max8997->haptic, max8997);
- max8997->muic = i2c_new_dummy(i2c->adapter, I2C_ADDR_MUIC);
- if (!max8997->muic) {
+ max8997->muic = i2c_new_dummy_device(i2c->adapter, I2C_ADDR_MUIC);
+ if (IS_ERR(max8997->muic)) {
dev_err(max8997->dev, "Failed to allocate I2C device for MUIC\n");
- ret = -ENODEV;
+ ret = PTR_ERR(max8997->muic);
goto err_i2c_muic;
}
i2c_set_clientdata(max8997->muic, max8997);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 11/14] mfd: max8997: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 11/14] mfd: max8997: " Wolfram Sang
@ 2019-08-12 7:47 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:47 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max8997.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 12/14] mfd: max8998: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (10 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 11/14] mfd: max8997: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:48 ` Lee Jones
2019-07-22 17:26 ` [PATCH 13/14] mfd: palmas: " Wolfram Sang
2019-07-22 17:26 ` [PATCH 14/14] mfd: twl-core: " Wolfram Sang
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Lee Jones, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/max8998.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
index 56409df120f8..785f8e9841b7 100644
--- a/drivers/mfd/max8998.c
+++ b/drivers/mfd/max8998.c
@@ -195,10 +195,10 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
}
mutex_init(&max8998->iolock);
- max8998->rtc = i2c_new_dummy(i2c->adapter, RTC_I2C_ADDR);
- if (!max8998->rtc) {
+ max8998->rtc = i2c_new_dummy_device(i2c->adapter, RTC_I2C_ADDR);
+ if (IS_ERR(max8998->rtc)) {
dev_err(&i2c->dev, "Failed to allocate I2C device for RTC\n");
- return -ENODEV;
+ return PTR_ERR(max8998->rtc);
}
i2c_set_clientdata(max8998->rtc, max8998);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 12/14] mfd: max8998: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 12/14] mfd: max8998: " Wolfram Sang
@ 2019-08-12 7:48 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/max8998.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 13/14] mfd: palmas: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (11 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 12/14] mfd: max8998: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:48 ` Lee Jones
2019-07-22 17:26 ` [PATCH 14/14] mfd: twl-core: " Wolfram Sang
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Tony Lindgren, Lee Jones, linux-omap, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/palmas.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index 6818ff34837c..f5b3fa973b13 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -549,12 +549,12 @@ static int palmas_i2c_probe(struct i2c_client *i2c,
palmas->i2c_clients[i] = i2c;
else {
palmas->i2c_clients[i] =
- i2c_new_dummy(i2c->adapter,
+ i2c_new_dummy_device(i2c->adapter,
i2c->addr + i);
- if (!palmas->i2c_clients[i]) {
+ if (IS_ERR(palmas->i2c_clients[i])) {
dev_err(palmas->dev,
"can't attach client %d\n", i);
- ret = -ENOMEM;
+ ret = PTR_ERR(palmas->i2c_clients[i]);
goto err_i2c;
}
palmas->i2c_clients[i]->dev.of_node = of_node_get(node);
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 13/14] mfd: palmas: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 13/14] mfd: palmas: " Wolfram Sang
@ 2019-08-12 7:48 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Tony Lindgren, linux-omap, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/palmas.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread
* [PATCH 14/14] mfd: twl-core: convert to i2c_new_dummy_device
2019-07-22 17:26 [PATCH 00/14] mfd: convert subsystem to i2c_new_dummy_device() Wolfram Sang
` (12 preceding siblings ...)
2019-07-22 17:26 ` [PATCH 13/14] mfd: palmas: " Wolfram Sang
@ 2019-07-22 17:26 ` Wolfram Sang
2019-08-12 7:48 ` Lee Jones
13 siblings, 1 reply; 32+ messages in thread
From: Wolfram Sang @ 2019-07-22 17:26 UTC (permalink / raw)
To: linux-i2c
Cc: Wolfram Sang, Tony Lindgren, Lee Jones, linux-omap, linux-kernel
Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
ERRPTR which we use in error handling.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
drivers/mfd/twl-core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 448d9397ff04..20cf8cfe4f3b 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -1141,12 +1141,12 @@ twl_probe(struct i2c_client *client, const struct i2c_device_id *id)
if (i == 0) {
twl->client = client;
} else {
- twl->client = i2c_new_dummy(client->adapter,
+ twl->client = i2c_new_dummy_device(client->adapter,
client->addr + i);
- if (!twl->client) {
+ if (IS_ERR(twl->client)) {
dev_err(&client->dev,
"can't attach client %d\n", i);
- status = -ENOMEM;
+ status = PTR_ERR(twl->client);
goto fail;
}
}
--
2.20.1
^ permalink raw reply related [flat|nested] 32+ messages in thread
* Re: [PATCH 14/14] mfd: twl-core: convert to i2c_new_dummy_device
2019-07-22 17:26 ` [PATCH 14/14] mfd: twl-core: " Wolfram Sang
@ 2019-08-12 7:48 ` Lee Jones
0 siblings, 0 replies; 32+ messages in thread
From: Lee Jones @ 2019-08-12 7:48 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, Tony Lindgren, linux-omap, linux-kernel
On Mon, 22 Jul 2019, Wolfram Sang wrote:
> Move from i2c_new_dummy() to i2c_new_dummy_device(), so we now get an
> ERRPTR which we use in error handling.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Generated with coccinelle. Build tested by me and buildbot. Not tested on HW.
>
> drivers/mfd/twl-core.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 32+ messages in thread