linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] gpio/qoriq: select IRQ_DOMAIN
@ 2016-04-19 12:10 Arnd Bergmann
  2016-04-29  9:13 ` Linus Walleij
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-04-19 12:10 UTC (permalink / raw)
  To: Linus Walleij
  Cc: Liu Gang, Arnd Bergmann, Alexandre Courbot, linux-gpio, linux-kernel

The gpio-mpc8xxx driver requires IRQ domains but can be built
without them, resulting on a failure to build certain randconfigs
on ARM:

drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_to_irq':
drivers/gpio/gpio-mpc8xxx.c:92:10: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
   return irq_create_mapping(mpc8xxx_gc->irq, offset);

This selects IRQ_DOMAIN from the driver to ensure we can build it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 5df7fd46b70b ("gpio/qoriq: Add qoriq platforms support")
---
 drivers/gpio/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index f73f26b43532..dcdf3fb301d1 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -304,6 +304,7 @@ config GPIO_MPC8XXX
 		   FSL_SOC_BOOKE || PPC_86xx || ARCH_LAYERSCAPE || ARM || \
 		   COMPILE_TEST
 	select GPIO_GENERIC
+	select IRQ_DOMAIN
 	help
 	  Say Y here if you're going to use hardware that connects to the
 	  MPC512x/831x/834x/837x/8572/8610/QorIQ GPIOs.
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] gpio/qoriq: select IRQ_DOMAIN
  2016-04-19 12:10 [PATCH] gpio/qoriq: select IRQ_DOMAIN Arnd Bergmann
@ 2016-04-29  9:13 ` Linus Walleij
  0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2016-04-29  9:13 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Liu Gang, Alexandre Courbot, linux-gpio, linux-kernel

On Tue, Apr 19, 2016 at 2:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:

> The gpio-mpc8xxx driver requires IRQ domains but can be built
> without them, resulting on a failure to build certain randconfigs
> on ARM:
>
> drivers/gpio/gpio-mpc8xxx.c: In function 'mpc8xxx_gpio_to_irq':
> drivers/gpio/gpio-mpc8xxx.c:92:10: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
>    return irq_create_mapping(mpc8xxx_gc->irq, offset);
>
> This selects IRQ_DOMAIN from the driver to ensure we can build it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 5df7fd46b70b ("gpio/qoriq: Add qoriq platforms support")

Patch applied.

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-29  9:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-19 12:10 [PATCH] gpio/qoriq: select IRQ_DOMAIN Arnd Bergmann
2016-04-29  9:13 ` Linus Walleij

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).