[PATCH] w1: Allow compile test of GPIO consumers if !GPIOLIB

[PATCH] w1: Allow compile test of GPIO consumers if !GPIOLIB

[Geert Uytterhoeven]

The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
functionality only, can still be compiled if GPIOLIB is not enabled.

Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
appropriate.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
---
v3:
  - Add Acked-by,

v2:
  - Add Acked-by.
---
 drivers/w1/masters/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig
index 1708b2300c7a9ca2..00827d2897b534bc 100644
--- a/drivers/w1/masters/Kconfig
+++ b/drivers/w1/masters/Kconfig
@@ -49,7 +49,7 @@ config W1_MASTER_DS1WM
 
 config W1_MASTER_GPIO
 	tristate "GPIO 1-wire busmaster"
-	depends on GPIOLIB
+	depends on GPIOLIB || COMPILE_TEST
 	help
 	  Say Y here if you want to communicate with your 1-wire devices using
 	  GPIO pins. This driver uses the GPIO API to control the wire.
-- 
2.17.1

Re: [PATCH] w1: Allow compile test of GPIO consumers if !GPIOLIB

[Linus Walleij]

On Thu, Jun 21, 2018 at 8:54 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> v3:
>   - Add Acked-by,

I think my last change to w1 I just put into the GPIO tree.

Should I simply carry this patch in the GPIO tree?

Yours,
Linus Walleij

Re: [PATCH] w1: Allow compile test of GPIO consumers if !GPIOLIB

[Geert Uytterhoeven]

Hi Linus,

On Tue, Jun 26, 2018 at 9:34 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Thu, Jun 21, 2018 at 8:54 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> > not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> > functionality only, can still be compiled if GPIOLIB is not enabled.
> >
> > Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> > appropriate.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> > ---
> > v3:
> >   - Add Acked-by,
>
> I think my last change to w1 I just put into the GPIO tree.
>
> Should I simply carry this patch in the GPIO tree?

Fine for me ;-)

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] w1: Allow compile test of GPIO consumers if !GPIOLIB

[Linus Walleij]

On Thu, Jun 21, 2018 at 8:54 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:

> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is
> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer
> functionality only, can still be compiled if GPIOLIB is not enabled.
>
> Relax the dependency on GPIOLIB if COMPILE_TEST is enabled, where
> appropriate.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
> ---
> v3:

Patch applied to the GPIO tree.

Yours,
Linus Walleij