* [PATCH v3 0/2] Enable ehci and ohci devices for exynos5250 @ 2012-12-13 16:36 Vivek Gautam 2012-12-13 16:36 ` [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam 2012-12-13 16:36 ` [PATCH v3 2/2] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam 0 siblings, 2 replies; 8+ messages in thread From: Vivek Gautam @ 2012-12-13 16:36 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree-discuss Cc: linux-kernel, linux-usb, grant.likely, kgene.kim, jg1.han, thomas.abraham Changes from v2: - Changed the compatible string to chip specific(samsung,exynos4210), since ehci-s5p and ohci-exynos are being used from exynso4210 onwards. - Based on changes for drivers available at: http://www.mail-archive.com/devicetree-discuss@lists.ozlabs.org/msg23218.html Changes from v1: - Changed the device node names from 'ehci' and 'ohci' to 'usb@12110000' and 'usb@12120000' as per discussion for the change 'http://www.spinics.net/lists/linux-usb/msg73993.html' - Rebased on for-next branch of linux-samsung. Vivek Gautam (2): ARM: Exynos5250: Enabling ehci-s5p driver ARM: Exynos5250: Enabling ohci-exynos driver .../devicetree/bindings/usb/exynos-usb.txt | 40 ++++++++++++++++++++ arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 ++ arch/arm/boot/dts/exynos5250.dtsi | 12 ++++++ arch/arm/mach-exynos/include/mach/map.h | 2 + arch/arm/mach-exynos/mach-exynos5-dt.c | 4 ++ 5 files changed, 62 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt -- 1.7.6.5 ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-13 16:36 [PATCH v3 0/2] Enable ehci and ohci devices for exynos5250 Vivek Gautam @ 2012-12-13 16:36 ` Vivek Gautam 2012-12-15 7:23 ` Grant Likely 2012-12-13 16:36 ` [PATCH v3 2/2] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam 1 sibling, 1 reply; 8+ messages in thread From: Vivek Gautam @ 2012-12-13 16:36 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree-discuss Cc: linux-kernel, linux-usb, grant.likely, kgene.kim, jg1.han, thomas.abraham Adding EHCI device tree node for Exynos5250 along with the device base adress and gpio line for vbus. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Jingoo Han <jg1.han@samsung.com> --- .../devicetree/bindings/usb/exynos-usb.txt | 25 ++++++++++++++++++++ arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 +++ arch/arm/boot/dts/exynos5250.dtsi | 6 ++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 2 + 5 files changed, 38 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt new file mode 100644 index 0000000..e8bbb47 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt @@ -0,0 +1,25 @@ +Samsung Exynos SoC USB controller + +The USB devices interface with USB controllers on Exynos SOCs. +The device node has following properties. + +EHCI +Required properties: + - compatible: should be "samsung,exynos4210-ehci" for USB 2.0 + EHCI controller in host mode. + - reg: physical base address of the controller and length of memory mapped + region. + - interrupts: interrupt number to the cpu. + +Optional properties: + - samsung,vbus-gpio: if present, specifies the GPIO that + needs to be pulled up for the bus to be powered. + +Example: + + usb@12110000 { + compatible = "samsung,exynos4210-ehci"; + reg = <0x12110000 0x100>; + interrupts = <0 71 0>; + samsung,vbus-gpio = <&gpx2 6 1 3 3>; + }; diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index 711b55f..f990086 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -218,4 +218,8 @@ i2s_2: i2s@12D70000 { status = "disabled"; }; + + usb@12110000 { + samsung,vbus-gpio = <&gpx2 6 1 3 3>; + }; }; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 581e57a..584bb9a 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -299,6 +299,12 @@ rx-dma-channel = <&pdma0 11>; /* preliminary */ }; + usb@12110000 { + compatible = "samsung,exynos4210-ehci"; + reg = <0x12110000 0x100>; + interrupts = <0 71 0>; + }; + amba { #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index cbb2852..b2c662f 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -201,6 +201,7 @@ #define EXYNOS4_PA_EHCI 0x12580000 #define EXYNOS4_PA_OHCI 0x12590000 #define EXYNOS4_PA_HSPHY 0x125B0000 +#define EXYNOS5_PA_EHCI 0x12110000 #define EXYNOS4_PA_MFC 0x13400000 #define EXYNOS4_PA_UART 0x13800000 diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c index 462e5ac..b3b9af1 100644 --- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { "samsung-i2s.1", NULL), OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, "samsung-i2s.2", NULL), + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, + "s5p-ehci", NULL), {}, }; -- 1.7.6.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-13 16:36 ` [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam @ 2012-12-15 7:23 ` Grant Likely 2012-12-19 13:50 ` Vivek Gautam 0 siblings, 1 reply; 8+ messages in thread From: Grant Likely @ 2012-12-15 7:23 UTC (permalink / raw) To: Vivek Gautam, linux-arm-kernel, linux-samsung-soc, devicetree-discuss Cc: linux-kernel, linux-usb, kgene.kim, jg1.han, thomas.abraham On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote: > Adding EHCI device tree node for Exynos5250 along with > the device base adress and gpio line for vbus. > > Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> > Acked-by: Jingoo Han <jg1.han@samsung.com> > --- > .../devicetree/bindings/usb/exynos-usb.txt | 25 ++++++++++++++++++++ > arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 +++ > arch/arm/boot/dts/exynos5250.dtsi | 6 ++++ > arch/arm/mach-exynos/include/mach/map.h | 1 + > arch/arm/mach-exynos/mach-exynos5-dt.c | 2 + > 5 files changed, 38 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt > > diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt > new file mode 100644 > index 0000000..e8bbb47 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt > @@ -0,0 +1,25 @@ > +Samsung Exynos SoC USB controller > + > +The USB devices interface with USB controllers on Exynos SOCs. > +The device node has following properties. > + > +EHCI > +Required properties: > + - compatible: should be "samsung,exynos4210-ehci" for USB 2.0 > + EHCI controller in host mode. > + - reg: physical base address of the controller and length of memory mapped > + region. > + - interrupts: interrupt number to the cpu. > + > +Optional properties: > + - samsung,vbus-gpio: if present, specifies the GPIO that > + needs to be pulled up for the bus to be powered. > + > +Example: > + > + usb@12110000 { > + compatible = "samsung,exynos4210-ehci"; > + reg = <0x12110000 0x100>; > + interrupts = <0 71 0>; > + samsung,vbus-gpio = <&gpx2 6 1 3 3>; > + }; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index 711b55f..f990086 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -218,4 +218,8 @@ > i2s_2: i2s@12D70000 { > status = "disabled"; > }; > + > + usb@12110000 { > + samsung,vbus-gpio = <&gpx2 6 1 3 3>; > + }; > }; > diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi > index 581e57a..584bb9a 100644 > --- a/arch/arm/boot/dts/exynos5250.dtsi > +++ b/arch/arm/boot/dts/exynos5250.dtsi > @@ -299,6 +299,12 @@ > rx-dma-channel = <&pdma0 11>; /* preliminary */ > }; > > + usb@12110000 { > + compatible = "samsung,exynos4210-ehci"; > + reg = <0x12110000 0x100>; > + interrupts = <0 71 0>; > + }; > + > amba { > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h > index cbb2852..b2c662f 100644 > --- a/arch/arm/mach-exynos/include/mach/map.h > +++ b/arch/arm/mach-exynos/include/mach/map.h > @@ -201,6 +201,7 @@ > #define EXYNOS4_PA_EHCI 0x12580000 > #define EXYNOS4_PA_OHCI 0x12590000 > #define EXYNOS4_PA_HSPHY 0x125B0000 > +#define EXYNOS5_PA_EHCI 0x12110000 > #define EXYNOS4_PA_MFC 0x13400000 > > #define EXYNOS4_PA_UART 0x13800000 > diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c > index 462e5ac..b3b9af1 100644 > --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { > "samsung-i2s.1", NULL), > OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, > "samsung-i2s.2", NULL), > + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, > + "s5p-ehci", NULL), I'm assuming the above change is temporary. What is left to be done to drop the auxdata in theses two patches? Otherwise the patch looks fine. Acked-by: Grant Likely <grant.likely@secretlab.ca> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-15 7:23 ` Grant Likely @ 2012-12-19 13:50 ` Vivek Gautam 2012-12-21 8:16 ` Vivek Gautam 0 siblings, 1 reply; 8+ messages in thread From: Vivek Gautam @ 2012-12-19 13:50 UTC (permalink / raw) To: linux-samsung-soc Cc: dianders, linux-arm-kernel, devicetree-discuss, linux-kernel, linux-usb, kgene.kim, Grant Likely, Vivek Gautam CC: Doug Anderson On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely <grant.likely@secretlab.ca> wrote: > On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote: >> Adding EHCI device tree node for Exynos5250 along with >> the device base adress and gpio line for vbus. >> >> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >> Acked-by: Jingoo Han <jg1.han@samsung.com> >> --- >> .../devicetree/bindings/usb/exynos-usb.txt | 25 ++++++++++++++++++++ >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 +++ >> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++ >> arch/arm/mach-exynos/include/mach/map.h | 1 + >> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 + >> 5 files changed, 38 insertions(+), 0 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt >> >> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt >> new file mode 100644 >> index 0000000..e8bbb47 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt >> @@ -0,0 +1,25 @@ >> +Samsung Exynos SoC USB controller >> + >> +The USB devices interface with USB controllers on Exynos SOCs. >> +The device node has following properties. >> + >> +EHCI >> +Required properties: >> + - compatible: should be "samsung,exynos4210-ehci" for USB 2.0 >> + EHCI controller in host mode. >> + - reg: physical base address of the controller and length of memory mapped >> + region. >> + - interrupts: interrupt number to the cpu. >> + >> +Optional properties: >> + - samsung,vbus-gpio: if present, specifies the GPIO that >> + needs to be pulled up for the bus to be powered. >> + >> +Example: >> + >> + usb@12110000 { >> + compatible = "samsung,exynos4210-ehci"; >> + reg = <0x12110000 0x100>; >> + interrupts = <0 71 0>; >> + samsung,vbus-gpio = <&gpx2 6 1 3 3>; >> + }; >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> index 711b55f..f990086 100644 >> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> @@ -218,4 +218,8 @@ >> i2s_2: i2s@12D70000 { >> status = "disabled"; >> }; >> + >> + usb@12110000 { >> + samsung,vbus-gpio = <&gpx2 6 1 3 3>; >> + }; >> }; >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 581e57a..584bb9a 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -299,6 +299,12 @@ >> rx-dma-channel = <&pdma0 11>; /* preliminary */ >> }; >> >> + usb@12110000 { >> + compatible = "samsung,exynos4210-ehci"; >> + reg = <0x12110000 0x100>; >> + interrupts = <0 71 0>; >> + }; >> + >> amba { >> #address-cells = <1>; >> #size-cells = <1>; >> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h >> index cbb2852..b2c662f 100644 >> --- a/arch/arm/mach-exynos/include/mach/map.h >> +++ b/arch/arm/mach-exynos/include/mach/map.h >> @@ -201,6 +201,7 @@ >> #define EXYNOS4_PA_EHCI 0x12580000 >> #define EXYNOS4_PA_OHCI 0x12590000 >> #define EXYNOS4_PA_HSPHY 0x125B0000 >> +#define EXYNOS5_PA_EHCI 0x12110000 >> #define EXYNOS4_PA_MFC 0x13400000 >> >> #define EXYNOS4_PA_UART 0x13800000 >> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c >> index 462e5ac..b3b9af1 100644 >> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c >> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c >> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { >> "samsung-i2s.1", NULL), >> OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, >> "samsung-i2s.2", NULL), >> + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, >> + "s5p-ehci", NULL), > > I'm assuming the above change is temporary. What is left to be done to > drop the auxdata in theses two patches? > > Otherwise the patch looks fine. > > Acked-by: Grant Likely <grant.likely@secretlab.ca> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Thanks & Regards Vivek ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-19 13:50 ` Vivek Gautam @ 2012-12-21 8:16 ` Vivek Gautam 2012-12-21 18:13 ` Doug Anderson 0 siblings, 1 reply; 8+ messages in thread From: Vivek Gautam @ 2012-12-21 8:16 UTC (permalink / raw) To: linux-samsung-soc Cc: dianders, linux-arm-kernel, devicetree-discuss, linux-kernel, linux-usb, kgene.kim, Grant Likely, Vivek Gautam Hi all, On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely > <grant.likely@secretlab.ca> wrote: >> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote: >>> Adding EHCI device tree node for Exynos5250 along with >>> the device base adress and gpio line for vbus. >>> >>> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> >>> Acked-by: Jingoo Han <jg1.han@samsung.com> >>> --- >>> .../devicetree/bindings/usb/exynos-usb.txt | 25 ++++++++++++++++++++ >>> arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 +++ >>> arch/arm/boot/dts/exynos5250.dtsi | 6 ++++ >>> arch/arm/mach-exynos/include/mach/map.h | 1 + >>> arch/arm/mach-exynos/mach-exynos5-dt.c | 2 + >>> 5 files changed, 38 insertions(+), 0 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/usb/exynos-usb.txt >>> >>> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt >>> new file mode 100644 >>> index 0000000..e8bbb47 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt >>> @@ -0,0 +1,25 @@ >>> +Samsung Exynos SoC USB controller >>> + >>> +The USB devices interface with USB controllers on Exynos SOCs. >>> +The device node has following properties. >>> + >>> +EHCI >>> +Required properties: >>> + - compatible: should be "samsung,exynos4210-ehci" for USB 2.0 >>> + EHCI controller in host mode. >>> + - reg: physical base address of the controller and length of memory mapped >>> + region. >>> + - interrupts: interrupt number to the cpu. >>> + >>> +Optional properties: >>> + - samsung,vbus-gpio: if present, specifies the GPIO that >>> + needs to be pulled up for the bus to be powered. >>> + >>> +Example: >>> + >>> + usb@12110000 { >>> + compatible = "samsung,exynos4210-ehci"; >>> + reg = <0x12110000 0x100>; >>> + interrupts = <0 71 0>; >>> + samsung,vbus-gpio = <&gpx2 6 1 3 3>; >>> + }; >>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> index 711b55f..f990086 100644 >>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >>> @@ -218,4 +218,8 @@ >>> i2s_2: i2s@12D70000 { >>> status = "disabled"; >>> }; >>> + >>> + usb@12110000 { >>> + samsung,vbus-gpio = <&gpx2 6 1 3 3>; >>> + }; >>> }; >>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >>> index 581e57a..584bb9a 100644 >>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> @@ -299,6 +299,12 @@ >>> rx-dma-channel = <&pdma0 11>; /* preliminary */ >>> }; >>> >>> + usb@12110000 { >>> + compatible = "samsung,exynos4210-ehci"; >>> + reg = <0x12110000 0x100>; >>> + interrupts = <0 71 0>; >>> + }; >>> + >>> amba { >>> #address-cells = <1>; >>> #size-cells = <1>; >>> diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h >>> index cbb2852..b2c662f 100644 >>> --- a/arch/arm/mach-exynos/include/mach/map.h >>> +++ b/arch/arm/mach-exynos/include/mach/map.h >>> @@ -201,6 +201,7 @@ >>> #define EXYNOS4_PA_EHCI 0x12580000 >>> #define EXYNOS4_PA_OHCI 0x12590000 >>> #define EXYNOS4_PA_HSPHY 0x125B0000 >>> +#define EXYNOS5_PA_EHCI 0x12110000 >>> #define EXYNOS4_PA_MFC 0x13400000 >>> >>> #define EXYNOS4_PA_UART 0x13800000 >>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c >>> index 462e5ac..b3b9af1 100644 >>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c >>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c >>> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { >>> "samsung-i2s.1", NULL), >>> OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, >>> "samsung-i2s.2", NULL), >>> + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, >>> + "s5p-ehci", NULL), >> >> I'm assuming the above change is temporary. What is left to be done to >> drop the auxdata in theses two patches? >> >> Otherwise the patch looks fine. >> >> Acked-by: Grant Likely <grant.likely@secretlab.ca> Any more thought about this patch? Or does this change seems fine? >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Please read the FAQ at http://www.tux.org/lkml/ > > > > -- > Thanks & Regards > Vivek -- Thanks & Regards Vivek ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-21 8:16 ` Vivek Gautam @ 2012-12-21 18:13 ` Doug Anderson 2013-02-08 21:41 ` Grant Likely 0 siblings, 1 reply; 8+ messages in thread From: Doug Anderson @ 2012-12-21 18:13 UTC (permalink / raw) To: Vivek Gautam Cc: linux-samsung-soc, linux-arm-kernel, devicetree-discuss, linux-kernel, linux-usb, Kukjin Kim, Grant Likely, Vivek Gautam Vivek, On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: > Hi all, > > > On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: >> CC: Doug Anderson >> >> >> On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely >> <grant.likely@secretlab.ca> wrote: >>> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote: >>>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c >>>> index 462e5ac..b3b9af1 100644 >>>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c >>>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c >>>> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { >>>> "samsung-i2s.1", NULL), >>>> OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, >>>> "samsung-i2s.2", NULL), >>>> + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, >>>> + "s5p-ehci", NULL), >>> >>> I'm assuming the above change is temporary. What is left to be done to >>> drop the auxdata in theses two patches? >>> >>> Otherwise the patch looks fine. >>> >>> Acked-by: Grant Likely <grant.likely@secretlab.ca> > > Any more thought about this patch? > Or does this change seems fine? I'm fairly certain we can just drop the OF_DEV_AUXDATA entry here. I haven't been following this as closely as I should, but I know that the comment for this table says that the whole purpose is to override device names and that it should be temporary. We don't need to do any overriding of device names here, do we? When I drop this (and the ohci and phy) entries from my table I can still boot and still can use USB. The big difference is what shows up in dmesg [ 1.605000] s5p-ehci s5p-ehci: S5P EHCI Host Controller Becomes: [ 1.550000] s5p-ehci 12110000.usb: S5P EHCI Host Controller ...and some sysfs paths change. -Doug ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver 2012-12-21 18:13 ` Doug Anderson @ 2013-02-08 21:41 ` Grant Likely 0 siblings, 0 replies; 8+ messages in thread From: Grant Likely @ 2013-02-08 21:41 UTC (permalink / raw) To: Doug Anderson, Vivek Gautam Cc: linux-samsung-soc, linux-arm-kernel, devicetree-discuss, linux-kernel, linux-usb, Kukjin Kim, Vivek Gautam On Fri, 21 Dec 2012 10:13:50 -0800, Doug Anderson <dianders@chromium.org> wrote: > Vivek, > > > On Fri, Dec 21, 2012 at 12:16 AM, Vivek Gautam > <gautamvivek1987@gmail.com> wrote: > > Hi all, > > > > > > On Wed, Dec 19, 2012 at 7:20 PM, Vivek Gautam <gautamvivek1987@gmail.com> wrote: > >> CC: Doug Anderson > >> > >> > >> On Sat, Dec 15, 2012 at 12:53 PM, Grant Likely > >> <grant.likely@secretlab.ca> wrote: > >>> On Thu, 13 Dec 2012 22:06:01 +0530, Vivek Gautam <gautam.vivek@samsung.com> wrote: > >>>> diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c > >>>> index 462e5ac..b3b9af1 100644 > >>>> --- a/arch/arm/mach-exynos/mach-exynos5-dt.c > >>>> +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c > >>>> @@ -110,6 +110,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { > >>>> "samsung-i2s.1", NULL), > >>>> OF_DEV_AUXDATA("samsung,samsung-i2s", 0x12D70000, > >>>> "samsung-i2s.2", NULL), > >>>> + OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, > >>>> + "s5p-ehci", NULL), > >>> > >>> I'm assuming the above change is temporary. What is left to be done to > >>> drop the auxdata in theses two patches? > >>> > >>> Otherwise the patch looks fine. > >>> > >>> Acked-by: Grant Likely <grant.likely@secretlab.ca> > > > > Any more thought about this patch? > > Or does this change seems fine? > > I'm fairly certain we can just drop the OF_DEV_AUXDATA entry here. I > haven't been following this as closely as I should, but I know that > the comment for this table says that the whole purpose is to override > device names and that it should be temporary. We don't need to do any > overriding of device names here, do we? > > When I drop this (and the ohci and phy) entries from my table I can > still boot and still can use USB. The big difference is what shows up > in dmesg > > [ 1.605000] s5p-ehci s5p-ehci: S5P EHCI Host Controller > > Becomes: > > [ 1.550000] s5p-ehci 12110000.usb: S5P EHCI Host Controller > > ...and some sysfs paths change. Right. Drop the AUXDATA then. :-) g. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v3 2/2] ARM: Exynos5250: Enabling ohci-exynos driver 2012-12-13 16:36 [PATCH v3 0/2] Enable ehci and ohci devices for exynos5250 Vivek Gautam 2012-12-13 16:36 ` [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam @ 2012-12-13 16:36 ` Vivek Gautam 1 sibling, 0 replies; 8+ messages in thread From: Vivek Gautam @ 2012-12-13 16:36 UTC (permalink / raw) To: linux-arm-kernel, linux-samsung-soc, devicetree-discuss Cc: linux-kernel, linux-usb, grant.likely, kgene.kim, jg1.han, thomas.abraham Adding OHCI device tree node for Exynos5250 along with the device base address. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> Acked-by: Jingoo Han <jg1.han@samsung.com> --- .../devicetree/bindings/usb/exynos-usb.txt | 15 +++++++++++++++ arch/arm/boot/dts/exynos5250.dtsi | 6 ++++++ arch/arm/mach-exynos/include/mach/map.h | 1 + arch/arm/mach-exynos/mach-exynos5-dt.c | 2 ++ 4 files changed, 24 insertions(+), 0 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt b/Documentation/devicetree/bindings/usb/exynos-usb.txt index e8bbb47..f66fcdd 100644 --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt @@ -23,3 +23,18 @@ Example: interrupts = <0 71 0>; samsung,vbus-gpio = <&gpx2 6 1 3 3>; }; + +OHCI +Required properties: + - compatible: should be "samsung,exynos4210-ohci" for USB 2.0 + OHCI companion controller in host mode. + - reg: physical base address of the controller and length of memory mapped + region. + - interrupts: interrupt number to the cpu. + +Example: + usb@12120000 { + compatible = "samsung,exynos4210-ohci"; + reg = <0x12120000 0x100>; + interrupts = <0 71 0>; + }; diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi index 584bb9a..75510d1 100644 --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -305,6 +305,12 @@ interrupts = <0 71 0>; }; + usb@12120000 { + compatible = "samsung,exynos4210-ohci"; + reg = <0x12120000 0x100>; + interrupts = <0 71 0>; + }; + amba { #address-cells = <1>; #size-cells = <1>; diff --git a/arch/arm/mach-exynos/include/mach/map.h b/arch/arm/mach-exynos/include/mach/map.h index b2c662f..4bf6fd9 100644 --- a/arch/arm/mach-exynos/include/mach/map.h +++ b/arch/arm/mach-exynos/include/mach/map.h @@ -202,6 +202,7 @@ #define EXYNOS4_PA_OHCI 0x12590000 #define EXYNOS4_PA_HSPHY 0x125B0000 #define EXYNOS5_PA_EHCI 0x12110000 +#define EXYNOS5_PA_OHCI 0x12120000 #define EXYNOS4_PA_MFC 0x13400000 #define EXYNOS4_PA_UART 0x13800000 diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c index b3b9af1..07aa586 100644 --- a/arch/arm/mach-exynos/mach-exynos5-dt.c +++ b/arch/arm/mach-exynos/mach-exynos5-dt.c @@ -112,6 +112,8 @@ static const struct of_dev_auxdata exynos5250_auxdata_lookup[] __initconst = { "samsung-i2s.2", NULL), OF_DEV_AUXDATA("samsung,exynos4210-ehci", EXYNOS5_PA_EHCI, "s5p-ehci", NULL), + OF_DEV_AUXDATA("samsung,exynos4210-ohci", EXYNOS5_PA_OHCI, + "exynos-ohci", NULL), {}, }; -- 1.7.6.5 ^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-02-08 21:41 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2012-12-13 16:36 [PATCH v3 0/2] Enable ehci and ohci devices for exynos5250 Vivek Gautam 2012-12-13 16:36 ` [PATCH v3 1/2] ARM: Exynos5250: Enabling ehci-s5p driver Vivek Gautam 2012-12-15 7:23 ` Grant Likely 2012-12-19 13:50 ` Vivek Gautam 2012-12-21 8:16 ` Vivek Gautam 2012-12-21 18:13 ` Doug Anderson 2013-02-08 21:41 ` Grant Likely 2012-12-13 16:36 ` [PATCH v3 2/2] ARM: Exynos5250: Enabling ohci-exynos driver Vivek Gautam
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).