* [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status @ 2022-03-22 8:02 Xin Ji 2022-03-22 8:43 ` Hsin-Yi Wang 0 siblings, 1 reply; 9+ messages in thread From: Xin Ji @ 2022-03-22 8:02 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter Cc: bliang, qwen, treapking, pihsun, tzungbi, hsinyi, Xin Ji, dri-devel, linux-kernel As downstream sink was set into standby mode while bridge disabled, this patch used for setting downstream sink into normal status while enable bridge. Signed-off-by: Xin Ji <xji@analogixsemi.com> Reviewed-by: Pin-Yen Lin <treapking@chromium.org> --- V1 -> V2: use dev_dbg replace of dev_info --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 9a2a19ad4202..dcf3275a00fe 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) { int ret; struct device *dev = &ctx->client->dev; + u8 data; if (!ctx->display_timing_valid) { DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); return; } + dev_dbg(dev, "set downstream sink into normal\n"); + /* Downstream sink enter into normal mode */ + data = 1; + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); + if (ret < 0) + dev_err(dev, "IO error : set sink into normal mode fail\n"); + /* Disable HDCP */ anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); -- 2.25.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 8:02 [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status Xin Ji @ 2022-03-22 8:43 ` Hsin-Yi Wang 2022-03-22 8:52 ` Xin Ji 2022-03-22 8:52 ` Pin-yen Lin 0 siblings, 2 replies; 9+ messages in thread From: Hsin-Yi Wang @ 2022-03-22 8:43 UTC (permalink / raw) To: Xin Ji Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, treapking, pihsun, tzungbi, dri-devel, linux-kernel On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote: > > As downstream sink was set into standby mode while bridge disabled, > this patch used for setting downstream sink into normal status > while enable bridge. > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > Reviewed-by: Pin-Yen Lin <treapking@chromium.org> > > --- > V1 -> V2: use dev_dbg replace of dev_info > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 9a2a19ad4202..dcf3275a00fe 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > { > int ret; > struct device *dev = &ctx->client->dev; > + u8 data; > > if (!ctx->display_timing_valid) { > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > return; > } > > + dev_dbg(dev, "set downstream sink into normal\n"); > + /* Downstream sink enter into normal mode */ > + data = 1; > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > + if (ret < 0) > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > + The driver uses DRM_DEV_* for logs. Can we use this? > /* Disable HDCP */ > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > -- > 2.25.1 > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 8:43 ` Hsin-Yi Wang @ 2022-03-22 8:52 ` Xin Ji 2022-03-22 9:16 ` Chen-Yu Tsai 2022-03-22 8:52 ` Pin-yen Lin 1 sibling, 1 reply; 9+ messages in thread From: Xin Ji @ 2022-03-22 8:52 UTC (permalink / raw) To: Hsin-Yi Wang Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, treapking, pihsun, tzungbi, dri-devel, linux-kernel On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > Reviewed-by: Pin-Yen Lin <treapking@chromium.org> > > > > --- > > V1 -> V2: use dev_dbg replace of dev_info > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 9a2a19ad4202..dcf3275a00fe 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > { > > int ret; > > struct device *dev = &ctx->client->dev; > > + u8 data; > > > > if (!ctx->display_timing_valid) { > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > return; > > } > > > > + dev_dbg(dev, "set downstream sink into normal\n"); > > + /* Downstream sink enter into normal mode */ > > + data = 1; > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > + if (ret < 0) > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > + > > The driver uses DRM_DEV_* for logs. Can we use this? Hi Hsin-Yi, as comment in drm/drm_print.h: "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* later. Thanks, Xin > > > /* Disable HDCP */ > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > > > -- > > 2.25.1 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 8:52 ` Xin Ji @ 2022-03-22 9:16 ` Chen-Yu Tsai 2022-03-22 10:13 ` Xin Ji 0 siblings, 1 reply; 9+ messages in thread From: Chen-Yu Tsai @ 2022-03-22 9:16 UTC (permalink / raw) To: Xin Ji Cc: Hsin-Yi Wang, dri-devel, Jonas Karlman, David Airlie, Robert Foss, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, treapking, pihsun, Laurent Pinchart, Andrzej Hajda, tzungbi, bliang On Tue, Mar 22, 2022 at 4:52 PM Xin Ji <xji@analogixsemi.com> wrote: > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote: > > > > > > As downstream sink was set into standby mode while bridge disabled, > > > this patch used for setting downstream sink into normal status > > > while enable bridge. > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > Reviewed-by: Pin-Yen Lin <treapking@chromium.org> > > > > > > --- > > > V1 -> V2: use dev_dbg replace of dev_info > > > --- > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > index 9a2a19ad4202..dcf3275a00fe 100644 > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > { > > > int ret; > > > struct device *dev = &ctx->client->dev; > > > + u8 data; > > > > > > if (!ctx->display_timing_valid) { > > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > > return; > > > } > > > > > > + dev_dbg(dev, "set downstream sink into normal\n"); > > > + /* Downstream sink enter into normal mode */ > > > + data = 1; > > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > > + if (ret < 0) > > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > > + > > > > The driver uses DRM_DEV_* for logs. Can we use this? > Hi Hsin-Yi, as comment in drm/drm_print.h: > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > later. drm_dbg is better than dev_dbg though. With the former, you still get the option to control it with the drm.debug module parameter, unlike the latter which normally gets compiled out. Please use drm_dbg*. ChenYu > Thanks, > Xin > > > > > /* Disable HDCP */ > > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > > > > > -- > > > 2.25.1 > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 9:16 ` Chen-Yu Tsai @ 2022-03-22 10:13 ` Xin Ji 2022-03-24 12:07 ` Robert Foss 0 siblings, 1 reply; 9+ messages in thread From: Xin Ji @ 2022-03-22 10:13 UTC (permalink / raw) To: Chen-Yu Tsai Cc: Hsin-Yi Wang, dri-devel, Jonas Karlman, David Airlie, Robert Foss, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, treapking, pihsun, Laurent Pinchart, Andrzej Hajda, tzungbi, bliang On Tue, Mar 22, 2022 at 05:16:43PM +0800, Chen-Yu Tsai wrote: > On Tue, Mar 22, 2022 at 4:52 PM Xin Ji <xji@analogixsemi.com> wrote: > > > > On Tue, Mar 22, 2022 at 04:43:20PM +0800, Hsin-Yi Wang wrote: > > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > As downstream sink was set into standby mode while bridge disabled, > > > > this patch used for setting downstream sink into normal status > > > > while enable bridge. > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > Reviewed-by: Pin-Yen Lin <treapking@chromium.org> > > > > > > > > --- > > > > V1 -> V2: use dev_dbg replace of dev_info > > > > --- > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > > > 1 file changed, 8 insertions(+) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > index 9a2a19ad4202..dcf3275a00fe 100644 > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > > > { > > > > int ret; > > > > struct device *dev = &ctx->client->dev; > > > > + u8 data; > > > > > > > > if (!ctx->display_timing_valid) { > > > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > > > return; > > > > } > > > > > > > > + dev_dbg(dev, "set downstream sink into normal\n"); > > > > + /* Downstream sink enter into normal mode */ > > > > + data = 1; > > > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > > > + if (ret < 0) > > > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > > > + > > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > later. > > drm_dbg is better than dev_dbg though. With the former, you still get the > option to control it with the drm.debug module parameter, unlike the latter > which normally gets compiled out. > > Please use drm_dbg*. > > ChenYu Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will change more code, I'll consider to upstream new patch to replace all of them later. Thanks, Xin > > > Thanks, > > Xin > > > > > > > /* Disable HDCP */ > > > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > > > > > > > -- > > > > 2.25.1 > > > > ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 10:13 ` Xin Ji @ 2022-03-24 12:07 ` Robert Foss 2022-03-25 6:29 ` Xin Ji 0 siblings, 1 reply; 9+ messages in thread From: Robert Foss @ 2022-03-24 12:07 UTC (permalink / raw) To: Xin Ji Cc: Chen-Yu Tsai, Hsin-Yi Wang, dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, treapking, pihsun, Laurent Pinchart, Andrzej Hajda, tzungbi, bliang > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > later. > > > > drm_dbg is better than dev_dbg though. With the former, you still get the > > option to control it with the drm.debug module parameter, unlike the latter > > which normally gets compiled out. > > > > Please use drm_dbg*. > > > > ChenYu > > Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will > change more code, I'll consider to upstream new patch to replace all of > them later. > Alright, since the driver already uses these logging functions, let's apply this patch and fix the logging function this driver uses in a separate series. Xin: Can you submit a patch/series that converts this driver to use drm_dbg* functions instead? ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-24 12:07 ` Robert Foss @ 2022-03-25 6:29 ` Xin Ji 2022-03-28 13:21 ` Robert Foss 0 siblings, 1 reply; 9+ messages in thread From: Xin Ji @ 2022-03-25 6:29 UTC (permalink / raw) To: Robert Foss Cc: Chen-Yu Tsai, Hsin-Yi Wang, dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, treapking, pihsun, Laurent Pinchart, Andrzej Hajda, tzungbi, bliang On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > > later. > > > > > > drm_dbg is better than dev_dbg though. With the former, you still get the > > > option to control it with the drm.debug module parameter, unlike the latter > > > which normally gets compiled out. > > > > > > Please use drm_dbg*. > > > > > > ChenYu > > > > Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will > > change more code, I'll consider to upstream new patch to replace all of > > them later. > > > > Alright, since the driver already uses these logging functions, let's > apply this patch and fix the logging function this driver uses in a > separate series. > > Xin: Can you submit a patch/series that converts this driver to use > drm_dbg* functions instead? Hi Robert Foss, OK, I'll submit patch after this patch get merged. Thanks, Xin ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-25 6:29 ` Xin Ji @ 2022-03-28 13:21 ` Robert Foss 0 siblings, 0 replies; 9+ messages in thread From: Robert Foss @ 2022-03-28 13:21 UTC (permalink / raw) To: Xin Ji Cc: Chen-Yu Tsai, Hsin-Yi Wang, dri-devel, Jonas Karlman, David Airlie, qwen, Neil Armstrong, linux-kernel, Jernej Skrabec, treapking, pihsun, Laurent Pinchart, Andrzej Hajda, tzungbi, bliang On Fri, 25 Mar 2022 at 07:29, Xin Ji <xji@analogixsemi.com> wrote: > > On Thu, Mar 24, 2022 at 01:07:56PM +0100, Robert Foss wrote: > > > > > > The driver uses DRM_DEV_* for logs. Can we use this? > > > > > Hi Hsin-Yi, as comment in drm/drm_print.h: > > > > > "NOTE: this is deprecated in favor of drm_dbg". DRM bridge driver not > > > > > use DRM_DEV_* any more. I'll send a patch to replace all of DRM_DEV_* > > > > > later. > > > > > > > > drm_dbg is better than dev_dbg though. With the former, you still get the > > > > option to control it with the drm.debug module parameter, unlike the latter > > > > which normally gets compiled out. > > > > > > > > Please use drm_dbg*. > > > > > > > > ChenYu > > > > > > Hi ChenYu, the parameter of drm_dbg is "drm", if use drm_dbg, it will > > > change more code, I'll consider to upstream new patch to replace all of > > > them later. > > > > > > > Alright, since the driver already uses these logging functions, let's > > apply this patch and fix the logging function this driver uses in a > > separate series. > > > > Xin: Can you submit a patch/series that converts this driver to use > > drm_dbg* functions instead? > Hi Robert Foss, OK, I'll submit patch after this patch get merged. > Thanks, Applied to drm-misc-next. Rob. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status 2022-03-22 8:43 ` Hsin-Yi Wang 2022-03-22 8:52 ` Xin Ji @ 2022-03-22 8:52 ` Pin-yen Lin 1 sibling, 0 replies; 9+ messages in thread From: Pin-yen Lin @ 2022-03-22 8:52 UTC (permalink / raw) To: Hsin-Yi Wang Cc: Xin Ji, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter, bliang, qwen, pihsun, tzungbi, dri-devel, linux-kernel The DRM_DEV_* macros have been deprecated: https://www.kernel.org/doc/html/latest/gpu/drm-internals.html#c.DRM_DEV_DEBUG_DRIVER On Tue, Mar 22, 2022 at 4:43 PM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > On Tue, Mar 22, 2022 at 4:02 PM Xin Ji <xji@analogixsemi.com> wrote: > > > > As downstream sink was set into standby mode while bridge disabled, > > this patch used for setting downstream sink into normal status > > while enable bridge. > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > Reviewed-by: Pin-Yen Lin <treapking@chromium.org> > > > > --- > > V1 -> V2: use dev_dbg replace of dev_info > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 9a2a19ad4202..dcf3275a00fe 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -924,12 +924,20 @@ static void anx7625_dp_start(struct anx7625_data *ctx) > > { > > int ret; > > struct device *dev = &ctx->client->dev; > > + u8 data; > > > > if (!ctx->display_timing_valid) { > > DRM_DEV_ERROR(dev, "mipi not set display timing yet.\n"); > > return; > > } > > > > + dev_dbg(dev, "set downstream sink into normal\n"); > > + /* Downstream sink enter into normal mode */ > > + data = 1; > > + ret = anx7625_aux_trans(ctx, DP_AUX_NATIVE_WRITE, 0x000600, 1, &data); > > + if (ret < 0) > > + dev_err(dev, "IO error : set sink into normal mode fail\n"); > > + > > The driver uses DRM_DEV_* for logs. Can we use this? > > > /* Disable HDCP */ > > anx7625_write_and(ctx, ctx->i2c.rx_p1_client, 0xee, 0x9f); > > > > -- > > 2.25.1 > > ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-03-28 13:21 UTC | newest] Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-03-22 8:02 [PATCH v2] drm/bridge: anx7625: Set downstream sink into normal status Xin Ji 2022-03-22 8:43 ` Hsin-Yi Wang 2022-03-22 8:52 ` Xin Ji 2022-03-22 9:16 ` Chen-Yu Tsai 2022-03-22 10:13 ` Xin Ji 2022-03-24 12:07 ` Robert Foss 2022-03-25 6:29 ` Xin Ji 2022-03-28 13:21 ` Robert Foss 2022-03-22 8:52 ` Pin-yen Lin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).