Re: [RFC PATCH v3 35/37] tools: Add FUSE, update bpf includes

From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Daniel Rosenberg <drosen@google.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Amir Goldstein <amir73il@gmail.com>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-unionfs@vger.kernel.org,
	Daniel Borkmann <daniel@iogearbox.net>,
	John Fastabend <john.fastabend@gmail.com>,
	Andrii Nakryiko <andrii@kernel.org>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Shuah Khan <shuah@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Joanne Koong <joannelkoong@gmail.com>,
	Mykola Lysenko <mykolal@fb.com>,
	kernel-team@android.com
Subject: Re: [RFC PATCH v3 35/37] tools: Add FUSE, update bpf includes
Date: Wed, 26 Apr 2023 21:24:37 -0700	[thread overview]
Message-ID: <CAEf4BzYD9P+1aP+q77i7RJPJW=iSS6-iTw+rfPuCz=FFB2MiZw@mail.gmail.com> (raw)
In-Reply-To: <20230418014037.2412394-36-drosen@google.com>

On Mon, Apr 17, 2023 at 6:42 PM Daniel Rosenberg <drosen@google.com> wrote:
>
> Updates the bpf includes under tools, and adds fuse
>
> Signed-off-by: Daniel Rosenberg <drosen@google.com>
> ---
>  tools/include/uapi/linux/bpf.h  |   12 +
>  tools/include/uapi/linux/fuse.h | 1135 +++++++++++++++++++++++++++++++
>  2 files changed, 1147 insertions(+)
>  create mode 100644 tools/include/uapi/linux/fuse.h
>
> diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h
> index 4b20a7269bee..6521c40875c7 100644
> --- a/tools/include/uapi/linux/bpf.h
> +++ b/tools/include/uapi/linux/bpf.h
> @@ -7155,4 +7155,16 @@ struct bpf_iter_num {
>         __u64 __opaque[1];
>  } __attribute__((aligned(8)));
>
> +/* Return Codes for Fuse BPF struct_op programs */
> +#define BPF_FUSE_CONTINUE              0
> +#define BPF_FUSE_USER                  1
> +#define BPF_FUSE_USER_PREFILTER                2
> +#define BPF_FUSE_POSTFILTER            3
> +#define BPF_FUSE_USER_POSTFILTER       4

nit: can this be an enum instead? It would be more self-documenting,
IMO. At given it's FUSE BPF-specific, why is it not in
uapi/linux/fuse.h?

> +
> +/* Op Code Filter values for BPF Programs */
> +#define FUSE_OPCODE_FILTER     0x0ffff
> +#define FUSE_PREFILTER         0x10000
> +#define FUSE_POSTFILTER                0x20000
> +

[...]