* [PATCH v2] Fix a hard coding style when determining if a device is a container.
@ 2012-10-12 12:31 Tang Chen
2012-10-17 3:26 ` Tang Chen
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Tang Chen @ 2012-10-12 12:31 UTC (permalink / raw)
To: bhelgaas, lenb, yinghai, jiang.liu, izumi.taku, isimatu.yasuaki,
linux-acpi, linux-pci, linux-kernel
Cc: Tang Chen
"ACPI0004","PNP0A05" and "PNP0A06" are all defined in array
container_device_ids[], so use it, but not the hard coding style.
Also, introduce a new api is_container_device() to determine if a
device is a container device.
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
drivers/acpi/container.c | 17 ++++++++++++++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
index 1f9f7d7..ffd76ee 100644
--- a/drivers/acpi/container.c
+++ b/drivers/acpi/container.c
@@ -92,6 +92,19 @@ static int is_device_present(acpi_handle handle)
return ((sta & ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
}
+static int is_container_device(const char *hid)
+{
+ const struct acpi_device_id *container_id;
+
+ for (container_id = container_device_ids;
+ container_id->id[0]; container_id++) {
+ if (!strcmp((char *)container_id->id, hid))
+ return 1;
+ }
+
+ return 0;
+}
+
/*******************************************************************/
static int acpi_container_add(struct acpi_device *device)
{
@@ -232,10 +245,8 @@ container_walk_namespace_cb(acpi_handle handle,
goto end;
}
- if (strcmp(hid, "ACPI0004") && strcmp(hid, "PNP0A05") &&
- strcmp(hid, "PNP0A06")) {
+ if (!is_container_device(hid))
goto end;
- }
switch (*action) {
case INSTALL_NOTIFY_HANDLER:
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.
2012-10-12 12:31 [PATCH v2] Fix a hard coding style when determining if a device is a container Tang Chen
@ 2012-10-17 3:26 ` Tang Chen
2012-10-23 12:05 ` Tang Chen
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Tang Chen @ 2012-10-17 3:26 UTC (permalink / raw)
To: Tang Chen
Cc: bhelgaas, lenb, yinghai, jiang.liu, izumi.taku, isimatu.yasuaki,
linux-acpi, linux-pci, linux-kernel
Hi,
Would anyone help to review this patch, and give some comments, please ?
Thanks. :)
On 10/12/2012 08:31 PM, Tang Chen wrote:
> "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array
> container_device_ids[], so use it, but not the hard coding style.
>
> Also, introduce a new api is_container_device() to determine if a
> device is a container device.
>
> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu<isimatu.yasuaki@jp.fujitsu.com>
> ---
> drivers/acpi/container.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
> index 1f9f7d7..ffd76ee 100644
> --- a/drivers/acpi/container.c
> +++ b/drivers/acpi/container.c
> @@ -92,6 +92,19 @@ static int is_device_present(acpi_handle handle)
> return ((sta& ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
> }
>
> +static int is_container_device(const char *hid)
> +{
> + const struct acpi_device_id *container_id;
> +
> + for (container_id = container_device_ids;
> + container_id->id[0]; container_id++) {
> + if (!strcmp((char *)container_id->id, hid))
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> /*******************************************************************/
> static int acpi_container_add(struct acpi_device *device)
> {
> @@ -232,10 +245,8 @@ container_walk_namespace_cb(acpi_handle handle,
> goto end;
> }
>
> - if (strcmp(hid, "ACPI0004")&& strcmp(hid, "PNP0A05")&&
> - strcmp(hid, "PNP0A06")) {
> + if (!is_container_device(hid))
> goto end;
> - }
>
> switch (*action) {
> case INSTALL_NOTIFY_HANDLER:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.
2012-10-12 12:31 [PATCH v2] Fix a hard coding style when determining if a device is a container Tang Chen
2012-10-17 3:26 ` Tang Chen
@ 2012-10-23 12:05 ` Tang Chen
2012-10-23 16:00 ` Bjorn Helgaas
2012-10-24 22:16 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Tang Chen @ 2012-10-23 12:05 UTC (permalink / raw)
To: Tang Chen
Cc: bhelgaas, lenb, yinghai, jiang.liu, izumi.taku, isimatu.yasuaki,
linux-acpi, linux-pci, linux-kernel
Hi,
Would somebody give some comments ?
Thanks. :)
On 10/12/2012 08:31 PM, Tang Chen wrote:
> "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array
> container_device_ids[], so use it, but not the hard coding style.
>
> Also, introduce a new api is_container_device() to determine if a
> device is a container device.
>
> Signed-off-by: Tang Chen<tangchen@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu<isimatu.yasuaki@jp.fujitsu.com>
> ---
> drivers/acpi/container.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
> index 1f9f7d7..ffd76ee 100644
> --- a/drivers/acpi/container.c
> +++ b/drivers/acpi/container.c
> @@ -92,6 +92,19 @@ static int is_device_present(acpi_handle handle)
> return ((sta& ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
> }
>
> +static int is_container_device(const char *hid)
> +{
> + const struct acpi_device_id *container_id;
> +
> + for (container_id = container_device_ids;
> + container_id->id[0]; container_id++) {
> + if (!strcmp((char *)container_id->id, hid))
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> /*******************************************************************/
> static int acpi_container_add(struct acpi_device *device)
> {
> @@ -232,10 +245,8 @@ container_walk_namespace_cb(acpi_handle handle,
> goto end;
> }
>
> - if (strcmp(hid, "ACPI0004")&& strcmp(hid, "PNP0A05")&&
> - strcmp(hid, "PNP0A06")) {
> + if (!is_container_device(hid))
> goto end;
> - }
>
> switch (*action) {
> case INSTALL_NOTIFY_HANDLER:
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.
2012-10-12 12:31 [PATCH v2] Fix a hard coding style when determining if a device is a container Tang Chen
2012-10-17 3:26 ` Tang Chen
2012-10-23 12:05 ` Tang Chen
@ 2012-10-23 16:00 ` Bjorn Helgaas
2012-10-24 22:16 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Bjorn Helgaas @ 2012-10-23 16:00 UTC (permalink / raw)
To: Tang Chen
Cc: lenb, yinghai, jiang.liu, izumi.taku, isimatu.yasuaki,
linux-acpi, linux-pci, linux-kernel
On Fri, Oct 12, 2012 at 6:31 AM, Tang Chen <tangchen@cn.fujitsu.com> wrote:
> "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array
> container_device_ids[], so use it, but not the hard coding style.
>
> Also, introduce a new api is_container_device() to determine if a
> device is a container device.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Looks good to me, but is_container_device() should be of type "bool",
not type "int".
With that change,
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/acpi/container.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
> index 1f9f7d7..ffd76ee 100644
> --- a/drivers/acpi/container.c
> +++ b/drivers/acpi/container.c
> @@ -92,6 +92,19 @@ static int is_device_present(acpi_handle handle)
> return ((sta & ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
> }
>
> +static int is_container_device(const char *hid)
> +{
> + const struct acpi_device_id *container_id;
> +
> + for (container_id = container_device_ids;
> + container_id->id[0]; container_id++) {
> + if (!strcmp((char *)container_id->id, hid))
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> /*******************************************************************/
> static int acpi_container_add(struct acpi_device *device)
> {
> @@ -232,10 +245,8 @@ container_walk_namespace_cb(acpi_handle handle,
> goto end;
> }
>
> - if (strcmp(hid, "ACPI0004") && strcmp(hid, "PNP0A05") &&
> - strcmp(hid, "PNP0A06")) {
> + if (!is_container_device(hid))
> goto end;
> - }
>
> switch (*action) {
> case INSTALL_NOTIFY_HANDLER:
> --
> 1.7.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fix a hard coding style when determining if a device is a container.
2012-10-12 12:31 [PATCH v2] Fix a hard coding style when determining if a device is a container Tang Chen
` (2 preceding siblings ...)
2012-10-23 16:00 ` Bjorn Helgaas
@ 2012-10-24 22:16 ` Rafael J. Wysocki
3 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2012-10-24 22:16 UTC (permalink / raw)
To: Tang Chen
Cc: bhelgaas, lenb, yinghai, jiang.liu, izumi.taku, isimatu.yasuaki,
linux-acpi, linux-pci, linux-kernel
On Friday 12 of October 2012 20:31:38 Tang Chen wrote:
> "ACPI0004","PNP0A05" and "PNP0A06" are all defined in array
> container_device_ids[], so use it, but not the hard coding style.
>
> Also, introduce a new api is_container_device() to determine if a
> device is a container device.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Applied to linux-pm.git/acpi-next as v3.8 material.
Thanks,
Rafael
> ---
> drivers/acpi/container.c | 17 ++++++++++++++---
> 1 files changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/container.c b/drivers/acpi/container.c
> index 1f9f7d7..ffd76ee 100644
> --- a/drivers/acpi/container.c
> +++ b/drivers/acpi/container.c
> @@ -92,6 +92,19 @@ static int is_device_present(acpi_handle handle)
> return ((sta & ACPI_STA_DEVICE_PRESENT) == ACPI_STA_DEVICE_PRESENT);
> }
>
> +static int is_container_device(const char *hid)
> +{
> + const struct acpi_device_id *container_id;
> +
> + for (container_id = container_device_ids;
> + container_id->id[0]; container_id++) {
> + if (!strcmp((char *)container_id->id, hid))
> + return 1;
> + }
> +
> + return 0;
> +}
> +
> /*******************************************************************/
> static int acpi_container_add(struct acpi_device *device)
> {
> @@ -232,10 +245,8 @@ container_walk_namespace_cb(acpi_handle handle,
> goto end;
> }
>
> - if (strcmp(hid, "ACPI0004") && strcmp(hid, "PNP0A05") &&
> - strcmp(hid, "PNP0A06")) {
> + if (!is_container_device(hid))
> goto end;
> - }
>
> switch (*action) {
> case INSTALL_NOTIFY_HANDLER:
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-24 22:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-12 12:31 [PATCH v2] Fix a hard coding style when determining if a device is a container Tang Chen
2012-10-17 3:26 ` Tang Chen
2012-10-23 12:05 ` Tang Chen
2012-10-23 16:00 ` Bjorn Helgaas
2012-10-24 22:16 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).