* [PATCH] drm/msm: Fix undefined "rd_full" link error
@ 2020-04-30 19:24 Bjorn Andersson
2020-05-01 18:07 ` Rob Clark
2020-05-03 22:32 ` Stephen Rothwell
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Andersson @ 2020-04-30 19:24 UTC (permalink / raw)
To: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse
Cc: linux-arm-msm, dri-devel, freedreno, linux-kernel, Stephen Rothwell
rd_full should be defined outside the CONFIG_DEBUG_FS region, in order
to be able to link the msm driver even when CONFIG_DEBUG_FS is disabled.
Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers")
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
drivers/gpu/drm/msm/msm_rd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
index 732f65df5c4f..fea30e7aa9e8 100644
--- a/drivers/gpu/drm/msm/msm_rd.c
+++ b/drivers/gpu/drm/msm/msm_rd.c
@@ -29,8 +29,6 @@
* or shader programs (if not emitted inline in cmdstream).
*/
-#ifdef CONFIG_DEBUG_FS
-
#include <linux/circ_buf.h>
#include <linux/debugfs.h>
#include <linux/kfifo.h>
@@ -47,6 +45,8 @@ bool rd_full = false;
MODULE_PARM_DESC(rd_full, "If true, $debugfs/.../rd will snapshot all buffer contents");
module_param_named(rd_full, rd_full, bool, 0600);
+#ifdef CONFIG_DEBUG_FS
+
enum rd_sect_type {
RD_NONE,
RD_TEST, /* ascii text */
--
2.24.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Fix undefined "rd_full" link error
2020-04-30 19:24 [PATCH] drm/msm: Fix undefined "rd_full" link error Bjorn Andersson
@ 2020-05-01 18:07 ` Rob Clark
2020-05-03 22:32 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Rob Clark @ 2020-05-01 18:07 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse,
linux-arm-msm, dri-devel, freedreno, Linux Kernel Mailing List,
Stephen Rothwell
On Thu, Apr 30, 2020 at 12:25 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> rd_full should be defined outside the CONFIG_DEBUG_FS region, in order
> to be able to link the msm driver even when CONFIG_DEBUG_FS is disabled.
>
> Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
thanks,
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/msm/msm_rd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
> index 732f65df5c4f..fea30e7aa9e8 100644
> --- a/drivers/gpu/drm/msm/msm_rd.c
> +++ b/drivers/gpu/drm/msm/msm_rd.c
> @@ -29,8 +29,6 @@
> * or shader programs (if not emitted inline in cmdstream).
> */
>
> -#ifdef CONFIG_DEBUG_FS
> -
> #include <linux/circ_buf.h>
> #include <linux/debugfs.h>
> #include <linux/kfifo.h>
> @@ -47,6 +45,8 @@ bool rd_full = false;
> MODULE_PARM_DESC(rd_full, "If true, $debugfs/.../rd will snapshot all buffer contents");
> module_param_named(rd_full, rd_full, bool, 0600);
>
> +#ifdef CONFIG_DEBUG_FS
> +
> enum rd_sect_type {
> RD_NONE,
> RD_TEST, /* ascii text */
> --
> 2.24.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Fix undefined "rd_full" link error
2020-04-30 19:24 [PATCH] drm/msm: Fix undefined "rd_full" link error Bjorn Andersson
2020-05-01 18:07 ` Rob Clark
@ 2020-05-03 22:32 ` Stephen Rothwell
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2020-05-03 22:32 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Rob Clark, Sean Paul, David Airlie, Daniel Vetter, Jordan Crouse,
linux-arm-msm, dri-devel, freedreno, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1454 bytes --]
Hi all,
On Thu, 30 Apr 2020 12:24:27 -0700 Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> rd_full should be defined outside the CONFIG_DEBUG_FS region, in order
> to be able to link the msm driver even when CONFIG_DEBUG_FS is disabled.
>
> Fixes: e515af8d4a6f ("drm/msm: devcoredump should dump MSM_SUBMIT_BO_DUMP buffers")
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_rd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
> index 732f65df5c4f..fea30e7aa9e8 100644
> --- a/drivers/gpu/drm/msm/msm_rd.c
> +++ b/drivers/gpu/drm/msm/msm_rd.c
> @@ -29,8 +29,6 @@
> * or shader programs (if not emitted inline in cmdstream).
> */
>
> -#ifdef CONFIG_DEBUG_FS
> -
> #include <linux/circ_buf.h>
> #include <linux/debugfs.h>
> #include <linux/kfifo.h>
> @@ -47,6 +45,8 @@ bool rd_full = false;
> MODULE_PARM_DESC(rd_full, "If true, $debugfs/.../rd will snapshot all buffer contents");
> module_param_named(rd_full, rd_full, bool, 0600);
>
> +#ifdef CONFIG_DEBUG_FS
> +
> enum rd_sect_type {
> RD_NONE,
> RD_TEST, /* ascii text */
> --
> 2.24.0
>
Added to my fixes tree form today. I will remove it when it is merged
upstream through someone else's tree.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-03 22:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-30 19:24 [PATCH] drm/msm: Fix undefined "rd_full" link error Bjorn Andersson
2020-05-01 18:07 ` Rob Clark
2020-05-03 22:32 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).