* [PATCH] habanalbas: rephrase error message
@ 2020-07-04 19:51 Omer Shpigelman
2020-07-04 21:39 ` Oded Gabbay
0 siblings, 1 reply; 2+ messages in thread
From: Omer Shpigelman @ 2020-07-04 19:51 UTC (permalink / raw)
To: oded.gabbay; +Cc: linux-kernel
Rephrase F/W error message to make it more understandable to ordinary
users.
Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
---
drivers/misc/habanalabs/firmware_if.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
index baf790cf4b78..171baa2b56b0 100644
--- a/drivers/misc/habanalabs/firmware_if.c
+++ b/drivers/misc/habanalabs/firmware_if.c
@@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
"Device reports FIT image is corrupted\n");
else
dev_err(hdev->dev,
- "Device failed to load, %d\n", status);
+ "Failed to load firmware to device, %d\n",
+ status);
rc = -EIO;
goto out;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] habanalbas: rephrase error message
2020-07-04 19:51 [PATCH] habanalbas: rephrase error message Omer Shpigelman
@ 2020-07-04 21:39 ` Oded Gabbay
0 siblings, 0 replies; 2+ messages in thread
From: Oded Gabbay @ 2020-07-04 21:39 UTC (permalink / raw)
To: Omer Shpigelman; +Cc: Linux-Kernel@Vger. Kernel. Org
On Sat, Jul 4, 2020 at 10:51 PM Omer Shpigelman <oshpigelman@habana.ai> wrote:
>
> Rephrase F/W error message to make it more understandable to ordinary
> users.
>
> Signed-off-by: Omer Shpigelman <oshpigelman@habana.ai>
> ---
> drivers/misc/habanalabs/firmware_if.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b78..171baa2b56b0 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
> "Device reports FIT image is corrupted\n");
> else
> dev_err(hdev->dev,
> - "Device failed to load, %d\n", status);
> + "Failed to load firmware to device, %d\n",
> + status);
>
> rc = -EIO;
> goto out;
> --
> 2.17.1
>
This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-04 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 19:51 [PATCH] habanalbas: rephrase error message Omer Shpigelman
2020-07-04 21:39 ` Oded Gabbay
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).