* [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
[not found] <CAFDyS3P0rHeG9eNc4ttVx6EX18CtGj2WUi+9W+YRO3=fCvUsBQ@mail.gmail.com>
@ 2015-08-07 17:52 ` Tal Shorer
2015-08-07 18:06 ` Greg KH
2015-08-07 18:07 ` Greg KH
0 siblings, 2 replies; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 17:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Tal Shorer
>From the usb 3.1 spec available at http://www.usb.org/developers/docs/
table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
GetPortErrorCount as:
Request bmRequestType bRequest wValue wIndex wLength Data
SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
Errors on this port
Fix these two values to match the spec.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
include/linux/usb/hcd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index c9aa779..6a24416 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
/*-------------------------------------------------------------------------*/
-/* class requests from USB 3.0 hub spec, table 10-5 */
-#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
-#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
+/* class requests from USB 3.1 hub spec, table 10-7 */
+#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
+#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
/*
* Generic bandwidth allocation constants/support
--
2.4.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 17:52 ` [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer
@ 2015-08-07 18:06 ` Greg KH
2015-08-07 18:07 ` Greg KH
1 sibling, 0 replies; 10+ messages in thread
From: Greg KH @ 2015-08-07 18:06 UTC (permalink / raw)
To: Tal Shorer; +Cc: linux-usb, linux-kernel
On Fri, Aug 07, 2015 at 08:52:25PM +0300, Tal Shorer wrote:
> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
>
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
> Errors on this port
This doesn't make much sense at all, can you properly format it to look
correct?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 17:52 ` [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer
2015-08-07 18:06 ` Greg KH
@ 2015-08-07 18:07 ` Greg KH
2015-08-07 18:13 ` [Patch v2] " Tal Shorer
2015-08-07 18:16 ` [Patch v3] " Tal Shorer
1 sibling, 2 replies; 10+ messages in thread
From: Greg KH @ 2015-08-07 18:07 UTC (permalink / raw)
To: Tal Shorer; +Cc: linux-usb, linux-kernel
On Fri, Aug 07, 2015 at 08:52:25PM +0300, Tal Shorer wrote:
> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
>
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
> Errors on this port
>
> Fix these two values to match the spec.
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> include/linux/usb/hcd.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..6a24416 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
>
> /*-------------------------------------------------------------------------*/
>
> -/* class requests from USB 3.0 hub spec, table 10-5 */
> -#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
> -#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
> +/* class requests from USB 3.1 hub spec, table 10-7 */
> +#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
> +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
Why did you loose the indentation?
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Patch v2] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:07 ` Greg KH
@ 2015-08-07 18:13 ` Tal Shorer
2015-08-07 18:15 ` Tal Shorer
2015-08-07 18:16 ` [Patch v3] " Tal Shorer
1 sibling, 1 reply; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 18:13 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Tal Shorer
>From the usb 3.1 spec available at http://www.usb.org/developers/docs/
table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
GetPortErrorCount as:
Request bmRequestType bRequest wValue wIndex wLength Data
SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
Errors on this port
Fix these two values to match the spec.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
include/linux/usb/hcd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index c9aa779..d2784c1 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
/*-------------------------------------------------------------------------*/
-/* class requests from USB 3.0 hub spec, table 10-5 */
-#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
-#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
+/* class requests from USB 3.1 hub spec, table 10-7 */
+#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
+#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
/*
* Generic bandwidth allocation constants/support
--
2.4.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Patch v2] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:13 ` [Patch v2] " Tal Shorer
@ 2015-08-07 18:15 ` Tal Shorer
0 siblings, 0 replies; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 18:15 UTC (permalink / raw)
To: <gregkh@linuxfoundation.org>
Cc: USB list, <linux-kernel@vger.kernel.org>, Tal Shorer
Please ignore v2, I missed that you
On Fri, Aug 7, 2015 at 9:13 PM, Tal Shorer <tal.shorer@gmail.com> wrote:
> From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
>
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link
> Errors on this port
>
> Fix these two values to match the spec.
>
> Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
> ---
> include/linux/usb/hcd.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..d2784c1 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
>
> /*-------------------------------------------------------------------------*/
>
> -/* class requests from USB 3.0 hub spec, table 10-5 */
> -#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
> -#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
> +/* class requests from USB 3.1 hub spec, table 10-7 */
> +#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
> +#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
>
> /*
> * Generic bandwidth allocation constants/support
> --
> 2.4.6
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:07 ` Greg KH
2015-08-07 18:13 ` [Patch v2] " Tal Shorer
@ 2015-08-07 18:16 ` Tal Shorer
2015-08-07 18:40 ` Greg KH
1 sibling, 1 reply; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 18:16 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Tal Shorer
>From the usb 3.1 spec available at http://www.usb.org/developers/docs/
table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
GetPortErrorCount as:
Request bmRequestType bRequest wValue wIndex wLength Data
SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
Fix these two values to match the spec.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
include/linux/usb/hcd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index c9aa779..d2784c1 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
/*-------------------------------------------------------------------------*/
-/* class requests from USB 3.0 hub spec, table 10-5 */
-#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
-#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
+/* class requests from USB 3.1 hub spec, table 10-7 */
+#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
+#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
/*
* Generic bandwidth allocation constants/support
--
2.4.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:16 ` [Patch v3] " Tal Shorer
@ 2015-08-07 18:40 ` Greg KH
2015-08-07 18:48 ` Tal Shorer
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2015-08-07 18:40 UTC (permalink / raw)
To: Tal Shorer; +Cc: linux-usb, linux-kernel
On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote:
> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> GetPortErrorCount as:
>
> Request bmRequestType bRequest wValue wIndex wLength Data
> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
Still does not look correct to me, how about you?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:40 ` Greg KH
@ 2015-08-07 18:48 ` Tal Shorer
2015-08-07 19:30 ` Greg KH
0 siblings, 1 reply; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 18:48 UTC (permalink / raw)
To: Greg KH; +Cc: USB list, <linux-kernel@vger.kernel.org>
On Fri, Aug 7, 2015 at 9:40 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote:
>> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
>> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
>> GetPortErrorCount as:
>>
>> Request bmRequestType bRequest wValue wIndex wLength Data
>> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
>> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
>
> Still does not look correct to me, how about you?
>
Not sure what you mean. This is a simple copy-paste from the spec document.
Do you want me to put quotation marks around the multi-word Data column?
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Patch v3] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 18:48 ` Tal Shorer
@ 2015-08-07 19:30 ` Greg KH
2015-08-07 19:35 ` [Patch v4] " Tal Shorer
0 siblings, 1 reply; 10+ messages in thread
From: Greg KH @ 2015-08-07 19:30 UTC (permalink / raw)
To: Tal Shorer; +Cc: USB list, <linux-kernel@vger.kernel.org>
On Fri, Aug 07, 2015 at 09:48:19PM +0300, Tal Shorer wrote:
> On Fri, Aug 7, 2015 at 9:40 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Aug 07, 2015 at 09:16:00PM +0300, Tal Shorer wrote:
> >> >From the usb 3.1 spec available at http://www.usb.org/developers/docs/
> >> table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
> >> GetPortErrorCount as:
> >>
> >> Request bmRequestType bRequest wValue wIndex wLength Data
> >> SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
> >> GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
> >
> > Still does not look correct to me, how about you?
> >
>
> Not sure what you mean. This is a simple copy-paste from the spec document.
> Do you want me to put quotation marks around the multi-word Data column?
I want the columns to line up so that they look sane and someone can
understand what they mean :)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Patch v4] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification
2015-08-07 19:30 ` Greg KH
@ 2015-08-07 19:35 ` Tal Shorer
0 siblings, 0 replies; 10+ messages in thread
From: Tal Shorer @ 2015-08-07 19:35 UTC (permalink / raw)
To: gregkh; +Cc: linux-usb, linux-kernel, Tal Shorer
>From the usb 3.1 spec available at http://www.usb.org/developers/docs/
table 10-7 (Hub Class Requests) specifies the values for SetHubDepth and
GetPortErrorCount as:
Request bmRequestType bRequest wValue wIndex wLength Data
SetHubDepth 00100000B SET_HUB_DEPTH Hub Depth Zero Zero None
GetPortErrorCount 10100011B GET_PORT_ERR_COUNT Zero Port Two Number of Link Errors on this port
Fix these two values to match the spec.
Signed-off-by: Tal Shorer <tal.shorer@gmail.com>
---
include/linux/usb/hcd.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index c9aa779..d2784c1 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -564,9 +564,9 @@ extern void usb_ep0_reinit(struct usb_device *);
/*-------------------------------------------------------------------------*/
-/* class requests from USB 3.0 hub spec, table 10-5 */
-#define SetHubDepth (0x3000 | HUB_SET_DEPTH)
-#define GetPortErrorCount (0x8000 | HUB_GET_PORT_ERR_COUNT)
+/* class requests from USB 3.1 hub spec, table 10-7 */
+#define SetHubDepth (0x2000 | HUB_SET_DEPTH)
+#define GetPortErrorCount (0xa300 | HUB_GET_PORT_ERR_COUNT)
/*
* Generic bandwidth allocation constants/support
--
2.4.6
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-08-07 19:36 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAFDyS3P0rHeG9eNc4ttVx6EX18CtGj2WUi+9W+YRO3=fCvUsBQ@mail.gmail.com>
2015-08-07 17:52 ` [PATCH] usb: hcd.h: Fix the values of SetHubDepth and GetPortErrorCount to match USB 3.1 specification Tal Shorer
2015-08-07 18:06 ` Greg KH
2015-08-07 18:07 ` Greg KH
2015-08-07 18:13 ` [Patch v2] " Tal Shorer
2015-08-07 18:15 ` Tal Shorer
2015-08-07 18:16 ` [Patch v3] " Tal Shorer
2015-08-07 18:40 ` Greg KH
2015-08-07 18:48 ` Tal Shorer
2015-08-07 19:30 ` Greg KH
2015-08-07 19:35 ` [Patch v4] " Tal Shorer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).