* [PATCH] drm/meson: add support for 1080p25 mode
@ 2018-11-21 9:39 Christian Hewitt
2018-11-21 9:47 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Christian Hewitt @ 2018-11-21 9:39 UTC (permalink / raw)
Cc: christianshewitt, Neil Armstrong, David Airlie, Carlo Caione,
Kevin Hilman, dri-devel, linux-amlogic, linux-arm-kernel,
linux-kernel
This essential mode for PAL users is missing, so add it.
Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
---
drivers/gpu/drm/meson/meson_venc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
index acbbad3..ab16046 100644
--- a/drivers/gpu/drm/meson/meson_venc.c
+++ b/drivers/gpu/drm/meson/meson_venc.c
@@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
{ 5, &meson_hdmi_encp_mode_1080i60 },
{ 20, &meson_hdmi_encp_mode_1080i50 },
{ 32, &meson_hdmi_encp_mode_1080p24 },
+ { 33, &meson_hdmi_encp_mode_1080p50 },
{ 34, &meson_hdmi_encp_mode_1080p30 },
{ 31, &meson_hdmi_encp_mode_1080p50 },
{ 16, &meson_hdmi_encp_mode_1080p60 },
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] drm/meson: add support for 1080p25 mode
2018-11-21 9:39 [PATCH] drm/meson: add support for 1080p25 mode Christian Hewitt
@ 2018-11-21 9:47 ` Neil Armstrong
2018-11-23 12:57 ` Michal Lazo
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2018-11-21 9:47 UTC (permalink / raw)
To: Christian Hewitt
Cc: David Airlie, Carlo Caione, Kevin Hilman, dri-devel,
linux-amlogic, linux-arm-kernel, linux-kernel
On 21/11/2018 10:39, Christian Hewitt wrote:
> This essential mode for PAL users is missing, so add it.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> ---
> drivers/gpu/drm/meson/meson_venc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> index acbbad3..ab16046 100644
> --- a/drivers/gpu/drm/meson/meson_venc.c
> +++ b/drivers/gpu/drm/meson/meson_venc.c
> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> { 5, &meson_hdmi_encp_mode_1080i60 },
> { 20, &meson_hdmi_encp_mode_1080i50 },
> { 32, &meson_hdmi_encp_mode_1080p24 },
> + { 33, &meson_hdmi_encp_mode_1080p50 },
> { 34, &meson_hdmi_encp_mode_1080p30 },
> { 31, &meson_hdmi_encp_mode_1080p50 },
> { 16, &meson_hdmi_encp_mode_1080p60 },
>
Exact, I forgot this mode...
Thanks for the change !
Acked-by: Neil Armstrong <narmstrong@baylibre.com>
I'll add :
Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
when applying to drm-misc-fixes.
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/meson: add support for 1080p25 mode
2018-11-21 9:47 ` Neil Armstrong
@ 2018-11-23 12:57 ` Michal Lazo
2018-11-23 13:15 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Michal Lazo @ 2018-11-23 12:57 UTC (permalink / raw)
To: narmstrong
Cc: christianshewitt, airlied, khilman, linux-kernel, dri-devel,
carlo, linux-amlogic, linux-arm-kernel
I would suggest same aproach as for
"meson_hdmi_encp_mode_1080p30"
and "meson_hdmi_encp_mode_1080p60"
so duplicate "meson_hdmi_encp_mode_1080p50"
with name "meson_hdmi_encp_mode_1080p25"
now the code looks really like common copy paste problem
Michal Lazo
On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> On 21/11/2018 10:39, Christian Hewitt wrote:
> > This essential mode for PAL users is missing, so add it.
> >
> > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> > ---
> > drivers/gpu/drm/meson/meson_venc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> > index acbbad3..ab16046 100644
> > --- a/drivers/gpu/drm/meson/meson_venc.c
> > +++ b/drivers/gpu/drm/meson/meson_venc.c
> > @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> > { 5, &meson_hdmi_encp_mode_1080i60 },
> > { 20, &meson_hdmi_encp_mode_1080i50 },
> > { 32, &meson_hdmi_encp_mode_1080p24 },
> > + { 33, &meson_hdmi_encp_mode_1080p50 },
> > { 34, &meson_hdmi_encp_mode_1080p30 },
> > { 31, &meson_hdmi_encp_mode_1080p50 },
> > { 16, &meson_hdmi_encp_mode_1080p60 },
> >
>
> Exact, I forgot this mode...
>
> Thanks for the change !
>
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>
> I'll add :
> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
> when applying to drm-misc-fixes.
>
> Neil
>
> _______________________________________________
> linux-amlogic mailing list
> linux-amlogic@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-amlogic
--
Best Regards
Michal Lazo
Senior developer engineer
mdragon.org
Slovakia
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/meson: add support for 1080p25 mode
2018-11-23 12:57 ` Michal Lazo
@ 2018-11-23 13:15 ` Neil Armstrong
2018-11-23 13:23 ` Michal Lazo
0 siblings, 1 reply; 6+ messages in thread
From: Neil Armstrong @ 2018-11-23 13:15 UTC (permalink / raw)
To: Michal Lazo
Cc: christianshewitt, airlied, khilman, linux-kernel, dri-devel,
carlo, linux-amlogic, linux-arm-kernel
Hi Michal,
On 23/11/2018 13:57, Michal Lazo wrote:
> I would suggest same aproach as for
> "meson_hdmi_encp_mode_1080p30"
> and "meson_hdmi_encp_mode_1080p60"
>
> so duplicate "meson_hdmi_encp_mode_1080p50"
> with name "meson_hdmi_encp_mode_1080p25"
The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60,
so I don't see the point about duplicating a same table for the sake of naming.
We will the exact same thing to support the 2160p50/2160p60 modes by reusing the
same config are 2160p25/2160p50, and I don't see the point of duplication the
tables here aswell.
Neil
>
> now the code looks really like common copy paste problem
> Michal Lazo
> On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> On 21/11/2018 10:39, Christian Hewitt wrote:
>>> This essential mode for PAL users is missing, so add it.
>>>
>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>> ---
>>> drivers/gpu/drm/meson/meson_venc.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
>>> index acbbad3..ab16046 100644
>>> --- a/drivers/gpu/drm/meson/meson_venc.c
>>> +++ b/drivers/gpu/drm/meson/meson_venc.c
>>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
>>> { 5, &meson_hdmi_encp_mode_1080i60 },
>>> { 20, &meson_hdmi_encp_mode_1080i50 },
>>> { 32, &meson_hdmi_encp_mode_1080p24 },
>>> + { 33, &meson_hdmi_encp_mode_1080p50 },
>>> { 34, &meson_hdmi_encp_mode_1080p30 },
>>> { 31, &meson_hdmi_encp_mode_1080p50 },
>>> { 16, &meson_hdmi_encp_mode_1080p60 },
>>>
>>
>> Exact, I forgot this mode...
>>
>> Thanks for the change !
>>
>> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>>
>> I'll add :
>> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
>> when applying to drm-misc-fixes.
>>
>> Neil
>>
>> _______________________________________________
>> linux-amlogic mailing list
>> linux-amlogic@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/meson: add support for 1080p25 mode
2018-11-23 13:15 ` Neil Armstrong
@ 2018-11-23 13:23 ` Michal Lazo
2018-11-26 8:52 ` Neil Armstrong
0 siblings, 1 reply; 6+ messages in thread
From: Michal Lazo @ 2018-11-23 13:23 UTC (permalink / raw)
To: narmstrong
Cc: christianshewitt, airlied, khilman, linux-kernel, dri-devel,
carlo, linux-amlogic, linux-arm-kernel
I checked 1080p30/1080p60 and values are same
I didn't check others
so clean duplicates
or make duplicates :)
On Fri, Nov 23, 2018 at 2:15 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>
> Hi Michal,
>
> On 23/11/2018 13:57, Michal Lazo wrote:
> > I would suggest same aproach as for
> > "meson_hdmi_encp_mode_1080p30"
> > and "meson_hdmi_encp_mode_1080p60"
> >
> > so duplicate "meson_hdmi_encp_mode_1080p50"
> > with name "meson_hdmi_encp_mode_1080p25"
>
> The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60,
> so I don't see the point about duplicating a same table for the sake of naming.
>
> We will the exact same thing to support the 2160p50/2160p60 modes by reusing the
> same config are 2160p25/2160p50, and I don't see the point of duplication the
> tables here aswell.
>
> Neil
>
> >
> > now the code looks really like common copy paste problem
> > Michal Lazo
> > On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
> >>
> >> On 21/11/2018 10:39, Christian Hewitt wrote:
> >>> This essential mode for PAL users is missing, so add it.
> >>>
> >>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
> >>> ---
> >>> drivers/gpu/drm/meson/meson_venc.c | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
> >>> index acbbad3..ab16046 100644
> >>> --- a/drivers/gpu/drm/meson/meson_venc.c
> >>> +++ b/drivers/gpu/drm/meson/meson_venc.c
> >>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
> >>> { 5, &meson_hdmi_encp_mode_1080i60 },
> >>> { 20, &meson_hdmi_encp_mode_1080i50 },
> >>> { 32, &meson_hdmi_encp_mode_1080p24 },
> >>> + { 33, &meson_hdmi_encp_mode_1080p50 },
> >>> { 34, &meson_hdmi_encp_mode_1080p30 },
> >>> { 31, &meson_hdmi_encp_mode_1080p50 },
> >>> { 16, &meson_hdmi_encp_mode_1080p60 },
> >>>
> >>
> >> Exact, I forgot this mode...
> >>
> >> Thanks for the change !
> >>
> >> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> >>
> >> I'll add :
> >> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
> >> when applying to drm-misc-fixes.
> >>
> >> Neil
> >>
> >> _______________________________________________
> >> linux-amlogic mailing list
> >> linux-amlogic@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-amlogic
> >
> >
> >
>
--
Best Regards
Michal Lazo
Senior developer engineer
mdragon.org
Slovakia
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] drm/meson: add support for 1080p25 mode
2018-11-23 13:23 ` Michal Lazo
@ 2018-11-26 8:52 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2018-11-26 8:52 UTC (permalink / raw)
To: Michal Lazo
Cc: christianshewitt, airlied, khilman, linux-kernel, dri-devel,
carlo, linux-amlogic, linux-arm-kernel
Hi Michal,
On 23/11/2018 14:23, Michal Lazo wrote:
Please do not top-post !
> I checked 1080p30/1080p60 and values are same
> I didn't check others
> so clean duplicates
> or make duplicates :)
I'll be happy to apply your patches !
Neil
>
>
> On Fri, Nov 23, 2018 at 2:15 PM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>
>> Hi Michal,
>>
>> On 23/11/2018 13:57, Michal Lazo wrote:
>>> I would suggest same aproach as for
>>> "meson_hdmi_encp_mode_1080p30"
>>> and "meson_hdmi_encp_mode_1080p60"
>>>
>>> so duplicate "meson_hdmi_encp_mode_1080p50"
>>> with name "meson_hdmi_encp_mode_1080p25"
>>
>> The configs are litterally the same for 1080p25 and 1080p60 unlike 1080p30/1080p60,
>> so I don't see the point about duplicating a same table for the sake of naming.
>>
>> We will the exact same thing to support the 2160p50/2160p60 modes by reusing the
>> same config are 2160p25/2160p50, and I don't see the point of duplication the
>> tables here aswell.
>>
>> Neil
>>
>>>
>>> now the code looks really like common copy paste problem
>>> Michal Lazo
>>> On Wed, Nov 21, 2018 at 10:47 AM Neil Armstrong <narmstrong@baylibre.com> wrote:
>>>>
>>>> On 21/11/2018 10:39, Christian Hewitt wrote:
>>>>> This essential mode for PAL users is missing, so add it.
>>>>>
>>>>> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
>>>>> ---
>>>>> drivers/gpu/drm/meson/meson_venc.c | 1 +
>>>>> 1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c
>>>>> index acbbad3..ab16046 100644
>>>>> --- a/drivers/gpu/drm/meson/meson_venc.c
>>>>> +++ b/drivers/gpu/drm/meson/meson_venc.c
>>>>> @@ -714,6 +714,7 @@ struct meson_hdmi_venc_vic_mode {
>>>>> { 5, &meson_hdmi_encp_mode_1080i60 },
>>>>> { 20, &meson_hdmi_encp_mode_1080i50 },
>>>>> { 32, &meson_hdmi_encp_mode_1080p24 },
>>>>> + { 33, &meson_hdmi_encp_mode_1080p50 },
>>>>> { 34, &meson_hdmi_encp_mode_1080p30 },
>>>>> { 31, &meson_hdmi_encp_mode_1080p50 },
>>>>> { 16, &meson_hdmi_encp_mode_1080p60 },
>>>>>
>>>>
>>>> Exact, I forgot this mode...
>>>>
>>>> Thanks for the change !
>>>>
>>>> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
>>>>
>>>> I'll add :
>>>> Fixes: 335e3713afb87 ("drm/meson: Add support for HDMI venc modes and settings")
>>>> when applying to drm-misc-fixes.
>>>>
>>>> Neil
>>>>
>>>> _______________________________________________
>>>> linux-amlogic mailing list
>>>> linux-amlogic@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/linux-amlogic
>>>
>>>
>>>
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-26 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-21 9:39 [PATCH] drm/meson: add support for 1080p25 mode Christian Hewitt
2018-11-21 9:47 ` Neil Armstrong
2018-11-23 12:57 ` Michal Lazo
2018-11-23 13:15 ` Neil Armstrong
2018-11-23 13:23 ` Michal Lazo
2018-11-26 8:52 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).