* [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies
@ 2021-05-04 22:02 Adrien Grassein
2021-05-05 14:28 ` Robert Foss
2021-05-05 17:18 ` Michal Suchánek
0 siblings, 2 replies; 4+ messages in thread
From: Adrien Grassein @ 2021-05-04 22:02 UTC (permalink / raw)
Cc: msuchanek, a.hajda, narmstrong, robert.foss, Laurent.pinchart,
jonas, jernej.skrabec, airlied, daniel, adrien.grassein,
dri-devel, linux-kernel
LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
DRM framework that needs VIDEOMODE_HELPERS to be enabled.
Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Reported-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 400193e38d29..70bcceaae9bf 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select REGMAP_I2C
+ select VIDEOMODE_HELPERS
help
Driver for Lontium LT8912B DSI to HDMI bridge
chip driver.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies
2021-05-04 22:02 [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies Adrien Grassein
@ 2021-05-05 14:28 ` Robert Foss
2021-05-05 14:30 ` Robert Foss
2021-05-05 17:18 ` Michal Suchánek
1 sibling, 1 reply; 4+ messages in thread
From: Robert Foss @ 2021-05-05 14:28 UTC (permalink / raw)
To: Adrien Grassein
Cc: msuchanek, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Hi Adrien,
Thanks for the quick fix.
On Wed, 5 May 2021 at 00:02, Adrien Grassein <adrien.grassein@gmail.com> wrote:
>
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select REGMAP_I2C
> + select VIDEOMODE_HELPERS
> help
> Driver for Lontium LT8912B DSI to HDMI bridge
> chip driver.
>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies
2021-05-05 14:28 ` Robert Foss
@ 2021-05-05 14:30 ` Robert Foss
0 siblings, 0 replies; 4+ messages in thread
From: Robert Foss @ 2021-05-05 14:30 UTC (permalink / raw)
To: Adrien Grassein
Cc: msuchanek, Andrzej Hajda, Neil Armstrong, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter,
dri-devel, linux-kernel
Pushed to drm-misc-next
On Wed, 5 May 2021 at 16:28, Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Adrien,
>
> Thanks for the quick fix.
>
> On Wed, 5 May 2021 at 00:02, Adrien Grassein <adrien.grassein@gmail.com> wrote:
> >
> > LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> > DRM framework that needs VIDEOMODE_HELPERS to be enabled.
> >
> > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> > Reported-by: Michal Suchánek <msuchanek@suse.de>
> > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > ---
> > drivers/gpu/drm/bridge/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 400193e38d29..70bcceaae9bf 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select REGMAP_I2C
> > + select VIDEOMODE_HELPERS
> > help
> > Driver for Lontium LT8912B DSI to HDMI bridge
> > chip driver.
> >
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies
2021-05-04 22:02 [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies Adrien Grassein
2021-05-05 14:28 ` Robert Foss
@ 2021-05-05 17:18 ` Michal Suchánek
1 sibling, 0 replies; 4+ messages in thread
From: Michal Suchánek @ 2021-05-05 17:18 UTC (permalink / raw)
To: Adrien Grassein
Cc: a.hajda, narmstrong, robert.foss, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, dri-devel, linux-kernel
On Wed, May 05, 2021 at 12:02:07AM +0200, Adrien Grassein wrote:
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select REGMAP_I2C
> + select VIDEOMODE_HELPERS
> help
> Driver for Lontium LT8912B DSI to HDMI bridge
> chip driver.
Indeed, this fixes the problem.
Thanks
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-05 17:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-04 22:02 [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies Adrien Grassein
2021-05-05 14:28 ` Robert Foss
2021-05-05 14:30 ` Robert Foss
2021-05-05 17:18 ` Michal Suchánek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).