[PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

[PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

[Adrien Grassein]

LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
DRM framework that needs VIDEOMODE_HELPERS to be enabled.

Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Reported-by: Michal Suchánek <msuchanek@suse.de>
Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
---
 drivers/gpu/drm/bridge/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index 400193e38d29..70bcceaae9bf 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
 	select DRM_KMS_HELPER
 	select DRM_MIPI_DSI
 	select REGMAP_I2C
+	select VIDEOMODE_HELPERS
 	help
 	  Driver for Lontium LT8912B DSI to HDMI bridge
 	  chip driver.
-- 
2.25.1

Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

[Robert Foss]

Hi Adrien,

Thanks for the quick fix.

On Wed, 5 May 2021 at 00:02, Adrien Grassein <adrien.grassein@gmail.com> wrote:
>
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
>         select DRM_KMS_HELPER
>         select DRM_MIPI_DSI
>         select REGMAP_I2C
> +       select VIDEOMODE_HELPERS
>         help
>           Driver for Lontium LT8912B DSI to HDMI bridge
>           chip driver.
>

Reviewed-by: Robert Foss <robert.foss@linaro.org>

Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

[Robert Foss]

Pushed to drm-misc-next

On Wed, 5 May 2021 at 16:28, Robert Foss <robert.foss@linaro.org> wrote:
>
> Hi Adrien,
>
> Thanks for the quick fix.
>
> On Wed, 5 May 2021 at 00:02, Adrien Grassein <adrien.grassein@gmail.com> wrote:
> >
> > LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> > DRM framework that needs VIDEOMODE_HELPERS to be enabled.
> >
> > Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> > Reported-by: Michal Suchánek <msuchanek@suse.de>
> > Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> > ---
> >  drivers/gpu/drm/bridge/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> > index 400193e38d29..70bcceaae9bf 100644
> > --- a/drivers/gpu/drm/bridge/Kconfig
> > +++ b/drivers/gpu/drm/bridge/Kconfig
> > @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
> >         select DRM_KMS_HELPER
> >         select DRM_MIPI_DSI
> >         select REGMAP_I2C
> > +       select VIDEOMODE_HELPERS
> >         help
> >           Driver for Lontium LT8912B DSI to HDMI bridge
> >           chip driver.
> >
>
> Reviewed-by: Robert Foss <robert.foss@linaro.org>

Re: [PATCH] drm/bridge: fix LONTIUM_LT8912B dependencies

[Michal Suchánek]

On Wed, May 05, 2021 at 12:02:07AM +0200, Adrien Grassein wrote:
> LONTIUM_LT8912B uses "drm_display_mode_to_videomode" from
> DRM framework that needs VIDEOMODE_HELPERS to be enabled.
> 
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Reported-by: Michal Suchánek <msuchanek@suse.de>
> Signed-off-by: Adrien Grassein <adrien.grassein@gmail.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 400193e38d29..70bcceaae9bf 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -68,6 +68,7 @@ config DRM_LONTIUM_LT8912B
>  	select DRM_KMS_HELPER
>  	select DRM_MIPI_DSI
>  	select REGMAP_I2C
> +	select VIDEOMODE_HELPERS
>  	help
>  	  Driver for Lontium LT8912B DSI to HDMI bridge
>  	  chip driver.

Indeed, this fixes the problem.

Thanks

Michal