Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware

From: Chanwoo Choi <cwchoi00@gmail.com>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Tue, 28 Jun 2016 21:06:48 +0900	[thread overview]
Message-ID: <CAGTfZH3ZhZ2gQcOSuAByZWD59E3Bro1aayr2JsM2W+mYa2LQTQ@mail.gmail.com> (raw)
In-Reply-To: <146705470025.30684.13257433085055355379@sboyd-linaro>

2016-06-28 4:11 GMT+09:00 Stephen Boyd <stephen.boyd@linaro.org>:
> Quoting Chanwoo Choi (2016-06-26 04:20:43)
>> 2016-06-26 14:56 GMT+09:00 Stephen Boyd <stephen.boyd@linaro.org>:
>> > +PROPERTIES
>> > +
>> > +- compatible:
>> > +    Usage: required
>> > +    Value type: <string>
>> > +    Definition: Should contain "qcom,pm8941-misc";
>> > +
>> > +- reg:
>> > +    Usage: required
>> > +    Value type: <u32>
>> > +    Definition: Should contain the offset to the misc address space
>>
>> 'reg' property is used on extcon-qcom-spmi-misc.c?
>> I think that you don't need to include this property.
>
> No it isn't used in the driver right now, but there is a register offset
> for this module and there are registers that can be read/written in this
> module. I'd like to keep it as required so we can easily read the
> registers in the future if needed.

OK.
But, If you want to remain the reg property, you should add the code to get
the register offset by using OF functions. This patch don't include the OF
function to handle it.

[snip]