From: Stephen Boyd <stephen.boyd@linaro.org>
To: Roger Quadros <rogerq@ti.com>, "Chanwoo Choi" <cw00.choi@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Tue, 28 Jun 2016 01:47:07 -0700 [thread overview]
Message-ID: <146710362771.3879.13924434427129313640@sboyd-linaro> (raw)
In-Reply-To: <57721AEA.6010509@ti.com>
Quoting Roger Quadros (2016-06-27 23:36:26)
> On 27/06/16 22:30, Stephen Boyd wrote:
> >
> > The VBUS notification is done through another piece of hardware. In this
> > case it's done by the charger module. I've sent a patch for that[1].
>
> Isn't it better if ID event is handled as well in that PMIC driver instead of
> creating a separate one here?
>
> Why do you need ID to be handled outside of the PMIC driver?
> You mentioned earlier that some Qualcomm PMICs have ID detection.
Sorry I must have confused you. There are two modules in the PMIC that
are doing detection here. The charger module is detecting the VBUS event
and this misc module is detecting the ID pin. I'm not sure why they're
two different blocks, but it is what it is in the hardware.
next prev parent reply other threads:[~2016-06-28 8:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 5:56 [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd
2016-06-26 11:20 ` Chanwoo Choi
2016-06-26 11:22 ` Chanwoo Choi
[not found] ` <146705470025.30684.13257433085055355379@sboyd-linaro>
2016-06-28 12:06 ` Chanwoo Choi
[not found] ` <CGME20160628215923epcas1p3f7942aca724bf2746c20319750184584@epcas1p3.samsung.com>
[not found] ` <146715115921.31418.2315766296233007937@sboyd-linaro>
2016-06-29 6:25 ` Chanwoo Choi
2016-06-29 18:48 ` Stephen Boyd
2016-06-30 0:35 ` Chanwoo Choi
2016-06-30 1:04 ` Stephen Boyd
2016-06-27 7:39 ` Roger Quadros
2016-06-27 19:30 ` Stephen Boyd
2016-06-28 6:36 ` Roger Quadros
2016-06-28 8:47 ` Stephen Boyd [this message]
2016-06-28 9:13 ` Roger Quadros
2016-06-28 22:01 ` Stephen Boyd
2016-06-29 6:10 ` Roger Quadros
2016-06-29 18:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146710362771.3879.13924434427129313640@sboyd-linaro \
--to=stephen.boyd@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).