From: Stephen Boyd <stephen.boyd@linaro.org>
To: Chanwoo Choi <cw00.choi@samsung.com>, Rob Herring <robh+dt@kernel.org>
Cc: Chanwoo Choi <cwchoi00@gmail.com>,
linux-arm-msm@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware
Date: Wed, 29 Jun 2016 18:04:54 -0700 [thread overview]
Message-ID: <CAJOFmgwBWUL9wYmzNgXqidGQbEPNYj-qYZGdNjidJ2Utswm3Gw@mail.gmail.com> (raw)
In-Reply-To: <57746935.4030107@samsung.com>
On 29 June 2016 at 17:35, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> On 2016년 06월 30일 03:48, Stephen Boyd wrote:
>> Quoting Chanwoo Choi (2016-06-28 23:25:57)
>>> On 2016년 06월 29일 06:59, Stephen Boyd wrote:
>>>> Quoting Chanwoo Choi (2016-06-28 05:06:48)
>>>>> 2016-06-28 4:11 GMT+09:00 Stephen Boyd <stephen.boyd@linaro.org>:
>>>>>> Quoting Chanwoo Choi (2016-06-26 04:20:43)
>>>>>>> 2016-06-26 14:56 GMT+09:00 Stephen Boyd <stephen.boyd@linaro.org>:
>>>>>>>> +PROPERTIES
>>>>>>>> +
>>>>>>>> +- compatible:
>>>>>>>> + Usage: required
>>>>>>>> + Value type: <string>
>>>>>>>> + Definition: Should contain "qcom,pm8941-misc";
>>>>>>>> +
>>>>>>>> +- reg:
>>>>>>>> + Usage: required
>>>>>>>> + Value type: <u32>
>>>>>>>> + Definition: Should contain the offset to the misc address space
>>>>>>>
>>>>>>> 'reg' property is used on extcon-qcom-spmi-misc.c?
>>>>>>> I think that you don't need to include this property.
>>>>>>
>>>>>> No it isn't used in the driver right now, but there is a register offset
>>>>>> for this module and there are registers that can be read/written in this
>>>>>> module. I'd like to keep it as required so we can easily read the
>>>>>> registers in the future if needed.
>>>>>
>>>>> OK.
>>>>> But, If you want to remain the reg property, you should add the code to get
>>>>> the register offset by using OF functions. This patch don't include the OF
>>>>> function to handle it.
>>>>>
>>>>
>>>> Sorry I don't follow the argument. I've put the reg property here for
>>>> future proofing so that the binding doesn't have to change in backwards
>>>> incompatible ways in the future if we do need to get the property later.
>>>
>>> I don't mention that 'reg' property should be removed.
>>
>> Ok good. We need to keep reg property as this device is on a bus that
>> uses reg property for addressing.
>>
>>> Just if you want to remain it, you should add some codes as following:
>>> For exmaple,
>>> - of_get_address() to get the address information from device-tree.
>>>
>>> If documentation include the some properties, you should add the handling code
>>> in device driver. When you add the code to get the offset from device-tree,
>>> it doesn't influence the some behavior in the future.
>>
>> Sorry I don't understand that argument. We can put properties into
>> bindings and not use them in drivers if there isn't any immediate need
>> to use them.
>>
>> From what I can tell you're suggesting we call of_get_address() in the
>> driver and then do nothing with the value of the property? Is that just
>> to check that the node is compliant with the binding and actually has a
>> reg property? We don't add code in the kernel to check dts compliance,
>> so I'm not inclined to do anything more here.
>
> I don't agree.
>
> When he DT binding document include the 'reg' property.
> But, the device driver don't include any code to handle the 'reg' property
> (just to get the offset). It is obviously wrong.
>
> It is just basic principle to write the Device-tree binding document.
>
> Other developer who don' know the history about 'reg' property
> would be embarrassed. Why don't extcon driver include the code to
> handle the 'reg' property? There is no method to explain it.
>
Perhaps Rob can explain why having a reg property is required for a
bus that has #address-cells=<1> even though the device driver isn't
using the reg property.
next prev parent reply other threads:[~2016-06-30 1:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-26 5:56 [PATCH] extcon: Add support for qcom SPMI PMIC USB id detection hardware Stephen Boyd
2016-06-26 11:20 ` Chanwoo Choi
2016-06-26 11:22 ` Chanwoo Choi
[not found] ` <146705470025.30684.13257433085055355379@sboyd-linaro>
2016-06-28 12:06 ` Chanwoo Choi
[not found] ` <CGME20160628215923epcas1p3f7942aca724bf2746c20319750184584@epcas1p3.samsung.com>
[not found] ` <146715115921.31418.2315766296233007937@sboyd-linaro>
2016-06-29 6:25 ` Chanwoo Choi
2016-06-29 18:48 ` Stephen Boyd
2016-06-30 0:35 ` Chanwoo Choi
2016-06-30 1:04 ` Stephen Boyd [this message]
2016-06-27 7:39 ` Roger Quadros
2016-06-27 19:30 ` Stephen Boyd
2016-06-28 6:36 ` Roger Quadros
2016-06-28 8:47 ` Stephen Boyd
2016-06-28 9:13 ` Roger Quadros
2016-06-28 22:01 ` Stephen Boyd
2016-06-29 6:10 ` Roger Quadros
2016-06-29 18:51 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJOFmgwBWUL9wYmzNgXqidGQbEPNYj-qYZGdNjidJ2Utswm3Gw@mail.gmail.com \
--to=stephen.boyd@linaro.org \
--cc=cw00.choi@samsung.com \
--cc=cwchoi00@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).