* [PATCH v1] module: Fully remove the kernel_module_from_file hook
@ 2016-07-09 18:19 Mickaël Salaün
2016-07-11 18:41 ` Kees Cook
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Mickaël Salaün @ 2016-07-09 18:19 UTC (permalink / raw)
To: linux-kernel
Cc: Mickaël Salaün, Mimi Zohar, Kees Cook,
Luis R . Rodriguez, Rusty Russell, Linus Torvalds,
Greg Kroah-Hartman, stable, linux-security-module
Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Luis R. Rodriguez <mcgrof@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
include/linux/lsm_hooks.h | 1 -
include/linux/security.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
index 7ae397669d8b..58c777ec8bcf 100644
--- a/include/linux/lsm_hooks.h
+++ b/include/linux/lsm_hooks.h
@@ -1455,7 +1455,6 @@ union security_list_options {
int (*kernel_act_as)(struct cred *new, u32 secid);
int (*kernel_create_files_as)(struct cred *new, struct inode *inode);
int (*kernel_module_request)(char *kmod_name);
- int (*kernel_module_from_file)(struct file *file);
int (*kernel_read_file)(struct file *file, enum kernel_read_file_id id);
int (*kernel_post_read_file)(struct file *file, char *buf, loff_t size,
enum kernel_read_file_id id);
diff --git a/include/linux/security.h b/include/linux/security.h
index 14df373ff2ca..2b8c7d2a3fd8 100644
--- a/include/linux/security.h
+++ b/include/linux/security.h
@@ -307,7 +307,6 @@ void security_transfer_creds(struct cred *new, const struct cred *old);
int security_kernel_act_as(struct cred *new, u32 secid);
int security_kernel_create_files_as(struct cred *new, struct inode *inode);
int security_kernel_module_request(char *kmod_name);
-int security_kernel_module_from_file(struct file *file);
int security_kernel_read_file(struct file *file, enum kernel_read_file_id id);
int security_kernel_post_read_file(struct file *file, char *buf, loff_t size,
enum kernel_read_file_id id);
--
2.8.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-07-09 18:19 [PATCH v1] module: Fully remove the kernel_module_from_file hook Mickaël Salaün
@ 2016-07-11 18:41 ` Kees Cook
2016-07-11 21:42 ` Greg Kroah-Hartman
2016-07-12 12:48 ` James Morris
2 siblings, 0 replies; 7+ messages in thread
From: Kees Cook @ 2016-07-11 18:41 UTC (permalink / raw)
To: Mickaël Salaün, James Morris
Cc: LKML, Mimi Zohar, Luis R . Rodriguez, Rusty Russell,
Linus Torvalds, Greg Kroah-Hartman, # 3.4.x,
linux-security-module
On Sat, Jul 9, 2016 at 2:19 PM, Mickaël Salaün <mic@digikod.net> wrote:
> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
Oh, hrm, was that still in there? Thanks for the catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> include/linux/lsm_hooks.h | 1 -
> include/linux/security.h | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index 7ae397669d8b..58c777ec8bcf 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -1455,7 +1455,6 @@ union security_list_options {
> int (*kernel_act_as)(struct cred *new, u32 secid);
> int (*kernel_create_files_as)(struct cred *new, struct inode *inode);
> int (*kernel_module_request)(char *kmod_name);
> - int (*kernel_module_from_file)(struct file *file);
> int (*kernel_read_file)(struct file *file, enum kernel_read_file_id id);
> int (*kernel_post_read_file)(struct file *file, char *buf, loff_t size,
> enum kernel_read_file_id id);
> diff --git a/include/linux/security.h b/include/linux/security.h
> index 14df373ff2ca..2b8c7d2a3fd8 100644
> --- a/include/linux/security.h
> +++ b/include/linux/security.h
> @@ -307,7 +307,6 @@ void security_transfer_creds(struct cred *new, const struct cred *old);
> int security_kernel_act_as(struct cred *new, u32 secid);
> int security_kernel_create_files_as(struct cred *new, struct inode *inode);
> int security_kernel_module_request(char *kmod_name);
> -int security_kernel_module_from_file(struct file *file);
> int security_kernel_read_file(struct file *file, enum kernel_read_file_id id);
> int security_kernel_post_read_file(struct file *file, char *buf, loff_t size,
> enum kernel_read_file_id id);
> --
> 2.8.1
>
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-07-09 18:19 [PATCH v1] module: Fully remove the kernel_module_from_file hook Mickaël Salaün
2016-07-11 18:41 ` Kees Cook
@ 2016-07-11 21:42 ` Greg Kroah-Hartman
2016-07-12 12:48 ` James Morris
2 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2016-07-11 21:42 UTC (permalink / raw)
To: Mickaël Salaün
Cc: linux-kernel, Mimi Zohar, Kees Cook, Luis R . Rodriguez,
Rusty Russell, Linus Torvalds, stable, linux-security-module
On Sat, Jul 09, 2016 at 08:19:15PM +0200, Mickaël Salaün wrote:
> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
It's not a "fix", it's a "cleanup remaining bits"
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-07-09 18:19 [PATCH v1] module: Fully remove the kernel_module_from_file hook Mickaël Salaün
2016-07-11 18:41 ` Kees Cook
2016-07-11 21:42 ` Greg Kroah-Hartman
@ 2016-07-12 12:48 ` James Morris
2016-07-28 18:30 ` Kees Cook
2 siblings, 1 reply; 7+ messages in thread
From: James Morris @ 2016-07-12 12:48 UTC (permalink / raw)
To: Mickaël Salaün
Cc: linux-kernel, Mimi Zohar, Kees Cook, Luis R . Rodriguez,
Rusty Russell, Linus Torvalds, Greg Kroah-Hartman, stable,
linux-security-module
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Sat, 9 Jul 2016, Mickaël Salaün wrote:
> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
>
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> Cc: Rusty Russell <rusty@rustcorp.com.au>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: James Morris <james.l.morris@oracle.com>
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-07-12 12:48 ` James Morris
@ 2016-07-28 18:30 ` Kees Cook
2016-08-01 2:34 ` Mimi Zohar
0 siblings, 1 reply; 7+ messages in thread
From: Kees Cook @ 2016-07-28 18:30 UTC (permalink / raw)
To: James Morris
Cc: Mickaël Salaün, LKML, Mimi Zohar, Luis R . Rodriguez,
Rusty Russell, Linus Torvalds, Greg Kroah-Hartman, # 3.4.x,
linux-security-module
On Tue, Jul 12, 2016 at 5:48 AM, James Morris <jmorris@namei.org> wrote:
> On Sat, 9 Jul 2016, Mickaël Salaün wrote:
>
>> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
>>
>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
>> Cc: Kees Cook <keescook@chromium.org>
>> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
>> Cc: Rusty Russell <rusty@rustcorp.com.au>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
>
> Acked-by: James Morris <james.l.morris@oracle.com>
James, can you take this via the security-next tree?
Thanks!
-Kees
--
Kees Cook
Chrome OS & Brillo Security
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-07-28 18:30 ` Kees Cook
@ 2016-08-01 2:34 ` Mimi Zohar
2016-08-02 1:12 ` James Morris
0 siblings, 1 reply; 7+ messages in thread
From: Mimi Zohar @ 2016-08-01 2:34 UTC (permalink / raw)
To: Kees Cook
Cc: James Morris, Mickaël Salaün, LKML, Luis R . Rodriguez,
Rusty Russell, Linus Torvalds, Greg Kroah-Hartman, # 3.4.x,
linux-security-module
On Do, 2016-07-28 at 11:30 -0700, Kees Cook wrote:
> On Tue, Jul 12, 2016 at 5:48 AM, James Morris <jmorris@namei.org> wrote:
> > On Sat, 9 Jul 2016, Mickaël Salaün wrote:
> >
> >> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
> >>
> >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> >> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> >> Cc: Kees Cook <keescook@chromium.org>
> >> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> >> Cc: Rusty Russell <rusty@rustcorp.com.au>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >
> >
> > Acked-by: James Morris <james.l.morris@oracle.com>
>
> James, can you take this via the security-next tree?
Kees, thank you for staying on top of this. James, did you want a pull
request for this patch?
Mimi
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] module: Fully remove the kernel_module_from_file hook
2016-08-01 2:34 ` Mimi Zohar
@ 2016-08-02 1:12 ` James Morris
0 siblings, 0 replies; 7+ messages in thread
From: James Morris @ 2016-08-02 1:12 UTC (permalink / raw)
To: Mimi Zohar
Cc: Kees Cook, Mickaël Salaün, LKML, Luis R . Rodriguez,
Rusty Russell, Linus Torvalds, Greg Kroah-Hartman, # 3.4.x,
linux-security-module
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
On Sun, 31 Jul 2016, Mimi Zohar wrote:
> On Do, 2016-07-28 at 11:30 -0700, Kees Cook wrote:
> > On Tue, Jul 12, 2016 at 5:48 AM, James Morris <jmorris@namei.org> wrote:
> > > On Sat, 9 Jul 2016, Mickaël Salaün wrote:
> > >
> > >> Fixes: a1db74209483 ("module: replace copy_module_from_fd with kernel version")
> > >>
> > >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> > >> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>
> > >> Cc: Kees Cook <keescook@chromium.org>
> > >> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> > >> Cc: Rusty Russell <rusty@rustcorp.com.au>
> > >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > >> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > >
> > >
> > > Acked-by: James Morris <james.l.morris@oracle.com>
> >
> > James, can you take this via the security-next tree?
>
> Kees, thank you for staying on top of this. James, did you want a pull
> request for this patch?
Nope, just a copy of the patch.
--
James Morris
<jmorris@namei.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-08-02 1:15 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-09 18:19 [PATCH v1] module: Fully remove the kernel_module_from_file hook Mickaël Salaün
2016-07-11 18:41 ` Kees Cook
2016-07-11 21:42 ` Greg Kroah-Hartman
2016-07-12 12:48 ` James Morris
2016-07-28 18:30 ` Kees Cook
2016-08-01 2:34 ` Mimi Zohar
2016-08-02 1:12 ` James Morris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).