[PATCH] platform/x86/intel-vbtn: add volume up and down

[PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

Tested on HP Elite X2 1012 G1.
Matches event report of Lenovo Helix 2
(https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).

V2: Fix indent and add sign-off

Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
---
 drivers/platform/x86/intel-vbtn.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 554e82ebe83c..1616cb9c4ae5 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
 static const struct key_entry intel_vbtn_keymap[] = {
 	{ KE_IGNORE, 0xC0, { KEY_POWER } },	/* power key press */
 	{ KE_KEY, 0xC1, { KEY_POWER } },	/* power key release */
+	{ KE_KEY, 0xC4, { KEY_VOLUMEUP} },	/* volume-up key press */
+	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },	/* volume-up key release */
+	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },	/* volume-down key press */
+	{ KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },	/* volume-down key release */
 	{ KE_END },
 };
 
-- 
2.12.2

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Andy Shevchenko]

On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
> Tested on HP Elite X2 1012 G1.
> Matches event report of Lenovo Helix 2
> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>

Much better!

> V2: Fix indent and add sign-off

Usually this line goes after --- (body delimiter).
No need to resend this time. I would wait a bit for actual
author/driver maintainer to comment. Otherwise patch looks good enough
to me.

>
> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
> ---
>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 554e82ebe83c..1616cb9c4ae5 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>  static const struct key_entry intel_vbtn_keymap[] = {
>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>         { KE_END },
>  };
>
> --
> 2.12.2
>



-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
>> Tested on HP Elite X2 1012 G1.
>> Matches event report of Lenovo Helix 2
>> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>>
>
> Much better!
>
>> V2: Fix indent and add sign-off
>
> Usually this line goes after --- (body delimiter).
> No need to resend this time. I would wait a bit for actual
> author/driver maintainer to comment. Otherwise patch looks good enough
> to me.

The intent is not have this in the commit message?
I'll keep an eye out if i can place it below "---" next time.
Although i suspect the message would end in the actual code diff,
which seems odd.

>
>>
>> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
>> ---
>>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
>> index 554e82ebe83c..1616cb9c4ae5 100644
>> --- a/drivers/platform/x86/intel-vbtn.c
>> +++ b/drivers/platform/x86/intel-vbtn.c
>> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>>  static const struct key_entry intel_vbtn_keymap[] = {
>>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
>> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
>> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
>> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
>> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>>         { KE_END },
>>  };
>>
>> --
>> 2.12.2
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[AceLan Kao]

According the spec. I have, the values are correct.
Please merge it, thanks.

2017-04-25 5:41 GMT+08:00 Maarten Maathuis <madman2003@gmail.com>:
> On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
>>> Tested on HP Elite X2 1012 G1.
>>> Matches event report of Lenovo Helix 2
>>> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>>>
>>
>> Much better!
>>
>>> V2: Fix indent and add sign-off
>>
>> Usually this line goes after --- (body delimiter).
>> No need to resend this time. I would wait a bit for actual
>> author/driver maintainer to comment. Otherwise patch looks good enough
>> to me.
>
> The intent is not have this in the commit message?
> I'll keep an eye out if i can place it below "---" next time.
> Although i suspect the message would end in the actual code diff,
> which seems odd.
>
>>
>>>
>>> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
>>> ---
>>>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
>>> index 554e82ebe83c..1616cb9c4ae5 100644
>>> --- a/drivers/platform/x86/intel-vbtn.c
>>> +++ b/drivers/platform/x86/intel-vbtn.c
>>> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>>>  static const struct key_entry intel_vbtn_keymap[] = {
>>>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>>>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
>>> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
>>> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
>>> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
>>> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>>>         { KE_END },
>>>  };
>>>
>>> --
>>> 2.12.2
>>>
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>
>
>
> --
> Far away from the primal instinct, the song seems to fade away, the
> river get wider between your thoughts and the things we do and say.

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

On Tue, Apr 25, 2017 at 4:43 AM, AceLan Kao <acelan.kao@canonical.com> wrote:
> According the spec. I have, the values are correct.
> Please merge it, thanks.
>

Is there a reason the whole spec isn't implemented?
Is it under NDA?

> 2017-04-25 5:41 GMT+08:00 Maarten Maathuis <madman2003@gmail.com>:
>> On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
>>>> Tested on HP Elite X2 1012 G1.
>>>> Matches event report of Lenovo Helix 2
>>>> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>>>>
>>>
>>> Much better!
>>>
>>>> V2: Fix indent and add sign-off
>>>
>>> Usually this line goes after --- (body delimiter).
>>> No need to resend this time. I would wait a bit for actual
>>> author/driver maintainer to comment. Otherwise patch looks good enough
>>> to me.
>>
>> The intent is not have this in the commit message?
>> I'll keep an eye out if i can place it below "---" next time.
>> Although i suspect the message would end in the actual code diff,
>> which seems odd.
>>
>>>
>>>>
>>>> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
>>>> ---
>>>>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
>>>> index 554e82ebe83c..1616cb9c4ae5 100644
>>>> --- a/drivers/platform/x86/intel-vbtn.c
>>>> +++ b/drivers/platform/x86/intel-vbtn.c
>>>> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>>>>  static const struct key_entry intel_vbtn_keymap[] = {
>>>>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>>>>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
>>>> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
>>>> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
>>>> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
>>>> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>>>>         { KE_END },
>>>>  };
>>>>
>>>> --
>>>> 2.12.2
>>>>
>>>
>>>
>>>
>>> --
>>> With Best Regards,
>>> Andy Shevchenko
>>
>>
>>
>> --
>> Far away from the primal instinct, the song seems to fade away, the
>> river get wider between your thoughts and the things we do and say.



-- 
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[AceLan Kao]

In the beginning, we just need the power button function, so I didn't
implement all the keys to the driver.
And we didn't get any further requirement from the following projects
we were working on,
so I'm not aware that there are machines other than Dell using this driver.

I'll try filling up all events on the spec later.

2017-04-25 13:01 GMT+08:00 Maarten Maathuis <madman2003@gmail.com>:
> On Tue, Apr 25, 2017 at 4:43 AM, AceLan Kao <acelan.kao@canonical.com> wrote:
>> According the spec. I have, the values are correct.
>> Please merge it, thanks.
>>
>
> Is there a reason the whole spec isn't implemented?
> Is it under NDA?
>
>> 2017-04-25 5:41 GMT+08:00 Maarten Maathuis <madman2003@gmail.com>:
>>> On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko
>>> <andy.shevchenko@gmail.com> wrote:
>>>> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
>>>>> Tested on HP Elite X2 1012 G1.
>>>>> Matches event report of Lenovo Helix 2
>>>>> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>>>>>
>>>>
>>>> Much better!
>>>>
>>>>> V2: Fix indent and add sign-off
>>>>
>>>> Usually this line goes after --- (body delimiter).
>>>> No need to resend this time. I would wait a bit for actual
>>>> author/driver maintainer to comment. Otherwise patch looks good enough
>>>> to me.
>>>
>>> The intent is not have this in the commit message?
>>> I'll keep an eye out if i can place it below "---" next time.
>>> Although i suspect the message would end in the actual code diff,
>>> which seems odd.
>>>
>>>>
>>>>>
>>>>> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
>>>>> ---
>>>>>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>>>>>  1 file changed, 4 insertions(+)
>>>>>
>>>>> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
>>>>> index 554e82ebe83c..1616cb9c4ae5 100644
>>>>> --- a/drivers/platform/x86/intel-vbtn.c
>>>>> +++ b/drivers/platform/x86/intel-vbtn.c
>>>>> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>>>>>  static const struct key_entry intel_vbtn_keymap[] = {
>>>>>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>>>>>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
>>>>> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },      /* volume-up key press */
>>>>> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
>>>>> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
>>>>> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>>>>>         { KE_END },
>>>>>  };
>>>>>
>>>>> --
>>>>> 2.12.2
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> With Best Regards,
>>>> Andy Shevchenko
>>>
>>>
>>>
>>> --
>>> Far away from the primal instinct, the song seems to fade away, the
>>> river get wider between your thoughts and the things we do and say.
>
>
>
> --
> Far away from the primal instinct, the song seems to fade away, the
> river get wider between your thoughts and the things we do and say.



-- 
Chia-Lin Kao(AceLan)
http://blog.acelan.idv.tw/
E-Mail: acelan.kaoATcanonical.com (s/AT/@/)

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Andy Shevchenko]

On Tue, Apr 25, 2017 at 12:35 AM, Maarten Maathuis <madman2003@gmail.com> wrote:
> Tested on HP Elite X2 1012 G1.
> Matches event report of Lenovo Helix 2
> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>
> V2: Fix indent and add sign-off
> V3: Missing whitespace correction

Slightly modified (*) version pushed to testing, thanks!

*) Fixed subject, removed changelog from commit message, improved indentation

>
> Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
> ---
>  drivers/platform/x86/intel-vbtn.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 554e82ebe83c..dc270fe793a1 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>  static const struct key_entry intel_vbtn_keymap[] = {
>         { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>         { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP } },     /* volume-up key press */
> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },  /* volume-up key release */
> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },   /* volume-down key press */
> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },        /* volume-down key release */
>         { KE_END },
>  };
>
> --
> 2.12.2
>



-- 
With Best Regards,
Andy Shevchenko

[PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

Tested on HP Elite X2 1012 G1.
Matches event report of Lenovo Helix 2
(https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).

V2: Fix indent and add sign-off
V3: Missing whitespace correction

Signed-off-by: Maarten Maathuis <madman2003@shikahr.net>
---
 drivers/platform/x86/intel-vbtn.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 554e82ebe83c..dc270fe793a1 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -37,6 +37,10 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
 static const struct key_entry intel_vbtn_keymap[] = {
 	{ KE_IGNORE, 0xC0, { KEY_POWER } },	/* power key press */
 	{ KE_KEY, 0xC1, { KEY_POWER } },	/* power key release */
+	{ KE_KEY, 0xC4, { KEY_VOLUMEUP } },	/* volume-up key press */
+	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },	/* volume-up key release */
+	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN } },	/* volume-down key press */
+	{ KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } },	/* volume-down key release */
 	{ KE_END },
 };
 
-- 
2.12.2

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

On Mon, Apr 24, 2017 at 10:55 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Apr 24, 2017 at 11:47 PM, Maarten Maathuis <madman2003@gmail.com> wrote:
>> Tested on HP Elite X2 1012 G1.
>> Matches event report of Lenovo Helix 2
>> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
>
> Thanks for the patch.
>
> A bit of work still required.
>
> According to Submitting Patches document [1] we need your Signed-off-by tag.
>
> Besides that see my comment below.
>
> [1] https://www.kernel.org/doc/Documentation/process/submitting-patches.rst
>
>
>> ---
>>  drivers/platform/x86/intel-vbtn.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
>> index 554e82ebe83c..1fbebbad350d 100644
>> --- a/drivers/platform/x86/intel-vbtn.c
>> +++ b/drivers/platform/x86/intel-vbtn.c
>> @@ -35,8 +35,12 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>>
>>  /* In theory, these are HID usages. */
>>  static const struct key_entry intel_vbtn_keymap[] = {
>
>> -       { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
>> -       { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
>> +       { KE_IGNORE, 0xC0, { KEY_POWER } },      /* power key press */
>> +       { KE_KEY, 0xC1, { KEY_POWER } },         /* power key release */
>
> As far as I can see nothing should happen on these lines. I think your
> editor (or maybe email setup) is configured somehow wrongly. We expect
> TAB as an indentation starter.
>
> We also encourage to use git send-email tool instead of manual
> submitting patches through some (broken) MUAs.

I fell back to an other SMTP server, until i can find a structural
long term solution.
The difference in the other two lines was due to a misunderstanding
about indenting
policy. hopefully it's better now.

>
>> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },       /* volume-up key press */
>> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },   /* volume-up key release */
>> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN} },     /* volume-down key press */
>> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
>>         { KE_END },
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
Far away from the primal instinct, the song seems to fade away, the
river get wider between your thoughts and the things we do and say.

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

[Andy Shevchenko]

On Mon, Apr 24, 2017 at 11:47 PM, Maarten Maathuis <madman2003@gmail.com> wrote:
> Tested on HP Elite X2 1012 G1.
> Matches event report of Lenovo Helix 2
> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).

Thanks for the patch.

A bit of work still required.

According to Submitting Patches document [1] we need your Signed-off-by tag.

Besides that see my comment below.

[1] https://www.kernel.org/doc/Documentation/process/submitting-patches.rst


> ---
>  drivers/platform/x86/intel-vbtn.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
> index 554e82ebe83c..1fbebbad350d 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -35,8 +35,12 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
>
>  /* In theory, these are HID usages. */
>  static const struct key_entry intel_vbtn_keymap[] = {

> -       { KE_IGNORE, 0xC0, { KEY_POWER } },     /* power key press */
> -       { KE_KEY, 0xC1, { KEY_POWER } },        /* power key release */
> +       { KE_IGNORE, 0xC0, { KEY_POWER } },      /* power key press */
> +       { KE_KEY, 0xC1, { KEY_POWER } },         /* power key release */

As far as I can see nothing should happen on these lines. I think your
editor (or maybe email setup) is configured somehow wrongly. We expect
TAB as an indentation starter.

We also encourage to use git send-email tool instead of manual
submitting patches through some (broken) MUAs.

> +       { KE_KEY, 0xC4, { KEY_VOLUMEUP} },       /* volume-up key press */
> +       { KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },   /* volume-up key release */
> +       { KE_KEY, 0xC6, { KEY_VOLUMEDOWN} },     /* volume-down key press */
> +       { KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
>         { KE_END },

-- 
With Best Regards,
Andy Shevchenko

[PATCH] platform/x86/intel-vbtn: add volume up and down

[Maarten Maathuis]

Tested on HP Elite X2 1012 G1.
Matches event report of Lenovo Helix 2
(https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html).
---
 drivers/platform/x86/intel-vbtn.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platform/x86/intel-vbtn.c
index 554e82ebe83c..1fbebbad350d 100644
--- a/drivers/platform/x86/intel-vbtn.c
+++ b/drivers/platform/x86/intel-vbtn.c
@@ -35,8 +35,12 @@ static const struct acpi_device_id intel_vbtn_ids[] = {
 
 /* In theory, these are HID usages. */
 static const struct key_entry intel_vbtn_keymap[] = {
-	{ KE_IGNORE, 0xC0, { KEY_POWER } },	/* power key press */
-	{ KE_KEY, 0xC1, { KEY_POWER } },	/* power key release */
+	{ KE_IGNORE, 0xC0, { KEY_POWER } },	 /* power key press */
+	{ KE_KEY, 0xC1, { KEY_POWER } },	 /* power key release */
+	{ KE_KEY, 0xC4, { KEY_VOLUMEUP} },	 /* volume-up key press */
+	{ KE_IGNORE, 0xC5, { KEY_VOLUMEUP } },	 /* volume-up key release */
+	{ KE_KEY, 0xC6, { KEY_VOLUMEDOWN} },	 /* volume-down key press */
+	{ KE_IGNORE, 0xC7, { KEY_VOLUMEDOWN } }, /* volume-down key release */
 	{ KE_END },
 };
 
-- 
2.12.2