linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
@ 2016-06-02  2:36 luoyi.ly
  2016-06-02  2:55 ` [linux-sunxi] " Julian Calaby
  0 siblings, 1 reply; 10+ messages in thread
From: luoyi.ly @ 2016-06-02  2:36 UTC (permalink / raw)
  To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
	maxime.ripard, wens, devicetree, linux-arm-kernel, linux-kernel,
	linux-sunxi
  Cc: Luo Yi

From: Luo Yi <luoyi.ly@gmail.com>

Add support for the Bananapi M1 Plus A20 development board from
sinovoip.com.cn . This board is nearly a clone of the Lemaker's
Bananapro, but differ with the wlan chipset connection and i2s pinout.
And I also enable the integrated audio codec on default.
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
new file mode 100644
index 0000000..6fd55d7
--- /dev/null
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -0,0 +1,72 @@
+/*
+ * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
+ *
+ * This file is dual-licensed: you can use it either under the terms
+ * of the GPL or the X11 license, at your option. Note that this dual
+ * licensing only applies to this file, and not this project as a
+ * whole.
+ *
+ *  a) This file is free software; you can redistribute it and/or
+ *     modify it under the terms of the GNU General Public License as
+ *     published by the Free Software Foundation; either version 2 of the
+ *     License, or (at your option) any later version.
+ *
+ *     This file is distributed in the hope that it will be useful,
+ *     but WITHOUT ANY WARRANTY; without even the implied warranty of
+ *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ *     GNU General Public License for more details.
+ *
+ * Or, alternatively,
+ *
+ *  b) Permission is hereby granted, free of charge, to any person
+ *     obtaining a copy of this software and associated documentation
+ *     files (the "Software"), to deal in the Software without
+ *     restriction, including without limitation the rights to use,
+ *     copy, modify, merge, publish, distribute, sublicense, and/or
+ *     sell copies of the Software, and to permit persons to whom the
+ *     Software is furnished to do so, subject to the following
+ *     conditions:
+ *
+ *     The above copyright notice and this permission notice shall be
+ *     included in all copies or substantial portions of the Software.
+ *
+ *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+ *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
+ *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+ *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
+ *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
+ *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ *     OTHER DEALINGS IN THE SOFTWARE.
+ */
+
+#include "sun7i-a20-bananapro.dts"
+
+/ {
+	model = "Banana Pi BPI-M1-Plus";
+	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
+};
+
+
+&codec {
+	status = "okay";
+};
+
+&mmc3 {
+	enable-sdio-wakeup;
+
+	brcmf: bcrmf@1 {
+		reg = <1>;
+		compatible = "brcm,bcm4329-fmac";
+		interrupt-parent = <&pio>;
+		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
+		interrupt-names = "host-wake";
+	};
+
+};
+
+&mmc3_pins_a {
+    /* AP6210 requires pull-up */
+	allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
+};
+
-- 
2.8.3

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-02  2:36 [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly
@ 2016-06-02  2:55 ` Julian Calaby
  2016-06-02  8:16   ` Maxime Ripard
  0 siblings, 1 reply; 10+ messages in thread
From: Julian Calaby @ 2016-06-02  2:55 UTC (permalink / raw)
  To: luoyi.ly
  Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, Maxime Ripard, Chen-Yu Tsai, devicetree,
	Mailing List, Arm, linux-kernel, linux-sunxi

Hi Luo yi,

On Thu, Jun 2, 2016 at 12:36 PM,  <luoyi.ly@gmail.com> wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
>
> Add support for the Bananapi M1 Plus A20 development board from
> sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> Bananapro, but differ with the wlan chipset connection and i2s pinout.
> And I also enable the integrated audio codec on default.

No signed-off-by.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
>  1 file changed, 72 insertions(+)
>  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> new file mode 100644
> index 0000000..6fd55d7
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -0,0 +1,72 @@
> +/*
> + * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
> + *
> + * This file is dual-licensed: you can use it either under the terms
> + * of the GPL or the X11 license, at your option. Note that this dual
> + * licensing only applies to this file, and not this project as a
> + * whole.
> + *
> + *  a) This file is free software; you can redistribute it and/or
> + *     modify it under the terms of the GNU General Public License as
> + *     published by the Free Software Foundation; either version 2 of the
> + *     License, or (at your option) any later version.
> + *
> + *     This file is distributed in the hope that it will be useful,
> + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *     GNU General Public License for more details.
> + *
> + * Or, alternatively,
> + *
> + *  b) Permission is hereby granted, free of charge, to any person
> + *     obtaining a copy of this software and associated documentation
> + *     files (the "Software"), to deal in the Software without
> + *     restriction, including without limitation the rights to use,
> + *     copy, modify, merge, publish, distribute, sublicense, and/or
> + *     sell copies of the Software, and to permit persons to whom the
> + *     Software is furnished to do so, subject to the following
> + *     conditions:
> + *
> + *     The above copyright notice and this permission notice shall be
> + *     included in all copies or substantial portions of the Software.
> + *
> + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> + *     OTHER DEALINGS IN THE SOFTWARE.
> + */
> +
> +#include "sun7i-a20-bananapro.dts"
> +
> +/ {
> +       model = "Banana Pi BPI-M1-Plus";
> +       compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> +};
> +
> +

Extra line.

> +&codec {
> +       status = "okay";
> +};

Does anyone know if this should be enabled on the bananapro too?

> +
> +&mmc3 {
> +       enable-sdio-wakeup;
> +
> +       brcmf: bcrmf@1 {
> +               reg = <1>;
> +               compatible = "brcm,bcm4329-fmac";
> +               interrupt-parent = <&pio>;
> +               interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>;
> +               interrupt-names = "host-wake";
> +       };
> +

Extra line.

> +};
> +
> +&mmc3_pins_a {
> +    /* AP6210 requires pull-up */

Should this be indented the same as the following line?

> +       allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> +};
> +

Extra line.

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-02  2:55 ` [linux-sunxi] " Julian Calaby
@ 2016-06-02  8:16   ` Maxime Ripard
  2016-06-02  9:15     ` Bernhard Nortmann
  0 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2016-06-02  8:16 UTC (permalink / raw)
  To: Julian Calaby
  Cc: luoyi.ly, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, Chen-Yu Tsai, devicetree, Mailing List,
	Arm, linux-kernel, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 3849 bytes --]

On Thu, Jun 02, 2016 at 12:55:23PM +1000, Julian Calaby wrote:
> Hi Luo yi,
> 
> On Thu, Jun 2, 2016 at 12:36 PM,  <luoyi.ly@gmail.com> wrote:
> > From: Luo Yi <luoyi.ly@gmail.com>
> >
> > Add support for the Bananapi M1 Plus A20 development board from
> > sinovoip.com.cn . This board is nearly a clone of the Lemaker's
> > Bananapro, but differ with the wlan chipset connection and i2s pinout.
> > And I also enable the integrated audio codec on default.
> 
> No signed-off-by.
> 
> > ---
> >  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 72 ++++++++++++++++++++++++
> >  1 file changed, 72 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> >
> > diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> > new file mode 100644
> > index 0000000..6fd55d7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> > @@ -0,0 +1,72 @@
> > +/*
> > + * Copyright 2016 Luo Yi <luoyi.ly@gmail.com>
> > + *
> > + * This file is dual-licensed: you can use it either under the terms
> > + * of the GPL or the X11 license, at your option. Note that this dual
> > + * licensing only applies to this file, and not this project as a
> > + * whole.
> > + *
> > + *  a) This file is free software; you can redistribute it and/or
> > + *     modify it under the terms of the GNU General Public License as
> > + *     published by the Free Software Foundation; either version 2 of the
> > + *     License, or (at your option) any later version.
> > + *
> > + *     This file is distributed in the hope that it will be useful,
> > + *     but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + *     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + *     GNU General Public License for more details.
> > + *
> > + * Or, alternatively,
> > + *
> > + *  b) Permission is hereby granted, free of charge, to any person
> > + *     obtaining a copy of this software and associated documentation
> > + *     files (the "Software"), to deal in the Software without
> > + *     restriction, including without limitation the rights to use,
> > + *     copy, modify, merge, publish, distribute, sublicense, and/or
> > + *     sell copies of the Software, and to permit persons to whom the
> > + *     Software is furnished to do so, subject to the following
> > + *     conditions:
> > + *
> > + *     The above copyright notice and this permission notice shall be
> > + *     included in all copies or substantial portions of the Software.
> > + *
> > + *     THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > + *     EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES
> > + *     OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
> > + *     NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT
> > + *     HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY,
> > + *     WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > + *     FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > + *     OTHER DEALINGS IN THE SOFTWARE.
> > + */
> > +
> > +#include "sun7i-a20-bananapro.dts"
> > +
> > +/ {
> > +       model = "Banana Pi BPI-M1-Plus";
> > +       compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
> > +};
> > +
> > +
> 
> Extra line.
> 
> > +&codec {
> > +       status = "okay";
> > +};
> 
> Does anyone know if this should be enabled on the bananapro too?

Yes, everything that is shared with the banana-pro (which, judging
from Bernhard, is pretty much everything but a GPIO) should be merged
in the banapro DT.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-02  8:16   ` Maxime Ripard
@ 2016-06-02  9:15     ` Bernhard Nortmann
  2016-06-03  6:13       ` luoyi.ly
  2016-06-10  9:38       ` Maxime Ripard
  0 siblings, 2 replies; 10+ messages in thread
From: Bernhard Nortmann @ 2016-06-02  9:15 UTC (permalink / raw)
  To: maxime.ripard, Julian Calaby
  Cc: luoyi.ly, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
	Kumar Gala, Russell King, Chen-Yu Tsai, devicetree, Mailing List,
	Arm, linux-kernel, linux-sunxi

Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> [...]
> Yes, everything that is shared with the banana-pro (which, judging
> from Bernhard, is pretty much everything but a GPIO) should be merged
> in the banapro DT.
>
> Maxime
>

Don't take my word for granted, as I do not own this hardware or know it
particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
very similar, but if in doubt the information form the wiki should be 
verified.

@luoyi:

You seem to be using an editor that uses 4 spaces for displaying a <TAB>.
It looks like that makes you prone to whitespace formatting issues, which
have shown up in both versions of the .dts you submitted so far.

Please double-check that you're using TABs for indentation and they weren't
mixed up with SPACEs accidentally. (Most editors will also offer a setting
that allows you to display "non-printable" chars, where you might be able to
distinguish whitespace better.)

Regards, B. Nortmann

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-02  9:15     ` Bernhard Nortmann
@ 2016-06-03  6:13       ` luoyi.ly
  2016-06-10  9:39         ` Maxime Ripard
  2016-06-10  9:38       ` Maxime Ripard
  1 sibling, 1 reply; 10+ messages in thread
From: luoyi.ly @ 2016-06-03  6:13 UTC (permalink / raw)
  To: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
	maxime.ripard, wens, devicetree, linux-arm-kernel, linux-kernel
  Cc: Luo Yi

From: Luo Yi <luoyi.ly@gmail.com>

Remove the extra empty line and add signed off. 

Signed-off-by: Luo Yi <luoyi.ly@gmail.com>
---
 arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
index 6fd55d7..f9063ba 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
@@ -47,7 +47,6 @@
 	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
 };
 
-
 &codec {
 	status = "okay";
 };
@@ -62,11 +61,8 @@
 		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
 		interrupt-names = "host-wake";
 	};
-
 };
 
 &mmc3_pins_a {
-    /* AP6210 requires pull-up */
 	allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
 };
-
-- 
2.8.3

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-02  9:15     ` Bernhard Nortmann
  2016-06-03  6:13       ` luoyi.ly
@ 2016-06-10  9:38       ` Maxime Ripard
  2016-06-13  3:01         ` Chen-Yu Tsai
  1 sibling, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2016-06-10  9:38 UTC (permalink / raw)
  To: Chen-Yu Tsai, Bernhard Nortmann
  Cc: Julian Calaby, luoyi.ly, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, devicetree, Mailing List,
	Arm, linux-kernel, linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 769 bytes --]

On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> >[...]
> >Yes, everything that is shared with the banana-pro (which, judging
> >from Bernhard, is pretty much everything but a GPIO) should be merged
> >in the banapro DT.
> >
> >Maxime
> >
> 
> Don't take my word for granted, as I do not own this hardware or know it
> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
> very similar, but if in doubt the information form the wiki should be
> verified.

Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
more than I do.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-03  6:13       ` luoyi.ly
@ 2016-06-10  9:39         ` Maxime Ripard
  0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2016-06-10  9:39 UTC (permalink / raw)
  To: luoyi.ly
  Cc: robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux,
	wens, devicetree, linux-arm-kernel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1124 bytes --]

On Fri, Jun 03, 2016 at 02:13:36PM +0800, luoyi.ly@gmail.com wrote:
> From: Luo Yi <luoyi.ly@gmail.com>
> 
> Remove the extra empty line and add signed off. 
> 
> Signed-off-by: Luo Yi <luoyi.ly@gmail.com>

Please send a new patch.

> ---
>  arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> index 6fd55d7..f9063ba 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi-m1-plus.dts
> @@ -47,7 +47,6 @@
>  	compatible = "sinovoip,bpi-m1-plus", "allwinner,sun7i-a20";
>  };
>  
> -
>  &codec {
>  	status = "okay";
>  };
> @@ -62,11 +61,8 @@
>  		interrupts = <7 15 IRQ_TYPE_LEVEL_LOW>; 
>  		interrupt-names = "host-wake";
>  	};
> -
>  };
>  
>  &mmc3_pins_a {
> -    /* AP6210 requires pull-up */

And that comment was fine, why did you remove it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-10  9:38       ` Maxime Ripard
@ 2016-06-13  3:01         ` Chen-Yu Tsai
  2016-06-15 20:52           ` Maxime Ripard
  0 siblings, 1 reply; 10+ messages in thread
From: Chen-Yu Tsai @ 2016-06-13  3:01 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Chen-Yu Tsai, Bernhard Nortmann, Julian Calaby, 罗翼,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, Mailing List, Arm, linux-kernel,
	linux-sunxi

On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
>> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
>> >[...]
>> >Yes, everything that is shared with the banana-pro (which, judging
>> >from Bernhard, is pretty much everything but a GPIO) should be merged
>> >in the banapro DT.
>> >
>> >Maxime
>> >
>>
>> Don't take my word for granted, as I do not own this hardware or know it
>> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
>> very similar, but if in doubt the information form the wiki should be
>> verified.
>
> Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
> more than I do.

I did a comparison of the "Banana Pro" vs the "BPi-M1+".

The differences are similar to what we have with any other development
board, say the Cubietruck:

  - A different WiFi chip is used, and the BT part is not hooked up.
  - Different GPIOs for external power regulator/switches
  - Different GPIOs for LEDs
  - Different peripherals exposed on the headers.

IMO There's no need to merge or have a common .dtsi for the two boards.
They (and all the other development boards) look similar because
everyone is following the basic set by Allwinner's reference design,
like which MMC controller and pins are used for SD/MMC, which ones
are used for SDIO-based WiFi, and so on.

I did a version completely from scratch using just the schematics:

  https://github.com/wens/linux/commits/bpi-m1-plus

Please ignore the last commit. It's just me playing with NTP support
for GPS time.


Regards
ChenYu

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-13  3:01         ` Chen-Yu Tsai
@ 2016-06-15 20:52           ` Maxime Ripard
  2016-06-16  3:05             ` Chen-Yu Tsai
  0 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2016-06-15 20:52 UTC (permalink / raw)
  To: Chen-Yu Tsai
  Cc: Bernhard Nortmann, Julian Calaby, 罗翼,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, Mailing List, Arm, linux-kernel,
	linux-sunxi

[-- Attachment #1: Type: text/plain, Size: 2006 bytes --]

Hi Chen-Yu,

On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
> <maxime.ripard@free-electrons.com> wrote:
> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
> >> >[...]
> >> >Yes, everything that is shared with the banana-pro (which, judging
> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
> >> >in the banapro DT.
> >> >
> >> >Maxime
> >> >
> >>
> >> Don't take my word for granted, as I do not own this hardware or know it
> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
> >> very similar, but if in doubt the information form the wiki should be
> >> verified.
> >
> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
> > more than I do.
> 
> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
> 
> The differences are similar to what we have with any other development
> board, say the Cubietruck:
> 
>   - A different WiFi chip is used, and the BT part is not hooked up.
>   - Different GPIOs for external power regulator/switches
>   - Different GPIOs for LEDs
>   - Different peripherals exposed on the headers.
> 
> IMO There's no need to merge or have a common .dtsi for the two boards.

Ok.

> They (and all the other development boards) look similar because
> everyone is following the basic set by Allwinner's reference design,
> like which MMC controller and pins are used for SD/MMC, which ones
> are used for SDIO-based WiFi, and so on.
> 
> I did a version completely from scratch using just the schematics:
> 
>   https://github.com/wens/linux/commits/bpi-m1-plus

So, what do you mean by that? Do you have some comments on that patch,
or should I merge it, and you'll post your additions on top of it?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [linux-sunxi] [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board
  2016-06-15 20:52           ` Maxime Ripard
@ 2016-06-16  3:05             ` Chen-Yu Tsai
  0 siblings, 0 replies; 10+ messages in thread
From: Chen-Yu Tsai @ 2016-06-16  3:05 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: Chen-Yu Tsai, Bernhard Nortmann, Julian Calaby, 罗翼,
	Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
	Russell King, devicetree, Mailing List, Arm, linux-kernel,
	linux-sunxi

On Thu, Jun 16, 2016 at 4:52 AM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> Hi Chen-Yu,
>
> On Mon, Jun 13, 2016 at 11:01:53AM +0800, Chen-Yu Tsai wrote:
>> On Fri, Jun 10, 2016 at 5:38 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > On Thu, Jun 02, 2016 at 11:15:55AM +0200, Bernhard Nortmann wrote:
>> >> Am 02.06.2016 um 10:16 schrieb Maxime Ripard:
>> >> >[...]
>> >> >Yes, everything that is shared with the banana-pro (which, judging
>> >> >from Bernhard, is pretty much everything but a GPIO) should be merged
>> >> >in the banapro DT.
>> >> >
>> >> >Maxime
>> >> >
>> >>
>> >> Don't take my word for granted, as I do not own this hardware or know it
>> >> particularly well. There is no doubt that "BPi-M1+" and "Banana Pro" are
>> >> very similar, but if in doubt the information form the wiki should be
>> >> verified.
>> >
>> > Hmmmm, ok. Chen-Yu, any input on this? You know the banana-pis much
>> > more than I do.
>>
>> I did a comparison of the "Banana Pro" vs the "BPi-M1+".
>>
>> The differences are similar to what we have with any other development
>> board, say the Cubietruck:
>>
>>   - A different WiFi chip is used, and the BT part is not hooked up.
>>   - Different GPIOs for external power regulator/switches
>>   - Different GPIOs for LEDs
>>   - Different peripherals exposed on the headers.
>>
>> IMO There's no need to merge or have a common .dtsi for the two boards.
>
> Ok.
>
>> They (and all the other development boards) look similar because
>> everyone is following the basic set by Allwinner's reference design,
>> like which MMC controller and pins are used for SD/MMC, which ones
>> are used for SDIO-based WiFi, and so on.
>>
>> I did a version completely from scratch using just the schematics:
>>
>>   https://github.com/wens/linux/commits/bpi-m1-plus
>
> So, what do you mean by that? Do you have some comments on that patch,
> or should I merge it, and you'll post your additions on top of it?

I'd like Luo to send a new version, based on what was his updated v1.

I'll reply to that one with some comments.


ChenYu

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2016-06-16  3:06 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-02  2:36 [PATCH] [V2] ARM: dts: sun7i: Add dts file for Bananapi M1 Plus board luoyi.ly
2016-06-02  2:55 ` [linux-sunxi] " Julian Calaby
2016-06-02  8:16   ` Maxime Ripard
2016-06-02  9:15     ` Bernhard Nortmann
2016-06-03  6:13       ` luoyi.ly
2016-06-10  9:39         ` Maxime Ripard
2016-06-10  9:38       ` Maxime Ripard
2016-06-13  3:01         ` Chen-Yu Tsai
2016-06-15 20:52           ` Maxime Ripard
2016-06-16  3:05             ` Chen-Yu Tsai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).