* [PATCH v1] usb: gadget: configfs: log function unbinding as information
@ 2016-07-26 16:21 Romain Izard
2016-08-29 8:11 ` Romain Izard
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Romain Izard @ 2016-07-26 16:21 UTC (permalink / raw)
To: linux-usb, linux-kernel, Felipe Balbi; +Cc: Greg Kroah-Hartman, Romain Izard
Disabling USB gadget functions configured through configfs is something
that can happen in normal use cases. Keep the existing log for this type
of event, but only as information, not as an error.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
drivers/usb/gadget/configfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index 70cf3477f951..11f3a649d9e5 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
list_move_tail(&f->list, &cfg->func_list);
if (f->unbind) {
- dev_err(&gi->cdev.gadget->dev, "unbind function"
- " '%s'/%p\n", f->name, f);
+ dev_info(&gi->cdev.gadget->dev,
+ "unbind function '%s'/%p\n",
+ f->name, f);
f->unbind(c, f);
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
@ 2016-08-29 8:11 ` Romain Izard
2016-08-29 8:13 ` Felipe Balbi
2016-08-29 9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
2 siblings, 0 replies; 7+ messages in thread
From: Romain Izard @ 2016-08-29 8:11 UTC (permalink / raw)
To: linux-usb, LKML, Felipe Balbi; +Cc: Greg Kroah-Hartman, Romain Izard
2016-07-26 18:21 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/usb/gadget/configfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> - dev_err(&gi->cdev.gadget->dev, "unbind function"
> - " '%s'/%p\n", f->name, f);
> + dev_info(&gi->cdev.gadget->dev,
> + "unbind function '%s'/%p\n",
> + f->name, f);
> f->unbind(c, f);
> }
> }
> --
> 2.7.4
>
Ping ?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
2016-08-29 8:11 ` Romain Izard
@ 2016-08-29 8:13 ` Felipe Balbi
2016-08-29 8:22 ` Romain Izard
2016-08-29 9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
2 siblings, 1 reply; 7+ messages in thread
From: Felipe Balbi @ 2016-08-29 8:13 UTC (permalink / raw)
To: Romain Izard, linux-usb, linux-kernel; +Cc: Greg Kroah-Hartman, Romain Izard
[-- Attachment #1: Type: text/plain, Size: 1107 bytes --]
Hi,
Romain Izard <romain.izard.pro@gmail.com> writes:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as information, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> drivers/usb/gadget/configfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index 70cf3477f951..11f3a649d9e5 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> - dev_err(&gi->cdev.gadget->dev, "unbind function"
> - " '%s'/%p\n", f->name, f);
> + dev_info(&gi->cdev.gadget->dev,
seems to me dev_dbg() is a far better alternative. We really don't need
this on everybody's log buffer unless they really _are_ debugging some
possible issues.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v1] usb: gadget: configfs: log function unbinding as information
2016-08-29 8:13 ` Felipe Balbi
@ 2016-08-29 8:22 ` Romain Izard
0 siblings, 0 replies; 7+ messages in thread
From: Romain Izard @ 2016-08-29 8:22 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-usb, LKML, Greg Kroah-Hartman
2016-08-29 10:13 GMT+02:00 Felipe Balbi <balbi@kernel.org>:
>
> Hi,
>
> Romain Izard <romain.izard.pro@gmail.com> writes:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as information, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> drivers/usb/gadget/configfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index 70cf3477f951..11f3a649d9e5 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>> list_move_tail(&f->list, &cfg->func_list);
>> if (f->unbind) {
>> - dev_err(&gi->cdev.gadget->dev, "unbind function"
>> - " '%s'/%p\n", f->name, f);
>> + dev_info(&gi->cdev.gadget->dev,
>
> seems to me dev_dbg() is a far better alternative. We really don't need
> this on everybody's log buffer unless they really _are_ debugging some
> possible issues.
OK, I'll send a v2.
--
Romain Izard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] usb: gadget: configfs: log function unbinding as debug
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
2016-08-29 8:11 ` Romain Izard
2016-08-29 8:13 ` Felipe Balbi
@ 2016-08-29 9:07 ` Romain Izard
2016-09-07 9:43 ` Romain Izard
2 siblings, 1 reply; 7+ messages in thread
From: Romain Izard @ 2016-08-29 9:07 UTC (permalink / raw)
To: linux-usb, linux-kernel, Felipe Balbi; +Cc: Greg Kroah-Hartman, Romain Izard
Disabling USB gadget functions configured through configfs is something
that can happen in normal use cases. Keep the existing log for this type
of event, but only as debug, not as an error.
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
v1 -> v2:
- use dev_dbg instead of dev_info
drivers/usb/gadget/configfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
index f9237fe2be05..3984787f8e97 100644
--- a/drivers/usb/gadget/configfs.c
+++ b/drivers/usb/gadget/configfs.c
@@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
list_move_tail(&f->list, &cfg->func_list);
if (f->unbind) {
- dev_err(&gi->cdev.gadget->dev, "unbind function"
- " '%s'/%p\n", f->name, f);
+ dev_dbg(&gi->cdev.gadget->dev,
+ "unbind function '%s'/%p\n",
+ f->name, f);
f->unbind(c, f);
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug
2016-08-29 9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
@ 2016-09-07 9:43 ` Romain Izard
2016-09-07 10:44 ` Felipe Balbi
0 siblings, 1 reply; 7+ messages in thread
From: Romain Izard @ 2016-09-07 9:43 UTC (permalink / raw)
To: linux-usb, LKML, Felipe Balbi; +Cc: Greg Kroah-Hartman, Romain Izard
2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
> Disabling USB gadget functions configured through configfs is something
> that can happen in normal use cases. Keep the existing log for this type
> of event, but only as debug, not as an error.
>
> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
> ---
> v1 -> v2:
> - use dev_dbg instead of dev_info
>
> drivers/usb/gadget/configfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index f9237fe2be05..3984787f8e97 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>
> list_move_tail(&f->list, &cfg->func_list);
> if (f->unbind) {
> - dev_err(&gi->cdev.gadget->dev, "unbind function"
> - " '%s'/%p\n", f->name, f);
> + dev_dbg(&gi->cdev.gadget->dev,
> + "unbind function '%s'/%p\n",
> + f->name, f);
> f->unbind(c, f);
> }
> }
> --
> 2.7.4
>
Ping ?
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v2] usb: gadget: configfs: log function unbinding as debug
2016-09-07 9:43 ` Romain Izard
@ 2016-09-07 10:44 ` Felipe Balbi
0 siblings, 0 replies; 7+ messages in thread
From: Felipe Balbi @ 2016-09-07 10:44 UTC (permalink / raw)
To: Romain Izard, linux-usb, LKML; +Cc: Greg Kroah-Hartman, Romain Izard
[-- Attachment #1: Type: text/plain, Size: 1610 bytes --]
Romain Izard <romain.izard.pro@gmail.com> writes:
> 2016-08-29 11:07 GMT+02:00 Romain Izard <romain.izard.pro@gmail.com>:
>> Disabling USB gadget functions configured through configfs is something
>> that can happen in normal use cases. Keep the existing log for this type
>> of event, but only as debug, not as an error.
>>
>> Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
>> ---
>> v1 -> v2:
>> - use dev_dbg instead of dev_info
>>
>> drivers/usb/gadget/configfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
>> index f9237fe2be05..3984787f8e97 100644
>> --- a/drivers/usb/gadget/configfs.c
>> +++ b/drivers/usb/gadget/configfs.c
>> @@ -1211,8 +1211,9 @@ static void purge_configs_funcs(struct gadget_info *gi)
>>
>> list_move_tail(&f->list, &cfg->func_list);
>> if (f->unbind) {
>> - dev_err(&gi->cdev.gadget->dev, "unbind function"
>> - " '%s'/%p\n", f->name, f);
>> + dev_dbg(&gi->cdev.gadget->dev,
>> + "unbind function '%s'/%p\n",
>> + f->name, f);
>> f->unbind(c, f);
>> }
>> }
>> --
>> 2.7.4
>>
>
> Ping ?
https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=da7b895d518cc1753ee5f4b7f2158087282d1a65
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-09-07 10:45 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-26 16:21 [PATCH v1] usb: gadget: configfs: log function unbinding as information Romain Izard
2016-08-29 8:11 ` Romain Izard
2016-08-29 8:13 ` Felipe Balbi
2016-08-29 8:22 ` Romain Izard
2016-08-29 9:07 ` [PATCH v2] usb: gadget: configfs: log function unbinding as debug Romain Izard
2016-09-07 9:43 ` Romain Izard
2016-09-07 10:44 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).