From: Sven Van Asbroeck <thesven73@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mark Brown <broonie@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Discussions about the Letux Kernel
<letux-kernel@openphoenux.org>
Subject: Re: [BUG] SPI broken for SPI based panel drivers
Date: Tue, 1 Dec 2020 09:08:34 -0500 [thread overview]
Message-ID: <CAGngYiVU5Udm6zUzrJPNF-V+uchhiv0-tWbUzb+_aSYVF=Dpug@mail.gmail.com> (raw)
In-Reply-To: <460191B6-EDD3-46DE-A1ED-47F758F111E8@goldelico.com>
On Tue, Dec 1, 2020 at 8:36 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Well I only complain because you wrote that you knew that it may
> break something else. So it is known to induces a regression.
We knew that it would fix an important, common problem, but
we also knew that there is always a possibility of breaking
something else when making a change to the core.
>
> Maybe printing a "please check your spi setup" in spi_setup() with
> a comment hinting at your patch would have saved me a lot of time.
>
You could ask the maintainer for such a policy, but I fear that soon
the code would emit too many "please check" messages.
>
> Well, I am sort of maintainer of a vendor kernel that tries to
> follow linus/master and fix things before we release an LTS.
Makes sense, I understand your situation better now.
>
> Anyways, there is still time until v5.10.0 to fix it better than by
> a revert.
When we find a fix, it'll have a Fixes: tag, which means it'll
automatically be applied to every supported kernel, including
v5.10 even if already released.
>
> Hope that you have an idea soon. I am happy to test any suggestions/patches/alternatives
> better than a simple revert.
>
Thank you, that's great. I may come back with a few suggestions
for you to test this week.
next prev parent reply other threads:[~2020-12-01 14:10 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 19:03 [BUG] SPI broken for SPI based panel drivers H. Nikolaus Schaller
2020-11-30 20:13 ` Sven Van Asbroeck
2020-11-30 20:22 ` Sven Van Asbroeck
2020-12-01 8:59 ` H. Nikolaus Schaller
2020-12-01 12:16 ` Mark Brown
2020-12-01 14:05 ` H. Nikolaus Schaller
2020-12-01 14:20 ` Linus Walleij
2020-12-01 14:34 ` Sven Van Asbroeck
2020-12-01 14:35 ` H. Nikolaus Schaller
2020-12-01 15:52 ` Sven Van Asbroeck
2020-12-01 16:46 ` H. Nikolaus Schaller
2020-12-01 16:10 ` Sven Van Asbroeck
2020-12-01 16:39 ` H. Nikolaus Schaller
2020-12-01 16:53 ` Sven Van Asbroeck
2020-12-01 17:10 ` H. Nikolaus Schaller
2020-12-01 18:43 ` Sven Van Asbroeck
2020-12-02 12:19 ` Mark Brown
2020-12-04 10:08 ` H. Nikolaus Schaller
2020-12-04 13:46 ` Sven Van Asbroeck
2020-12-04 16:49 ` H. Nikolaus Schaller
2020-12-04 19:19 ` Sven Van Asbroeck
2020-12-04 21:31 ` H. Nikolaus Schaller
2020-12-05 0:25 ` Linus Walleij
2020-12-05 7:04 ` H. Nikolaus Schaller
2020-12-09 8:04 ` Andreas Kemnade
2020-12-09 8:40 ` H. Nikolaus Schaller
2020-12-09 8:38 ` Linus Walleij
2020-12-09 8:45 ` H. Nikolaus Schaller
2020-12-01 22:51 ` Linus Walleij
2020-12-01 16:44 ` [Letux-kernel] " Andreas Kemnade
2020-12-01 16:51 ` H. Nikolaus Schaller
2020-12-01 16:52 ` H. Nikolaus Schaller
2020-12-01 16:55 ` Sven Van Asbroeck
2020-12-01 16:20 ` Mark Brown
2020-12-01 16:41 ` H. Nikolaus Schaller
2020-12-01 17:11 ` Mark Brown
2020-12-01 12:41 ` Sven Van Asbroeck
2020-12-01 13:32 ` H. Nikolaus Schaller
2020-12-01 14:08 ` Sven Van Asbroeck [this message]
2020-12-01 15:33 ` Mark Brown
2020-12-05 20:57 ` Pavel Machek
2020-12-07 13:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGngYiVU5Udm6zUzrJPNF-V+uchhiv0-tWbUzb+_aSYVF=Dpug@mail.gmail.com' \
--to=thesven73@gmail.com \
--cc=broonie@kernel.org \
--cc=hns@goldelico.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=letux-kernel@openphoenux.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).