From: Nishanth Menon <nm@ti.com>
To: Jonghwan Choi <jhbird.choi@samsung.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>,
Amit Daniel Kachhap <amit.daniel@samsung.com>
Subject: Re: [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table
Date: Tue, 6 May 2014 20:00:03 -0500 [thread overview]
Message-ID: <CAGo_u6o0J_T_hnmDAiYpsDxe77iKPCjuWisZJfTjYYOVGJF96A@mail.gmail.com> (raw)
In-Reply-To: <003e01cf6984$fb950280$f2bf0780$@samsung.com>
On Tue, May 6, 2014 at 6:43 PM, Jonghwan Choi <jhbird.choi@samsung.com> wrote:
> Hi
Please dont top post. it is usually frowned upon.
>
> My holiday is finished.
>
> I implemented another cpufreq driver. And that driver also have to use exynos_sort_descend_freq_table().
> Then exynos5440 and new cpufreq have a duplicate function.(exynos_sort_descend_freq_table().
> So I want to solve it.
As discussed in the thread, creating stuff that are common into a
common file, and even isolating this into cpufreq specific solution
might be good.
[1] now moves that entire logic of table creation to be cpufreq
specific - we could consider modifier functions to them.
In some quick tests by reversing table [2], I cant see any difference
in behavior in ascending[3] or descending[4] order of the cpufreq
table.
So, we could do [2] as default as well, if it is determined to impact
no one else making any form of assumptions on table ordering - but it
might be preferable for drivers not to depend on framework ordering of
data as things could change in the future.
[1] https://patchwork.kernel.org/patch/4115141/ +
https://patchwork.kernel.org/patch/4115101/
[2] http://slexy.org/view/s21HyCUhXK
[3] http://slexy.org/view/s202xTUG59
[4] http://slexy.org/view/s20ewFa6PW
Regards,
Nishanth Menon
next prev parent reply other threads:[~2014-05-07 1:00 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-30 6:28 [PATCH 1/3] PM / OPP: Add support for descending order for cpufreq table Jonghwan Choi
2014-04-30 8:25 ` Viresh Kumar
2014-05-03 0:16 ` Jonghwan Choi
2014-05-05 5:54 ` Viresh Kumar
2014-05-05 13:38 ` Nishanth Menon
2014-05-05 14:14 ` Viresh Kumar
2014-05-05 14:23 ` Nishanth Menon
2014-05-05 14:38 ` Viresh Kumar
2014-05-05 14:46 ` Nishanth Menon
2014-05-06 23:43 ` Jonghwan Choi
2014-05-07 1:00 ` Nishanth Menon [this message]
2014-05-07 6:04 ` Viresh Kumar
2014-05-08 1:22 ` Jonghwan Choi
2014-05-08 1:55 ` Nishanth Menon
2014-05-08 2:07 ` Jonghwan Choi
2014-05-08 5:55 ` Viresh Kumar
2014-05-09 1:09 ` Jonghwan Choi
2014-05-09 6:00 ` Viresh Kumar
2014-05-09 11:59 ` jonghwan Choi
2014-05-09 13:23 ` Nishanth Menon
2014-05-11 11:38 ` jonghwan Choi
2014-05-12 6:18 ` Viresh Kumar
2014-05-08 5:50 ` Viresh Kumar
2014-05-06 17:25 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGo_u6o0J_T_hnmDAiYpsDxe77iKPCjuWisZJfTjYYOVGJF96A@mail.gmail.com \
--to=nm@ti.com \
--cc=amit.daniel@samsung.com \
--cc=jhbird.choi@samsung.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).