From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: "Jérémy Lefaure" <jeremy.lefaure@lse.epita.fr>
Cc: David Howells <dhowells@redhat.com>,
linux-cachefs@redhat.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type
Date: Wed, 26 Apr 2017 01:04:05 +0300 [thread overview]
Message-ID: <CAHp75VcB-Wpjz9JEh1iJBGuVX-sc=KLp_CQqbX8JyxFAVqga+A@mail.gmail.com> (raw)
In-Reply-To: <20170425173700.124ee74d@blatinox-laptop.localdomain>
On Wed, Apr 26, 2017 at 12:37 AM, Jérémy Lefaure
<jeremy.lefaure@lse.epita.fr> wrote:
> On Tue, 25 Apr 2017 00:47:41 +0300
> Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> Ok I get it. But changing the format can break the userland tool
> anyway, can't it ? For example if a userland tool expects the value 75,
> it won't read it properpy in BCD.
Maybe.
>> So, if it's okay in this, perhaps paragraph explaining side effects in
>> commit message would be good to have/
>>
> Maybe the best fix would be to increase the size of the _type buffer to
> 4 so the unsigned byte can fit in it. And change the documentation to
> decimal value. What do you think about this solution ?
Yes, it would work.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2017-04-25 22:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 20:38 Jérémy Lefaure
2017-04-21 19:41 ` Andy Shevchenko
2017-04-21 23:09 ` Jérémy Lefaure
2017-04-24 21:47 ` Andy Shevchenko
2017-04-25 21:37 ` Jérémy Lefaure
2017-04-25 22:04 ` Andy Shevchenko [this message]
2017-04-27 0:31 ` [PATCH v2] FS-Cache: fix buffer size for decimal value of special cookie type Jérémy Lefaure
2017-04-27 15:03 ` [PATCH] FS-Cache: print hexadecimal value for special cookies type David Howells
2017-04-27 15:11 ` Jérémy Lefaure
2017-04-27 15:41 ` David Howells
2017-05-28 0:31 ` Jérémy Lefaure
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VcB-Wpjz9JEh1iJBGuVX-sc=KLp_CQqbX8JyxFAVqga+A@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=dhowells@redhat.com \
--cc=jeremy.lefaure@lse.epita.fr \
--cc=linux-cachefs@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).