* [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN
@ 2019-07-24 8:14 Rhys Kidd
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Rhys Kidd @ 2019-07-24 8:14 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Rhys Kidd
There's a wmi event generated by dell-wmi when pressing keyboard backlight
toggle key:
[1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed
This event is for notification purposes, let's ignore it.
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
---
drivers/platform/x86/dell-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 1f565fb69098..ae331ac119a1 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
/* Keyboard backlight level changed */
{ KE_IGNORE, 0x01e1, { KEY_RESERVED } },
+ { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
{ KE_IGNORE, 0x02ea, { KEY_RESERVED } },
{ KE_IGNORE, 0x02eb, { KEY_RESERVED } },
{ KE_IGNORE, 0x02ec, { KEY_RESERVED } },
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN
2019-07-24 8:14 [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Rhys Kidd
@ 2019-07-24 8:14 ` Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-24 8:14 ` [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values Rhys Kidd
2019-07-25 17:59 ` [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: Rhys Kidd @ 2019-07-24 8:14 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Rhys Kidd
There's a wmi event generated by dell-wmi when pressing keyboard backlight
toggle key:
[1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressed
This event is for notification purposes, let's ignore it.
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
---
drivers/platform/x86/dell-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index ae331ac119a1..68a8a4eba4e3 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
/* Keyboard backlight level changed */
{ KE_IGNORE, 0x01e1, { KEY_RESERVED } },
{ KE_IGNORE, 0x01e2, { KEY_RESERVED } },
+ { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
{ KE_IGNORE, 0x02ea, { KEY_RESERVED } },
{ KE_IGNORE, 0x02eb, { KEY_RESERVED } },
{ KE_IGNORE, 0x02ec, { KEY_RESERVED } },
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values
2019-07-24 8:14 [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Rhys Kidd
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
@ 2019-07-24 8:14 ` Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-25 17:59 ` [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Andy Shevchenko
2 siblings, 1 reply; 6+ messages in thread
From: Rhys Kidd @ 2019-07-24 8:14 UTC (permalink / raw)
To: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
platform-driver-x86, linux-kernel
Cc: Rhys Kidd
These values have already been defined in platform/x86/dell-smbios.h
Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
---
drivers/platform/x86/dell-wmi.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index 68a8a4eba4e3..fc33c38f5f82 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
{ KE_IGNORE, 0xfff1, { KEY_RESERVED } },
/* Keyboard backlight level changed */
- { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
- { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
- { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
- { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
- { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
- { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
- { KE_IGNORE, 0x02f6, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_OFF_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_ON_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_AUTO_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_AUTO_25_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_AUTO_50_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_AUTO_75_TOKEN, { KEY_RESERVED } },
+ { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } },
};
static void dell_wmi_process_key(struct wmi_device *wdev, int type, int code)
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN
2019-07-24 8:14 [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Rhys Kidd
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
2019-07-24 8:14 ` [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values Rhys Kidd
@ 2019-07-25 17:59 ` Andy Shevchenko
2 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-07-25 17:59 UTC (permalink / raw)
To: Rhys Kidd
Cc: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jul 24, 2019 at 11:14 AM Rhys Kidd <rhyskidd@gmail.com> wrote:
>
> There's a wmi event generated by dell-wmi when pressing keyboard backlight
> toggle key:
> [1224203.948894] dell_wmi: Unknown key with type 0x0011 and code 0x01e2 pressed
>
> This event is for notification purposes, let's ignore it.
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/platform/x86/dell-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 1f565fb69098..ae331ac119a1 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -312,6 +312,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
>
> /* Keyboard backlight level changed */
> { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
> + { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
> { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
@ 2019-07-25 17:59 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-07-25 17:59 UTC (permalink / raw)
To: Rhys Kidd
Cc: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jul 24, 2019 at 11:14 AM Rhys Kidd <rhyskidd@gmail.com> wrote:
>
> There's a wmi event generated by dell-wmi when pressing keyboard backlight
> toggle key:
> [1224178.355650] dell_wmi: Unknown key with type 0x0011 and code 0x01e3 pressed
>
> This event is for notification purposes, let's ignore it.
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/platform/x86/dell-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index ae331ac119a1..68a8a4eba4e3 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -313,6 +313,7 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
> /* Keyboard backlight level changed */
> { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
> { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
> + { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
> { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
> { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values
2019-07-24 8:14 ` [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values Rhys Kidd
@ 2019-07-25 17:59 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2019-07-25 17:59 UTC (permalink / raw)
To: Rhys Kidd
Cc: Matthew Garrett, Pali Rohár, Darren Hart, Andy Shevchenko,
Platform Driver, Linux Kernel Mailing List
On Wed, Jul 24, 2019 at 11:14 AM Rhys Kidd <rhyskidd@gmail.com> wrote:
>
> These values have already been defined in platform/x86/dell-smbios.h
>
Pushed to my review and testing queue, thanks!
> Signed-off-by: Rhys Kidd <rhyskidd@gmail.com>
> ---
> drivers/platform/x86/dell-wmi.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index 68a8a4eba4e3..fc33c38f5f82 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -311,13 +311,13 @@ static const struct key_entry dell_wmi_keymap_type_0011[] = {
> { KE_IGNORE, 0xfff1, { KEY_RESERVED } },
>
> /* Keyboard backlight level changed */
> - { KE_IGNORE, 0x01e1, { KEY_RESERVED } },
> - { KE_IGNORE, 0x01e2, { KEY_RESERVED } },
> - { KE_IGNORE, 0x01e3, { KEY_RESERVED } },
> - { KE_IGNORE, 0x02ea, { KEY_RESERVED } },
> - { KE_IGNORE, 0x02eb, { KEY_RESERVED } },
> - { KE_IGNORE, 0x02ec, { KEY_RESERVED } },
> - { KE_IGNORE, 0x02f6, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_OFF_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_ON_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_AUTO_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_AUTO_25_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_AUTO_50_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_AUTO_75_TOKEN, { KEY_RESERVED } },
> + { KE_IGNORE, KBD_LED_AUTO_100_TOKEN, { KEY_RESERVED } },
> };
>
> static void dell_wmi_process_key(struct wmi_device *wdev, int type, int code)
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-25 18:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-24 8:14 [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Rhys Kidd
2019-07-24 8:14 ` [PATCH 2/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_AUTO_TOKEN Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-24 8:14 ` [PATCH 3/3] platform/x86: dell-wmi: Use existing defined KBD_LED_* magic values Rhys Kidd
2019-07-25 17:59 ` Andy Shevchenko
2019-07-25 17:59 ` [PATCH 1/3] platform/x86: dell-wmi: Ignore keyboard backlight change KBD_LED_ON_TOKEN Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).