From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: chenyu56@huawei.com
Cc: USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
John Stultz <john.stultz@linaro.org>,
Wangbinghui <wangbinghui@hisilicon.com>
Subject: Re: [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform
Date: Mon, 3 Dec 2018 10:12:01 +0200 [thread overview]
Message-ID: <CAHp75VcdbJ9KV2Xr9mQsAcODMCJUMXz0OY0t_FSJgZ6dXx2fYQ@mail.gmail.com> (raw)
In-Reply-To: <20181203034515.91412-5-chenyu56@huawei.com>
On Mon, Dec 3, 2018 at 5:48 AM Yu Chen <chenyu56@huawei.com> wrote:
>
> This driver handles the poweron and shutdown of dwc3 core
> on Hisilicon Soc Platform.
> +config USB_DWC3_HISI
> + tristate "HiSilicon Kirin Platforms"
> + depends on ((ARCH_HISI && ARM64) || COMPILE_TEST) && OF
It would be easy to read if
depends on OF
would be on a separate line
> + default USB_DWC3
> + help
> + Support USB2/3 functionality in HiSilicon Kirin platforms.
> + Say 'Y' or 'M' if you have one such device.
> +++ b/drivers/usb/dwc3/dwc3-hisi.c
> @@ -0,0 +1,335 @@
> +// SPDX-License-Identifier: GPL-2.0+
You need to talk to your manager and fix License correspondingly.
Currently there is an ambigous reading.
> +/**
Why /** ?
> + * dwc3-hisi.c - Support for dwc3 platform devices on HiSilicon platforms
Usually put filename in the file is not the best idea.
> + *
> + * Copyright (C) 2017-2018 Hilisicon Electronics Co., Ltd.
> + * http://www.huawei.com
> + *
> + * Authors: Yu Chen <chenyu56@huawei.com>
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 of
> + * the License as published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
The idea of SPDX is exactly to remove the above boilerplate text.
> + */
> +
> +#include <linux/module.h>
> +#include <linux/kernel.h>
> +#include <linux/slab.h>
> +#include <linux/of.h>
> +#include <linux/of_platform.h>
> +#include <linux/pm_runtime.h>
> +#include <linux/clk.h>
> +#include <linux/clk-provider.h>
> +#include <linux/regmap.h>
> +#include <linux/reset.h>
> +#include <linux/extcon.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/pinctrl/consumer.h>
It would be easy to maintain ordered list in the future.
> + while (--i >= 0)
while (i--)
> + while (--i >= 0)
while (i--)
> + while (--i >= 0)
while (i--)
> + while (--i >= 0)
while (i--)
> + while (--i >= 0)
> +static int dwc3_hisi_probe(struct platform_device *pdev)
> +{
> + struct dwc3_hisi *dwc3_hisi;
> + struct device *dev = &pdev->dev;
> + struct device_node *np = dev->of_node;
> +
Redundant blank line
> + int ret;
> + int i;
> +}
> +#ifdef CONFIG_PM_SLEEP
> +static int dwc3_hisi_suspend(struct device *dev)
Don't know the usual practice here, but you can just use
__maybe_unused and remove this #ifdef.
> +{
> + struct dwc3_hisi *dwc3_hisi = dev_get_drvdata(dev);
> + int ret;
> +
> + dev_info(dev, "%s\n", __func__);
Noise
> +}
> +static int dwc3_hisi_resume(struct device *dev)
__maybe_unused ?
> +{
> + dev_info(dev, "%s\n", __func__);
Noise.
> + /* Wait for clock stable */
> + msleep(100);
Don't you have any hardware notification that clocks are stable?
(Something like PLL locked?)
> +
> + return 0;
> +}
> +#endif /* CONFIG_PM_SLEEP */
> +static const struct of_device_id dwc3_hisi_match[] = {
> + { .compatible = "hisilicon,hi3660-dwc3" },
> + { /* sentinel */ },
No need comma for terminator line.
> +};
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2018-12-03 8:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03 8:35 ` Sergei Shtylyov
2018-12-03 8:51 ` Chen Yu
2018-12-03 8:59 ` Sergei Shtylyov
2018-12-03 9:28 ` Chen Yu
2018-12-19 14:09 ` Rob Herring
2018-12-20 1:33 ` Chen Yu
2018-12-20 6:46 ` Felipe Balbi
2018-12-20 13:48 ` Rob Herring
2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-19 14:14 ` Rob Herring
2018-12-20 1:52 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-19 14:21 ` Rob Herring
2018-12-20 2:02 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03 8:12 ` Andy Shevchenko [this message]
2018-12-03 8:30 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03 8:02 ` Andy Shevchenko
2018-12-03 8:23 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03 8:14 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen
2018-12-03 8:17 ` Andy Shevchenko
2018-12-03 12:25 ` Heikki Krogerus
2019-01-21 8:36 ` Chen Yu
2019-01-21 13:51 ` Heikki Krogerus
2019-01-25 12:35 ` Heikki Krogerus
2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 12:38 ` Heikki Krogerus
2018-12-04 1:07 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03 9:15 ` Andy Shevchenko
2018-12-03 9:30 ` Chen Yu
2018-12-03 12:43 ` Heikki Krogerus
2018-12-04 10:54 ` Heikki Krogerus
2018-12-05 0:56 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03 9:23 ` Andy Shevchenko
2018-12-04 1:40 ` Chen Yu
2018-12-04 17:47 ` Andy Shevchenko
2018-12-05 1:57 ` Chen Yu
2018-12-05 8:44 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03 9:25 ` Andy Shevchenko
2018-12-04 1:22 ` Chen Yu
2018-12-03 9:53 ` Krzysztof Opasiak
2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-04 12:45 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcdbJ9KV2Xr9mQsAcODMCJUMXz0OY0t_FSJgZ6dXx2fYQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=chenyu56@huawei.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=suzhuangluan@hisilicon.com \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).