linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: chenyu56@huawei.com
Cc: liuyu712@hisilicon.com, Wangbinghui <wangbinghui@hisilicon.com>,
	USB <linux-usb@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Suzhuangluan <suzhuangluan@hisilicon.com>,
	Kongfei <kongfei@hisilicon.com>, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	John Stultz <john.stultz@linaro.org>,
	"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960
Date: Wed, 5 Dec 2018 10:44:31 +0200	[thread overview]
Message-ID: <CAHp75Vee21_x47wS9y7eoLsnemst=gigVv9sw_LrUd-kTs0mtA@mail.gmail.com> (raw)
In-Reply-To: <a1168f88-5679-6245-41d8-5ef4be5493b2@huawei.com>

On Wed, Dec 5, 2018 at 3:57 AM Chen Yu <chenyu56@huawei.com> wrote:
> On 2018/12/5 1:47, Andy Shevchenko wrote:
> > On Tue, Dec 4, 2018 at 3:40 AM Chen Yu <chenyu56@huawei.com> wrote:
> >> On 2018/12/3 17:23, Andy Shevchenko wrote:
> >>> On Mon, Dec 3, 2018 at 5:47 AM Yu Chen <chenyu56@huawei.com> wrote:
> >
> >>>> +               .of_match_table = of_match_ptr(id_table_hisi_hikey_usb),
> >>>
> >>> Does it compiles for non-OF case? Why macro is in use?
> >
> >> OK. I will add the "CONFIG_OF".
> > Why? Is this driver supposed to work without DT?
> >
> No. This driver should depend on OF.
> Can I solve this by add "dpends on OF" in Kconfig?

Yes and don't forget to drop unneeded macro(s) like of_match_ptr() above.


-- 
With Best Regards,
Andy Shevchenko

  reply	other threads:[~2018-12-05  8:44 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03  3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03  3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03  8:35   ` Sergei Shtylyov
2018-12-03  8:51     ` Chen Yu
2018-12-03  8:59       ` Sergei Shtylyov
2018-12-03  9:28         ` Chen Yu
2018-12-19 14:09           ` Rob Herring
2018-12-20  1:33             ` Chen Yu
2018-12-20  6:46             ` Felipe Balbi
2018-12-20 13:48               ` Rob Herring
2018-12-03  3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-19 14:14   ` Rob Herring
2018-12-20  1:52     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-19 14:21   ` Rob Herring
2018-12-20  2:02     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03  8:12   ` Andy Shevchenko
2018-12-03  8:30     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03  8:02   ` Andy Shevchenko
2018-12-03  8:23     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03  8:14   ` Andy Shevchenko
2018-12-03  3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen
2018-12-03  8:17   ` Andy Shevchenko
2018-12-03 12:25     ` Heikki Krogerus
2019-01-21  8:36       ` Chen Yu
2019-01-21 13:51         ` Heikki Krogerus
2019-01-25 12:35           ` Heikki Krogerus
2018-12-03  3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 12:38   ` Heikki Krogerus
2018-12-04  1:07     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03  9:15   ` Andy Shevchenko
2018-12-03  9:30     ` Chen Yu
2018-12-03 12:43   ` Heikki Krogerus
2018-12-04 10:54   ` Heikki Krogerus
2018-12-05  0:56     ` Chen Yu
2018-12-03  3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03  9:23   ` Andy Shevchenko
2018-12-04  1:40     ` Chen Yu
2018-12-04 17:47       ` Andy Shevchenko
2018-12-05  1:57         ` Chen Yu
2018-12-05  8:44           ` Andy Shevchenko [this message]
2018-12-03  3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03  9:25   ` Andy Shevchenko
2018-12-04  1:22     ` Chen Yu
2018-12-03  9:53   ` Krzysztof Opasiak
2018-12-03  3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-04 12:45   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHp75Vee21_x47wS9y7eoLsnemst=gigVv9sw_LrUd-kTs0mtA@mail.gmail.com' \
    --to=andy.shevchenko@gmail.com \
    --cc=arnd@arndb.de \
    --cc=chenyu56@huawei.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=john.stultz@linaro.org \
    --cc=kongfei@hisilicon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=liuyu712@hisilicon.com \
    --cc=suzhuangluan@hisilicon.com \
    --cc=wangbinghui@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).