From: Chen Yu <chenyu56@huawei.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <liuyu712@hisilicon.com>, USB <linux-usb@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Suzhuangluan <suzhuangluan@hisilicon.com>,
Kongfei <kongfei@hisilicon.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
"John Stultz" <john.stultz@linaro.org>
Subject: Re: [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node
Date: Mon, 21 Jan 2019 16:36:13 +0800 [thread overview]
Message-ID: <e9a8f745-6211-d6d2-24f0-ac86f82924f0@huawei.com> (raw)
In-Reply-To: <20181203122534.GD24338@kuha.fi.intel.com>
Hi Heikki,
On 2018/12/3 20:25, Heikki Krogerus wrote:
> Hi,
>
> On Mon, Dec 03, 2018 at 10:17:20AM +0200, Andy Shevchenko wrote:
>> On Mon, Dec 3, 2018 at 5:45 AM Yu Chen <chenyu56@huawei.com> wrote:
>>>
>>> This patch adds code for supporting find usb role switch by matching against
>>> the device node described using of_graph.
>>
>>> #include <linux/module.h>
>>> #include <linux/mutex.h>
>>> #include <linux/slab.h>
>>> +#include <linux/of.h>
>>> +#include <linux/of_graph.h>
>>
>> Keep it ordered.
>>
>>> +static int __switch_match_by_of_node(struct device *dev, const void *name)
>>> +{
>>> + if (!dev->parent || !dev->parent->of_node)
>>> + return 0;
>>> +
>>> + return of_node_name_eq(dev->parent->of_node, (const char *)name);
>>> +}
>>
>> I think Heikki has introduced some more generic function for this.
>
> Yes, for this I'm proposing a new function fwnode_get_name() that
> should allow us to support ACPI as well as OF platforms:
> https://lkml.org/lkml/2018/11/28/784
>
>>> sw = device_connection_find_match(dev, "usb-role-switch", NULL,
>>> usb_role_switch_match);
>>
>>> + sw = of_graph_find_match_by_type(dev, "usb-role-switch");
>>
>> Why this is here?! device_connection_find_match() should take care for OF case.
>
> Exactly. device_connection_find_match() needs to parse the graph (OF
> and ACPI), and I already made proposal (RFC) for that:
> https://lkml.org/lkml/2018/10/24/619
>
> I have prepared a more finalized version of those patches. I've been
> waiting for that fwnode_get_name() to be accepted before sending it
> out since we are going to need that function, but I'll send a new RFC
> if nothing happens soon with that fwnode_get_name() series.
>
>
> Br,
>
Have the fwnode_get_name() patches been accepted?
And I will be grateful if you can tell me your plan about the
https://lkml.org/lkml/2018/10/24/619 patches.
thanks
- Yu Chen
next prev parent reply other threads:[~2019-01-21 8:36 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 3:45 [PATCH v1 00/12] Add support for usb on Hikey960 Yu Chen
2018-12-03 3:45 ` [PATCH v1 01/12] dt-bindings: usb: add support for dwc3 controller on HiSilicon SoCs Yu Chen
2018-12-03 8:35 ` Sergei Shtylyov
2018-12-03 8:51 ` Chen Yu
2018-12-03 8:59 ` Sergei Shtylyov
2018-12-03 9:28 ` Chen Yu
2018-12-19 14:09 ` Rob Herring
2018-12-20 1:33 ` Chen Yu
2018-12-20 6:46 ` Felipe Balbi
2018-12-20 13:48 ` Rob Herring
2018-12-03 3:45 ` [PATCH v1 02/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Yu Chen
2018-12-19 14:14 ` Rob Herring
2018-12-20 1:52 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 03/12] dt-bindings: misc: Add bindings for HiSilicon usb hub and data role switch functionality on HiKey960 Yu Chen
2018-12-19 14:21 ` Rob Herring
2018-12-20 2:02 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 04/12] usb: dwc3: dwc3-hisi: Add code for dwc3 of Hisilicon Soc Platform Yu Chen
2018-12-03 8:12 ` Andy Shevchenko
2018-12-03 8:30 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 05/12] usb: dwc3: Add two quirks for Hisilicon Kirin " Yu Chen
2018-12-03 8:02 ` Andy Shevchenko
2018-12-03 8:23 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 06/12] phy: Add usb phy support for hi3660 Soc of Hisilicon Yu Chen
2018-12-03 8:14 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 07/12] usb: roles: Find the usb role switch by also matching against the device node Yu Chen
2018-12-03 8:17 ` Andy Shevchenko
2018-12-03 12:25 ` Heikki Krogerus
2019-01-21 8:36 ` Chen Yu [this message]
2019-01-21 13:51 ` Heikki Krogerus
2019-01-25 12:35 ` Heikki Krogerus
2018-12-03 3:45 ` [PATCH v1 08/12] usb: roles: Add usb role switch notifier Yu Chen
2018-12-03 12:38 ` Heikki Krogerus
2018-12-04 1:07 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 09/12] usb: dwc3: Registering a role switch in the DRD code Yu Chen
2018-12-03 9:15 ` Andy Shevchenko
2018-12-03 9:30 ` Chen Yu
2018-12-03 12:43 ` Heikki Krogerus
2018-12-04 10:54 ` Heikki Krogerus
2018-12-05 0:56 ` Chen Yu
2018-12-03 3:45 ` [PATCH v1 10/12] hikey960: Support usb functionality of Hikey960 Yu Chen
2018-12-03 9:23 ` Andy Shevchenko
2018-12-04 1:40 ` Chen Yu
2018-12-04 17:47 ` Andy Shevchenko
2018-12-05 1:57 ` Chen Yu
2018-12-05 8:44 ` Andy Shevchenko
2018-12-03 3:45 ` [PATCH v1 11/12] usb: gadget: Add configfs attribuite for controling match_existing_only Yu Chen
2018-12-03 9:25 ` Andy Shevchenko
2018-12-04 1:22 ` Chen Yu
2018-12-03 9:53 ` Krzysztof Opasiak
2018-12-03 3:45 ` [PATCH v1 12/12] dts: hi3660: Add support for usb on Hikey960 Yu Chen
2018-12-04 12:45 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a8f745-6211-d6d2-24f0-ac86f82924f0@huawei.com \
--to=chenyu56@huawei.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=kongfei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liuyu712@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).