* [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
@ 2020-06-02 9:21 Piotr Stankiewicz
2020-06-02 15:39 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Piotr Stankiewicz @ 2020-06-02 9:21 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta, David S . Miller, Jakub Kicinski
Cc: netdev, linux-kernel, Piotr Stankiewicz
Seeing as there is shorthand available to use when asking for any type
of interrupt, or any type of message signalled interrupt, leverage it.
Signed-off-by: Piotr Stankiewicz <piotr.stankiewicz@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +--
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
index a758f9ae32be..c49313e87170 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
@@ -2334,8 +2334,7 @@ static int hclge_init_msi(struct hclge_dev *hdev)
int i;
vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
- hdev->num_msi,
- PCI_IRQ_MSI | PCI_IRQ_MSIX);
+ hdev->num_msi, PCI_IRQ_MSI_TYPES);
if (vectors < 0) {
dev_err(&pdev->dev,
"failed(%d) to allocate MSI/MSI-X vectors\n",
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
index e02d427131ee..002a40e65ab7 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
@@ -2342,7 +2342,7 @@ static int hclgevf_init_msi(struct hclgevf_dev *hdev)
else
vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
hdev->num_msi,
- PCI_IRQ_MSI | PCI_IRQ_MSIX);
+ PCI_IRQ_MSI_TYPES);
if (vectors < 0) {
dev_err(&pdev->dev,
--
2.17.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 9:21 [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
@ 2020-06-02 15:39 ` Andy Shevchenko
2020-06-03 8:49 ` Stankiewicz, Piotr
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-06-02 15:39 UTC (permalink / raw)
To: Piotr Stankiewicz
Cc: Yisen Zhuang, Salil Mehta, David S . Miller, Jakub Kicinski,
netdev, Linux Kernel Mailing List
On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
<piotr.stankiewicz@intel.com> wrote:
>
> Seeing as there is shorthand available to use when asking for any type
> of interrupt, or any type of message signalled interrupt, leverage it.
...
> vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> - hdev->num_msi,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + hdev->num_msi, PCI_IRQ_MSI_TYPES);
...
> vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> hdev->num_msi,
> - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> + PCI_IRQ_MSI_TYPES);
One line as above?
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-02 15:39 ` Andy Shevchenko
@ 2020-06-03 8:49 ` Stankiewicz, Piotr
2020-06-03 10:36 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Stankiewicz, Piotr @ 2020-06-03 8:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Yisen Zhuang, Salil Mehta, David S . Miller, Jakub Kicinski,
netdev, Linux Kernel Mailing List
> -----Original Message-----
> From: Andy Shevchenko <andy.shevchenko@gmail.com>
> Sent: Tuesday, June 2, 2020 5:39 PM
>
> On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
> <piotr.stankiewicz@intel.com> wrote:
> >
> > Seeing as there is shorthand available to use when asking for any type
> > of interrupt, or any type of message signalled interrupt, leverage it.
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
> > - hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + hdev->num_msi, PCI_IRQ_MSI_TYPES);
>
> ...
>
> > vectors = pci_alloc_irq_vectors(pdev, HNAE3_MIN_VECTOR_NUM,
>
> > hdev->num_msi,
> > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > + PCI_IRQ_MSI_TYPES);
>
> One line as above?
>
It would push the line above 80 characters.
> --
> With Best Regards,
> Andy Shevchenko
BR,
Piotr
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate
2020-06-03 8:49 ` Stankiewicz, Piotr
@ 2020-06-03 10:36 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2020-06-03 10:36 UTC (permalink / raw)
To: Stankiewicz, Piotr
Cc: Yisen Zhuang, Salil Mehta, David S . Miller, Jakub Kicinski,
netdev, Linux Kernel Mailing List
On Wed, Jun 3, 2020 at 11:50 AM Stankiewicz, Piotr
<piotr.stankiewicz@intel.com> wrote:
> > -----Original Message-----
> > From: Andy Shevchenko <andy.shevchenko@gmail.com>
> > Sent: Tuesday, June 2, 2020 5:39 PM
> > On Tue, Jun 2, 2020 at 12:26 PM Piotr Stankiewicz
> > <piotr.stankiewicz@intel.com> wrote:
...
> > > hdev->num_msi,
> > > - PCI_IRQ_MSI | PCI_IRQ_MSIX);
> > > + PCI_IRQ_MSI_TYPES);
> >
> > One line as above?
> >
>
> It would push the line above 80 characters.
It's now relaxed limit, but if it is only few characters, I wouldn't care.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-03 10:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-02 9:21 [PATCH 14/15] net: hns3: use PCI_IRQ_MSI_TYPES where appropriate Piotr Stankiewicz
2020-06-02 15:39 ` Andy Shevchenko
2020-06-03 8:49 ` Stankiewicz, Piotr
2020-06-03 10:36 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).