[PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

[PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Derek Robson]

Two files change in style fix, changes are octal file permissions.

Derek Robson (2):
  Staging: unisys: visorbus: style fix, using octal file permissions
  Staging: unisys: visorbus: style fix, using octal file permissions

 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.11.0

[PATCH 1/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Derek Robson]

Changed file permissions to octal style.
Found with checkpatch

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c
index 3457ef338e1e..28ca291a4053 100644
--- a/drivers/staging/unisys/visorbus/visorbus_main.c
+++ b/drivers/staging/unisys/visorbus/visorbus_main.c
@@ -984,7 +984,7 @@ create_bus_instance(struct visor_device *dev)
 		goto err_hdr_info;
 	}
 	dev->debugfs_client_bus_info =
-		debugfs_create_file("client_bus_info", S_IRUSR | S_IRGRP,
+		debugfs_create_file("client_bus_info", 0440,
 				    dev->debugfs_dir, dev,
 				    &client_bus_info_debugfs_fops);
 	if (!dev->debugfs_client_bus_info) {
@@ -1337,10 +1337,10 @@ visorbus_exit(void)
 	debugfs_remove_recursive(visorbus_debugfs_dir);
 }
 
-module_param_named(forcematch, visorbus_forcematch, int, S_IRUGO);
+module_param_named(forcematch, visorbus_forcematch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcematch,
 		 "1 to force a successful dev <--> drv match");
 
-module_param_named(forcenomatch, visorbus_forcenomatch, int, S_IRUGO);
+module_param_named(forcenomatch, visorbus_forcenomatch, int, 0444);
 MODULE_PARM_DESC(visorbus_forcenomatch,
 		 "1 to force an UNsuccessful dev <--> drv match");
-- 
2.11.0

[PATCH 2/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Derek Robson]

Changed file permissions to octal sytle.
Found using checkpatch.

Signed-off-by: Derek Robson <robsonde@gmail.com>
---
 drivers/staging/unisys/visorbus/visorchipset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
index d7148c351d3f..66944e7534e9 100644
--- a/drivers/staging/unisys/visorbus/visorchipset.c
+++ b/drivers/staging/unisys/visorbus/visorchipset.c
@@ -2277,7 +2277,7 @@ static void exit_unisys(void)
 	acpi_bus_unregister_driver(&unisys_acpi_driver);
 }
 
-module_param_named(major, visorchipset_major, int, S_IRUGO);
+module_param_named(major, visorchipset_major, int, 0444);
 MODULE_PARM_DESC(visorchipset_major,
 		 "major device number to use for the device node");
 
-- 
2.11.0

RE: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Kershner, David A]

> -----Original Message-----
> From: Derek Robson [mailto:robsonde@gmail.com]
> Sent: Friday, January 6, 2017 10:48 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org; Sell, Timothy C <Timothy.Sell@unisys.com>
> Cc: *S-Par-Maintainer <SParMaintainer@unisys.com>;
> devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Derek Robson
> <robsonde@gmail.com>
> Subject: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file
> permissions
> 
> Two files change in style fix, changes are octal file permissions.
> 

Series looks fine to me and runs on top of the s-Par firmware.

Acked-by: David Kershner <david.kershner@unisys.com>

> Derek Robson (2):
>   Staging: unisys: visorbus: style fix, using octal file permissions
>   Staging: unisys: visorbus: style fix, using octal file permissions
> 
>  drivers/staging/unisys/visorbus/visorbus_main.c | 6 +++---
>  drivers/staging/unisys/visorbus/visorchipset.c  | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> --
> 2.11.0

Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Greg KH]

On Sat, Jan 07, 2017 at 04:48:01PM +1300, Derek Robson wrote:
> Two files change in style fix, changes are octal file permissions.
> 
> Derek Robson (2):
>   Staging: unisys: visorbus: style fix, using octal file permissions
>   Staging: unisys: visorbus: style fix, using octal file permissions

You can't send different patches that do different things with identical
subject lines, as that doesn't make sense, right?

Please resend making these subject unique, and add David's ack to them
as well on the resend.

thanks,

greg k-h

Re: [PATCH 0/2] Staging: unisys: visorbus: style fix, using octal file permissions

[Andy Shevchenko]

On Sat, Jan 7, 2017 at 5:48 AM, Derek Robson <robsonde@gmail.com> wrote:
> Two files change in style fix, changes are octal file permissions.

Does it make any sense? Or did I miss something?

-- 
With Best Regards,
Andy Shevchenko