* [PATCH] platform/x86: acer-wmi: refactor function has_cap
@ 2018-08-06 20:00 Gustavo A. R. Silva
2018-08-06 20:16 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-06 20:00 UTC (permalink / raw)
To: Lee, Chun-Yi, Darren Hart, Andy Shevchenko, Joe Perches, David Laight
Cc: platform-driver-x86, linux-kernel, Gustavo A. R. Silva
Refactor function has_cap in order to avoid returning integer
values, when instead it should return booleans.
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/platform/x86/acer-wmi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 8952173..ff1689d 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -672,10 +672,7 @@ static void __init find_quirks(void)
static bool has_cap(u32 cap)
{
- if ((interface->capability & cap) != 0)
- return 1;
-
- return 0;
+ return (interface->capability & cap) != 0;
}
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: refactor function has_cap
2018-08-06 20:00 [PATCH] platform/x86: acer-wmi: refactor function has_cap Gustavo A. R. Silva
@ 2018-08-06 20:16 ` Andy Shevchenko
2018-08-06 20:31 ` Gustavo A. R. Silva
0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2018-08-06 20:16 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Lee, Chun-Yi, Darren Hart, Andy Shevchenko, Joe Perches,
David Laight, Platform Driver, Linux Kernel Mailing List
On Mon, Aug 6, 2018 at 11:00 PM, Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
> Refactor function has_cap in order to avoid returning integer
> values, when instead it should return booleans.
>
> This code was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/platform/x86/acer-wmi.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 8952173..ff1689d 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>
> static bool has_cap(u32 cap)
> {
> - if ((interface->capability & cap) != 0)
> - return 1;
> -
> - return 0;
> + return (interface->capability & cap) != 0;
> }
Thanks, as Joe mentioned even != 0 part is not needed (followed by
unneeded parens), though I would let it be (one line is good enough to
me) if there will be no strong preferences.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: refactor function has_cap
2018-08-06 20:16 ` Andy Shevchenko
@ 2018-08-06 20:31 ` Gustavo A. R. Silva
0 siblings, 0 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-06 20:31 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Lee, Chun-Yi, Darren Hart, Andy Shevchenko, Joe Perches,
David Laight, Platform Driver, Linux Kernel Mailing List
On 8/6/18 3:16 PM, Andy Shevchenko wrote:
> On Mon, Aug 6, 2018 at 11:00 PM, Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>> Refactor function has_cap in order to avoid returning integer
>> values, when instead it should return booleans.
>>
>> This code was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/platform/x86/acer-wmi.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
>> index 8952173..ff1689d 100644
>> --- a/drivers/platform/x86/acer-wmi.c
>> +++ b/drivers/platform/x86/acer-wmi.c
>> @@ -672,10 +672,7 @@ static void __init find_quirks(void)
>>
>> static bool has_cap(u32 cap)
>> {
>> - if ((interface->capability & cap) != 0)
>> - return 1;
>> -
>> - return 0;
>> + return (interface->capability & cap) != 0;
>> }
>
> Thanks, as Joe mentioned even != 0 part is not needed (followed by
> unneeded parens), though I would let it be (one line is good enough to
> me) if there will be no strong preferences.
>
Oh, yeah. I like it better what Joe suggested.
Let me send v2, shortly.
Thanks
--
Gustavo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-06 20:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-06 20:00 [PATCH] platform/x86: acer-wmi: refactor function has_cap Gustavo A. R. Silva
2018-08-06 20:16 ` Andy Shevchenko
2018-08-06 20:31 ` Gustavo A. R. Silva
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).