* [PATCH] brcmfmac: fix wrong location to get firmware feature
[not found] <CGME20200330052521epcas1p1eedc926d4b11513f8502cf0c90ecf433@epcas1p1.samsung.com>
@ 2020-03-30 5:25 ` Jaehoon Chung
2020-03-30 9:08 ` Andy Shevchenko
2020-04-14 15:03 ` Kalle Valo
0 siblings, 2 replies; 5+ messages in thread
From: Jaehoon Chung @ 2020-03-30 5:25 UTC (permalink / raw)
To: linux-wireless
Cc: brcm80211-dev-list.pdl, brcm80211-dev-list, linux-kernel, kvalo,
arend.vanspriel, franky.lin, hante.meuleman, chi-hsien.lin,
wright.feng, Jaehoon Chung
sup_wpa feature is getting after setting feature_disable flag.
If firmware is supported sup_wpa feature, it's always enabled
regardless of feature_disable flag.
Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
index 5da0dda0d899..0dcefbd0c000 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c
@@ -285,13 +285,14 @@ void brcmf_feat_attach(struct brcmf_pub *drvr)
if (!err)
ifp->drvr->feat_flags |= BIT(BRCMF_FEAT_SCAN_RANDOM_MAC);
+ brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_FWSUP, "sup_wpa");
+
if (drvr->settings->feature_disable) {
brcmf_dbg(INFO, "Features: 0x%02x, disable: 0x%02x\n",
ifp->drvr->feat_flags,
drvr->settings->feature_disable);
ifp->drvr->feat_flags &= ~drvr->settings->feature_disable;
}
- brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_FWSUP, "sup_wpa");
brcmf_feat_firmware_overrides(drvr);
--
2.26.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
2020-03-30 5:25 ` [PATCH] brcmfmac: fix wrong location to get firmware feature Jaehoon Chung
@ 2020-03-30 9:08 ` Andy Shevchenko
2020-03-30 10:16 ` Kalle Valo
2020-04-14 15:03 ` Kalle Valo
1 sibling, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-03-30 9:08 UTC (permalink / raw)
To: Jaehoon Chung
Cc: open list:TI WILINK WIRELES...,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
brcm80211-dev-list, Linux Kernel Mailing List, Kalle Valo,
Arend van Spriel, Franky Lin, Hante Meuleman, Chi-Hsien Lin,
Wright Feng
On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>
> sup_wpa feature is getting after setting feature_disable flag.
> If firmware is supported sup_wpa feature, it's always enabled
> regardless of feature_disable flag.
>
> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
No blank line in between. (Dunno if you need to resend, just wait what
maintainer says)
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
2020-03-30 9:08 ` Andy Shevchenko
@ 2020-03-30 10:16 ` Kalle Valo
2020-04-01 10:20 ` Jaehoon Chung
0 siblings, 1 reply; 5+ messages in thread
From: Kalle Valo @ 2020-03-30 10:16 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Jaehoon Chung, open list:TI WILINK WIRELES...,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
brcm80211-dev-list, Linux Kernel Mailing List, Arend van Spriel,
Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng
Andy Shevchenko <andy.shevchenko@gmail.com> writes:
> On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>
>> sup_wpa feature is getting after setting feature_disable flag.
>> If firmware is supported sup_wpa feature, it's always enabled
>> regardless of feature_disable flag.
>>
>
>> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>
> No blank line in between. (Dunno if you need to resend, just wait what
> maintainer says)
I can fix that during commit, no need to resend because of this.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
2020-03-30 10:16 ` Kalle Valo
@ 2020-04-01 10:20 ` Jaehoon Chung
0 siblings, 0 replies; 5+ messages in thread
From: Jaehoon Chung @ 2020-04-01 10:20 UTC (permalink / raw)
To: Kalle Valo, Andy Shevchenko
Cc: open list:TI WILINK WIRELES...,
open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER,
brcm80211-dev-list, Linux Kernel Mailing List, Arend van Spriel,
Franky Lin, Hante Meuleman, Chi-Hsien Lin, Wright Feng
On 3/30/20 7:16 PM, Kalle Valo wrote:
> Andy Shevchenko <andy.shevchenko@gmail.com> writes:
>
>> On Mon, Mar 30, 2020 at 8:26 AM Jaehoon Chung <jh80.chung@samsung.com> wrote:
>>>
>>> sup_wpa feature is getting after setting feature_disable flag.
>>> If firmware is supported sup_wpa feature, it's always enabled
>>> regardless of feature_disable flag.
>>>
>>
>>> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>
>> No blank line in between. (Dunno if you need to resend, just wait what
>> maintainer says)
>
> I can fix that during commit, no need to resend because of this.
Thanks!
BTW, I have a question about brcmfmac's firmware feature.
When i have tested on RPI4, it seems that 4-way handshake offloading feature is using.
If I entered the wrong password, which event is triggered from firmware?
And how does wpa_supplicant know about wrong key?
I don't have much knowledge about this..but if my analyzing is correct.
<7>[ 119.278494] brcmfmac: brcmf_is_nonetwork Processing failed supplicant state: 8
...
<7>[ 119.278525] brcmfmac: brcmf_bss_connect_done Report connect result - connection failed
...
<7>[ 119.278726] brcmfmac: brcmf_fweh_event_worker event DEAUTH_IND (6) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx
<7>[ 119.280966] brcmfmac: brcmf_fweh_event_worker event DEAUTH (5) ifidx 0 bsscfg 0 addr 70:5d:cc:6e:b5:xx
firmware is indicating DEAUTH event and driver will be controlled with it, right?
Can someone explain to me in more detail, plz?
Best Regards,
Jaehoon Chung
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] brcmfmac: fix wrong location to get firmware feature
2020-03-30 5:25 ` [PATCH] brcmfmac: fix wrong location to get firmware feature Jaehoon Chung
2020-03-30 9:08 ` Andy Shevchenko
@ 2020-04-14 15:03 ` Kalle Valo
1 sibling, 0 replies; 5+ messages in thread
From: Kalle Valo @ 2020-04-14 15:03 UTC (permalink / raw)
To: Jaehoon Chung
Cc: linux-wireless, brcm80211-dev-list.pdl, brcm80211-dev-list,
linux-kernel, arend.vanspriel, franky.lin, hante.meuleman,
chi-hsien.lin, wright.feng, Jaehoon Chung
Jaehoon Chung <jh80.chung@samsung.com> wrote:
> sup_wpa feature is getting after setting feature_disable flag.
> If firmware is supported sup_wpa feature, it's always enabled
> regardless of feature_disable flag.
>
> Fixes: b8a64f0e96c2 ("brcmfmac: support 4-way handshake offloading for WPA/WPA2-PSK")
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
Patch applied to wireless-drivers-next.git, thanks.
c57673852062 brcmfmac: fix wrong location to get firmware feature
--
https://patchwork.kernel.org/patch/11464609/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-14 15:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200330052521epcas1p1eedc926d4b11513f8502cf0c90ecf433@epcas1p1.samsung.com>
2020-03-30 5:25 ` [PATCH] brcmfmac: fix wrong location to get firmware feature Jaehoon Chung
2020-03-30 9:08 ` Andy Shevchenko
2020-03-30 10:16 ` Kalle Valo
2020-04-01 10:20 ` Jaehoon Chung
2020-04-14 15:03 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).