From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
willy.mh.wolff.ml@gmail.com, k.konieczny@samsung.com,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Bartłomiej Żołnierkiewicz" <b.zolnierkie@samsung.com>,
chanwoo@kernel.org, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, s.nawrocki@samsung.com,
kgene@kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422
Date: Fri, 21 Aug 2020 08:31:28 +0200 [thread overview]
Message-ID: <CAJKOXPc063m_YcouAO2Q9piJ_GV1Fh9XeS3ZZ3KR=ZyMxPKZ5w@mail.gmail.com> (raw)
In-Reply-To: <2099aea9-5a63-6e5b-d7f9-4e6476584461@arm.com>
On Mon, 17 Aug 2020 at 19:17, Lukasz Luba <lukasz.luba@arm.com> wrote:
>
> Hi Krzysztof,
>
> On 8/17/20 4:50 PM, Krzysztof Kozlowski wrote:
> > On Wed, Jul 08, 2020 at 04:34:20PM +0100, Lukasz Luba wrote:
> >> The interrupts in Dynamic Memory Controller in Exynos5422 and Odroid
> >> XU3-family boards are no longer needed. They have been used in order
> >> to workaround some issues in scheduled work in devfreq. Now when the
> >> devfreq framework design is improved, remove the interrupt driven
> >> approach and rely on devfreq monitoring mechanism with fixed intervals.
> >>
> >> Reported-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> >> ---
> >> arch/arm/boot/dts/exynos5420.dtsi | 3 ---
> >> 1 file changed, 3 deletions(-)
> >
> > I think the dependencies were merged so this can be safely applied
> > without bisectability problems?
>
> I have created v2 of that fix and it got merged
> via Chanwoo's tree, the commit 4fc9a0470d2dc37028
> https://lkml.org/lkml/2020/7/10/1048
>
> That commit switched the driver default mode from 'irq driven' to
> new devfreq monitoring mechanism. Furthermore, when the driver is
> built as a module, you can try to use the 'irq mode', but for this
> you would need the DT IRQs description (this $subject tries to remove).
>
> I would like to keep this IRQ mode for experimentation, as I
> described in answers to Bartek's questions:
> https://lkml.org/lkml/2020/7/14/315
>
> Unfortunately, I am quite busy and won't make any progress before the
> LPC.
None of these were the actual answer to my question, unless by "v2 of
that fix and it got merged" means the dependencies?
I'll drop it from the queue. Please resend if it is valid.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-08-21 6:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:34 [PATCH 0/2] Exynos5422 DMC: adjust to new devfreq monitoring mechanism Lukasz Luba
2020-07-08 15:34 ` [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Lukasz Luba
2020-07-09 4:08 ` Chanwoo Choi
2020-07-10 8:34 ` Lukasz Luba
2020-07-10 12:45 ` Krzysztof Kozlowski
2020-07-10 12:56 ` Lukasz Luba
2020-07-10 13:07 ` Krzysztof Kozlowski
2020-07-10 13:49 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:00 ` Lukasz Luba
2020-07-10 14:47 ` Krzysztof Kozlowski
2020-07-10 13:13 ` Marek Szyprowski
2020-07-10 13:19 ` Krzysztof Kozlowski
2020-07-10 13:41 ` Lukasz Luba
2020-07-10 14:49 ` Krzysztof Kozlowski
2020-07-10 15:45 ` Lukasz Luba
2020-07-08 15:34 ` [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422 Lukasz Luba
2020-08-17 15:50 ` Krzysztof Kozlowski
2020-08-17 17:17 ` Lukasz Luba
2020-08-21 6:31 ` Krzysztof Kozlowski [this message]
2020-08-21 6:32 ` Krzysztof Kozlowski
2020-08-24 11:34 ` Lukasz Luba
2020-10-26 19:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPc063m_YcouAO2Q9piJ_GV1Fh9XeS3ZZ3KR=ZyMxPKZ5w@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.konieczny@samsung.com \
--cc=kgene@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).