From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Lukasz Luba <lukasz.luba@arm.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Cc: willy.mh.wolff.ml@gmail.com, k.konieczny@samsung.com,
b.zolnierkie@samsung.com, krzk@kernel.org, chanwoo@kernel.org,
myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
s.nawrocki@samsung.com, kgene@kernel.org
Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold
Date: Fri, 10 Jul 2020 15:13:18 +0200 [thread overview]
Message-ID: <c016e256-65a6-8075-d88d-c3fad4815b4d@samsung.com> (raw)
In-Reply-To: <a676fc18-6f1f-8502-e8d5-5ad1ccf0eec6@arm.com>
Hi Lukasz,
On 10.07.2020 10:34, Lukasz Luba wrote:
> Hi Chanwoo,
>
> On 7/9/20 5:08 AM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> On 7/9/20 12:34 AM, Lukasz Luba wrote:
>>> In order to react faster and make better decisions under some
>>> workloads,
>>> benchmarking the memory subsystem behavior, adjust the polling interval
>>> and upthreshold value used by the simple_ondemand governor.
>>>
>>> Reported-by: Willy Wolff <willy.mh.wolff.ml@gmail.com>
>>> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
>>> ---
>>> drivers/memory/samsung/exynos5422-dmc.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/memory/samsung/exynos5422-dmc.c
>>> b/drivers/memory/samsung/exynos5422-dmc.c
>>> index 93e9c2429c0d..e03ee35f0ab5 100644
>>> --- a/drivers/memory/samsung/exynos5422-dmc.c
>>> +++ b/drivers/memory/samsung/exynos5422-dmc.c
>>> @@ -1466,10 +1466,10 @@ static int exynos5_dmc_probe(struct
>>> platform_device *pdev)
>>> * Setup default thresholds for the devfreq governor.
>>> * The values are chosen based on experiments.
>>> */
>>> - dmc->gov_data.upthreshold = 30;
>>> + dmc->gov_data.upthreshold = 10;
>>> dmc->gov_data.downdifferential = 5;
>>> - exynos5_dmc_df_profile.polling_ms = 500;
>>> + exynos5_dmc_df_profile.polling_ms = 100;
>>> }
>>>
>>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>>
>
> Thank you for the review. Do you think this patch could go through
> your tree together with your patches?
>
> I don't know Krzysztof's opinion about the patch 2/2, but
> I would expect, assuming the patch itself is correct, he would
> like to take it into his next/dt branch.
Is there really a need to remove the interrupts property? imho they are
correct hw description, it just a matter of the driver to use or not to
use them.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2020-07-10 13:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:34 [PATCH 0/2] Exynos5422 DMC: adjust to new devfreq monitoring mechanism Lukasz Luba
2020-07-08 15:34 ` [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Lukasz Luba
2020-07-09 4:08 ` Chanwoo Choi
2020-07-10 8:34 ` Lukasz Luba
2020-07-10 12:45 ` Krzysztof Kozlowski
2020-07-10 12:56 ` Lukasz Luba
2020-07-10 13:07 ` Krzysztof Kozlowski
2020-07-10 13:49 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:00 ` Lukasz Luba
2020-07-10 14:47 ` Krzysztof Kozlowski
2020-07-10 13:13 ` Marek Szyprowski [this message]
2020-07-10 13:19 ` Krzysztof Kozlowski
2020-07-10 13:41 ` Lukasz Luba
2020-07-10 14:49 ` Krzysztof Kozlowski
2020-07-10 15:45 ` Lukasz Luba
2020-07-08 15:34 ` [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422 Lukasz Luba
2020-08-17 15:50 ` Krzysztof Kozlowski
2020-08-17 17:17 ` Lukasz Luba
2020-08-21 6:31 ` Krzysztof Kozlowski
2020-08-21 6:32 ` Krzysztof Kozlowski
2020-08-24 11:34 ` Lukasz Luba
2020-10-26 19:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c016e256-65a6-8075-d88d-c3fad4815b4d@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.konieczny@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=myungjoo.ham@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).