From: Lukasz Luba <lukasz.luba@arm.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, willy.mh.wolff.ml@gmail.com,
k.konieczny@samsung.com, b.zolnierkie@samsung.com,
chanwoo@kernel.org, myungjoo.ham@samsung.com,
kyungmin.park@samsung.com, s.nawrocki@samsung.com,
kgene@kernel.org
Subject: Re: [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold
Date: Fri, 10 Jul 2020 16:45:24 +0100 [thread overview]
Message-ID: <df121ab9-a84e-41ac-057a-e7e9d0cbab48@arm.com> (raw)
In-Reply-To: <20200710144947.GB23140@pi3>
On 7/10/20 3:49 PM, Krzysztof Kozlowski wrote:
> On Fri, Jul 10, 2020 at 02:41:28PM +0100, Lukasz Luba wrote:
>>
>>
>> On 7/10/20 2:19 PM, Krzysztof Kozlowski wrote:
>>> On Fri, Jul 10, 2020 at 03:13:18PM +0200, Marek Szyprowski wrote:
> > In such case, maybe as you said, let's switch to polling mode
>>> unconditionally?
>>
>> I can make happen that the polling mode will be unconditionally
>> set as default.
>>
>> Do you think that the interrupt mode code can still stay in the
>> driver, because maybe in future could be fixed?
>
> How interrupt mode would exist in such case? Or rather: how would it be
> used? There is no point to keep dead code and code once removed, can be
> easily brought back.
I can make a module param i.e. irq-mode=1, while in default where
the user don't provide param, we use polling mode. Then I don't have to
remove DT interrupts and the related code from the driver.
Regards,
Lukasz
next prev parent reply other threads:[~2020-07-10 15:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 15:34 [PATCH 0/2] Exynos5422 DMC: adjust to new devfreq monitoring mechanism Lukasz Luba
2020-07-08 15:34 ` [PATCH 1/2] memory: samsung: exynos5422-dmc: Adjust polling interval and uptreshold Lukasz Luba
2020-07-09 4:08 ` Chanwoo Choi
2020-07-10 8:34 ` Lukasz Luba
2020-07-10 12:45 ` Krzysztof Kozlowski
2020-07-10 12:56 ` Lukasz Luba
2020-07-10 13:07 ` Krzysztof Kozlowski
2020-07-10 13:49 ` Bartlomiej Zolnierkiewicz
2020-07-10 14:00 ` Lukasz Luba
2020-07-10 14:47 ` Krzysztof Kozlowski
2020-07-10 13:13 ` Marek Szyprowski
2020-07-10 13:19 ` Krzysztof Kozlowski
2020-07-10 13:41 ` Lukasz Luba
2020-07-10 14:49 ` Krzysztof Kozlowski
2020-07-10 15:45 ` Lukasz Luba [this message]
2020-07-08 15:34 ` [PATCH 2/2] ARM: dts: exynos: Remove interrupts from DMC controller in Exynos5422 Lukasz Luba
2020-08-17 15:50 ` Krzysztof Kozlowski
2020-08-17 17:17 ` Lukasz Luba
2020-08-21 6:31 ` Krzysztof Kozlowski
2020-08-21 6:32 ` Krzysztof Kozlowski
2020-08-24 11:34 ` Lukasz Luba
2020-10-26 19:57 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df121ab9-a84e-41ac-057a-e7e9d0cbab48@arm.com \
--to=lukasz.luba@arm.com \
--cc=b.zolnierkie@samsung.com \
--cc=chanwoo@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=k.konieczny@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=s.nawrocki@samsung.com \
--cc=willy.mh.wolff.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).