From: Eugenio Perez Martin <eperezma@redhat.com>
To: Si-Wei Liu <si-wei.liu@oracle.com>
Cc: jasowang@redhat.com, mst@redhat.com, xuanzhuo@linux.alibaba.com,
dtatulea@nvidia.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] vhost-vdpa: reset vendor specific mapping to initial state in .release
Date: Wed, 11 Oct 2023 13:21:46 +0200 [thread overview]
Message-ID: <CAJaqyWe=RwotkcNKFuStvX=HxQh6sdtfsH23jhf994eXi3-2Og@mail.gmail.com> (raw)
In-Reply-To: <1696928580-7520-3-git-send-email-si-wei.liu@oracle.com>
On Tue, Oct 10, 2023 at 11:05 AM Si-Wei Liu <si-wei.liu@oracle.com> wrote:
>
> Devices with on-chip IOMMU or vendor specific IOTLB implementation
> may need to restore iotlb mapping to the initial or default state
> using the .reset_map op, as it's desirable for some parent devices
> to solely manipulate mappings by its own, independent of virtio device
> state. For instance, device reset does not cause mapping go away on
> such IOTLB model in need of persistent mapping. Before vhost-vdpa
> is going away, give them a chance to reset iotlb back to the initial
> state in vhost_vdpa_cleanup().
>
> Signed-off-by: Si-Wei Liu <si-wei.liu@oracle.com>
> ---
> drivers/vhost/vdpa.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
> index 851535f..a3f8160 100644
> --- a/drivers/vhost/vdpa.c
> +++ b/drivers/vhost/vdpa.c
> @@ -131,6 +131,15 @@ static struct vhost_vdpa_as *vhost_vdpa_find_alloc_as(struct vhost_vdpa *v,
> return vhost_vdpa_alloc_as(v, asid);
> }
>
> +static void vhost_vdpa_reset_map(struct vhost_vdpa *v, u32 asid)
> +{
> + struct vdpa_device *vdpa = v->vdpa;
> + const struct vdpa_config_ops *ops = vdpa->config;
> +
> + if (ops->reset_map)
> + ops->reset_map(vdpa, asid);
> +}
> +
> static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid)
> {
> struct vhost_vdpa_as *as = asid_to_as(v, asid);
> @@ -140,6 +149,13 @@ static int vhost_vdpa_remove_as(struct vhost_vdpa *v, u32 asid)
>
> hlist_del(&as->hash_link);
> vhost_vdpa_iotlb_unmap(v, &as->iotlb, 0ULL, 0ULL - 1, asid);
Now I'm wondering, does this call to vhost_vdpa_iotlb_unmap sets a
different map (via .set_map) per element of the vhost_iotlb_itree? Not
a big deal since we're in the cleanup path, but it could be a nice
optimization on top as we're going to reset the map of the asid
anyway.
> + /*
> + * Devices with vendor specific IOMMU may need to restore
> + * iotlb to the initial or default state which is not done
> + * through device reset, as the IOTLB mapping manipulation
> + * could be decoupled from the virtio device life cycle.
> + */
> + vhost_vdpa_reset_map(v, asid);
> kfree(as);
>
> return 0;
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2023-10-11 11:23 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 9:02 [PATCH 0/4] vdpa: decouple reset of iotlb mapping from device reset Si-Wei Liu
2023-10-10 9:02 ` [PATCH 1/4] vdpa: introduce .reset_map operation callback Si-Wei Liu
2023-10-13 2:49 ` Jason Wang
2023-10-13 7:36 ` Si-Wei Liu
2023-10-16 5:30 ` Jason Wang
2023-10-10 9:02 ` [PATCH 2/4] vhost-vdpa: reset vendor specific mapping to initial state in .release Si-Wei Liu
2023-10-11 11:21 ` Eugenio Perez Martin [this message]
2023-10-12 6:18 ` Si-Wei Liu
2023-10-13 3:01 ` Jason Wang
2023-10-13 7:35 ` Si-Wei Liu
2023-10-16 6:32 ` Jason Wang
2023-10-16 11:28 ` Eugenio Perez Martin
2023-10-16 20:30 ` Si-Wei Liu
2023-10-17 2:35 ` Jason Wang
2023-10-17 13:58 ` Eugenio Perez Martin
2023-10-18 4:35 ` Si-Wei Liu
2023-10-18 5:27 ` Jason Wang
2023-10-18 7:00 ` Jason Wang
2023-10-18 8:49 ` Si-Wei Liu
2023-10-19 2:53 ` Jason Wang
2023-10-19 6:46 ` Si-Wei Liu
2023-10-19 8:27 ` Jason Wang
2023-10-19 14:39 ` Eugenio Perez Martin
2023-10-19 22:28 ` Si-Wei Liu
2023-10-20 4:11 ` Jason Wang
2023-10-20 5:57 ` Si-Wei Liu
2023-10-18 8:44 ` Si-Wei Liu
2023-10-18 11:14 ` Eugenio Perez Martin
2023-10-18 23:21 ` Si-Wei Liu
2023-10-19 2:48 ` Jason Wang
2023-10-19 22:57 ` Si-Wei Liu
2023-10-16 20:10 ` Si-Wei Liu
2023-10-10 9:02 ` [PATCH 3/4] vhost-vdpa: introduce IOTLB_PERSIST backend feature bit Si-Wei Liu
2023-10-10 9:03 ` [PATCH 4/4] vdpa/mlx5: implement .reset_map driver op Si-Wei Liu
2023-10-13 3:04 ` Jason Wang
2023-10-13 7:55 ` Si-Wei Liu
2023-10-11 11:30 ` [PATCH 0/4] vdpa: decouple reset of iotlb mapping from device reset Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJaqyWe=RwotkcNKFuStvX=HxQh6sdtfsH23jhf994eXi3-2Og@mail.gmail.com' \
--to=eperezma@redhat.com \
--cc=dtatulea@nvidia.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).