* [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)
@ 2015-11-30 6:14 Masahiro Yamada
2015-12-06 20:40 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2015-11-30 6:14 UTC (permalink / raw)
To: devicetree
Cc: Masahiro Yamada, Frank Rowand, Rob Herring, linux-kernel, Grant Likely
A trivial change suggested by checkpatch.pl.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/of/address.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/address.c b/drivers/of/address.c
index cd53fe4..5289c80 100644
--- a/drivers/of/address.c
+++ b/drivers/of/address.c
@@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
pbus = of_match_bus(parent);
pbus->count_cells(dev, &pna, &pns);
if (!OF_CHECK_COUNTS(pna, pns)) {
- printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
+ pr_err("prom_parse: Bad cell count for %s\n",
of_node_full_name(dev));
break;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)
2015-11-30 6:14 [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Masahiro Yamada
@ 2015-12-06 20:40 ` Rob Herring
2015-12-08 16:09 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2015-12-06 20:40 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: devicetree, Frank Rowand, linux-kernel, Grant Likely
On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> A trivial change suggested by checkpatch.pl.
You might as well all levels while you are at it. Looks like that is
only one more:
drivers/of/address.c: printk(KERN_DEBUG "%s", s);
Rob
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/of/address.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/address.c b/drivers/of/address.c
> index cd53fe4..5289c80 100644
> --- a/drivers/of/address.c
> +++ b/drivers/of/address.c
> @@ -596,7 +596,7 @@ static u64 __of_translate_address(struct device_node *dev,
> pbus = of_match_bus(parent);
> pbus->count_cells(dev, &pna, &pns);
> if (!OF_CHECK_COUNTS(pna, pns)) {
> - printk(KERN_ERR "prom_parse: Bad cell count for %s\n",
> + pr_err("prom_parse: Bad cell count for %s\n",
> of_node_full_name(dev));
> break;
> }
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...)
2015-12-06 20:40 ` Rob Herring
@ 2015-12-08 16:09 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2015-12-08 16:09 UTC (permalink / raw)
To: Rob Herring; +Cc: devicetree, Frank Rowand, linux-kernel, Grant Likely
Hi Rob,
2015-12-07 5:40 GMT+09:00 Rob Herring <robh+dt@kernel.org>:
> On Mon, Nov 30, 2015 at 12:14 AM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>> A trivial change suggested by checkpatch.pl.
>
> You might as well all levels while you are at it. Looks like that is
> only one more:
>
> drivers/of/address.c: printk(KERN_DEBUG "%s", s);
>
OK, I have just posted v2.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-08 16:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-30 6:14 [PATCH] of/address: replace printk(KERN_ERR ...) with pr_err(...) Masahiro Yamada
2015-12-06 20:40 ` Rob Herring
2015-12-08 16:09 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).