* [PATCH] ARC: [plat-hsdk]: fix USB regression
@ 2020-04-07 16:19 Eugeniy Paltsev
2020-04-07 16:22 ` Eugeniy Paltsev
2020-04-08 1:20 ` Nathan Chancellor
0 siblings, 2 replies; 5+ messages in thread
From: Eugeniy Paltsev @ 2020-04-07 16:19 UTC (permalink / raw)
To: linux-snps-arc, Vineet Gupta
Cc: linux-kernel, Alexey Brodkin, Masahiro Yamada, Thomas Zimmermann,
Eugeniy Paltsev
As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
in its kconfig.
The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
reverse the dependencies between UDL and USB so UDL now depends on
CONFIG_USB and not selects it. This introduces regression for ARC HSDK
board as HSDK defconfig wasn't adjusted and now it misses USB support
due to lack of CONFIG_USB enabled.
Fix that.
Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
arch/arc/configs/hsdk_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
index 0974226fab55..f79c15892704 100644
--- a/arch/arc/configs/hsdk_defconfig
+++ b/arch/arc/configs/hsdk_defconfig
@@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
CONFIG_DRM_ETNAVIV=y
CONFIG_FB=y
CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_USB
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_HCD_PLATFORM=y
CONFIG_USB_OHCI_HCD=y
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARC: [plat-hsdk]: fix USB regression
2020-04-07 16:19 [PATCH] ARC: [plat-hsdk]: fix USB regression Eugeniy Paltsev
@ 2020-04-07 16:22 ` Eugeniy Paltsev
2020-04-08 1:04 ` Masahiro Yamada
2020-04-08 1:20 ` Nathan Chancellor
1 sibling, 1 reply; 5+ messages in thread
From: Eugeniy Paltsev @ 2020-04-07 16:22 UTC (permalink / raw)
To: Masahiro Yamada
Cc: linux-kernel, Alexey Brodkin, Thomas Zimmermann, Vineet Gupta,
linux-snps-arc, Eugeniy Paltsev
Hi Masahiro,
I'm wondering what is proper way to deal with such type of regressions?
Is is responsibility of person who change kconfig to check (and possibly adjust) affected defconfigs?
A question for you as a kconfig expert :)
---
Eugeniy Paltsev
________________________________________
From: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Sent: Tuesday, April 7, 2020 19:19
To: linux-snps-arc@lists.infradead.org; Vineet Gupta
Cc: linux-kernel@vger.kernel.org; Alexey Brodkin; Masahiro Yamada; Thomas Zimmermann; Eugeniy Paltsev
Subject: [PATCH] ARC: [plat-hsdk]: fix USB regression
As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
in its kconfig.
The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
reverse the dependencies between UDL and USB so UDL now depends on
CONFIG_USB and not selects it. This introduces regression for ARC HSDK
board as HSDK defconfig wasn't adjusted and now it misses USB support
due to lack of CONFIG_USB enabled.
Fix that.
Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
arch/arc/configs/hsdk_defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
index 0974226fab55..f79c15892704 100644
--- a/arch/arc/configs/hsdk_defconfig
+++ b/arch/arc/configs/hsdk_defconfig
@@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
CONFIG_DRM_ETNAVIV=y
CONFIG_FB=y
CONFIG_FRAMEBUFFER_CONSOLE=y
+CONFIG_USB
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_HCD_PLATFORM=y
CONFIG_USB_OHCI_HCD=y
--
2.21.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARC: [plat-hsdk]: fix USB regression
2020-04-07 16:22 ` Eugeniy Paltsev
@ 2020-04-08 1:04 ` Masahiro Yamada
0 siblings, 0 replies; 5+ messages in thread
From: Masahiro Yamada @ 2020-04-08 1:04 UTC (permalink / raw)
To: Eugeniy Paltsev
Cc: linux-kernel, Alexey Brodkin, Thomas Zimmermann, Vineet Gupta,
linux-snps-arc
On Wed, Apr 8, 2020 at 1:22 AM Eugeniy Paltsev
<Eugeniy.Paltsev@synopsys.com> wrote:
>
> Hi Masahiro,
>
> I'm wondering what is proper way to deal with such type of regressions?
> Is is responsibility of person who change kconfig to check (and possibly adjust) affected defconfigs?
I think the patch submitter should take care of
affected defconfigs when (s)he drops select/imply.
Also, this kind of mistake should be caught
in the review process.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARC: [plat-hsdk]: fix USB regression
2020-04-07 16:19 [PATCH] ARC: [plat-hsdk]: fix USB regression Eugeniy Paltsev
2020-04-07 16:22 ` Eugeniy Paltsev
@ 2020-04-08 1:20 ` Nathan Chancellor
2020-04-08 1:59 ` Nathan Chancellor
1 sibling, 1 reply; 5+ messages in thread
From: Nathan Chancellor @ 2020-04-08 1:20 UTC (permalink / raw)
To: Eugeniy Paltsev
Cc: linux-snps-arc, Vineet Gupta, linux-kernel, Alexey Brodkin,
Masahiro Yamada, Thomas Zimmermann
On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote:
> As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
> as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
> in its kconfig.
> The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> reverse the dependencies between UDL and USB so UDL now depends on
> CONFIG_USB and not selects it. This introduces regression for ARC HSDK
> board as HSDK defconfig wasn't adjusted and now it misses USB support
> due to lack of CONFIG_USB enabled.
>
> Fix that.
>
> Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> arch/arc/configs/hsdk_defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> index 0974226fab55..f79c15892704 100644
> --- a/arch/arc/configs/hsdk_defconfig
> +++ b/arch/arc/configs/hsdk_defconfig
> @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
> CONFIG_DRM_ETNAVIV=y
> CONFIG_FB=y
> CONFIG_FRAMEBUFFER_CONSOLE=y
> +CONFIG_USB
Shouldn't this be CONFIG_USB=y?
As it stands, this patch does nothing.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARC: [plat-hsdk]: fix USB regression
2020-04-08 1:20 ` Nathan Chancellor
@ 2020-04-08 1:59 ` Nathan Chancellor
0 siblings, 0 replies; 5+ messages in thread
From: Nathan Chancellor @ 2020-04-08 1:59 UTC (permalink / raw)
To: Eugeniy Paltsev
Cc: linux-snps-arc, Vineet Gupta, linux-kernel, Alexey Brodkin,
Masahiro Yamada, Thomas Zimmermann
On Tue, Apr 07, 2020 at 06:20:28PM -0700, Nathan Chancellor wrote:
> On Tue, Apr 07, 2020 at 07:19:33PM +0300, Eugeniy Paltsev wrote:
> > As of today the CONFIG_USB isn't explicitly present in HSDK defconfig
> > as it is implicitly forcibly enabled by UDL driver which selects CONFIG_USB
> > in its kconfig.
> > The commit 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > reverse the dependencies between UDL and USB so UDL now depends on
> > CONFIG_USB and not selects it. This introduces regression for ARC HSDK
> > board as HSDK defconfig wasn't adjusted and now it misses USB support
> > due to lack of CONFIG_USB enabled.
> >
> > Fix that.
> >
> > Fixes: 5d50bd440bc2 ("drm/udl: Make udl driver depend on CONFIG_USB")
> > Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> > ---
> > arch/arc/configs/hsdk_defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig
> > index 0974226fab55..f79c15892704 100644
> > --- a/arch/arc/configs/hsdk_defconfig
> > +++ b/arch/arc/configs/hsdk_defconfig
> > @@ -65,6 +65,7 @@ CONFIG_DRM_UDL=y
> > CONFIG_DRM_ETNAVIV=y
> > CONFIG_FB=y
> > CONFIG_FRAMEBUFFER_CONSOLE=y
> > +CONFIG_USB
>
> Shouldn't this be CONFIG_USB=y?
>
> As it stands, this patch does nothing.
>
> Cheers,
> Nathan
Nevermind, I came across v2 on the mailing list, sorry for the noise.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-04-08 1:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-07 16:19 [PATCH] ARC: [plat-hsdk]: fix USB regression Eugeniy Paltsev
2020-04-07 16:22 ` Eugeniy Paltsev
2020-04-08 1:04 ` Masahiro Yamada
2020-04-08 1:20 ` Nathan Chancellor
2020-04-08 1:59 ` Nathan Chancellor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).