From: Arnd Bergmann <arnd@arndb.de>
To: Christian Brauner <christian@brauner.io>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>,
Joel Fernandes <joel@joelfernandes.org>,
Thomas Gleixner <tglx@linutronix.de>, Tejun Heo <tj@kernel.org>,
David Howells <dhowells@redhat.com>, Jann Horn <jannh@google.com>,
Andy Lutomirski <luto@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Aleksa Sarai <cyphar@cyphar.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Android Kernel Team <kernel-team@android.com>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH 2/5] pidfd: add pidfd_wait()
Date: Fri, 26 Jul 2019 10:19:55 +0200 [thread overview]
Message-ID: <CAK8P3a0+3wqCzQv-A-QmWTtioFRGjYUvq6QiLysqi9OFs3kJsw@mail.gmail.com> (raw)
In-Reply-To: <20190724144651.28272-3-christian@brauner.io>
On Wed, Jul 24, 2019 at 4:47 PM Christian Brauner <christian@brauner.io> wrote:
> +
> +static int copy_rusage_to_user_any(struct rusage *kru, struct rusage __user *ru)
> +{
> +#ifdef CONFIG_COMPAT
> + if (in_compat_syscall())
> + return put_compat_rusage(kru, (struct compat_rusage __user *)ru);
> +#endif
> + return copy_to_user(ru, kru, sizeof(*kru));
> +}
I think this code needs a check for COMPAT_USE_64BIT_TIME in order
to handle x32 correctly.
It would be nice to introduce it in a separate patch, and then use it
to kill off
compat_sys_getrusage() and compat_sys_wait4(), and possibly even
compat_sys_waitid() in combination with your copy_siginfo_to_user_any().
That could be done as a cleanup patch afterwards, or as part of your series.
Arnd
next prev parent reply other threads:[~2019-07-26 8:20 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 14:46 [PATCH 0/5] pidfd: waiting on processes through pidfds Christian Brauner
2019-07-24 14:46 ` [RFC][PATCH 1/5] exit: kill struct waitid_info Christian Brauner
2019-07-24 17:37 ` Linus Torvalds
2019-07-24 22:01 ` Christian Brauner
2019-07-25 12:46 ` Eric W. Biederman
2019-07-26 8:01 ` Christian Brauner
2019-07-26 11:59 ` Eric W. Biederman
2019-07-26 12:37 ` Christian Brauner
2019-07-25 9:40 ` Oleg Nesterov
2019-07-25 10:07 ` Christian Brauner
2019-07-24 14:46 ` [PATCH 2/5] pidfd: add pidfd_wait() Christian Brauner
2019-07-24 17:45 ` Linus Torvalds
2019-07-24 17:50 ` Christian Brauner
2019-07-24 17:52 ` Christian Brauner
2019-07-25 14:34 ` Eric W. Biederman
2019-07-25 10:16 ` Oleg Nesterov
2019-07-25 10:21 ` Christian Brauner
2019-07-26 8:19 ` Arnd Bergmann [this message]
2019-07-26 8:24 ` Christian Brauner
2019-07-26 9:57 ` Arnd Bergmann
2019-07-24 14:46 ` [PATCH 3/5] arch: wire-up pidfd_wait() Christian Brauner
2019-07-24 14:46 ` [PATCH 4/5] pidfd: add CLONE_WAIT_PID Christian Brauner
2019-07-24 18:14 ` Jann Horn
2019-07-24 18:27 ` Christian Brauner
2019-07-24 19:07 ` Jann Horn
2019-07-24 19:10 ` Christian Brauner
2019-07-25 10:11 ` Christian Brauner
2019-07-25 10:30 ` Oleg Nesterov
2019-07-25 10:36 ` Christian Brauner
2019-07-25 10:35 ` Oleg Nesterov
2019-07-25 10:40 ` Christian Brauner
2019-07-25 11:25 ` Oleg Nesterov
2019-07-25 11:41 ` Christian Brauner
2019-07-25 11:43 ` Oleg Nesterov
2019-07-25 12:26 ` Christian Brauner
2019-07-25 16:13 ` Oleg Nesterov
2019-07-25 16:56 ` Christian Brauner
2019-07-25 16:57 ` Eric W. Biederman
2019-07-24 14:46 ` [PATCH 5/5] pidfd: add pidfd_wait tests Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0+3wqCzQv-A-QmWTtioFRGjYUvq6QiLysqi9OFs3kJsw@mail.gmail.com \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).