* [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
@ 2021-01-19 5:34 Rayagonda Kokatanur
2021-01-19 8:45 ` Arnd Bergmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rayagonda Kokatanur @ 2021-01-19 5:34 UTC (permalink / raw)
To: Rob Herring, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Arnd Bergmann, Florian Fainelli, Zhen Lei, devicetree,
linux-arm-kernel, linux-kernel
Cc: Bharat Gooty, Rayagonda Kokatanur
[-- Attachment #1: Type: text/plain, Size: 1177 bytes --]
From: Bharat Gooty <bharat.gooty@broadcom.com>
Add a non-empty dma-ranges so that dma address translation
happens.
Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
index aef8f2b00778..5401a646c840 100644
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
@@ -4,11 +4,16 @@
*/
usb {
compatible = "simple-bus";
- dma-ranges;
#address-cells = <2>;
#size-cells = <2>;
ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
+ /*
+ * Internally, USB bus to the interconnect can only address up
+ * to 40-bit
+ */
+ dma-ranges = <0 0 0 0 0x100 0x0>;
+
usbphy0: usb-phy@0 {
compatible = "brcm,sr-usb-combo-phy";
reg = <0x0 0x00000000 0x0 0x100>;
--
2.17.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4187 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
2021-01-19 5:34 [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation Rayagonda Kokatanur
@ 2021-01-19 8:45 ` Arnd Bergmann
2021-01-19 17:44 ` Ray Jui
2021-01-20 18:45 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-01-19 8:45 UTC (permalink / raw)
To: Rayagonda Kokatanur
Cc: Rob Herring, Ray Jui, Scott Branden, bcm-kernel-feedback-list,
Arnd Bergmann, Florian Fainelli, Zhen Lei, DTML, Linux ARM,
linux-kernel, Bharat Gooty
On Tue, Jan 19, 2021 at 6:34 AM Rayagonda Kokatanur
<rayagonda.kokatanur@broadcom.com> wrote:
>
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Add a non-empty dma-ranges so that dma address translation
> happens.
>
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
2021-01-19 5:34 [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation Rayagonda Kokatanur
2021-01-19 8:45 ` Arnd Bergmann
@ 2021-01-19 17:44 ` Ray Jui
2021-01-20 18:45 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2021-01-19 17:44 UTC (permalink / raw)
To: Rayagonda Kokatanur, Rob Herring, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, Arnd Bergmann, Florian Fainelli,
Zhen Lei, devicetree, linux-arm-kernel, linux-kernel
Cc: Bharat Gooty
[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]
On 1/18/2021 9:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Add a non-empty dma-ranges so that dma address translation
> happens.
>
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
> arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> index aef8f2b00778..5401a646c840 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> @@ -4,11 +4,16 @@
> */
> usb {
> compatible = "simple-bus";
> - dma-ranges;
> #address-cells = <2>;
> #size-cells = <2>;
> ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
>
> + /*
> + * Internally, USB bus to the interconnect can only address up
> + * to 40-bit
> + */
> + dma-ranges = <0 0 0 0 0x100 0x0>;
> +
Should have had my signed-off since during our internal review, I added
the above comment to explain why we set it to 40-bit here despite the
USB controller itself is capable of addressing 64-bit as Arnd pointed out.
Well, the following ack should do it too, thanks.
Acked-by: Ray Jui <ray.jui@broadcom.com>
> usbphy0: usb-phy@0 {
> compatible = "brcm,sr-usb-combo-phy";
> reg = <0x0 0x00000000 0x0 0x100>;
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4151 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation
2021-01-19 5:34 [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation Rayagonda Kokatanur
2021-01-19 8:45 ` Arnd Bergmann
2021-01-19 17:44 ` Ray Jui
@ 2021-01-20 18:45 ` Florian Fainelli
2 siblings, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2021-01-20 18:45 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Rayagonda Kokatanur, Rob Herring,
Ray Jui, Scott Branden, Arnd Bergmann, Zhen Lei, devicetree,
linux-arm-kernel, linux-kernel
Cc: Bharat Gooty
On Tue, 19 Jan 2021 11:04:44 +0530, Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com> wrote:
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Add a non-empty dma-ranges so that dma address translation
> happens.
>
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> ---
Applied to devicetree-arm64/fixes, thanks!
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-20 19:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19 5:34 [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation Rayagonda Kokatanur
2021-01-19 8:45 ` Arnd Bergmann
2021-01-19 17:44 ` Ray Jui
2021-01-20 18:45 ` Florian Fainelli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).