* [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5
@ 2012-01-20 4:05 Seungwon Jeon
2012-01-20 4:35 ` Kyungmin Park
0 siblings, 1 reply; 4+ messages in thread
From: Seungwon Jeon @ 2012-01-20 4:05 UTC (permalink / raw)
To: linux-mmc; +Cc: 'Chris Ball', linux-kernel
This patch-set adds support of packed command feature
for eMMC4.5 devices.
Changes in v3:
- Add a variable member in mmc_host for minimum number of packed entries.
This value can be overrided by host.
- Fix a handling of error sequence.
Changes in v2:
- Fix the packed read sequence and error handling.
- Apply checking the exception status for all cases with
the comments from Maya Erez and Sahitya Tummala.
- Fix preparing the packed list with the comment from Maya Erez and Venkatraman.
Seungwon Jeon (2):
mmc: core: Add packed command feature of eMMC4.5
mmc: core: Support packed command for eMMC4.5 device
drivers/mmc/card/block.c | 469 +++++++++++++++++++++++++++++++++++++++++---
drivers/mmc/card/queue.c | 48 +++++-
drivers/mmc/card/queue.h | 13 ++
drivers/mmc/core/host.c | 2 +
drivers/mmc/core/mmc.c | 24 +++
drivers/mmc/core/mmc_ops.c | 1 +
include/linux/mmc/card.h | 3 +
include/linux/mmc/core.h | 3 +
include/linux/mmc/host.h | 4 +
include/linux/mmc/mmc.h | 15 ++
10 files changed, 555 insertions(+), 27 deletions(-)
Best regards,
Seungwon Jeon.
--
1.7.2.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5
2012-01-20 4:05 [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5 Seungwon Jeon
@ 2012-01-20 4:35 ` Kyungmin Park
2012-01-20 5:39 ` Namjae Jeon
2012-01-23 10:13 ` Saugata Das
0 siblings, 2 replies; 4+ messages in thread
From: Kyungmin Park @ 2012-01-20 4:35 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, Chris Ball, linux-kernel
Hi,
FYI: we get performance gain using packed command at write. however in
case of small size read, there are some performance drop since
protocol overhead.
In normal case, read command uses read operation only, but in case of
packed read. It sends the command to eMMC and read it.
Anyway it's good feature for eMMC v4.5.
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
On 1/20/12, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> This patch-set adds support of packed command feature
> for eMMC4.5 devices.
>
> Changes in v3:
> - Add a variable member in mmc_host for minimum number of packed entries.
> This value can be overrided by host.
> - Fix a handling of error sequence.
>
> Changes in v2:
> - Fix the packed read sequence and error handling.
> - Apply checking the exception status for all cases with
> the comments from Maya Erez and Sahitya Tummala.
> - Fix preparing the packed list with the comment from Maya Erez and
> Venkatraman.
>
>
> Seungwon Jeon (2):
> mmc: core: Add packed command feature of eMMC4.5
> mmc: core: Support packed command for eMMC4.5 device
>
> drivers/mmc/card/block.c | 469
> +++++++++++++++++++++++++++++++++++++++++---
> drivers/mmc/card/queue.c | 48 +++++-
> drivers/mmc/card/queue.h | 13 ++
> drivers/mmc/core/host.c | 2 +
> drivers/mmc/core/mmc.c | 24 +++
> drivers/mmc/core/mmc_ops.c | 1 +
> include/linux/mmc/card.h | 3 +
> include/linux/mmc/core.h | 3 +
> include/linux/mmc/host.h | 4 +
> include/linux/mmc/mmc.h | 15 ++
> 10 files changed, 555 insertions(+), 27 deletions(-)
>
> Best regards,
> Seungwon Jeon.
> --
> 1.7.2.3
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5
2012-01-20 4:35 ` Kyungmin Park
@ 2012-01-20 5:39 ` Namjae Jeon
2012-01-23 10:13 ` Saugata Das
1 sibling, 0 replies; 4+ messages in thread
From: Namjae Jeon @ 2012-01-20 5:39 UTC (permalink / raw)
To: Seungwon Jeon; +Cc: linux-mmc, Chris Ball, linux-kernel
Hi. Seungwon,
Would you show improved performance measurement
result(read/write,seq,ran) when using packed cmd ?
Thanks.
2012/1/20 Kyungmin Park <kmpark@infradead.org>:
> Hi,
>
> FYI: we get performance gain using packed command at write. however in
> case of small size read, there are some performance drop since
> protocol overhead.
> In normal case, read command uses read operation only, but in case of
> packed read. It sends the command to eMMC and read it.
> Anyway it's good feature for eMMC v4.5.
>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On 1/20/12, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> This patch-set adds support of packed command feature
>> for eMMC4.5 devices.
>>
>> Changes in v3:
>> - Add a variable member in mmc_host for minimum number of packed entries.
>> This value can be overrided by host.
>> - Fix a handling of error sequence.
>>
>> Changes in v2:
>> - Fix the packed read sequence and error handling.
>> - Apply checking the exception status for all cases with
>> the comments from Maya Erez and Sahitya Tummala.
>> - Fix preparing the packed list with the comment from Maya Erez and
>> Venkatraman.
>>
>>
>> Seungwon Jeon (2):
>> mmc: core: Add packed command feature of eMMC4.5
>> mmc: core: Support packed command for eMMC4.5 device
>>
>> drivers/mmc/card/block.c | 469
>> +++++++++++++++++++++++++++++++++++++++++---
>> drivers/mmc/card/queue.c | 48 +++++-
>> drivers/mmc/card/queue.h | 13 ++
>> drivers/mmc/core/host.c | 2 +
>> drivers/mmc/core/mmc.c | 24 +++
>> drivers/mmc/core/mmc_ops.c | 1 +
>> include/linux/mmc/card.h | 3 +
>> include/linux/mmc/core.h | 3 +
>> include/linux/mmc/host.h | 4 +
>> include/linux/mmc/mmc.h | 15 ++
>> 10 files changed, 555 insertions(+), 27 deletions(-)
>>
>> Best regards,
>> Seungwon Jeon.
>> --
>> 1.7.2.3
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5
2012-01-20 4:35 ` Kyungmin Park
2012-01-20 5:39 ` Namjae Jeon
@ 2012-01-23 10:13 ` Saugata Das
1 sibling, 0 replies; 4+ messages in thread
From: Saugata Das @ 2012-01-23 10:13 UTC (permalink / raw)
To: Kyungmin Park; +Cc: Seungwon Jeon, linux-mmc, Chris Ball, linux-kernel
On 20 January 2012 10:05, Kyungmin Park <kmpark@infradead.org> wrote:
> Hi,
>
> FYI: we get performance gain using packed command at write. however in
> case of small size read, there are some performance drop since
> protocol overhead.
> In normal case, read command uses read operation only, but in case of
> packed read. It sends the command to eMMC and read it.
> Anyway it's good feature for eMMC v4.5.
>
I believe the improvement will vary depending on how many commands are
packed, which will depend on use case (e.g. CPU load, rate of
application read/write), file system state (e.g. fragmentation, amount
of free space) etc. It will be very interesting if you can publish the
details of what you have tested and your observation of different
parameters related to packed command.
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On 1/20/12, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> This patch-set adds support of packed command feature
>> for eMMC4.5 devices.
>>
>> Changes in v3:
>> - Add a variable member in mmc_host for minimum number of packed entries.
>> This value can be overrided by host.
>> - Fix a handling of error sequence.
>>
>> Changes in v2:
>> - Fix the packed read sequence and error handling.
>> - Apply checking the exception status for all cases with
>> the comments from Maya Erez and Sahitya Tummala.
>> - Fix preparing the packed list with the comment from Maya Erez and
>> Venkatraman.
>>
>>
>> Seungwon Jeon (2):
>> mmc: core: Add packed command feature of eMMC4.5
>> mmc: core: Support packed command for eMMC4.5 device
>>
>> drivers/mmc/card/block.c | 469
>> +++++++++++++++++++++++++++++++++++++++++---
>> drivers/mmc/card/queue.c | 48 +++++-
>> drivers/mmc/card/queue.h | 13 ++
>> drivers/mmc/core/host.c | 2 +
>> drivers/mmc/core/mmc.c | 24 +++
>> drivers/mmc/core/mmc_ops.c | 1 +
>> include/linux/mmc/card.h | 3 +
>> include/linux/mmc/core.h | 3 +
>> include/linux/mmc/host.h | 4 +
>> include/linux/mmc/mmc.h | 15 ++
>> 10 files changed, 555 insertions(+), 27 deletions(-)
>>
>> Best regards,
>> Seungwon Jeon.
>> --
>> 1.7.2.3
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-23 10:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-20 4:05 [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5 Seungwon Jeon
2012-01-20 4:35 ` Kyungmin Park
2012-01-20 5:39 ` Namjae Jeon
2012-01-23 10:13 ` Saugata Das
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).