* [PATCH v2] kernel/SRCU: Fix ctags
@ 2018-10-29 20:09 Sam Protsenko
2018-10-29 20:11 ` Sam Protsenko
2018-10-29 20:11 ` Andy Shevchenko
0 siblings, 2 replies; 6+ messages in thread
From: Sam Protsenko @ 2018-10-29 20:09 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, Andy Shevchenko
ctags indexing ("make tags" command) throws this warning:
ctags: Warning: include/linux/notifier.h:125:
null expansion of name pattern "\1"
This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
getting rid of line break.
Similar fix was already done in commit 25528213fe9f ("tags: Fix
DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
include/linux/notifier.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index f35c7bf76143..0096a05395e3 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
#ifdef CONFIG_TREE_SRCU
#define _SRCU_NOTIFIER_HEAD(name, mod) \
- static DEFINE_PER_CPU(struct srcu_data, \
- name##_head_srcu_data); \
+ static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
mod struct srcu_notifier_head name = \
SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kernel/SRCU: Fix ctags
2018-10-29 20:09 [PATCH v2] kernel/SRCU: Fix ctags Sam Protsenko
@ 2018-10-29 20:11 ` Sam Protsenko
2018-10-30 6:34 ` Greg KH
2018-10-29 20:11 ` Andy Shevchenko
1 sibling, 1 reply; 6+ messages in thread
From: Sam Protsenko @ 2018-10-29 20:11 UTC (permalink / raw)
To: Greg KH; +Cc: linux-kernel, Andy Shevchenko
Hi Greg,
On Mon, Oct 29, 2018 at 10:09 PM, Sam Protsenko
<semen.protsenko@linaro.org> wrote:
> ctags indexing ("make tags" command) throws this warning:
>
> ctags: Warning: include/linux/notifier.h:125:
> null expansion of name pattern "\1"
>
> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
> getting rid of line break.
>
> Similar fix was already done in commit 25528213fe9f ("tags: Fix
> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
This one was sent some time ago, but there wasn't any response. Can
you please review it and merge if applicable?
Thanks!
> include/linux/notifier.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index f35c7bf76143..0096a05395e3 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
>
> #ifdef CONFIG_TREE_SRCU
> #define _SRCU_NOTIFIER_HEAD(name, mod) \
> - static DEFINE_PER_CPU(struct srcu_data, \
> - name##_head_srcu_data); \
> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
> mod struct srcu_notifier_head name = \
> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
>
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kernel/SRCU: Fix ctags
2018-10-29 20:09 [PATCH v2] kernel/SRCU: Fix ctags Sam Protsenko
2018-10-29 20:11 ` Sam Protsenko
@ 2018-10-29 20:11 ` Andy Shevchenko
2018-10-30 19:31 ` Sam Protsenko
1 sibling, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2018-10-29 20:11 UTC (permalink / raw)
To: Sam Protsenko; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko
<semen.protsenko@linaro.org> wrote:
>
> ctags indexing ("make tags" command) throws this warning:
>
> ctags: Warning: include/linux/notifier.h:125:
> null expansion of name pattern "\1"
>
> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
> getting rid of line break.
>
> Similar fix was already done in commit 25528213fe9f ("tags: Fix
> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
Why not to add Fixes tag here as well?
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> include/linux/notifier.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
> index f35c7bf76143..0096a05395e3 100644
> --- a/include/linux/notifier.h
> +++ b/include/linux/notifier.h
> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
>
> #ifdef CONFIG_TREE_SRCU
> #define _SRCU_NOTIFIER_HEAD(name, mod) \
> - static DEFINE_PER_CPU(struct srcu_data, \
> - name##_head_srcu_data); \
> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
> mod struct srcu_notifier_head name = \
> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
>
> --
> 2.19.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kernel/SRCU: Fix ctags
2018-10-29 20:11 ` Sam Protsenko
@ 2018-10-30 6:34 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2018-10-30 6:34 UTC (permalink / raw)
To: Sam Protsenko; +Cc: linux-kernel, Andy Shevchenko
On Mon, Oct 29, 2018 at 10:11:36PM +0200, Sam Protsenko wrote:
> Hi Greg,
>
> On Mon, Oct 29, 2018 at 10:09 PM, Sam Protsenko
> <semen.protsenko@linaro.org> wrote:
> > ctags indexing ("make tags" command) throws this warning:
> >
> > ctags: Warning: include/linux/notifier.h:125:
> > null expansion of name pattern "\1"
> >
> > This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
> > getting rid of line break.
> >
> > Similar fix was already done in commit 25528213fe9f ("tags: Fix
> > DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
> >
> > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> > ---
>
> This one was sent some time ago, but there wasn't any response. Can
> you please review it and merge if applicable?
As before, why ask me?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] kernel/SRCU: Fix ctags
2018-10-29 20:11 ` Andy Shevchenko
@ 2018-10-30 19:31 ` Sam Protsenko
0 siblings, 0 replies; 6+ messages in thread
From: Sam Protsenko @ 2018-10-30 19:31 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On Mon, Oct 29, 2018 at 10:11 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Oct 29, 2018 at 10:09 PM Sam Protsenko
> <semen.protsenko@linaro.org> wrote:
>>
>> ctags indexing ("make tags" command) throws this warning:
>>
>> ctags: Warning: include/linux/notifier.h:125:
>> null expansion of name pattern "\1"
>>
>> This is the result of DEFINE_PER_CPU() macro exapansion. Fix that by
>> getting rid of line break.
>>
>> Similar fix was already done in commit 25528213fe9f ("tags: Fix
>> DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
>
> Why not to add Fixes tag here as well?
>
Will do, thanks, Andy!
>>
>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
>> ---
>> include/linux/notifier.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/include/linux/notifier.h b/include/linux/notifier.h
>> index f35c7bf76143..0096a05395e3 100644
>> --- a/include/linux/notifier.h
>> +++ b/include/linux/notifier.h
>> @@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
>>
>> #ifdef CONFIG_TREE_SRCU
>> #define _SRCU_NOTIFIER_HEAD(name, mod) \
>> - static DEFINE_PER_CPU(struct srcu_data, \
>> - name##_head_srcu_data); \
>> + static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
>> mod struct srcu_notifier_head name = \
>> SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
>>
>> --
>> 2.19.1
>>
>
>
> --
> With Best Regards,
> Andy Shevchenko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] kernel/SRCU: Fix ctags
@ 2018-10-30 20:28 Sam Protsenko
0 siblings, 0 replies; 6+ messages in thread
From: Sam Protsenko @ 2018-10-30 20:28 UTC (permalink / raw)
To: Andrew Morton, kernel-janitors; +Cc: linux-kernel, Andy Shevchenko
ctags indexing ("make tags" command) throws this warning:
ctags: Warning: include/linux/notifier.h:125:
null expansion of name pattern "\1"
This is the result of DEFINE_PER_CPU() macro expansion. Fix that by
getting rid of line break.
Similar fix was already done in commit 25528213fe9f ("tags: Fix
DEFINE_PER_CPU expansions"), but this one probably wasn't noticed.
Fixes: 9c80172b902d ("kernel/SRCU: provide a static initializer")
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
include/linux/notifier.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/linux/notifier.h b/include/linux/notifier.h
index f35c7bf76143..0096a05395e3 100644
--- a/include/linux/notifier.h
+++ b/include/linux/notifier.h
@@ -122,8 +122,7 @@ extern void srcu_init_notifier_head(struct srcu_notifier_head *nh);
#ifdef CONFIG_TREE_SRCU
#define _SRCU_NOTIFIER_HEAD(name, mod) \
- static DEFINE_PER_CPU(struct srcu_data, \
- name##_head_srcu_data); \
+ static DEFINE_PER_CPU(struct srcu_data, name##_head_srcu_data); \
mod struct srcu_notifier_head name = \
SRCU_NOTIFIER_INIT(name, name##_head_srcu_data)
--
2.19.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-30 20:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-29 20:09 [PATCH v2] kernel/SRCU: Fix ctags Sam Protsenko
2018-10-29 20:11 ` Sam Protsenko
2018-10-30 6:34 ` Greg KH
2018-10-29 20:11 ` Andy Shevchenko
2018-10-30 19:31 ` Sam Protsenko
2018-10-30 20:28 Sam Protsenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).