* [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
@ 2019-07-01 13:04 Colin King
2019-07-01 13:12 ` walter harms
2019-07-01 17:48 ` Andy Lutomirski
0 siblings, 2 replies; 9+ messages in thread
From: Colin King @ 2019-07-01 13:04 UTC (permalink / raw)
To: Shuah Khan, Andy Lutomirski, Kees Cook, Thomas Gleixner, linux-kselftest
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
There is an spelling mistake in an a test error message. Fix it.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
tools/testing/selftests/x86/test_vsyscall.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
index 4602326b8f5b..a4f4d4cf22c3 100644
--- a/tools/testing/selftests/x86/test_vsyscall.c
+++ b/tools/testing/selftests/x86/test_vsyscall.c
@@ -451,7 +451,7 @@ static int test_vsys_x(void)
printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
segv_err);
} else {
- printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
+ printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
segv_err);
return 1;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-01 13:04 [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" Colin King
@ 2019-07-01 13:12 ` walter harms
2019-07-01 17:59 ` shuah
2019-07-01 17:48 ` Andy Lutomirski
1 sibling, 1 reply; 9+ messages in thread
From: walter harms @ 2019-07-01 13:12 UTC (permalink / raw)
To: Colin King
Cc: Shuah Khan, Andy Lutomirski, Kees Cook, Thomas Gleixner,
linux-kselftest, kernel-janitors, linux-kernel
Am 01.07.2019 15:04, schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an spelling mistake in an a test error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
> index 4602326b8f5b..a4f4d4cf22c3 100644
> --- a/tools/testing/selftests/x86/test_vsyscall.c
> +++ b/tools/testing/selftests/x86/test_vsyscall.c
> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
> segv_err);
> } else {
> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> segv_err);
> return 1;
> }
"wrong error" sounds like scratching table, perhaps "error" is here sufficient ?
Bomus points when user is expected to report this.
re,
wh
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-01 13:04 [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" Colin King
2019-07-01 13:12 ` walter harms
@ 2019-07-01 17:48 ` Andy Lutomirski
2019-07-02 14:22 ` shuah
1 sibling, 1 reply; 9+ messages in thread
From: Andy Lutomirski @ 2019-07-01 17:48 UTC (permalink / raw)
To: Colin King
Cc: Shuah Khan, Andy Lutomirski, Kees Cook, Thomas Gleixner,
open list:KERNEL SELFTEST FRAMEWORK, kernel-janitors, LKML
On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> There is an spelling mistake in an a test error message. Fix it.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
> index 4602326b8f5b..a4f4d4cf22c3 100644
> --- a/tools/testing/selftests/x86/test_vsyscall.c
> +++ b/tools/testing/selftests/x86/test_vsyscall.c
> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
> segv_err);
> } else {
> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
> segv_err);
> return 1;
> }
> --
> 2.20.1
>
Acked-by: Andy Lutomirski <luto@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-01 13:12 ` walter harms
@ 2019-07-01 17:59 ` shuah
0 siblings, 0 replies; 9+ messages in thread
From: shuah @ 2019-07-01 17:59 UTC (permalink / raw)
To: wharms, Colin King
Cc: Andy Lutomirski, Kees Cook, Thomas Gleixner, linux-kselftest,
kernel-janitors, linux-kernel, shuah
On 7/1/19 7:12 AM, walter harms wrote:
>
>
> Am 01.07.2019 15:04, schrieb Colin King:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is an spelling mistake in an a test error message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
>> index 4602326b8f5b..a4f4d4cf22c3 100644
>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
>> segv_err);
>> } else {
>> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
>> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
>> segv_err);
>> return 1;
>> }
>
>
> "wrong error" sounds like scratching table, perhaps "error" is here sufficient ?
> Bomus points when user is expected to report this.
>
Just "error" would not accurate her. I think the intent is to say
that syscall returned an invalid error code. "Invalid error code"
would be accurate.
It would be helpful to report the expected error code.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-01 17:48 ` Andy Lutomirski
@ 2019-07-02 14:22 ` shuah
2019-07-02 19:25 ` shuah
0 siblings, 1 reply; 9+ messages in thread
From: shuah @ 2019-07-02 14:22 UTC (permalink / raw)
To: Andy Lutomirski, Colin King
Cc: Kees Cook, Thomas Gleixner, open list:KERNEL SELFTEST FRAMEWORK,
kernel-janitors, LKML, shuah
On 7/1/19 11:48 AM, Andy Lutomirski wrote:
> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com> wrote:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is an spelling mistake in an a test error message. Fix it.
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c b/tools/testing/selftests/x86/test_vsyscall.c
>> index 4602326b8f5b..a4f4d4cf22c3 100644
>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>> printf("[OK]\tExecuting the vsyscall page failed: #PF(0x%lx)\n",
>> segv_err);
>> } else {
>> - printf("[FAILT]\tExecution failed with the wrong error: #PF(0x%lx)\n",
>> + printf("[FAIL]\tExecution failed with the wrong error: #PF(0x%lx)\n",
>> segv_err);
>> return 1;
>> }
>> --
>> 2.20.1
>>
>
> Acked-by: Andy Lutomirski <luto@kernel.org>
>
Thanks Andy!
I will queue this up for 5.3
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-02 14:22 ` shuah
@ 2019-07-02 19:25 ` shuah
2019-07-02 22:42 ` Colin Ian King
0 siblings, 1 reply; 9+ messages in thread
From: shuah @ 2019-07-02 19:25 UTC (permalink / raw)
To: Andy Lutomirski, Colin King
Cc: Kees Cook, Thomas Gleixner, open list:KERNEL SELFTEST FRAMEWORK,
kernel-janitors, LKML, shuah
On 7/2/19 8:22 AM, shuah wrote:
> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com>
>> wrote:
>>>
>>> From: Colin Ian King <colin.king@canonical.com>
>>>
>>> There is an spelling mistake in an a test error message. Fix it.
>>>
>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>> ---
>>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c
>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>> printf("[OK]\tExecuting the vsyscall page failed:
>>> #PF(0x%lx)\n",
>>> segv_err);
>>> } else {
>>> - printf("[FAILT]\tExecution failed with the wrong
>>> error: #PF(0x%lx)\n",
>>> + printf("[FAIL]\tExecution failed with the wrong
>>> error: #PF(0x%lx)\n",
>>> segv_err);
>>> return 1;
>>> }
>>> --
>>> 2.20.1
>>>
>>
>> Acked-by: Andy Lutomirski <luto@kernel.org>
>>
>
> Thanks Andy!
>
> I will queue this up for 5.3
>
> -- Shuah
>
Hi Colin,
Checkpatch warning on this. Probably failed on the original patch.
Could you please fix the checkpatch warn, and send v2.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-02 19:25 ` shuah
@ 2019-07-02 22:42 ` Colin Ian King
2019-07-02 22:48 ` shuah
0 siblings, 1 reply; 9+ messages in thread
From: Colin Ian King @ 2019-07-02 22:42 UTC (permalink / raw)
To: shuah, Andy Lutomirski
Cc: Kees Cook, Thomas Gleixner, open list:KERNEL SELFTEST FRAMEWORK,
kernel-janitors, LKML
On 02/07/2019 20:25, shuah wrote:
> On 7/2/19 8:22 AM, shuah wrote:
>> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com>
>>> wrote:
>>>>
>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>
>>>> There is an spelling mistake in an a test error message. Fix it.
>>>>
>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>> ---
>>>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c
>>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>>> printf("[OK]\tExecuting the vsyscall page failed:
>>>> #PF(0x%lx)\n",
>>>> segv_err);
>>>> } else {
>>>> - printf("[FAILT]\tExecution failed with the wrong
>>>> error: #PF(0x%lx)\n",
>>>> + printf("[FAIL]\tExecution failed with the wrong
>>>> error: #PF(0x%lx)\n",
>>>> segv_err);
>>>> return 1;
>>>> }
>>>> --
>>>> 2.20.1
>>>>
>>>
>>> Acked-by: Andy Lutomirski <luto@kernel.org>
>>>
>>
>> Thanks Andy!
>>
>> I will queue this up for 5.3
>>
>> -- Shuah
>>
>
> Hi Colin,
>
> Checkpatch warning on this. Probably failed on the original patch.
> Could you please fix the checkpatch warn, and send v2.
If I split the line, I get another checkpatch warning:
"WARNING: quoted string split across lines"
Either way checkpatch emits a warning. The convention is to not break
literal strings, and the line is only a few chars over the 80 char
boundary, so the V1 of the patch is the way it should be IMHO.
Colin
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-02 22:42 ` Colin Ian King
@ 2019-07-02 22:48 ` shuah
2019-07-02 22:50 ` Colin Ian King
0 siblings, 1 reply; 9+ messages in thread
From: shuah @ 2019-07-02 22:48 UTC (permalink / raw)
To: Colin Ian King, Andy Lutomirski
Cc: Kees Cook, Thomas Gleixner, open list:KERNEL SELFTEST FRAMEWORK,
kernel-janitors, LKML, shuah
On 7/2/19 4:42 PM, Colin Ian King wrote:
> On 02/07/2019 20:25, shuah wrote:
>> On 7/2/19 8:22 AM, shuah wrote:
>>> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>>>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com>
>>>> wrote:
>>>>>
>>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>>
>>>>> There is an spelling mistake in an a test error message. Fix it.
>>>>>
>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>>> ---
>>>>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c
>>>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>>>> printf("[OK]\tExecuting the vsyscall page failed:
>>>>> #PF(0x%lx)\n",
>>>>> segv_err);
>>>>> } else {
>>>>> - printf("[FAILT]\tExecution failed with the wrong
>>>>> error: #PF(0x%lx)\n",
>>>>> + printf("[FAIL]\tExecution failed with the wrong
>>>>> error: #PF(0x%lx)\n",
>>>>> segv_err);
>>>>> return 1;
>>>>> }
>>>>> --
>>>>> 2.20.1
>>>>>
>>>>
>>>> Acked-by: Andy Lutomirski <luto@kernel.org>
>>>>
>>>
>>> Thanks Andy!
>>>
>>> I will queue this up for 5.3
>>>
>>> -- Shuah
>>>
>>
>> Hi Colin,
>>
>> Checkpatch warning on this. Probably failed on the original patch.
>> Could you please fix the checkpatch warn, and send v2.
>
> If I split the line, I get another checkpatch warning:
>
> "WARNING: quoted string split across lines"
>
> Either way checkpatch emits a warning. The convention is to not break
> literal strings, and the line is only a few chars over the 80 char
> boundary, so the V1 of the patch is the way it should be IMHO.
>
As such this existed before your patch. I will apply v1.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL"
2019-07-02 22:48 ` shuah
@ 2019-07-02 22:50 ` Colin Ian King
0 siblings, 0 replies; 9+ messages in thread
From: Colin Ian King @ 2019-07-02 22:50 UTC (permalink / raw)
To: shuah, Andy Lutomirski
Cc: Kees Cook, Thomas Gleixner, open list:KERNEL SELFTEST FRAMEWORK,
kernel-janitors, LKML
On 02/07/2019 23:48, shuah wrote:
> On 7/2/19 4:42 PM, Colin Ian King wrote:
>> On 02/07/2019 20:25, shuah wrote:
>>> On 7/2/19 8:22 AM, shuah wrote:
>>>> On 7/1/19 11:48 AM, Andy Lutomirski wrote:
>>>>> On Mon, Jul 1, 2019 at 6:04 AM Colin King <colin.king@canonical.com>
>>>>> wrote:
>>>>>>
>>>>>> From: Colin Ian King <colin.king@canonical.com>
>>>>>>
>>>>>> There is an spelling mistake in an a test error message. Fix it.
>>>>>>
>>>>>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>>>>>> ---
>>>>>> tools/testing/selftests/x86/test_vsyscall.c | 2 +-
>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> b/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> index 4602326b8f5b..a4f4d4cf22c3 100644
>>>>>> --- a/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> +++ b/tools/testing/selftests/x86/test_vsyscall.c
>>>>>> @@ -451,7 +451,7 @@ static int test_vsys_x(void)
>>>>>> printf("[OK]\tExecuting the vsyscall page failed:
>>>>>> #PF(0x%lx)\n",
>>>>>> segv_err);
>>>>>> } else {
>>>>>> - printf("[FAILT]\tExecution failed with the wrong
>>>>>> error: #PF(0x%lx)\n",
>>>>>> + printf("[FAIL]\tExecution failed with the wrong
>>>>>> error: #PF(0x%lx)\n",
>>>>>> segv_err);
>>>>>> return 1;
>>>>>> }
>>>>>> --
>>>>>> 2.20.1
>>>>>>
>>>>>
>>>>> Acked-by: Andy Lutomirski <luto@kernel.org>
>>>>>
>>>>
>>>> Thanks Andy!
>>>>
>>>> I will queue this up for 5.3
>>>>
>>>> -- Shuah
>>>>
>>>
>>> Hi Colin,
>>>
>>> Checkpatch warning on this. Probably failed on the original patch.
>>> Could you please fix the checkpatch warn, and send v2.
>>
>> If I split the line, I get another checkpatch warning:
>>
>> "WARNING: quoted string split across lines"
>>
>> Either way checkpatch emits a warning. The convention is to not break
>> literal strings, and the line is only a few chars over the 80 char
>> boundary, so the V1 of the patch is the way it should be IMHO.
>>
>
> As such this existed before your patch. I will apply v1.
Cool, thanks Shuah.
>
> thanks,
> -- Shuah
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-07-03 1:18 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-01 13:04 [PATCH][next] selftests/x86: fix spelling mistake "FAILT" -> "FAIL" Colin King
2019-07-01 13:12 ` walter harms
2019-07-01 17:59 ` shuah
2019-07-01 17:48 ` Andy Lutomirski
2019-07-02 14:22 ` shuah
2019-07-02 19:25 ` shuah
2019-07-02 22:42 ` Colin Ian King
2019-07-02 22:48 ` shuah
2019-07-02 22:50 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).