* [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
@ 2018-08-23 16:24 Vitaly Kuznetsov
2018-08-23 16:26 ` Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Vitaly Kuznetsov @ 2018-08-23 16:24 UTC (permalink / raw)
To: kvm; +Cc: Paolo Bonzini, Radim Krčmář, Jim Mattson, linux-kernel
nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
check_vmentry_postreqs() don't seem to be resetting it (the later, however,
checks it).
Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
arch/x86/kvm/vmx.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index 6c3514750d0c..8a63b8cf9458 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
return -EINVAL;
- if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
- vmx->nested.nested_run_pending = 1;
-
vmx->nested.dirty_vmcs12 = true;
ret = enter_vmx_non_root_mode(vcpu, NULL);
if (ret)
--
2.14.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
2018-08-23 16:24 [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Vitaly Kuznetsov
@ 2018-08-23 16:26 ` Paolo Bonzini
2018-08-23 20:50 ` Jim Mattson
2018-08-23 16:38 ` Eduardo Valentin
2018-08-24 20:37 ` Krish Sadhukhan
2 siblings, 1 reply; 5+ messages in thread
From: Paolo Bonzini @ 2018-08-23 16:26 UTC (permalink / raw)
To: Vitaly Kuznetsov, kvm
Cc: Radim Krčmář, Jim Mattson, linux-kernel
On 23/08/2018 18:24, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
> check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
> return -EINVAL;
>
> - if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> - vmx->nested.nested_run_pending = 1;
> -
> vmx->nested.dirty_vmcs12 = true;
> ret = enter_vmx_non_root_mode(vcpu, NULL);
> if (ret)
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
2018-08-23 16:26 ` Paolo Bonzini
@ 2018-08-23 20:50 ` Jim Mattson
0 siblings, 0 replies; 5+ messages in thread
From: Jim Mattson @ 2018-08-23 20:50 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Vitaly Kuznetsov, kvm list, Radim Krčmář, LKML
On Thu, Aug 23, 2018 at 9:26 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 23/08/2018 18:24, Vitaly Kuznetsov wrote:
>> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
>> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
>> checks it).
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
2018-08-23 16:24 [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Vitaly Kuznetsov
2018-08-23 16:26 ` Paolo Bonzini
@ 2018-08-23 16:38 ` Eduardo Valentin
2018-08-24 20:37 ` Krish Sadhukhan
2 siblings, 0 replies; 5+ messages in thread
From: Eduardo Valentin @ 2018-08-23 16:38 UTC (permalink / raw)
To: Vitaly Kuznetsov
Cc: kvm, Paolo Bonzini, Radim Krčmář,
Jim Mattson, linux-kernel
On Thu, Aug 23, 2018 at 06:24:24PM +0200, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
Reviewed-by: Eduardo Valentin <eduval@amazon.com>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
> check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
> return -EINVAL;
>
> - if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> - vmx->nested.nested_run_pending = 1;
> -
> vmx->nested.dirty_vmcs12 = true;
> ret = enter_vmx_non_root_mode(vcpu, NULL);
> if (ret)
> --
> 2.14.4
>
>
--
All the best,
Eduardo Valentin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending
2018-08-23 16:24 [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Vitaly Kuznetsov
2018-08-23 16:26 ` Paolo Bonzini
2018-08-23 16:38 ` Eduardo Valentin
@ 2018-08-24 20:37 ` Krish Sadhukhan
2 siblings, 0 replies; 5+ messages in thread
From: Krish Sadhukhan @ 2018-08-24 20:37 UTC (permalink / raw)
To: Vitaly Kuznetsov, kvm
Cc: Paolo Bonzini, Radim Krčmář, Jim Mattson, linux-kernel
On 08/23/2018 09:24 AM, Vitaly Kuznetsov wrote:
> nested_run_pending is set 20 lines above and check_vmentry_prereqs()/
> check_vmentry_postreqs() don't seem to be resetting it (the later, however,
> checks it).
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 6c3514750d0c..8a63b8cf9458 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -14221,9 +14221,6 @@ static int vmx_set_nested_state(struct kvm_vcpu *vcpu,
> check_vmentry_postreqs(vcpu, vmcs12, &exit_qual))
> return -EINVAL;
>
> - if (kvm_state->flags & KVM_STATE_NESTED_RUN_PENDING)
> - vmx->nested.nested_run_pending = 1;
> -
> vmx->nested.dirty_vmcs12 = true;
> ret = enter_vmx_non_root_mode(vcpu, NULL);
> if (ret)
Reviewed-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-24 20:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-23 16:24 [PATCH] x86/kvm/nVMX: avoid redundant double assignment of nested_run_pending Vitaly Kuznetsov
2018-08-23 16:26 ` Paolo Bonzini
2018-08-23 20:50 ` Jim Mattson
2018-08-23 16:38 ` Eduardo Valentin
2018-08-24 20:37 ` Krish Sadhukhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).