From: Dan Streetman <ddstreet@ieee.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Dan Streetman <dan.streetman@canonical.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 17:49:19 -0500 [thread overview]
Message-ID: <CALZtONCTvpa4ctjN7QJaeKcXi2iEQ2EieqDkQac3wnmKoEyEcA@mail.gmail.com> (raw)
In-Reply-To: <20161207224627.GA16018@infradead.org>
On Wed, Dec 7, 2016 at 5:46 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Dec 07, 2016 at 05:49:42PM -0500, Keith Busch wrote:
>> I'm just saying that blk-mq's hctx mapping will end up choosing a queue
>> who's vector is mapped to a different CPU, and we don't want that.
>
> Right. For 4.10 we could use the pci_alloc_irq_vectors_affinity helper
> to set away a pre_vector IFF we want a separate vector for the admin
> queue.
>
>> We are currently sharing the first IO queue's interrupt vector with
>> the admin queue's on purpose. Are you saying there's something wrong
>> with that?
>
> But given that the sharing was done intentionally and we had a long
> discussion on it back then there should be no real reason to change
> the assignment in NVMe.
sorry, i missed the past discussion. It still seems strange and
obscure that it's intentional, from reading the code at least.
next prev parent reply other threads:[~2016-12-07 22:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 22:03 [PATCH] nvme: use the correct msix vector for each queue Dan Streetman
2016-12-07 22:44 ` Keith Busch
2016-12-07 22:36 ` Dan Streetman
2016-12-07 22:49 ` Keith Busch
2016-12-07 22:46 ` Christoph Hellwig
2016-12-07 22:49 ` Dan Streetman [this message]
2016-12-07 22:46 ` Dan Streetman
2016-12-07 23:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZtONCTvpa4ctjN7QJaeKcXi2iEQ2EieqDkQac3wnmKoEyEcA@mail.gmail.com \
--to=ddstreet@ieee.org \
--cc=axboe@fb.com \
--cc=dan.streetman@canonical.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).