* [PATCH V2 0/3] Add Spreadtrum SP9860G support
@ 2017-02-21 6:55 Chunyan Zhang
2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang
` (2 more replies)
0 siblings, 3 replies; 16+ messages in thread
From: Chunyan Zhang @ 2017-02-21 6:55 UTC (permalink / raw)
To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd
Cc: orson.zhai, sudeep.holla, linux-kernel, devicetree,
linux-arm-kernel, zhang.lyra
SC9860 is a Spreadtrum SoC with eight Cortex A53, which are divided
into 4 Big cores and 4 little cores.
This patch-set only provides a basic configuration for SC9860 in device
tree to make it run to console. We will continue to submit other drivers
later on, which are using on Spreadtrum's SoCs.
Changes from v1:
* Removed useless idle-state node 'deep_sleep' from DT
* Removed useless property 'sc-id' from DT
* Removed 'clock-frequency' property from the node 'timer'
* Added another compatible string '"arm,cortex-a53-pmu"' and property
'interrupt-affinity' for pmu
* Kept using the existed compatible string of sprd_serial driver, and added
a new one for sc9860 in DT.
Thanks,
Chunyan
Chunyan Zhang (1):
Documentation: sprd: Add bindings for SP9860G
Orson Zhai (1):
arm64: dts: Add basic DT to support Spreadtrum's SP9860G
Wei Qiao (1):
serial: sprd: adjust TIMEOUT to a big value
Documentation/devicetree/bindings/arm/sprd.txt | 13 +-
.../devicetree/bindings/serial/sprd-uart.txt | 16 +-
arch/arm64/boot/dts/sprd/Makefile | 3 +-
arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 +++++++++++++++++++++
arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 +++
arch/arm64/boot/dts/sprd/whale2.dtsi | 70 +++
drivers/tty/serial/sprd_serial.c | 2 +-
7 files changed, 683 insertions(+), 8 deletions(-)
create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi
create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts
create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi
--
2.7.4
^ permalink raw reply [flat|nested] 16+ messages in thread* [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-21 6:55 [PATCH V2 0/3] Add Spreadtrum SP9860G support Chunyan Zhang @ 2017-02-21 6:55 ` Chunyan Zhang 2017-02-21 10:57 ` Sudeep Holla ` (2 more replies) 2017-02-21 6:55 ` [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 3/3] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang 2 siblings, 3 replies; 16+ messages in thread From: Chunyan Zhang @ 2017-02-21 6:55 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, sudeep.holla, linux-kernel, devicetree, linux-arm-kernel, zhang.lyra From: Orson Zhai <orson.zhai@spreadtrum.com> SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. According to regular hierarchy of sprd dts, whale2.dtsi contains SoC peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff and sp9860g dts is for the board level. Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- arch/arm64/boot/dts/sprd/Makefile | 3 +- arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ 4 files changed, 659 insertions(+), 1 deletion(-) create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile index b658c5e..f0535e6 100644 --- a/arch/arm64/boot/dts/sprd/Makefile +++ b/arch/arm64/boot/dts/sprd/Makefile @@ -1,4 +1,5 @@ -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ + sp9860g-1h10.dtb always := $(dtb-y) subdir-y := $(dts-dirs) diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi new file mode 100644 index 0000000..73deb4e --- /dev/null +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi @@ -0,0 +1,531 @@ +/* + * Spreadtrum SP9860 SoC DTS file + * + * Copyright (C) 2016, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +#include <dt-bindings/interrupt-controller/arm-gic.h> +#include "whale2.dtsi" + +/ { + cpus { + #address-cells = <2>; + #size-cells = <0>; + + cpu-map { + cluster0 { + core0 { + cpu = <&CPU0>; + }; + core1 { + cpu = <&CPU1>; + }; + core2 { + cpu = <&CPU2>; + }; + core3 { + cpu = <&CPU3>; + }; + }; + + cluster1 { + core0 { + cpu = <&CPU4>; + }; + core1 { + cpu = <&CPU5>; + }; + core2 { + cpu = <&CPU6>; + }; + core3 { + cpu = <&CPU7>; + }; + }; + }; + + CPU0: cpu@530000 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530000>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU1: cpu@530001 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530001>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU2: cpu@530002 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530002>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU3: cpu@530003 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530003>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU4: cpu@530100 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530100>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU5: cpu@530101 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530101>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU6: cpu@530102 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530102>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + + CPU7: cpu@530103 { + device_type = "cpu"; + compatible = "arm,cortex-a53", "arm,armv8"; + reg = <0x0 0x530103>; + enable-method = "psci"; + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; + }; + }; + + idle-states{ + entry-method = "arm,psci"; + + CORE_PD: core_pd { + compatible = "arm,idle-state"; + entry-latency-us = <1000>; + exit-latency-us = <700>; + min-residency-us = <2500>; + local-timer-stop; + arm,psci-suspend-param = <0x00010002>; + }; + + CLUSTER_PD: cluster_pd { + compatible = "arm,idle-state"; + entry-latency-us = <1000>; + exit-latency-us = <1000>; + min-residency-us = <3000>; + local-timer-stop; + arm,psci-suspend-param = <0x01010003>; + }; + }; + + gic: interrupt-controller@12001000 { + compatible = "arm,gic-400"; + reg = <0 0x12001000 0 0x1000>, + <0 0x12002000 0 0x2000>, + <0 0x12004000 0 0x2000>, + <0 0x12006000 0 0x2000>; + #interrupt-cells = <3>; + interrupt-controller; + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_HIGH)>; + }; + + psci { + compatible = "arm,psci-0.2"; + method = "smc"; + }; + + timer { + compatible = "arm,armv8-timer"; + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>, + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) + | IRQ_TYPE_LEVEL_LOW)>; + }; + + pmu { + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; + interrupt-affinity = <&CPU0>, + <&CPU1>, + <&CPU2>, + <&CPU3>, + <&CPU4>, + <&CPU5>, + <&CPU6>, + <&CPU7>; + }; + + soc { + soc_funnel: funnel@10001000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x10001000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + soc_funnel_out_port: endpoint { + remote-endpoint = <&etb_in>; + }; + }; + + port@1 { + reg = <0>; + soc_funnel_in_port: endpoint { + slave-mode; + remote-endpoint = + <&main_funnel_out_port>; + }; + }; + }; + }; + + etb@10003000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x10003000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + port { + etb_in: endpoint { + slave-mode; + remote-endpoint = + <&soc_funnel_out_port>; + }; + }; + }; + + cluster0_funnel: funnel@11001000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11001000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + cluster0_funnel_out_port: endpoint { + remote-endpoint = + <&cluster0_etf_in>; + }; + }; + + port@1 { + reg = <0>; + cluster0_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = <&etm0_out>; + }; + }; + + port@2 { + reg = <1>; + cluster0_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = <&etm1_out>; + }; + }; + + port@3 { + reg = <2>; + cluster0_funnel_in_port2: endpoint { + slave-mode; + remote-endpoint = <&etm2_out>; + }; + }; + + port@4 { + reg = <4>; + cluster0_funnel_in_port3: endpoint { + slave-mode; + remote-endpoint = <&etm3_out>; + }; + }; + }; + }; + + cluster1_funnel: funnel@11002000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11002000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + cluster1_funnel_out_port: endpoint { + remote-endpoint = + <&cluster1_etf_in>; + }; + }; + + port@1 { + reg = <0>; + cluster1_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = <&etm4_out>; + }; + }; + + port@2 { + reg = <1>; + cluster1_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = <&etm5_out>; + }; + }; + + port@3 { + reg = <2>; + cluster1_funnel_in_port2: endpoint { + slave-mode; + remote-endpoint = <&etm6_out>; + }; + }; + + port@4 { + reg = <3>; + cluster1_funnel_in_port3: endpoint { + slave-mode; + remote-endpoint = <&etm7_out>; + }; + }; + }; + }; + + cluster0_etf: etf@11003000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x11003000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port@0 { + cluster0_etf_out: endpoint { + remote-endpoint = + <&main_funnel_in_port0>; + }; + }; + + port@1 { + cluster0_etf_in: endpoint { + slave-mode; + remote-endpoint = + <&cluster0_funnel_out_port>; + }; + }; + }; + + cluster1_etf: etf@11004000 { + compatible = "arm,coresight-tmc", "arm,primecell"; + reg = <0 0x11004000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port@0 { + cluster1_etf_out: endpoint { + remote-endpoint = + <&main_funnel_in_port1>; + }; + }; + + port@1 { + cluster1_etf_in: endpoint { + slave-mode; + remote-endpoint = + <&cluster1_funnel_out_port>; + }; + }; + }; + + main_funnel: funnel@11005000 { + compatible = "arm,coresight-funnel", "arm,primecell"; + reg = <0 0x11005000 0 0x1000>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + main_funnel_out_port: endpoint { + remote-endpoint = + <&soc_funnel_in_port>; + }; + }; + + port@1 { + reg = <0>; + main_funnel_in_port0: endpoint { + slave-mode; + remote-endpoint = + <&cluster0_etf_out>; + }; + }; + + port@2 { + reg = <1>; + main_funnel_in_port1: endpoint { + slave-mode; + remote-endpoint = + <&cluster1_etf_out>; + }; + }; + }; + }; + + etm@11440000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11440000 0 0x1000>; + cpu = <&CPU0>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm0_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port0>; + }; + }; + }; + + etm@11540000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11540000 0 0x1000>; + cpu = <&CPU1>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm1_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port1>; + }; + }; + }; + + etm@11640000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11640000 0 0x1000>; + cpu = <&CPU2>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm2_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port2>; + }; + }; + }; + + etm@11740000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11740000 0 0x1000>; + cpu = <&CPU3>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm3_out: endpoint { + remote-endpoint = + <&cluster0_funnel_in_port3>; + }; + }; + }; + + etm@11840000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11840000 0 0x1000>; + cpu = <&CPU4>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm4_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port0>; + }; + }; + }; + + etm@11940000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11940000 0 0x1000>; + cpu = <&CPU5>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm5_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port1>; + }; + }; + }; + + etm@11a40000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11a40000 0 0x1000>; + cpu = <&CPU6>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm6_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port2>; + }; + }; + }; + + etm@11b40000 { + compatible = "arm,coresight-etm4x", "arm,primecell"; + reg = <0 0x11b40000 0 0x1000>; + cpu = <&CPU7>; + clocks = <&ext_26m>; + clock-names = "apb_pclk"; + + port { + etm7_out: endpoint { + remote-endpoint = + <&cluster1_funnel_in_port3>; + }; + }; + }; + }; +}; diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts new file mode 100644 index 0000000..5faa452 --- /dev/null +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts @@ -0,0 +1,56 @@ +/* + * Spreadtrum SP9860g board DTS file + * + * Copyright (C) 2017, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +/dts-v1/; + +#include "sc9860.dtsi" + +/ { + model = "Spreadtrum SP9860G 3GFHD Board"; + + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; + + aliases { + serial0 = &uart0; /* for Bluetooth */ + serial1 = &uart1; /* UART console */ + serial2 = &uart2; /* Reserved */ + serial3 = &uart3; /* for GPS */ + }; + + memory{ + device_type = "memory"; + reg = <0x0 0x80000000 0 0x60000000>, + <0x1 0x80000000 0 0x60000000>; + }; + + chosen { + stdout-path = "serial1:115200n8"; + }; + + reserved-memory { + #address-cells = <2>; + #size-cells = <2>; + ranges; + }; +}; + +&uart0 { + status = "okay"; +}; + +&uart1 { + status = "okay"; +}; + +&uart2 { + status = "okay"; +}; + +&uart3 { + status = "okay"; +}; diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi new file mode 100644 index 0000000..64f06d9 --- /dev/null +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi @@ -0,0 +1,70 @@ +/* + * Spreadtrum Whale2 SoC platform peripherals DTS file + * + * Copyright (C) 2016, Spreadtrum Communications Inc. + * + * This file is licensed under a dual GPLv2 or X11 license. + */ + +/ { + interrupt-parent = <&gic>; + #address-cells = <2>; + #size-cells = <2>; + + soc: soc { + compatible = "simple-bus"; + #address-cells = <2>; + #size-cells = <2>; + ranges; + + ap-apb { + compatible = "simple-bus"; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x0 0x70000000 0x10000000>; + + uart0: serial@70000000 { + compatible = "sprd,sc9838-uart", + "sprd,sc9836-uart"; + reg = <0x000000 0x100>; + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart1: serial@70100000 { + compatible = "sprd,sc9838-uart", + "sprd,sc9836-uart"; + reg = <0x100000 0x100>; + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart2: serial@70200000 { + compatible = "sprd,sc9838-uart", + "sprd,sc9836-uart"; + reg = <0x200000 0x100>; + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + + uart3: serial@70300000 { + compatible = "sprd,sc9838-uart", + "sprd,sc9836-uart"; + reg = <0x300000 0x100>; + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; + }; + + ext_26m: ext-26m { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <26000000>; + clock-output-names = "ext_26m"; + }; + }; +}; -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang @ 2017-02-21 10:57 ` Sudeep Holla 2017-02-21 16:27 ` Mathieu Poirier 2017-02-24 0:00 ` Rob Herring 2 siblings, 0 replies; 16+ messages in thread From: Sudeep Holla @ 2017-02-21 10:57 UTC (permalink / raw) To: Chunyan Zhang Cc: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd, Sudeep Holla, orson.zhai, linux-kernel, devicetree, linux-arm-kernel, zhang.lyra On 21/02/17 06:55, Chunyan Zhang wrote: > From: Orson Zhai <orson.zhai@spreadtrum.com> > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > and sp9860g dts is for the board level. > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > arch/arm64/boot/dts/sprd/Makefile | 3 +- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ > 4 files changed, 659 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > [...] > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > new file mode 100644 > index 0000000..73deb4e > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > @@ -0,0 +1,531 @@ > +/* > + * Spreadtrum SP9860 SoC DTS file > + * > + * Copyright (C) 2016, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + [...] > + > + idle-states{ > + entry-method = "arm,psci"; > + > + CORE_PD: core_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <700>; > + min-residency-us = <2500>; > + local-timer-stop; > + arm,psci-suspend-param = <0x00010002>; > + }; > + > + CLUSTER_PD: cluster_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <1000>; > + min-residency-us = <3000>; > + local-timer-stop; > + arm,psci-suspend-param = <0x01010003>; > + }; Thanks for dropping the hacked up "deep sleep" state :) This version looks fine to me. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-21 10:57 ` Sudeep Holla @ 2017-02-21 16:27 ` Mathieu Poirier 2017-02-22 3:46 ` Chunyan Zhang 2017-02-24 0:00 ` Rob Herring 2 siblings, 1 reply; 16+ messages in thread From: Mathieu Poirier @ 2017-02-21 16:27 UTC (permalink / raw) To: Chunyan Zhang Cc: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd, devicetree, orson.zhai, zhang.lyra, linux-kernel, sudeep.holla, linux-arm-kernel On Tue, Feb 21, 2017 at 02:55:02PM +0800, Chunyan Zhang wrote: > From: Orson Zhai <orson.zhai@spreadtrum.com> Hello Chunyan, > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > and sp9860g dts is for the board level. > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > arch/arm64/boot/dts/sprd/Makefile | 3 +- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ > 4 files changed, 659 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > index b658c5e..f0535e6 100644 > --- a/arch/arm64/boot/dts/sprd/Makefile > +++ b/arch/arm64/boot/dts/sprd/Makefile > @@ -1,4 +1,5 @@ > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > + sp9860g-1h10.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > new file mode 100644 > index 0000000..73deb4e > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > @@ -0,0 +1,531 @@ > +/* > + * Spreadtrum SP9860 SoC DTS file > + * > + * Copyright (C) 2016, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include "whale2.dtsi" > + > +/ { > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&CPU0>; > + }; > + core1 { > + cpu = <&CPU1>; > + }; > + core2 { > + cpu = <&CPU2>; > + }; > + core3 { > + cpu = <&CPU3>; > + }; > + }; > + > + cluster1 { > + core0 { > + cpu = <&CPU4>; > + }; > + core1 { > + cpu = <&CPU5>; > + }; > + core2 { > + cpu = <&CPU6>; > + }; > + core3 { > + cpu = <&CPU7>; > + }; > + }; > + }; > + > + CPU0: cpu@530000 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530000>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU1: cpu@530001 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530001>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU2: cpu@530002 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530002>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU3: cpu@530003 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530003>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU4: cpu@530100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530100>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU5: cpu@530101 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530101>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU6: cpu@530102 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530102>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU7: cpu@530103 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530103>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + }; > + > + idle-states{ > + entry-method = "arm,psci"; > + > + CORE_PD: core_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <700>; > + min-residency-us = <2500>; > + local-timer-stop; > + arm,psci-suspend-param = <0x00010002>; > + }; > + > + CLUSTER_PD: cluster_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <1000>; > + min-residency-us = <3000>; > + local-timer-stop; > + arm,psci-suspend-param = <0x01010003>; > + }; > + }; > + > + gic: interrupt-controller@12001000 { > + compatible = "arm,gic-400"; > + reg = <0 0x12001000 0 0x1000>, > + <0 0x12002000 0 0x2000>, > + <0 0x12004000 0 0x2000>, > + <0 0x12006000 0 0x2000>; > + #interrupt-cells = <3>; > + interrupt-controller; > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>; > + }; > + > + pmu { > + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-affinity = <&CPU0>, > + <&CPU1>, > + <&CPU2>, > + <&CPU3>, > + <&CPU4>, > + <&CPU5>, > + <&CPU6>, > + <&CPU7>; > + }; > + > + soc { > + soc_funnel: funnel@10001000 { There is no need for a label ("soc_funnel) before the device name if that device is not referenced elsewhere in the DTS. The same comment applies to most of the component listed below. > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x10001000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + soc_funnel_out_port: endpoint { > + remote-endpoint = <&etb_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + soc_funnel_in_port: endpoint { > + slave-mode; > + remote-endpoint = > + <&main_funnel_out_port>; > + }; > + }; > + }; > + }; > + > + etb@10003000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x10003000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + port { > + etb_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&soc_funnel_out_port>; > + }; > + }; > + }; > + > + cluster0_funnel: funnel@11001000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11001000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + cluster0_funnel_out_port: endpoint { > + remote-endpoint = > + <&cluster0_etf_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + cluster0_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = <&etm0_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + cluster0_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = <&etm1_out>; > + }; > + }; > + > + port@3 { > + reg = <2>; > + cluster0_funnel_in_port2: endpoint { > + slave-mode; > + remote-endpoint = <&etm2_out>; > + }; > + }; > + > + port@4 { > + reg = <4>; > + cluster0_funnel_in_port3: endpoint { > + slave-mode; > + remote-endpoint = <&etm3_out>; > + }; > + }; > + }; > + }; > + > + cluster1_funnel: funnel@11002000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11002000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + cluster1_funnel_out_port: endpoint { > + remote-endpoint = > + <&cluster1_etf_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + cluster1_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = <&etm4_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + cluster1_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = <&etm5_out>; > + }; > + }; > + > + port@3 { > + reg = <2>; > + cluster1_funnel_in_port2: endpoint { > + slave-mode; > + remote-endpoint = <&etm6_out>; > + }; > + }; > + > + port@4 { > + reg = <3>; > + cluster1_funnel_in_port3: endpoint { > + slave-mode; > + remote-endpoint = <&etm7_out>; > + }; > + }; > + }; > + }; > + > + cluster0_etf: etf@11003000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x11003000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port@0 { > + cluster0_etf_out: endpoint { > + remote-endpoint = > + <&main_funnel_in_port0>; > + }; > + }; > + > + port@1 { > + cluster0_etf_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster0_funnel_out_port>; > + }; > + }; > + }; > + > + cluster1_etf: etf@11004000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x11004000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port@0 { > + cluster1_etf_out: endpoint { > + remote-endpoint = > + <&main_funnel_in_port1>; > + }; > + }; > + > + port@1 { > + cluster1_etf_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster1_funnel_out_port>; > + }; > + }; > + }; When more than one port is present it is customary to add another level of imbrication like it is done for funnels above: "ports {" port@0 { ... port@1 { ... } The same comment applies to both etf. > + > + main_funnel: funnel@11005000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11005000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + main_funnel_out_port: endpoint { > + remote-endpoint = > + <&soc_funnel_in_port>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + main_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster0_etf_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + main_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster1_etf_out>; > + }; > + }; > + }; > + }; > + > + etm@11440000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11440000 0 0x1000>; > + cpu = <&CPU0>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm0_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port0>; > + }; > + }; > + }; > + > + etm@11540000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11540000 0 0x1000>; > + cpu = <&CPU1>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm1_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port1>; > + }; > + }; > + }; > + > + etm@11640000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11640000 0 0x1000>; > + cpu = <&CPU2>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm2_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port2>; > + }; > + }; > + }; > + > + etm@11740000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11740000 0 0x1000>; > + cpu = <&CPU3>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm3_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port3>; > + }; > + }; > + }; > + > + etm@11840000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11840000 0 0x1000>; > + cpu = <&CPU4>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm4_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port0>; > + }; > + }; > + }; > + > + etm@11940000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11940000 0 0x1000>; > + cpu = <&CPU5>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm5_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port1>; > + }; > + }; > + }; > + > + etm@11a40000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11a40000 0 0x1000>; > + cpu = <&CPU6>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm6_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port2>; > + }; > + }; > + }; > + > + etm@11b40000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11b40000 0 0x1000>; > + cpu = <&CPU7>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm7_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port3>; > + }; > + }; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > new file mode 100644 > index 0000000..5faa452 > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > @@ -0,0 +1,56 @@ > +/* > + * Spreadtrum SP9860g board DTS file > + * > + * Copyright (C) 2017, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/dts-v1/; > + > +#include "sc9860.dtsi" > + > +/ { > + model = "Spreadtrum SP9860G 3GFHD Board"; > + > + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > + > + aliases { > + serial0 = &uart0; /* for Bluetooth */ > + serial1 = &uart1; /* UART console */ > + serial2 = &uart2; /* Reserved */ > + serial3 = &uart3; /* for GPS */ > + }; > + > + memory{ > + device_type = "memory"; > + reg = <0x0 0x80000000 0 0x60000000>, > + <0x1 0x80000000 0 0x60000000>; > + }; > + > + chosen { > + stdout-path = "serial1:115200n8"; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&uart1 { > + status = "okay"; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&uart3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi > new file mode 100644 > index 0000000..64f06d9 > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi > @@ -0,0 +1,70 @@ > +/* > + * Spreadtrum Whale2 SoC platform peripherals DTS file > + * > + * Copyright (C) 2016, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/ { > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + soc: soc { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ap-apb { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x70000000 0x10000000>; > + > + uart0: serial@70000000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x000000 0x100>; > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart1: serial@70100000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x100000 0x100>; > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart2: serial@70200000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x200000 0x100>; > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart3: serial@70300000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x300000 0x100>; > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + }; > + > + ext_26m: ext-26m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <26000000>; > + clock-output-names = "ext_26m"; > + }; > + }; > +}; > -- > 2.7.4 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-21 16:27 ` Mathieu Poirier @ 2017-02-22 3:46 ` Chunyan Zhang 2017-02-22 16:02 ` Mathieu Poirier 0 siblings, 1 reply; 16+ messages in thread From: Chunyan Zhang @ 2017-02-22 3:46 UTC (permalink / raw) To: Mathieu Poirier Cc: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd, devicetree, orson.zhai, zhang.lyra, linux-kernel, sudeep.holla, linux-arm-kernel Hello Mathieu, On 二, 2月 21, 2017 at 09:27:44上午 -0700, Mathieu Poirier wrote: > On Tue, Feb 21, 2017 at 02:55:02PM +0800, Chunyan Zhang wrote: > > From: Orson Zhai <orson.zhai@spreadtrum.com> > > Hello Chunyan, > > > > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > > and sp9860g dts is for the board level. > > > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > > --- > > arch/arm64/boot/dts/sprd/Makefile | 3 +- > > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ > > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ > > 4 files changed, 659 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > > index b658c5e..f0535e6 100644 > > --- a/arch/arm64/boot/dts/sprd/Makefile > > +++ b/arch/arm64/boot/dts/sprd/Makefile > > @@ -1,4 +1,5 @@ > > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > > + sp9860g-1h10.dtb > > > > always := $(dtb-y) > > subdir-y := $(dts-dirs) > > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > new file mode 100644 > > index 0000000..73deb4e > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > @@ -0,0 +1,531 @@ > > +/* > > + * Spreadtrum SP9860 SoC DTS file > > + * > > + * Copyright (C) 2016, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +#include <dt-bindings/interrupt-controller/arm-gic.h> > > +#include "whale2.dtsi" > > + > > +/ { > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > + > > + cpu-map { > > + cluster0 { > > + core0 { > > + cpu = <&CPU0>; > > + }; > > + core1 { > > + cpu = <&CPU1>; > > + }; > > + core2 { > > + cpu = <&CPU2>; > > + }; > > + core3 { > > + cpu = <&CPU3>; > > + }; > > + }; > > + > > + cluster1 { > > + core0 { > > + cpu = <&CPU4>; > > + }; > > + core1 { > > + cpu = <&CPU5>; > > + }; > > + core2 { > > + cpu = <&CPU6>; > > + }; > > + core3 { > > + cpu = <&CPU7>; > > + }; > > + }; > > + }; > > + > > + CPU0: cpu@530000 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530000>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU1: cpu@530001 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530001>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU2: cpu@530002 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530002>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU3: cpu@530003 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530003>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU4: cpu@530100 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530100>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU5: cpu@530101 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530101>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU6: cpu@530102 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530102>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU7: cpu@530103 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530103>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + }; > > + > > + idle-states{ > > + entry-method = "arm,psci"; > > + > > + CORE_PD: core_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <700>; > > + min-residency-us = <2500>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x00010002>; > > + }; > > + > > + CLUSTER_PD: cluster_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <1000>; > > + min-residency-us = <3000>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x01010003>; > > + }; > > + }; > > + > > + gic: interrupt-controller@12001000 { > > + compatible = "arm,gic-400"; > > + reg = <0 0x12001000 0 0x1000>, > > + <0 0x12002000 0 0x2000>, > > + <0 0x12004000 0 0x2000>, > > + <0 0x12006000 0 0x2000>; > > + #interrupt-cells = <3>; > > + interrupt-controller; > > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_HIGH)>; > > + }; > > + > > + psci { > > + compatible = "arm,psci-0.2"; > > + method = "smc"; > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>; > > + }; > > + > > + pmu { > > + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; > > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-affinity = <&CPU0>, > > + <&CPU1>, > > + <&CPU2>, > > + <&CPU3>, > > + <&CPU4>, > > + <&CPU5>, > > + <&CPU6>, > > + <&CPU7>; > > + }; > > + > > + soc { > > + soc_funnel: funnel@10001000 { > > There is no need for a label ("soc_funnel) before the device name if that > device is not referenced elsewhere in the DTS. The same comment applies to most > of the component listed below. > OK, I will remove these labels from this DT. And there's another issue I'd like to discuss with you, do you think which way is better: 1) use class name which can represent this kind of components as device node name in DT, e.g. funnel@... { } replicator@... { } etb@... { } etf@... etm@... stm@... 2) use more descriptive device name for those which are more than one on a SoC, e.g. soc-funnel@... { } cluster0-funnel@... { } cluster1-funnel@... { } I noticed Juno use the 2), would you suggest that way? Thanks, Chunyan > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x10001000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + soc_funnel_out_port: endpoint { > > + remote-endpoint = <&etb_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + soc_funnel_in_port: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&main_funnel_out_port>; > > + }; > > + }; > > + }; > > + }; > > + > > + etb@10003000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x10003000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + port { > > + etb_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&soc_funnel_out_port>; > > + }; > > + }; > > + }; > > + > > + cluster0_funnel: funnel@11001000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11001000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster0_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + cluster0_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm0_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + cluster0_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm1_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <2>; > > + cluster0_funnel_in_port2: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm2_out>; > > + }; > > + }; > > + > > + port@4 { > > + reg = <4>; > > + cluster0_funnel_in_port3: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm3_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + cluster1_funnel: funnel@11002000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11002000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster1_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + cluster1_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm4_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + cluster1_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm5_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <2>; > > + cluster1_funnel_in_port2: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm6_out>; > > + }; > > + }; > > + > > + port@4 { > > + reg = <3>; > > + cluster1_funnel_in_port3: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm7_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + cluster0_etf: etf@11003000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x11003000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port@0 { > > + cluster0_etf_out: endpoint { > > + remote-endpoint = > > + <&main_funnel_in_port0>; > > + }; > > + }; > > + > > + port@1 { > > + cluster0_etf_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster0_funnel_out_port>; > > + }; > > + }; > > + }; > > + > > + cluster1_etf: etf@11004000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x11004000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port@0 { > > + cluster1_etf_out: endpoint { > > + remote-endpoint = > > + <&main_funnel_in_port1>; > > + }; > > + }; > > + > > + port@1 { > > + cluster1_etf_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster1_funnel_out_port>; > > + }; > > + }; > > + }; > > When more than one port is present it is customary to add another level of > imbrication like it is done for funnels above: > "ports {" > port@0 { > ... > port@1 { > ... > } > > The same comment applies to both etf. > OK. > > + > > + main_funnel: funnel@11005000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11005000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + main_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&soc_funnel_in_port>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + main_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster0_etf_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + main_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster1_etf_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@11440000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11440000 0 0x1000>; > > + cpu = <&CPU0>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm0_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port0>; > > + }; > > + }; > > + }; > > + > > + etm@11540000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11540000 0 0x1000>; > > + cpu = <&CPU1>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm1_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port1>; > > + }; > > + }; > > + }; > > + > > + etm@11640000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11640000 0 0x1000>; > > + cpu = <&CPU2>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm2_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port2>; > > + }; > > + }; > > + }; > > + > > + etm@11740000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11740000 0 0x1000>; > > + cpu = <&CPU3>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm3_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port3>; > > + }; > > + }; > > + }; > > + > > + etm@11840000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11840000 0 0x1000>; > > + cpu = <&CPU4>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm4_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port0>; > > + }; > > + }; > > + }; > > + > > + etm@11940000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11940000 0 0x1000>; > > + cpu = <&CPU5>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm5_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port1>; > > + }; > > + }; > > + }; > > + > > + etm@11a40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11a40000 0 0x1000>; > > + cpu = <&CPU6>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm6_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port2>; > > + }; > > + }; > > + }; > > + > > + etm@11b40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11b40000 0 0x1000>; > > + cpu = <&CPU7>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm7_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port3>; > > + }; > > + }; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..5faa452 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,56 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > > + > > + aliases { > > + serial0 = &uart0; /* for Bluetooth */ > > + serial1 = &uart1; /* UART console */ > > + serial2 = &uart2; /* Reserved */ > > + serial3 = &uart3; /* for GPS */ > > + }; > > + > > + memory{ > > + device_type = "memory"; > > + reg = <0x0 0x80000000 0 0x60000000>, > > + <0x1 0x80000000 0 0x60000000>; > > + }; > > + > > + chosen { > > + stdout-path = "serial1:115200n8"; > > + }; > > + > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + }; > > +}; > > + > > +&uart0 { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "okay"; > > +}; > > + > > +&uart2 { > > + status = "okay"; > > +}; > > + > > +&uart3 { > > + status = "okay"; > > +}; > > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi > > new file mode 100644 > > index 0000000..64f06d9 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi > > @@ -0,0 +1,70 @@ > > +/* > > + * Spreadtrum Whale2 SoC platform peripherals DTS file > > + * > > + * Copyright (C) 2016, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/ { > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + soc: soc { > > + compatible = "simple-bus"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + ap-apb { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x0 0x70000000 0x10000000>; > > + > > + uart0: serial@70000000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x000000 0x100>; > > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart1: serial@70100000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x100000 0x100>; > > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart2: serial@70200000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x200000 0x100>; > > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart3: serial@70300000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x300000 0x100>; > > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + }; > > + > > + ext_26m: ext-26m { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <26000000>; > > + clock-output-names = "ext_26m"; > > + }; > > + }; > > +}; > > -- > > 2.7.4 > > > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-22 3:46 ` Chunyan Zhang @ 2017-02-22 16:02 ` Mathieu Poirier 2017-02-23 6:20 ` Chunyan Zhang 0 siblings, 1 reply; 16+ messages in thread From: Mathieu Poirier @ 2017-02-22 16:02 UTC (permalink / raw) To: Mathieu Poirier, Rob Herring, Mark Rutland, Greg KH, Catalin Marinas, Will Deacon, Arnd Bergmann, devicetree, Orson Zhai, Lyra Zhang, linux-kernel, Sudeep Holla, linux-arm-kernel On 21 February 2017 at 20:46, Chunyan Zhang <chunyan.zhang@spreadtrum.com> wrote: > Hello Mathieu, > > On 二, 2月 21, 2017 at 09:27:44上午 -0700, Mathieu Poirier wrote: >> On Tue, Feb 21, 2017 at 02:55:02PM +0800, Chunyan Zhang wrote: >> > From: Orson Zhai <orson.zhai@spreadtrum.com> >> >> Hello Chunyan, >> >> > >> > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. >> > >> > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC >> > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff >> > and sp9860g dts is for the board level. >> > >> > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> >> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> >> > --- >> > arch/arm64/boot/dts/sprd/Makefile | 3 +- >> > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ >> > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ >> > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ >> > 4 files changed, 659 insertions(+), 1 deletion(-) >> > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi >> > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts >> > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi >> > >> > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile >> > index b658c5e..f0535e6 100644 >> > --- a/arch/arm64/boot/dts/sprd/Makefile >> > +++ b/arch/arm64/boot/dts/sprd/Makefile >> > @@ -1,4 +1,5 @@ >> > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb >> > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ >> > + sp9860g-1h10.dtb >> > >> > always := $(dtb-y) >> > subdir-y := $(dts-dirs) >> > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi >> > new file mode 100644 >> > index 0000000..73deb4e >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi >> > @@ -0,0 +1,531 @@ >> > +/* >> > + * Spreadtrum SP9860 SoC DTS file >> > + * >> > + * Copyright (C) 2016, Spreadtrum Communications Inc. >> > + * >> > + * This file is licensed under a dual GPLv2 or X11 license. >> > + */ >> > + >> > +#include <dt-bindings/interrupt-controller/arm-gic.h> >> > +#include "whale2.dtsi" >> > + >> > +/ { >> > + cpus { >> > + #address-cells = <2>; >> > + #size-cells = <0>; >> > + >> > + cpu-map { >> > + cluster0 { >> > + core0 { >> > + cpu = <&CPU0>; >> > + }; >> > + core1 { >> > + cpu = <&CPU1>; >> > + }; >> > + core2 { >> > + cpu = <&CPU2>; >> > + }; >> > + core3 { >> > + cpu = <&CPU3>; >> > + }; >> > + }; >> > + >> > + cluster1 { >> > + core0 { >> > + cpu = <&CPU4>; >> > + }; >> > + core1 { >> > + cpu = <&CPU5>; >> > + }; >> > + core2 { >> > + cpu = <&CPU6>; >> > + }; >> > + core3 { >> > + cpu = <&CPU7>; >> > + }; >> > + }; >> > + }; >> > + >> > + CPU0: cpu@530000 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530000>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU1: cpu@530001 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530001>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU2: cpu@530002 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530002>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU3: cpu@530003 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530003>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU4: cpu@530100 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530100>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU5: cpu@530101 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530101>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU6: cpu@530102 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530102>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + >> > + CPU7: cpu@530103 { >> > + device_type = "cpu"; >> > + compatible = "arm,cortex-a53", "arm,armv8"; >> > + reg = <0x0 0x530103>; >> > + enable-method = "psci"; >> > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; >> > + }; >> > + }; >> > + >> > + idle-states{ >> > + entry-method = "arm,psci"; >> > + >> > + CORE_PD: core_pd { >> > + compatible = "arm,idle-state"; >> > + entry-latency-us = <1000>; >> > + exit-latency-us = <700>; >> > + min-residency-us = <2500>; >> > + local-timer-stop; >> > + arm,psci-suspend-param = <0x00010002>; >> > + }; >> > + >> > + CLUSTER_PD: cluster_pd { >> > + compatible = "arm,idle-state"; >> > + entry-latency-us = <1000>; >> > + exit-latency-us = <1000>; >> > + min-residency-us = <3000>; >> > + local-timer-stop; >> > + arm,psci-suspend-param = <0x01010003>; >> > + }; >> > + }; >> > + >> > + gic: interrupt-controller@12001000 { >> > + compatible = "arm,gic-400"; >> > + reg = <0 0x12001000 0 0x1000>, >> > + <0 0x12002000 0 0x2000>, >> > + <0 0x12004000 0 0x2000>, >> > + <0 0x12006000 0 0x2000>; >> > + #interrupt-cells = <3>; >> > + interrupt-controller; >> > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) >> > + | IRQ_TYPE_LEVEL_HIGH)>; >> > + }; >> > + >> > + psci { >> > + compatible = "arm,psci-0.2"; >> > + method = "smc"; >> > + }; >> > + >> > + timer { >> > + compatible = "arm,armv8-timer"; >> > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) >> > + | IRQ_TYPE_LEVEL_LOW)>, >> > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) >> > + | IRQ_TYPE_LEVEL_LOW)>, >> > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) >> > + | IRQ_TYPE_LEVEL_LOW)>, >> > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) >> > + | IRQ_TYPE_LEVEL_LOW)>; >> > + }; >> > + >> > + pmu { >> > + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; >> > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, >> > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; >> > + interrupt-affinity = <&CPU0>, >> > + <&CPU1>, >> > + <&CPU2>, >> > + <&CPU3>, >> > + <&CPU4>, >> > + <&CPU5>, >> > + <&CPU6>, >> > + <&CPU7>; >> > + }; >> > + >> > + soc { >> > + soc_funnel: funnel@10001000 { >> >> There is no need for a label ("soc_funnel) before the device name if that >> device is not referenced elsewhere in the DTS. The same comment applies to most >> of the component listed below. >> > > OK, I will remove these labels from this DT. > And there's another issue I'd like to discuss with you, do you think which way is better: > 1) use class name which can represent this kind of components as device node name in DT, e.g. > funnel@... { > > } > replicator@... { > > } > etb@... { > > } > etf@... > etm@... > stm@... > > 2) use more descriptive device name for those which are more than one on > a SoC, e.g. > soc-funnel@... { > > } > cluster0-funnel@... { > > } > cluster1-funnel@... { > > } > > I noticed Juno use the 2), would you suggest that way? It is better to describe the HW component themselves rather than where they are in the topology - the address of the component will make sure the names are unique. So just the component type (etm, funnel, replicator, ....) and the address they are located at. > > Thanks, > Chunyan > >> > + compatible = "arm,coresight-funnel", "arm,primecell"; >> > + reg = <0 0x10001000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + ports { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + >> > + port@0 { >> > + reg = <0>; >> > + soc_funnel_out_port: endpoint { >> > + remote-endpoint = <&etb_in>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + reg = <0>; >> > + soc_funnel_in_port: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&main_funnel_out_port>; >> > + }; >> > + }; >> > + }; >> > + }; >> > + >> > + etb@10003000 { >> > + compatible = "arm,coresight-tmc", "arm,primecell"; >> > + reg = <0 0x10003000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + port { >> > + etb_in: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&soc_funnel_out_port>; >> > + }; >> > + }; >> > + }; >> > + >> > + cluster0_funnel: funnel@11001000 { >> > + compatible = "arm,coresight-funnel", "arm,primecell"; >> > + reg = <0 0x11001000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + ports { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + >> > + port@0 { >> > + reg = <0>; >> > + cluster0_funnel_out_port: endpoint { >> > + remote-endpoint = >> > + <&cluster0_etf_in>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + reg = <0>; >> > + cluster0_funnel_in_port0: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm0_out>; >> > + }; >> > + }; >> > + >> > + port@2 { >> > + reg = <1>; >> > + cluster0_funnel_in_port1: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm1_out>; >> > + }; >> > + }; >> > + >> > + port@3 { >> > + reg = <2>; >> > + cluster0_funnel_in_port2: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm2_out>; >> > + }; >> > + }; >> > + >> > + port@4 { >> > + reg = <4>; >> > + cluster0_funnel_in_port3: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm3_out>; >> > + }; >> > + }; >> > + }; >> > + }; >> > + >> > + cluster1_funnel: funnel@11002000 { >> > + compatible = "arm,coresight-funnel", "arm,primecell"; >> > + reg = <0 0x11002000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + ports { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + >> > + port@0 { >> > + reg = <0>; >> > + cluster1_funnel_out_port: endpoint { >> > + remote-endpoint = >> > + <&cluster1_etf_in>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + reg = <0>; >> > + cluster1_funnel_in_port0: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm4_out>; >> > + }; >> > + }; >> > + >> > + port@2 { >> > + reg = <1>; >> > + cluster1_funnel_in_port1: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm5_out>; >> > + }; >> > + }; >> > + >> > + port@3 { >> > + reg = <2>; >> > + cluster1_funnel_in_port2: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm6_out>; >> > + }; >> > + }; >> > + >> > + port@4 { >> > + reg = <3>; >> > + cluster1_funnel_in_port3: endpoint { >> > + slave-mode; >> > + remote-endpoint = <&etm7_out>; >> > + }; >> > + }; >> > + }; >> > + }; >> > + >> > + cluster0_etf: etf@11003000 { >> > + compatible = "arm,coresight-tmc", "arm,primecell"; >> > + reg = <0 0x11003000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port@0 { >> > + cluster0_etf_out: endpoint { >> > + remote-endpoint = >> > + <&main_funnel_in_port0>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + cluster0_etf_in: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&cluster0_funnel_out_port>; >> > + }; >> > + }; >> > + }; >> > + >> > + cluster1_etf: etf@11004000 { >> > + compatible = "arm,coresight-tmc", "arm,primecell"; >> > + reg = <0 0x11004000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port@0 { >> > + cluster1_etf_out: endpoint { >> > + remote-endpoint = >> > + <&main_funnel_in_port1>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + cluster1_etf_in: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&cluster1_funnel_out_port>; >> > + }; >> > + }; >> > + }; >> >> When more than one port is present it is customary to add another level of >> imbrication like it is done for funnels above: >> "ports {" >> port@0 { >> ... >> port@1 { >> ... >> } >> >> The same comment applies to both etf. >> > > OK. > >> > + >> > + main_funnel: funnel@11005000 { >> > + compatible = "arm,coresight-funnel", "arm,primecell"; >> > + reg = <0 0x11005000 0 0x1000>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + ports { >> > + #address-cells = <1>; >> > + #size-cells = <0>; >> > + >> > + port@0 { >> > + reg = <0>; >> > + main_funnel_out_port: endpoint { >> > + remote-endpoint = >> > + <&soc_funnel_in_port>; >> > + }; >> > + }; >> > + >> > + port@1 { >> > + reg = <0>; >> > + main_funnel_in_port0: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&cluster0_etf_out>; >> > + }; >> > + }; >> > + >> > + port@2 { >> > + reg = <1>; >> > + main_funnel_in_port1: endpoint { >> > + slave-mode; >> > + remote-endpoint = >> > + <&cluster1_etf_out>; >> > + }; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11440000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11440000 0 0x1000>; >> > + cpu = <&CPU0>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm0_out: endpoint { >> > + remote-endpoint = >> > + <&cluster0_funnel_in_port0>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11540000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11540000 0 0x1000>; >> > + cpu = <&CPU1>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm1_out: endpoint { >> > + remote-endpoint = >> > + <&cluster0_funnel_in_port1>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11640000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11640000 0 0x1000>; >> > + cpu = <&CPU2>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm2_out: endpoint { >> > + remote-endpoint = >> > + <&cluster0_funnel_in_port2>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11740000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11740000 0 0x1000>; >> > + cpu = <&CPU3>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm3_out: endpoint { >> > + remote-endpoint = >> > + <&cluster0_funnel_in_port3>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11840000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11840000 0 0x1000>; >> > + cpu = <&CPU4>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm4_out: endpoint { >> > + remote-endpoint = >> > + <&cluster1_funnel_in_port0>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11940000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11940000 0 0x1000>; >> > + cpu = <&CPU5>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm5_out: endpoint { >> > + remote-endpoint = >> > + <&cluster1_funnel_in_port1>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11a40000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11a40000 0 0x1000>; >> > + cpu = <&CPU6>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm6_out: endpoint { >> > + remote-endpoint = >> > + <&cluster1_funnel_in_port2>; >> > + }; >> > + }; >> > + }; >> > + >> > + etm@11b40000 { >> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >> > + reg = <0 0x11b40000 0 0x1000>; >> > + cpu = <&CPU7>; >> > + clocks = <&ext_26m>; >> > + clock-names = "apb_pclk"; >> > + >> > + port { >> > + etm7_out: endpoint { >> > + remote-endpoint = >> > + <&cluster1_funnel_in_port3>; >> > + }; >> > + }; >> > + }; >> > + }; >> > +}; >> > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts >> > new file mode 100644 >> > index 0000000..5faa452 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts >> > @@ -0,0 +1,56 @@ >> > +/* >> > + * Spreadtrum SP9860g board DTS file >> > + * >> > + * Copyright (C) 2017, Spreadtrum Communications Inc. >> > + * >> > + * This file is licensed under a dual GPLv2 or X11 license. >> > + */ >> > + >> > +/dts-v1/; >> > + >> > +#include "sc9860.dtsi" >> > + >> > +/ { >> > + model = "Spreadtrum SP9860G 3GFHD Board"; >> > + >> > + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; >> > + >> > + aliases { >> > + serial0 = &uart0; /* for Bluetooth */ >> > + serial1 = &uart1; /* UART console */ >> > + serial2 = &uart2; /* Reserved */ >> > + serial3 = &uart3; /* for GPS */ >> > + }; >> > + >> > + memory{ >> > + device_type = "memory"; >> > + reg = <0x0 0x80000000 0 0x60000000>, >> > + <0x1 0x80000000 0 0x60000000>; >> > + }; >> > + >> > + chosen { >> > + stdout-path = "serial1:115200n8"; >> > + }; >> > + >> > + reserved-memory { >> > + #address-cells = <2>; >> > + #size-cells = <2>; >> > + ranges; >> > + }; >> > +}; >> > + >> > +&uart0 { >> > + status = "okay"; >> > +}; >> > + >> > +&uart1 { >> > + status = "okay"; >> > +}; >> > + >> > +&uart2 { >> > + status = "okay"; >> > +}; >> > + >> > +&uart3 { >> > + status = "okay"; >> > +}; >> > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi >> > new file mode 100644 >> > index 0000000..64f06d9 >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi >> > @@ -0,0 +1,70 @@ >> > +/* >> > + * Spreadtrum Whale2 SoC platform peripherals DTS file >> > + * >> > + * Copyright (C) 2016, Spreadtrum Communications Inc. >> > + * >> > + * This file is licensed under a dual GPLv2 or X11 license. >> > + */ >> > + >> > +/ { >> > + interrupt-parent = <&gic>; >> > + #address-cells = <2>; >> > + #size-cells = <2>; >> > + >> > + soc: soc { >> > + compatible = "simple-bus"; >> > + #address-cells = <2>; >> > + #size-cells = <2>; >> > + ranges; >> > + >> > + ap-apb { >> > + compatible = "simple-bus"; >> > + #address-cells = <1>; >> > + #size-cells = <1>; >> > + ranges = <0 0x0 0x70000000 0x10000000>; >> > + >> > + uart0: serial@70000000 { >> > + compatible = "sprd,sc9838-uart", >> > + "sprd,sc9836-uart"; >> > + reg = <0x000000 0x100>; >> > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; >> > + clocks = <&ext_26m>; >> > + status = "disabled"; >> > + }; >> > + >> > + uart1: serial@70100000 { >> > + compatible = "sprd,sc9838-uart", >> > + "sprd,sc9836-uart"; >> > + reg = <0x100000 0x100>; >> > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; >> > + clocks = <&ext_26m>; >> > + status = "disabled"; >> > + }; >> > + >> > + uart2: serial@70200000 { >> > + compatible = "sprd,sc9838-uart", >> > + "sprd,sc9836-uart"; >> > + reg = <0x200000 0x100>; >> > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; >> > + clocks = <&ext_26m>; >> > + status = "disabled"; >> > + }; >> > + >> > + uart3: serial@70300000 { >> > + compatible = "sprd,sc9838-uart", >> > + "sprd,sc9836-uart"; >> > + reg = <0x300000 0x100>; >> > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; >> > + clocks = <&ext_26m>; >> > + status = "disabled"; >> > + }; >> > + }; >> > + >> > + ext_26m: ext-26m { >> > + compatible = "fixed-clock"; >> > + #clock-cells = <0>; >> > + clock-frequency = <26000000>; >> > + clock-output-names = "ext_26m"; >> > + }; >> > + }; >> > +}; >> > -- >> > 2.7.4 >> > >> > >> > _______________________________________________ >> > linux-arm-kernel mailing list >> > linux-arm-kernel@lists.infradead.org >> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-22 16:02 ` Mathieu Poirier @ 2017-02-23 6:20 ` Chunyan Zhang 2017-02-23 10:56 ` Sudeep Holla 0 siblings, 1 reply; 16+ messages in thread From: Chunyan Zhang @ 2017-02-23 6:20 UTC (permalink / raw) To: Mathieu Poirier Cc: Rob Herring, Mark Rutland, Greg KH, Catalin Marinas, Will Deacon, Arnd Bergmann, devicetree, Orson Zhai, linux-kernel, Sudeep Holla, linux-arm-kernel [...] >>> > + >>> > + soc { >>> > + soc_funnel: funnel@10001000 { >>> >>> There is no need for a label ("soc_funnel) before the device name if that >>> device is not referenced elsewhere in the DTS. The same comment applies to most >>> of the component listed below. >>> >> >> OK, I will remove these labels from this DT. >> And there's another issue I'd like to discuss with you, do you think which way is better: >> 1) use class name which can represent this kind of components as device node name in DT, e.g. >> funnel@... { >> >> } >> replicator@... { >> >> } >> etb@... { >> >> } >> etf@... >> etm@... >> stm@... >> >> 2) use more descriptive device name for those which are more than one on >> a SoC, e.g. >> soc-funnel@... { >> >> } >> cluster0-funnel@... { >> >> } >> cluster1-funnel@... { >> >> } >> >> I noticed Juno use the 2), would you suggest that way? > > It is better to describe the HW component themselves rather than where > they are in the topology - the address of the component will make sure > the names are unique. So just the component type (etm, funnel, > replicator, ....) and the address they are located at. > OK. And to avoid making other person confused in the future, is it better to revise juno-base.dtsi according to this convention? Thanks, Chunyan >> >> Thanks, >> Chunyan >> >>> > + compatible = "arm,coresight-funnel", "arm,primecell"; >>> > + reg = <0 0x10001000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + ports { >>> > + #address-cells = <1>; >>> > + #size-cells = <0>; >>> > + >>> > + port@0 { >>> > + reg = <0>; >>> > + soc_funnel_out_port: endpoint { >>> > + remote-endpoint = <&etb_in>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + reg = <0>; >>> > + soc_funnel_in_port: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&main_funnel_out_port>; >>> > + }; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etb@10003000 { >>> > + compatible = "arm,coresight-tmc", "arm,primecell"; >>> > + reg = <0 0x10003000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + port { >>> > + etb_in: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&soc_funnel_out_port>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + cluster0_funnel: funnel@11001000 { >>> > + compatible = "arm,coresight-funnel", "arm,primecell"; >>> > + reg = <0 0x11001000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + ports { >>> > + #address-cells = <1>; >>> > + #size-cells = <0>; >>> > + >>> > + port@0 { >>> > + reg = <0>; >>> > + cluster0_funnel_out_port: endpoint { >>> > + remote-endpoint = >>> > + <&cluster0_etf_in>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + reg = <0>; >>> > + cluster0_funnel_in_port0: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm0_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@2 { >>> > + reg = <1>; >>> > + cluster0_funnel_in_port1: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm1_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@3 { >>> > + reg = <2>; >>> > + cluster0_funnel_in_port2: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm2_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@4 { >>> > + reg = <4>; >>> > + cluster0_funnel_in_port3: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm3_out>; >>> > + }; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + cluster1_funnel: funnel@11002000 { >>> > + compatible = "arm,coresight-funnel", "arm,primecell"; >>> > + reg = <0 0x11002000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + ports { >>> > + #address-cells = <1>; >>> > + #size-cells = <0>; >>> > + >>> > + port@0 { >>> > + reg = <0>; >>> > + cluster1_funnel_out_port: endpoint { >>> > + remote-endpoint = >>> > + <&cluster1_etf_in>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + reg = <0>; >>> > + cluster1_funnel_in_port0: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm4_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@2 { >>> > + reg = <1>; >>> > + cluster1_funnel_in_port1: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm5_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@3 { >>> > + reg = <2>; >>> > + cluster1_funnel_in_port2: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm6_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@4 { >>> > + reg = <3>; >>> > + cluster1_funnel_in_port3: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = <&etm7_out>; >>> > + }; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + cluster0_etf: etf@11003000 { >>> > + compatible = "arm,coresight-tmc", "arm,primecell"; >>> > + reg = <0 0x11003000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port@0 { >>> > + cluster0_etf_out: endpoint { >>> > + remote-endpoint = >>> > + <&main_funnel_in_port0>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + cluster0_etf_in: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&cluster0_funnel_out_port>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + cluster1_etf: etf@11004000 { >>> > + compatible = "arm,coresight-tmc", "arm,primecell"; >>> > + reg = <0 0x11004000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port@0 { >>> > + cluster1_etf_out: endpoint { >>> > + remote-endpoint = >>> > + <&main_funnel_in_port1>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + cluster1_etf_in: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&cluster1_funnel_out_port>; >>> > + }; >>> > + }; >>> > + }; >>> >>> When more than one port is present it is customary to add another level of >>> imbrication like it is done for funnels above: >>> "ports {" >>> port@0 { >>> ... >>> port@1 { >>> ... >>> } >>> >>> The same comment applies to both etf. >>> >> >> OK. >> >>> > + >>> > + main_funnel: funnel@11005000 { >>> > + compatible = "arm,coresight-funnel", "arm,primecell"; >>> > + reg = <0 0x11005000 0 0x1000>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + ports { >>> > + #address-cells = <1>; >>> > + #size-cells = <0>; >>> > + >>> > + port@0 { >>> > + reg = <0>; >>> > + main_funnel_out_port: endpoint { >>> > + remote-endpoint = >>> > + <&soc_funnel_in_port>; >>> > + }; >>> > + }; >>> > + >>> > + port@1 { >>> > + reg = <0>; >>> > + main_funnel_in_port0: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&cluster0_etf_out>; >>> > + }; >>> > + }; >>> > + >>> > + port@2 { >>> > + reg = <1>; >>> > + main_funnel_in_port1: endpoint { >>> > + slave-mode; >>> > + remote-endpoint = >>> > + <&cluster1_etf_out>; >>> > + }; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11440000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11440000 0 0x1000>; >>> > + cpu = <&CPU0>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm0_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster0_funnel_in_port0>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11540000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11540000 0 0x1000>; >>> > + cpu = <&CPU1>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm1_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster0_funnel_in_port1>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11640000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11640000 0 0x1000>; >>> > + cpu = <&CPU2>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm2_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster0_funnel_in_port2>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11740000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11740000 0 0x1000>; >>> > + cpu = <&CPU3>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm3_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster0_funnel_in_port3>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11840000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11840000 0 0x1000>; >>> > + cpu = <&CPU4>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm4_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster1_funnel_in_port0>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11940000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11940000 0 0x1000>; >>> > + cpu = <&CPU5>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm5_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster1_funnel_in_port1>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11a40000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11a40000 0 0x1000>; >>> > + cpu = <&CPU6>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm6_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster1_funnel_in_port2>; >>> > + }; >>> > + }; >>> > + }; >>> > + >>> > + etm@11b40000 { >>> > + compatible = "arm,coresight-etm4x", "arm,primecell"; >>> > + reg = <0 0x11b40000 0 0x1000>; >>> > + cpu = <&CPU7>; >>> > + clocks = <&ext_26m>; >>> > + clock-names = "apb_pclk"; >>> > + >>> > + port { >>> > + etm7_out: endpoint { >>> > + remote-endpoint = >>> > + <&cluster1_funnel_in_port3>; >>> > + }; >>> > + }; >>> > + }; >>> > + }; >>> > +}; [...] >>> > >>> > _______________________________________________ >>> > linux-arm-kernel mailing list >>> > linux-arm-kernel@lists.infradead.org >>> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-23 6:20 ` Chunyan Zhang @ 2017-02-23 10:56 ` Sudeep Holla 0 siblings, 0 replies; 16+ messages in thread From: Sudeep Holla @ 2017-02-23 10:56 UTC (permalink / raw) To: Chunyan Zhang Cc: Mathieu Poirier, Sudeep Holla, Rob Herring, Mark Rutland, Greg KH, Catalin Marinas, Will Deacon, Arnd Bergmann, devicetree, Orson Zhai, linux-kernel, linux-arm-kernel Hi Chunyan, On 23/02/17 06:20, Chunyan Zhang wrote: [...] >>> I noticed Juno use the 2), would you suggest that way? >> >> It is better to describe the HW component themselves rather than where >> they are in the topology - the address of the component will make sure >> the names are unique. So just the component type (etm, funnel, >> replicator, ....) and the address they are located at. >> > > OK. And to avoid making other person confused in the future, is it > better to revise juno-base.dtsi according to this convention? > Yes, it was noticed by Olof and should be now fixed for v4.11(already queued). You can check linux-next if you want to have a look before it gets merged. -- Regards, Sudeep ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-21 10:57 ` Sudeep Holla 2017-02-21 16:27 ` Mathieu Poirier @ 2017-02-24 0:00 ` Rob Herring 2017-02-24 7:57 ` Chunyan Zhang 2 siblings, 1 reply; 16+ messages in thread From: Rob Herring @ 2017-02-24 0:00 UTC (permalink / raw) To: Chunyan Zhang Cc: Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai(翟京), Sudeep Holla, linux-kernel, devicetree, linux-arm-kernel, Lyra Zhang On Tue, Feb 21, 2017 at 12:55 AM, Chunyan Zhang <chunyan.zhang@spreadtrum.com> wrote: > From: Orson Zhai <orson.zhai@spreadtrum.com> > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > and sp9860g dts is for the board level. > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > arch/arm64/boot/dts/sprd/Makefile | 3 +- > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ > 4 files changed, 659 insertions(+), 1 deletion(-) > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > index b658c5e..f0535e6 100644 > --- a/arch/arm64/boot/dts/sprd/Makefile > +++ b/arch/arm64/boot/dts/sprd/Makefile > @@ -1,4 +1,5 @@ > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > + sp9860g-1h10.dtb > > always := $(dtb-y) > subdir-y := $(dts-dirs) > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > new file mode 100644 > index 0000000..73deb4e > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > @@ -0,0 +1,531 @@ > +/* > + * Spreadtrum SP9860 SoC DTS file > + * > + * Copyright (C) 2016, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. Please use SPDX-License-Identifier tag instead. > + */ > + > +#include <dt-bindings/interrupt-controller/arm-gic.h> > +#include "whale2.dtsi" > + > +/ { > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&CPU0>; > + }; > + core1 { > + cpu = <&CPU1>; > + }; > + core2 { > + cpu = <&CPU2>; > + }; > + core3 { > + cpu = <&CPU3>; > + }; > + }; > + > + cluster1 { > + core0 { > + cpu = <&CPU4>; > + }; > + core1 { > + cpu = <&CPU5>; > + }; > + core2 { > + cpu = <&CPU6>; > + }; > + core3 { > + cpu = <&CPU7>; > + }; > + }; > + }; > + > + CPU0: cpu@530000 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530000>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU1: cpu@530001 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530001>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU2: cpu@530002 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530002>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU3: cpu@530003 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530003>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU4: cpu@530100 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530100>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU5: cpu@530101 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530101>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU6: cpu@530102 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530102>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + > + CPU7: cpu@530103 { > + device_type = "cpu"; > + compatible = "arm,cortex-a53", "arm,armv8"; > + reg = <0x0 0x530103>; > + enable-method = "psci"; > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > + }; > + }; > + > + idle-states{ > + entry-method = "arm,psci"; > + > + CORE_PD: core_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <700>; > + min-residency-us = <2500>; > + local-timer-stop; > + arm,psci-suspend-param = <0x00010002>; > + }; > + > + CLUSTER_PD: cluster_pd { > + compatible = "arm,idle-state"; > + entry-latency-us = <1000>; > + exit-latency-us = <1000>; > + min-residency-us = <3000>; > + local-timer-stop; > + arm,psci-suspend-param = <0x01010003>; > + }; > + }; > + > + gic: interrupt-controller@12001000 { > + compatible = "arm,gic-400"; > + reg = <0 0x12001000 0 0x1000>, > + <0 0x12002000 0 0x2000>, > + <0 0x12004000 0 0x2000>, > + <0 0x12006000 0 0x2000>; > + #interrupt-cells = <3>; > + interrupt-controller; > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + psci { > + compatible = "arm,psci-0.2"; > + method = "smc"; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>, > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > + | IRQ_TYPE_LEVEL_LOW)>; > + }; > + > + pmu { > + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-affinity = <&CPU0>, > + <&CPU1>, > + <&CPU2>, > + <&CPU3>, > + <&CPU4>, > + <&CPU5>, > + <&CPU6>, > + <&CPU7>; > + }; > + > + soc { > + soc_funnel: funnel@10001000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x10001000 0 0x1000>; If all the devices are within 0x1xxxxxxx, then use ranges property to limit the address range. It doesn't look like address or size cells needs to be 2. > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + soc_funnel_out_port: endpoint { > + remote-endpoint = <&etb_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + soc_funnel_in_port: endpoint { > + slave-mode; > + remote-endpoint = > + <&main_funnel_out_port>; > + }; > + }; > + }; > + }; > + > + etb@10003000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x10003000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + port { > + etb_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&soc_funnel_out_port>; > + }; > + }; > + }; > + > + cluster0_funnel: funnel@11001000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11001000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + cluster0_funnel_out_port: endpoint { > + remote-endpoint = > + <&cluster0_etf_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + cluster0_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = <&etm0_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + cluster0_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = <&etm1_out>; > + }; > + }; > + > + port@3 { > + reg = <2>; > + cluster0_funnel_in_port2: endpoint { > + slave-mode; > + remote-endpoint = <&etm2_out>; > + }; > + }; > + > + port@4 { > + reg = <4>; > + cluster0_funnel_in_port3: endpoint { > + slave-mode; > + remote-endpoint = <&etm3_out>; > + }; > + }; > + }; > + }; > + > + cluster1_funnel: funnel@11002000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11002000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + cluster1_funnel_out_port: endpoint { > + remote-endpoint = > + <&cluster1_etf_in>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + cluster1_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = <&etm4_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + cluster1_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = <&etm5_out>; > + }; > + }; > + > + port@3 { > + reg = <2>; > + cluster1_funnel_in_port2: endpoint { > + slave-mode; > + remote-endpoint = <&etm6_out>; > + }; > + }; > + > + port@4 { > + reg = <3>; > + cluster1_funnel_in_port3: endpoint { > + slave-mode; > + remote-endpoint = <&etm7_out>; > + }; > + }; > + }; > + }; > + > + cluster0_etf: etf@11003000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x11003000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port@0 { > + cluster0_etf_out: endpoint { > + remote-endpoint = > + <&main_funnel_in_port0>; > + }; > + }; > + > + port@1 { > + cluster0_etf_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster0_funnel_out_port>; > + }; > + }; > + }; > + > + cluster1_etf: etf@11004000 { > + compatible = "arm,coresight-tmc", "arm,primecell"; > + reg = <0 0x11004000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port@0 { > + cluster1_etf_out: endpoint { > + remote-endpoint = > + <&main_funnel_in_port1>; > + }; > + }; > + > + port@1 { > + cluster1_etf_in: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster1_funnel_out_port>; > + }; > + }; > + }; > + > + main_funnel: funnel@11005000 { > + compatible = "arm,coresight-funnel", "arm,primecell"; > + reg = <0 0x11005000 0 0x1000>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + main_funnel_out_port: endpoint { > + remote-endpoint = > + <&soc_funnel_in_port>; > + }; > + }; > + > + port@1 { > + reg = <0>; > + main_funnel_in_port0: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster0_etf_out>; > + }; > + }; > + > + port@2 { > + reg = <1>; > + main_funnel_in_port1: endpoint { > + slave-mode; > + remote-endpoint = > + <&cluster1_etf_out>; > + }; > + }; > + }; > + }; > + > + etm@11440000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11440000 0 0x1000>; > + cpu = <&CPU0>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm0_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port0>; > + }; > + }; > + }; > + > + etm@11540000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11540000 0 0x1000>; > + cpu = <&CPU1>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm1_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port1>; > + }; > + }; > + }; > + > + etm@11640000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11640000 0 0x1000>; > + cpu = <&CPU2>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm2_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port2>; > + }; > + }; > + }; > + > + etm@11740000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11740000 0 0x1000>; > + cpu = <&CPU3>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm3_out: endpoint { > + remote-endpoint = > + <&cluster0_funnel_in_port3>; > + }; > + }; > + }; > + > + etm@11840000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11840000 0 0x1000>; > + cpu = <&CPU4>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm4_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port0>; > + }; > + }; > + }; > + > + etm@11940000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11940000 0 0x1000>; > + cpu = <&CPU5>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm5_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port1>; > + }; > + }; > + }; > + > + etm@11a40000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11a40000 0 0x1000>; > + cpu = <&CPU6>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm6_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port2>; > + }; > + }; > + }; > + > + etm@11b40000 { > + compatible = "arm,coresight-etm4x", "arm,primecell"; > + reg = <0 0x11b40000 0 0x1000>; > + cpu = <&CPU7>; > + clocks = <&ext_26m>; > + clock-names = "apb_pclk"; > + > + port { > + etm7_out: endpoint { > + remote-endpoint = > + <&cluster1_funnel_in_port3>; > + }; > + }; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > new file mode 100644 > index 0000000..5faa452 > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > @@ -0,0 +1,56 @@ > +/* > + * Spreadtrum SP9860g board DTS file > + * > + * Copyright (C) 2017, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/dts-v1/; > + > +#include "sc9860.dtsi" > + > +/ { > + model = "Spreadtrum SP9860G 3GFHD Board"; > + > + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > + > + aliases { > + serial0 = &uart0; /* for Bluetooth */ > + serial1 = &uart1; /* UART console */ > + serial2 = &uart2; /* Reserved */ > + serial3 = &uart3; /* for GPS */ > + }; > + > + memory{ > + device_type = "memory"; > + reg = <0x0 0x80000000 0 0x60000000>, > + <0x1 0x80000000 0 0x60000000>; > + }; > + > + chosen { > + stdout-path = "serial1:115200n8"; > + }; > + > + reserved-memory { > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + }; > +}; > + > +&uart0 { > + status = "okay"; > +}; > + > +&uart1 { > + status = "okay"; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&uart3 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi > new file mode 100644 > index 0000000..64f06d9 > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi > @@ -0,0 +1,70 @@ > +/* > + * Spreadtrum Whale2 SoC platform peripherals DTS file > + * > + * Copyright (C) 2016, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/ { > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <2>; > + > + soc: soc { > + compatible = "simple-bus"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + > + ap-apb { > + compatible = "simple-bus"; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x70000000 0x10000000>; Probably you should have 2 buses for each range of addresses. > + > + uart0: serial@70000000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x000000 0x100>; > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart1: serial@70100000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x100000 0x100>; > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart2: serial@70200000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x200000 0x100>; > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + > + uart3: serial@70300000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x300000 0x100>; > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; > + }; > + }; > + > + ext_26m: ext-26m { This should be at the top-level. It is not part of the bus. > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <26000000>; > + clock-output-names = "ext_26m"; > + }; > + }; > +}; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-24 0:00 ` Rob Herring @ 2017-02-24 7:57 ` Chunyan Zhang 2017-02-24 15:07 ` Rob Herring 0 siblings, 1 reply; 16+ messages in thread From: Chunyan Zhang @ 2017-02-24 7:57 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai(翟京), Sudeep Holla, linux-kernel, devicetree, linux-arm-kernel, Lyra Zhang On 四, 2月 23, 2017 at 06:00:20下午 -0600, Rob Herring wrote: > On Tue, Feb 21, 2017 at 12:55 AM, Chunyan Zhang > <chunyan.zhang@spreadtrum.com> wrote: > > From: Orson Zhai <orson.zhai@spreadtrum.com> > > > > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. > > > > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC > > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff > > and sp9860g dts is for the board level. > > > > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > > --- > > arch/arm64/boot/dts/sprd/Makefile | 3 +- > > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ > > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ > > 4 files changed, 659 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi > > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi > > > > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile > > index b658c5e..f0535e6 100644 > > --- a/arch/arm64/boot/dts/sprd/Makefile > > +++ b/arch/arm64/boot/dts/sprd/Makefile > > @@ -1,4 +1,5 @@ > > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb > > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ > > + sp9860g-1h10.dtb > > > > always := $(dtb-y) > > subdir-y := $(dts-dirs) > > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > new file mode 100644 > > index 0000000..73deb4e > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi > > @@ -0,0 +1,531 @@ > > +/* > > + * Spreadtrum SP9860 SoC DTS file > > + * > > + * Copyright (C) 2016, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > Please use SPDX-License-Identifier tag instead. > Just to double check, if I use it like: SPDX-License-Identifier: (GPL-2.0 or X11) Is this what you mean? Will this file still be licensed under the same terms it was, right? > > + */ > > + > > +#include <dt-bindings/interrupt-controller/arm-gic.h> > > +#include "whale2.dtsi" > > + > > +/ { > > + cpus { > > + #address-cells = <2>; > > + #size-cells = <0>; > > + > > + cpu-map { > > + cluster0 { > > + core0 { > > + cpu = <&CPU0>; > > + }; > > + core1 { > > + cpu = <&CPU1>; > > + }; > > + core2 { > > + cpu = <&CPU2>; > > + }; > > + core3 { > > + cpu = <&CPU3>; > > + }; > > + }; > > + > > + cluster1 { > > + core0 { > > + cpu = <&CPU4>; > > + }; > > + core1 { > > + cpu = <&CPU5>; > > + }; > > + core2 { > > + cpu = <&CPU6>; > > + }; > > + core3 { > > + cpu = <&CPU7>; > > + }; > > + }; > > + }; > > + > > + CPU0: cpu@530000 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530000>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU1: cpu@530001 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530001>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU2: cpu@530002 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530002>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU3: cpu@530003 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530003>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU4: cpu@530100 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530100>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU5: cpu@530101 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530101>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU6: cpu@530102 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530102>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + > > + CPU7: cpu@530103 { > > + device_type = "cpu"; > > + compatible = "arm,cortex-a53", "arm,armv8"; > > + reg = <0x0 0x530103>; > > + enable-method = "psci"; > > + cpu-idle-states = <&CORE_PD &CLUSTER_PD>; > > + }; > > + }; > > + > > + idle-states{ > > + entry-method = "arm,psci"; > > + > > + CORE_PD: core_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <700>; > > + min-residency-us = <2500>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x00010002>; > > + }; > > + > > + CLUSTER_PD: cluster_pd { > > + compatible = "arm,idle-state"; > > + entry-latency-us = <1000>; > > + exit-latency-us = <1000>; > > + min-residency-us = <3000>; > > + local-timer-stop; > > + arm,psci-suspend-param = <0x01010003>; > > + }; > > + }; > > + > > + gic: interrupt-controller@12001000 { > > + compatible = "arm,gic-400"; > > + reg = <0 0x12001000 0 0x1000>, > > + <0 0x12002000 0 0x2000>, > > + <0 0x12004000 0 0x2000>, > > + <0 0x12006000 0 0x2000>; > > + #interrupt-cells = <3>; > > + interrupt-controller; > > + interrupts = <GIC_PPI 9 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_HIGH)>; > > + }; > > + > > + psci { > > + compatible = "arm,psci-0.2"; > > + method = "smc"; > > + }; > > + > > + timer { > > + compatible = "arm,armv8-timer"; > > + interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 14 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 11 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>, > > + <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(8) > > + | IRQ_TYPE_LEVEL_LOW)>; > > + }; > > + > > + pmu { > > + compatible = "arm,cortex-a53-pmu", "arm,armv8-pmuv3"; > > + interrupts = <GIC_SPI 122 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 124 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 154 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 155 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 156 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-affinity = <&CPU0>, > > + <&CPU1>, > > + <&CPU2>, > > + <&CPU3>, > > + <&CPU4>, > > + <&CPU5>, > > + <&CPU6>, > > + <&CPU7>; > > + }; > > + > > + soc { > > + soc_funnel: funnel@10001000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x10001000 0 0x1000>; > > If all the devices are within 0x1xxxxxxx, then use ranges property to > limit the address range. It doesn't look like address or size cells > needs to be 2. There're some devices not included in this DT for now whose addresses is 64-bit. I will add more devices into this device tree later on. > > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + soc_funnel_out_port: endpoint { > > + remote-endpoint = <&etb_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + soc_funnel_in_port: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&main_funnel_out_port>; > > + }; > > + }; > > + }; > > + }; > > + > > + etb@10003000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x10003000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + port { > > + etb_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&soc_funnel_out_port>; > > + }; > > + }; > > + }; > > + > > + cluster0_funnel: funnel@11001000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11001000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster0_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + cluster0_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm0_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + cluster0_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm1_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <2>; > > + cluster0_funnel_in_port2: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm2_out>; > > + }; > > + }; > > + > > + port@4 { > > + reg = <4>; > > + cluster0_funnel_in_port3: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm3_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + cluster1_funnel: funnel@11002000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11002000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster1_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + cluster1_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm4_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + cluster1_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm5_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <2>; > > + cluster1_funnel_in_port2: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm6_out>; > > + }; > > + }; > > + > > + port@4 { > > + reg = <3>; > > + cluster1_funnel_in_port3: endpoint { > > + slave-mode; > > + remote-endpoint = <&etm7_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + cluster0_etf: etf@11003000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x11003000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port@0 { > > + cluster0_etf_out: endpoint { > > + remote-endpoint = > > + <&main_funnel_in_port0>; > > + }; > > + }; > > + > > + port@1 { > > + cluster0_etf_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster0_funnel_out_port>; > > + }; > > + }; > > + }; > > + > > + cluster1_etf: etf@11004000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0x11004000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port@0 { > > + cluster1_etf_out: endpoint { > > + remote-endpoint = > > + <&main_funnel_in_port1>; > > + }; > > + }; > > + > > + port@1 { > > + cluster1_etf_in: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster1_funnel_out_port>; > > + }; > > + }; > > + }; > > + > > + main_funnel: funnel@11005000 { > > + compatible = "arm,coresight-funnel", "arm,primecell"; > > + reg = <0 0x11005000 0 0x1000>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + main_funnel_out_port: endpoint { > > + remote-endpoint = > > + <&soc_funnel_in_port>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <0>; > > + main_funnel_in_port0: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster0_etf_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <1>; > > + main_funnel_in_port1: endpoint { > > + slave-mode; > > + remote-endpoint = > > + <&cluster1_etf_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@11440000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11440000 0 0x1000>; > > + cpu = <&CPU0>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm0_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port0>; > > + }; > > + }; > > + }; > > + > > + etm@11540000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11540000 0 0x1000>; > > + cpu = <&CPU1>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm1_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port1>; > > + }; > > + }; > > + }; > > + > > + etm@11640000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11640000 0 0x1000>; > > + cpu = <&CPU2>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm2_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port2>; > > + }; > > + }; > > + }; > > + > > + etm@11740000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11740000 0 0x1000>; > > + cpu = <&CPU3>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm3_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in_port3>; > > + }; > > + }; > > + }; > > + > > + etm@11840000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11840000 0 0x1000>; > > + cpu = <&CPU4>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm4_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port0>; > > + }; > > + }; > > + }; > > + > > + etm@11940000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11940000 0 0x1000>; > > + cpu = <&CPU5>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm5_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port1>; > > + }; > > + }; > > + }; > > + > > + etm@11a40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11a40000 0 0x1000>; > > + cpu = <&CPU6>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm6_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port2>; > > + }; > > + }; > > + }; > > + > > + etm@11b40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0x11b40000 0 0x1000>; > > + cpu = <&CPU7>; > > + clocks = <&ext_26m>; > > + clock-names = "apb_pclk"; > > + > > + port { > > + etm7_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in_port3>; > > + }; > > + }; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > new file mode 100644 > > index 0000000..5faa452 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > > @@ -0,0 +1,56 @@ > > +/* > > + * Spreadtrum SP9860g board DTS file > > + * > > + * Copyright (C) 2017, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/dts-v1/; > > + > > +#include "sc9860.dtsi" > > + > > +/ { > > + model = "Spreadtrum SP9860G 3GFHD Board"; > > + > > + compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > > + > > + aliases { > > + serial0 = &uart0; /* for Bluetooth */ > > + serial1 = &uart1; /* UART console */ > > + serial2 = &uart2; /* Reserved */ > > + serial3 = &uart3; /* for GPS */ > > + }; > > + > > + memory{ > > + device_type = "memory"; > > + reg = <0x0 0x80000000 0 0x60000000>, > > + <0x1 0x80000000 0 0x60000000>; > > + }; > > + > > + chosen { > > + stdout-path = "serial1:115200n8"; > > + }; > > + > > + reserved-memory { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + }; > > +}; > > + > > +&uart0 { > > + status = "okay"; > > +}; > > + > > +&uart1 { > > + status = "okay"; > > +}; > > + > > +&uart2 { > > + status = "okay"; > > +}; > > + > > +&uart3 { > > + status = "okay"; > > +}; > > diff --git a/arch/arm64/boot/dts/sprd/whale2.dtsi b/arch/arm64/boot/dts/sprd/whale2.dtsi > > new file mode 100644 > > index 0000000..64f06d9 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sprd/whale2.dtsi > > @@ -0,0 +1,70 @@ > > +/* > > + * Spreadtrum Whale2 SoC platform peripherals DTS file > > + * > > + * Copyright (C) 2016, Spreadtrum Communications Inc. > > + * > > + * This file is licensed under a dual GPLv2 or X11 license. > > + */ > > + > > +/ { > > + interrupt-parent = <&gic>; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + soc: soc { > > + compatible = "simple-bus"; > > + #address-cells = <2>; > > + #size-cells = <2>; > > + ranges; > > + > > + ap-apb { > > + compatible = "simple-bus"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x0 0x70000000 0x10000000>; > > Probably you should have 2 buses for each range of addresses. I may not understand your point, I just looked at the SoC specification, the address range of this AP APB bus is from 0x70000000 ~ 0x7fffffff. > > > + > > + uart0: serial@70000000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x000000 0x100>; > > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart1: serial@70100000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x100000 0x100>; > > + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart2: serial@70200000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x200000 0x100>; > > + interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + > > + uart3: serial@70300000 { > > + compatible = "sprd,sc9838-uart", > > + "sprd,sc9836-uart"; > > + reg = <0x300000 0x100>; > > + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&ext_26m>; > > + status = "disabled"; > > + }; > > + }; > > + > > + ext_26m: ext-26m { > > This should be at the top-level. It is not part of the bus. This clock node is in 'soc' node, not under 'ap-apb'. Since there're other clocks on SC9860 which would have 'reg' property, we thought this fixed clock would be better under 'soc' with other clocks. Thanks your comments, Chunyan > > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <26000000>; > > + clock-output-names = "ext_26m"; > > + }; > > + }; > > +}; > > -- > > 2.7.4 > > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-24 7:57 ` Chunyan Zhang @ 2017-02-24 15:07 ` Rob Herring 2017-02-28 7:08 ` Chunyan Zhang 0 siblings, 1 reply; 16+ messages in thread From: Rob Herring @ 2017-02-24 15:07 UTC (permalink / raw) To: Rob Herring, Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai(翟京), Sudeep Holla, linux-kernel, devicetree, linux-arm-kernel, Lyra Zhang On Fri, Feb 24, 2017 at 1:57 AM, Chunyan Zhang <chunyan.zhang@spreadtrum.com> wrote: > On 四, 2月 23, 2017 at 06:00:20下午 -0600, Rob Herring wrote: >> On Tue, Feb 21, 2017 at 12:55 AM, Chunyan Zhang >> <chunyan.zhang@spreadtrum.com> wrote: >> > From: Orson Zhai <orson.zhai@spreadtrum.com> >> > >> > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. >> > >> > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC >> > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff >> > and sp9860g dts is for the board level. >> > >> > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> >> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> >> > --- >> > arch/arm64/boot/dts/sprd/Makefile | 3 +- >> > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ >> > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ >> > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ >> > 4 files changed, 659 insertions(+), 1 deletion(-) >> > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi >> > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts >> > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi >> > >> > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile >> > index b658c5e..f0535e6 100644 >> > --- a/arch/arm64/boot/dts/sprd/Makefile >> > +++ b/arch/arm64/boot/dts/sprd/Makefile >> > @@ -1,4 +1,5 @@ >> > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb >> > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ >> > + sp9860g-1h10.dtb >> > >> > always := $(dtb-y) >> > subdir-y := $(dts-dirs) >> > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi >> > new file mode 100644 >> > index 0000000..73deb4e >> > --- /dev/null >> > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi >> > @@ -0,0 +1,531 @@ >> > +/* >> > + * Spreadtrum SP9860 SoC DTS file >> > + * >> > + * Copyright (C) 2016, Spreadtrum Communications Inc. >> > + * >> > + * This file is licensed under a dual GPLv2 or X11 license. >> >> Please use SPDX-License-Identifier tag instead. >> > > Just to double check, if I use it like: > > SPDX-License-Identifier: (GPL-2.0 or X11) > > Is this what you mean? Yes. However, X11 is not actually correct (pretty much all dts files have it wrong). This is the X11 license[1] which is explicitly for the X Consortium and has a couple of extra clauses. While the MIT license[2] is the text that most dts files actually use (while also stating X11 license). It's obvious that everyone just copies and pastes the license and has not consulted their lawyers. > Will this file still be licensed under the same terms it was, right? Consult your lawyer. :) [...] >> > + ext_26m: ext-26m { >> >> This should be at the top-level. It is not part of the bus. > > This clock node is in 'soc' node, not under 'ap-apb'. Since there're other > clocks on SC9860 which would have 'reg' property, we thought this fixed > clock would be better under 'soc' with other clocks. But the clock is part of the board, not the soc. Or to put it another way, it's not related to anything else, so it shouldn't be a child of anything. Rob [1] https://spdx.org/licenses/X11.html [2] https://spdx.org/licenses/MIT.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G 2017-02-24 15:07 ` Rob Herring @ 2017-02-28 7:08 ` Chunyan Zhang 0 siblings, 0 replies; 16+ messages in thread From: Chunyan Zhang @ 2017-02-28 7:08 UTC (permalink / raw) To: Rob Herring Cc: Mark Rutland, Greg Kroah-Hartman, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai(翟京), Sudeep Holla, linux-kernel, devicetree, linux-arm-kernel On 24 February 2017 at 23:07, Rob Herring <robh+dt@kernel.org> wrote: > On Fri, Feb 24, 2017 at 1:57 AM, Chunyan Zhang > <chunyan.zhang@spreadtrum.com> wrote: >> On 四, 2月 23, 2017 at 06:00:20下午 -0600, Rob Herring wrote: >>> On Tue, Feb 21, 2017 at 12:55 AM, Chunyan Zhang >>> <chunyan.zhang@spreadtrum.com> wrote: >>> > From: Orson Zhai <orson.zhai@spreadtrum.com> >>> > >>> > SC9860G is a 8 cores of A53 SoC with 4G LTE support SoC from Spreadtrum. >>> > >>> > According to regular hierarchy of sprd dts, whale2.dtsi contains SoC >>> > peripherals IP nodes, sc9860.dtsi contains stuff related to ARM core stuff >>> > and sp9860g dts is for the board level. >>> > >>> > Signed-off-by: Orson Zhai <orson.zhai@spreadtrum.com> >>> > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> >>> > --- >>> > arch/arm64/boot/dts/sprd/Makefile | 3 +- >>> > arch/arm64/boot/dts/sprd/sc9860.dtsi | 531 ++++++++++++++++++++++++++++++ >>> > arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 56 ++++ >>> > arch/arm64/boot/dts/sprd/whale2.dtsi | 70 ++++ >>> > 4 files changed, 659 insertions(+), 1 deletion(-) >>> > create mode 100644 arch/arm64/boot/dts/sprd/sc9860.dtsi >>> > create mode 100644 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts >>> > create mode 100644 arch/arm64/boot/dts/sprd/whale2.dtsi >>> > >>> > diff --git a/arch/arm64/boot/dts/sprd/Makefile b/arch/arm64/boot/dts/sprd/Makefile >>> > index b658c5e..f0535e6 100644 >>> > --- a/arch/arm64/boot/dts/sprd/Makefile >>> > +++ b/arch/arm64/boot/dts/sprd/Makefile >>> > @@ -1,4 +1,5 @@ >>> > -dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb >>> > +dtb-$(CONFIG_ARCH_SPRD) += sc9836-openphone.dtb \ >>> > + sp9860g-1h10.dtb >>> > >>> > always := $(dtb-y) >>> > subdir-y := $(dts-dirs) >>> > diff --git a/arch/arm64/boot/dts/sprd/sc9860.dtsi b/arch/arm64/boot/dts/sprd/sc9860.dtsi >>> > new file mode 100644 >>> > index 0000000..73deb4e >>> > --- /dev/null >>> > +++ b/arch/arm64/boot/dts/sprd/sc9860.dtsi >>> > @@ -0,0 +1,531 @@ >>> > +/* >>> > + * Spreadtrum SP9860 SoC DTS file >>> > + * >>> > + * Copyright (C) 2016, Spreadtrum Communications Inc. >>> > + * >>> > + * This file is licensed under a dual GPLv2 or X11 license. >>> >>> Please use SPDX-License-Identifier tag instead. >>> >> >> Just to double check, if I use it like: >> >> SPDX-License-Identifier: (GPL-2.0 or X11) >> >> Is this what you mean? > > Yes. However, X11 is not actually correct (pretty much all dts files > have it wrong). This is the X11 license[1] which is explicitly for the > X Consortium and has a couple of extra clauses. While the MIT > license[2] is the text that most dts files actually use (while also > stating X11 license). It's obvious that everyone just copies and > pastes the license and has not consulted their lawyers. OK, got it. > >> Will this file still be licensed under the same terms it was, right? > > Consult your lawyer. :) > > [...] > >>> > + ext_26m: ext-26m { >>> >>> This should be at the top-level. It is not part of the bus. >> >> This clock node is in 'soc' node, not under 'ap-apb'. Since there're other >> clocks on SC9860 which would have 'reg' property, we thought this fixed >> clock would be better under 'soc' with other clocks. > > But the clock is part of the board, not the soc. Or to put it another > way, it's not related to anything else, so it shouldn't be a child of > anything. Ok, I will move it to the top-level. Thanks, Chunyan > > Rob > > [1] https://spdx.org/licenses/X11.html > [2] https://spdx.org/licenses/MIT.html ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G 2017-02-21 6:55 [PATCH V2 0/3] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang @ 2017-02-21 6:55 ` Chunyan Zhang 2017-02-27 19:56 ` Rob Herring 2017-02-21 6:55 ` [PATCH V2 3/3] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang 2 siblings, 1 reply; 16+ messages in thread From: Chunyan Zhang @ 2017-02-21 6:55 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, sudeep.holla, linux-kernel, devicetree, linux-arm-kernel, zhang.lyra Added support for Spreadtrum SP9860G board and SC9860 SoC. This patch also revised bindings of SC9836 to make the format more clear. Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- Documentation/devicetree/bindings/arm/sprd.txt | 13 ++++++++----- Documentation/devicetree/bindings/serial/sprd-uart.txt | 16 +++++++++++++++- 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt index 31a629d..3df034b 100644 --- a/Documentation/devicetree/bindings/arm/sprd.txt +++ b/Documentation/devicetree/bindings/arm/sprd.txt @@ -1,11 +1,14 @@ Spreadtrum SoC Platforms Device Tree Bindings ---------------------------------------------------- -Sharkl64 is a Spreadtrum's SoC Platform which is based -on ARM 64-bit processor. +SC9836 openphone Board +Required root node properties: + - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; -SC9836 openphone board with SC9836 SoC based on the -Sharkl64 Platform shall have the following properties. +SC9860 SoC +Required root node properties: + - compatible = "sprd,sc9860" +SP9860G 3GFHD Board Required root node properties: - - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; + - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt index 2aff0f2..f530cbb 100644 --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt @@ -1,7 +1,21 @@ * Spreadtrum serial UART Required properties: -- compatible: must be "sprd,sc9836-uart" +- compatible must contain: + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs + This also can be specific with: + * "sprd, sc9860-uart" for SC9860 + - reg: offset and length of the register set for the device - interrupts: exactly one interrupt specifier - clocks: phandles to input clocks. + +Example: + uart0: serial@70000000 { + compatible = "sprd,sc9838-uart", + "sprd,sc9836-uart"; + reg = <0x000000 0x100>; + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ext_26m>; + status = "disabled"; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G 2017-02-21 6:55 ` [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang @ 2017-02-27 19:56 ` Rob Herring 2017-02-28 9:14 ` Chunyan Zhang 0 siblings, 1 reply; 16+ messages in thread From: Rob Herring @ 2017-02-27 19:56 UTC (permalink / raw) To: Chunyan Zhang Cc: mark.rutland, gregkh, catalin.marinas, will.deacon, arnd, orson.zhai, sudeep.holla, linux-kernel, devicetree, linux-arm-kernel, zhang.lyra On Tue, Feb 21, 2017 at 02:55:03PM +0800, Chunyan Zhang wrote: > Added support for Spreadtrum SP9860G board and SC9860 SoC. > This patch also revised bindings of SC9836 to make the format > more clear. > > Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> > --- > Documentation/devicetree/bindings/arm/sprd.txt | 13 ++++++++----- > Documentation/devicetree/bindings/serial/sprd-uart.txt | 16 +++++++++++++++- Probably should be 2 commits. "dt-bindings: (arm|serial): " is the preferred subject prefix. > 2 files changed, 23 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt > index 31a629d..3df034b 100644 > --- a/Documentation/devicetree/bindings/arm/sprd.txt > +++ b/Documentation/devicetree/bindings/arm/sprd.txt > @@ -1,11 +1,14 @@ > Spreadtrum SoC Platforms Device Tree Bindings > ---------------------------------------------------- > > -Sharkl64 is a Spreadtrum's SoC Platform which is based > -on ARM 64-bit processor. > +SC9836 openphone Board > +Required root node properties: > + - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; > > -SC9836 openphone board with SC9836 SoC based on the > -Sharkl64 Platform shall have the following properties. > +SC9860 SoC > +Required root node properties: > + - compatible = "sprd,sc9860" > > +SP9860G 3GFHD Board > Required root node properties: > - - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; > + - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; > diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt > index 2aff0f2..f530cbb 100644 > --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt > +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt > @@ -1,7 +1,21 @@ > * Spreadtrum serial UART > > Required properties: > -- compatible: must be "sprd,sc9836-uart" > +- compatible must contain: > + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs > + This also can be specific with: > + * "sprd, sc9860-uart" for SC9860 space ^ > + > - reg: offset and length of the register set for the device > - interrupts: exactly one interrupt specifier > - clocks: phandles to input clocks. > + > +Example: > + uart0: serial@70000000 { > + compatible = "sprd,sc9838-uart", > + "sprd,sc9836-uart"; > + reg = <0x000000 0x100>; > + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&ext_26m>; > + status = "disabled"; No need for status in examples. > + }; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G 2017-02-27 19:56 ` Rob Herring @ 2017-02-28 9:14 ` Chunyan Zhang 0 siblings, 0 replies; 16+ messages in thread From: Chunyan Zhang @ 2017-02-28 9:14 UTC (permalink / raw) To: Rob Herring Cc: Chunyan Zhang, Mark Rutland, gregkh, Catalin Marinas, Will Deacon, Arnd Bergmann, Orson Zhai (翟京), Sudeep Holla, linux-kernel, devicetree, linux-arm-kernel On 28 February 2017 at 03:56, Rob Herring <robh@kernel.org> wrote: > On Tue, Feb 21, 2017 at 02:55:03PM +0800, Chunyan Zhang wrote: >> Added support for Spreadtrum SP9860G board and SC9860 SoC. >> This patch also revised bindings of SC9836 to make the format >> more clear. >> >> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> >> --- >> Documentation/devicetree/bindings/arm/sprd.txt | 13 ++++++++----- >> Documentation/devicetree/bindings/serial/sprd-uart.txt | 16 +++++++++++++++- > > Probably should be 2 commits. > > "dt-bindings: (arm|serial): " is the preferred subject prefix. Ok, will do. Thanks, Chunyan > >> 2 files changed, 23 insertions(+), 6 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt >> index 31a629d..3df034b 100644 >> --- a/Documentation/devicetree/bindings/arm/sprd.txt >> +++ b/Documentation/devicetree/bindings/arm/sprd.txt >> @@ -1,11 +1,14 @@ >> Spreadtrum SoC Platforms Device Tree Bindings >> ---------------------------------------------------- >> >> -Sharkl64 is a Spreadtrum's SoC Platform which is based >> -on ARM 64-bit processor. >> +SC9836 openphone Board >> +Required root node properties: >> + - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; >> >> -SC9836 openphone board with SC9836 SoC based on the >> -Sharkl64 Platform shall have the following properties. >> +SC9860 SoC >> +Required root node properties: >> + - compatible = "sprd,sc9860" >> >> +SP9860G 3GFHD Board >> Required root node properties: >> - - compatible = "sprd,sc9836-openphone", "sprd,sc9836"; >> + - compatible = "sprd,sp9860g-1h10", "sprd,sc9860"; >> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> index 2aff0f2..f530cbb 100644 >> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt >> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt >> @@ -1,7 +1,21 @@ >> * Spreadtrum serial UART >> >> Required properties: >> -- compatible: must be "sprd,sc9836-uart" >> +- compatible must contain: >> + * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs >> + This also can be specific with: >> + * "sprd, sc9860-uart" for SC9860 > space ^ > >> + >> - reg: offset and length of the register set for the device >> - interrupts: exactly one interrupt specifier >> - clocks: phandles to input clocks. >> + >> +Example: >> + uart0: serial@70000000 { >> + compatible = "sprd,sc9838-uart", >> + "sprd,sc9836-uart"; >> + reg = <0x000000 0x100>; >> + interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>; >> + clocks = <&ext_26m>; >> + status = "disabled"; > > No need for status in examples. > >> + }; >> -- >> 2.7.4 >> ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH V2 3/3] serial: sprd: adjust TIMEOUT to a big value 2017-02-21 6:55 [PATCH V2 0/3] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang @ 2017-02-21 6:55 ` Chunyan Zhang 2 siblings, 0 replies; 16+ messages in thread From: Chunyan Zhang @ 2017-02-21 6:55 UTC (permalink / raw) To: robh+dt, mark.rutland, gregkh, catalin.marinas, will.deacon, arnd Cc: orson.zhai, sudeep.holla, linux-kernel, devicetree, linux-arm-kernel, zhang.lyra From: Wei Qiao <wei.qiao@spreadtrum.com> SPRD_TIMEOUT was 256, which is too small to wait until the status switched to workable in a while loop, so that the earlycon could not work correctly. Signed-off-by: Wei Qiao <wei.qiao@spreadtrum.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com> --- drivers/tty/serial/sprd_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c index 699447a..cc1a55e 100644 --- a/drivers/tty/serial/sprd_serial.c +++ b/drivers/tty/serial/sprd_serial.c @@ -36,7 +36,7 @@ #define SPRD_FIFO_SIZE 128 #define SPRD_DEF_RATE 26000000 #define SPRD_BAUD_IO_LIMIT 3000000 -#define SPRD_TIMEOUT 256 +#define SPRD_TIMEOUT 256000 /* the offset of serial registers and BITs for them */ /* data registers */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-02-28 10:23 UTC | newest] Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-02-21 6:55 [PATCH V2 0/3] Add Spreadtrum SP9860G support Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 1/3] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang 2017-02-21 10:57 ` Sudeep Holla 2017-02-21 16:27 ` Mathieu Poirier 2017-02-22 3:46 ` Chunyan Zhang 2017-02-22 16:02 ` Mathieu Poirier 2017-02-23 6:20 ` Chunyan Zhang 2017-02-23 10:56 ` Sudeep Holla 2017-02-24 0:00 ` Rob Herring 2017-02-24 7:57 ` Chunyan Zhang 2017-02-24 15:07 ` Rob Herring 2017-02-28 7:08 ` Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang 2017-02-27 19:56 ` Rob Herring 2017-02-28 9:14 ` Chunyan Zhang 2017-02-21 6:55 ` [PATCH V2 3/3] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).