* [PATCH] dt-bindings: pwm: fix nodename pattern
@ 2019-12-11 15:00 Benjamin Gaignard
2019-12-11 19:52 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Gaignard @ 2019-12-11 15:00 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, robh+dt, mark.rutland
Cc: linux-pwm, devicetree, linux-kernel, Benjamin Gaignard
Typical pwm nodes should be named pwm@xxx.
The pattern shouldn't match nodes named pwm-xxx to avoid
conflicts with pinmux or pwm-fan nodes.
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
index fa4f9de92090..29b86886c282 100644
--- a/Documentation/devicetree/bindings/pwm/pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
@@ -11,7 +11,7 @@ maintainers:
properties:
$nodename:
- pattern: "^pwm(@.*|-[0-9a-f])*$"
+ pattern: "^pwm(@.*[0-9a-f])*$"
"#pwm-cells":
description:
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pwm: fix nodename pattern
2019-12-11 15:00 [PATCH] dt-bindings: pwm: fix nodename pattern Benjamin Gaignard
@ 2019-12-11 19:52 ` Rob Herring
2019-12-12 8:16 ` Benjamin GAIGNARD
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-12-11 19:52 UTC (permalink / raw)
To: Benjamin Gaignard
Cc: Thierry Reding, Uwe Kleine-König, Mark Rutland,
Linux PWM List, devicetree, linux-kernel
On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
<benjamin.gaignard@st.com> wrote:
>
> Typical pwm nodes should be named pwm@xxx.
> The pattern shouldn't match nodes named pwm-xxx to avoid
> conflicts with pinmux or pwm-fan nodes.
It only matches pwm-$(a-hex-number), not any string, so that shouldn't
be a problem. This is needed for things like GPIO based devices (not
just PWMs) which don't have any address.
Pinmux nodes are going to need to adopt some sort of standard pattern
we can match on.
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
> index fa4f9de92090..29b86886c282 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
> @@ -11,7 +11,7 @@ maintainers:
>
> properties:
> $nodename:
> - pattern: "^pwm(@.*|-[0-9a-f])*$"
> + pattern: "^pwm(@.*[0-9a-f])*$"
>
> "#pwm-cells":
> description:
> --
> 2.15.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pwm: fix nodename pattern
2019-12-11 19:52 ` Rob Herring
@ 2019-12-12 8:16 ` Benjamin GAIGNARD
2019-12-12 19:07 ` Rob Herring
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin GAIGNARD @ 2019-12-12 8:16 UTC (permalink / raw)
To: Rob Herring
Cc: Thierry Reding, Uwe Kleine-König, Mark Rutland,
Linux PWM List, devicetree, linux-kernel
On 12/11/19 8:52 PM, Rob Herring wrote:
> On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
> <benjamin.gaignard@st.com> wrote:
>> Typical pwm nodes should be named pwm@xxx.
>> The pattern shouldn't match nodes named pwm-xxx to avoid
>> conflicts with pinmux or pwm-fan nodes.
> It only matches pwm-$(a-hex-number), not any string, so that shouldn't
> be a problem. This is needed for things like GPIO based devices (not
> just PWMs) which don't have any address.
>
> Pinmux nodes are going to need to adopt some sort of standard pattern
> we can match on.
I have push a patch to stop using '@' and '_' in pinmux groups names:
https://lore.kernel.org/patchwork/patch/1162591/
It remove the warnings when compiling the devicetre with W=12 but pwm.yaml
complain because pwm pinmux is named pwm-1.
How can I solve these issues at the same time ?
Benjamin
>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>> ---
>> Documentation/devicetree/bindings/pwm/pwm.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm.yaml b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> index fa4f9de92090..29b86886c282 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm.yaml
>> @@ -11,7 +11,7 @@ maintainers:
>>
>> properties:
>> $nodename:
>> - pattern: "^pwm(@.*|-[0-9a-f])*$"
>> + pattern: "^pwm(@.*[0-9a-f])*$"
>>
>> "#pwm-cells":
>> description:
>> --
>> 2.15.0
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pwm: fix nodename pattern
2019-12-12 8:16 ` Benjamin GAIGNARD
@ 2019-12-12 19:07 ` Rob Herring
2019-12-13 11:09 ` Benjamin GAIGNARD
0 siblings, 1 reply; 5+ messages in thread
From: Rob Herring @ 2019-12-12 19:07 UTC (permalink / raw)
To: Benjamin GAIGNARD
Cc: Thierry Reding, Uwe Kleine-König, Mark Rutland,
Linux PWM List, devicetree, linux-kernel
On Thu, Dec 12, 2019 at 2:16 AM Benjamin GAIGNARD
<benjamin.gaignard@st.com> wrote:
>
>
> On 12/11/19 8:52 PM, Rob Herring wrote:
> > On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
> > <benjamin.gaignard@st.com> wrote:
> >> Typical pwm nodes should be named pwm@xxx.
> >> The pattern shouldn't match nodes named pwm-xxx to avoid
> >> conflicts with pinmux or pwm-fan nodes.
> > It only matches pwm-$(a-hex-number), not any string, so that shouldn't
> > be a problem. This is needed for things like GPIO based devices (not
> > just PWMs) which don't have any address.
> >
> > Pinmux nodes are going to need to adopt some sort of standard pattern
> > we can match on.
> I have push a patch to stop using '@' and '_' in pinmux groups names:
> https://lore.kernel.org/patchwork/patch/1162591/
> It remove the warnings when compiling the devicetre with W=12 but pwm.yaml
> complain because pwm pinmux is named pwm-1.
>
> How can I solve these issues at the same time ?
Name the nodes *-pins or *-pins-[0-9]. You're probably going to need
some pattern anyways when you do a pinmux schema.
Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: pwm: fix nodename pattern
2019-12-12 19:07 ` Rob Herring
@ 2019-12-13 11:09 ` Benjamin GAIGNARD
0 siblings, 0 replies; 5+ messages in thread
From: Benjamin GAIGNARD @ 2019-12-13 11:09 UTC (permalink / raw)
To: Rob Herring, Alexandre TORGUE
Cc: Thierry Reding, Uwe Kleine-König, Mark Rutland,
Linux PWM List, devicetree, linux-kernel
On 12/12/19 8:07 PM, Rob Herring wrote:
> On Thu, Dec 12, 2019 at 2:16 AM Benjamin GAIGNARD
> <benjamin.gaignard@st.com> wrote:
>>
>> On 12/11/19 8:52 PM, Rob Herring wrote:
>>> On Wed, Dec 11, 2019 at 9:00 AM Benjamin Gaignard
>>> <benjamin.gaignard@st.com> wrote:
>>>> Typical pwm nodes should be named pwm@xxx.
>>>> The pattern shouldn't match nodes named pwm-xxx to avoid
>>>> conflicts with pinmux or pwm-fan nodes.
>>> It only matches pwm-$(a-hex-number), not any string, so that shouldn't
>>> be a problem. This is needed for things like GPIO based devices (not
>>> just PWMs) which don't have any address.
>>>
>>> Pinmux nodes are going to need to adopt some sort of standard pattern
>>> we can match on.
>> I have push a patch to stop using '@' and '_' in pinmux groups names:
>> https://lore.kernel.org/patchwork/patch/1162591/
>> It remove the warnings when compiling the devicetre with W=12 but pwm.yaml
>> complain because pwm pinmux is named pwm-1.
>>
>> How can I solve these issues at the same time ?
> Name the nodes *-pins or *-pins-[0-9]. You're probably going to need
> some pattern anyways when you do a pinmux schema.
+ Alex because that impact pin node pattern in st,stm32-pinctrl.yaml
Benjamin
> Rob
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-13 20:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 15:00 [PATCH] dt-bindings: pwm: fix nodename pattern Benjamin Gaignard
2019-12-11 19:52 ` Rob Herring
2019-12-12 8:16 ` Benjamin GAIGNARD
2019-12-12 19:07 ` Rob Herring
2019-12-13 11:09 ` Benjamin GAIGNARD
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).