Re: [PATCH 02/31] nds32: Kernel booting and initialization

[Rob Herring <robh+dt@kernel.org>]

On Tue, Nov 7, 2017 at 11:54 PM, Greentime Hu <green.hu@gmail.com> wrote:
> From: Greentime Hu <greentime@andestech.com>
>

Commit message needed.

> Signed-off-by: Vincent Chen <vincentc@andestech.com>
> Signed-off-by: Greentime Hu <greentime@andestech.com>
> ---

> +       /* it could update max_pfn */
> +       if (max_pfn - ram_start_pfn <= MAXMEM_PFN)
> +               max_low_pfn = max_pfn;
> +       else {
> +               max_low_pfn = MAXMEM_PFN + ram_start_pfn;
> +#ifndef CONFIG_HIGHMEM

Use IS_ENABLED here and other ifdef's if possible.

> +               max_pfn = MAXMEM_PFN + ram_start_pfn;
> +#endif
> +       }


> +static int __init nds32_device_probe(void)
> +{
> +       return of_platform_populate(NULL, NULL, NULL, NULL);
> +}
> +
> +device_initcall(nds32_device_probe);

You can drop this. The core code will call of_platform_populate for you.