From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: jmondi <jacopo@jmondi.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Chris Brandt <Chris.Brandt@renesas.com>,
Jacopo Mondi <jacopo+renesas@jmondi.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable
Date: Fri, 12 May 2017 13:11:52 +0200 [thread overview]
Message-ID: <CAMuHMdXK7YB2zN4fz9XiqTuydxp7VvVV+wSgXWUYBB0evkp8dw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYsE1oeDp1HnYAFMKG2iPTg06cAtD41vxrmZPP70MJQdA@mail.gmail.com>
Hi Linus,
On Fri, May 12, 2017 at 11:04 AM, Linus Walleij
<linus.walleij@linaro.org> wrote:
> On Tue, May 9, 2017 at 12:54 PM, Geert Uytterhoeven
> <geert@linux-m68k.org> wrote:
>
> Oops missed this:
>
>> Hence I think we should not use generic pin properties, but consider these
>> settings to be part of pinmux configuration.
>> As having large tables in the driver is undesirable, I think storing the
>> settings in the "pinmux" property (by encoding them as flags passed to the
>> RZA1_PINMUX() macro) is our best option.
>
> I think it is better to have large tables in the driver in this case.
Jacopo, Chris: Would two bits per pin/function (none, input, output, bidir)
be sufficient?
That makes one u16 per pin. So roughtly 12 ports x 16 pins => 384 bytes.
Plus code to handle it. After all not that bad...
> It is the lesser evil.
>
> Having unintelligible and hard to grasp stuff in the device tree that
> no user will understand or dare to touch is not good, then it is better
> to have it with the code, where it is being used, so the developers of
> the driver can see it when they are dealing with this (quirky) hardware.
>
> As you say this is actually fixing hardware bugs, we can expect these
> quirky tables to be gone in the next hardware generation, right?
Let's hope so. Chris has a better crystal ball than I have ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2017-05-12 11:11 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 8:19 [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Jacopo Mondi
2017-04-27 14:56 ` Andy Shevchenko
2017-04-28 8:32 ` Linus Walleij
2017-04-28 10:09 ` Geert Uytterhoeven
2017-05-07 7:50 ` Linus Walleij
2017-04-28 12:07 ` Chris Brandt
2017-04-28 12:15 ` Andy Shevchenko
2017-04-28 13:18 ` Chris Brandt
2017-04-28 14:53 ` Andy Shevchenko
2017-04-28 15:16 ` Chris Brandt
2017-04-28 15:37 ` Andy Shevchenko
2017-04-28 16:46 ` Chris Brandt
2017-05-07 7:52 ` Linus Walleij
2017-05-08 16:01 ` jmondi
2017-05-08 16:08 ` Andy Shevchenko
2017-05-08 17:02 ` Chris Brandt
2017-05-08 18:26 ` Andy Shevchenko
2017-05-08 20:05 ` Chris Brandt
2017-05-08 17:25 ` jmondi
2017-05-08 17:47 ` Andy Shevchenko
2017-05-09 9:55 ` jmondi
2017-05-08 21:19 ` Linus Walleij
2017-05-09 10:54 ` Geert Uytterhoeven
2017-05-12 9:00 ` Linus Walleij
2017-05-12 9:04 ` Linus Walleij
2017-05-12 11:11 ` Geert Uytterhoeven [this message]
2017-05-12 12:13 ` Chris Brandt
2017-05-12 12:25 ` Geert Uytterhoeven
2017-05-12 12:57 ` Chris Brandt
2017-05-12 11:44 ` Chris Brandt
2017-05-23 10:08 ` Dong Aisheng
2017-05-23 18:37 ` jmondi
2017-05-29 8:45 ` Linus Walleij
2017-05-29 10:42 ` jmondi
2017-05-30 14:12 ` Chris Brandt
2017-06-09 7:26 ` Dong Aisheng
2017-06-09 7:50 ` jmondi
2017-06-11 21:45 ` Linus Walleij
2017-06-12 9:44 ` jmondi
2017-06-13 6:25 ` Dong Aisheng
2017-06-15 11:11 ` jmondi
2017-06-19 15:43 ` Dong Aisheng
2017-04-27 8:19 ` [PATCH v5 02/10] pinctrl: generic: Add macros to unpack properties Jacopo Mondi
2017-04-27 8:37 ` Geert Uytterhoeven
2017-04-28 8:16 ` Linus Walleij
2017-04-28 10:06 ` Geert Uytterhoeven
2017-04-28 12:49 ` jmondi
2017-04-28 16:23 ` Andy Shevchenko
2017-04-27 8:19 ` [PATCH v5 03/10] pinctrl: Renesas RZ/A1 pin and gpio controller Jacopo Mondi
2017-04-27 8:37 ` Geert Uytterhoeven
2017-04-27 8:19 ` [PATCH v5 04/10] dt-bindings: pinctrl: Add RZ/A1 bindings doc Jacopo Mondi
2017-04-27 8:37 ` Geert Uytterhoeven
2017-04-28 21:03 ` Rob Herring
2017-04-27 8:19 ` [PATCH v5 05/10] arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header Jacopo Mondi
2017-04-27 8:38 ` Geert Uytterhoeven
2017-04-28 5:19 ` Simon Horman
2017-04-27 8:19 ` [PATCH v5 06/10] arm: dts: r7s72100: Add pin controller node Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 07/10] arm: dts: genmai: Add SCIF2 pin group Jacopo Mondi
2017-04-28 5:21 ` Simon Horman
2017-04-27 8:19 ` [PATCH v5 08/10] arm: dts: genmai: Add RIIC2 " Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 09/10] arm: dts: genmai: Add user led device nodes Jacopo Mondi
2017-04-27 8:19 ` [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group Jacopo Mondi
2017-04-27 9:56 ` Geert Uytterhoeven
2017-04-27 10:48 ` Chris Brandt
2017-04-28 5:22 ` Simon Horman
2017-04-28 7:18 ` Geert Uytterhoeven
2017-04-28 14:48 ` Chris Brandt
2017-05-05 12:06 ` Linus Walleij
2017-05-05 12:20 ` Geert Uytterhoeven
2017-05-05 12:45 ` Chris Brandt
2017-05-11 13:48 ` Linus Walleij
2017-04-28 8:49 ` Linus Walleij
2017-04-28 13:50 ` Chris Brandt
2017-04-27 8:42 ` [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller Geert Uytterhoeven
2017-04-28 5:22 ` Simon Horman
2017-04-28 7:24 ` jmondi
2017-04-28 7:30 ` Geert Uytterhoeven
2017-04-28 7:31 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdXK7YB2zN4fz9XiqTuydxp7VvVV+wSgXWUYBB0evkp8dw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=Chris.Brandt@renesas.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jacopo+renesas@jmondi.org \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).