From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Mario Limonciello <mario_limonciello@dell.com>,
Matthew Garrett <matthew.garrett@nebula.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Jason Ekstrand" <jason@jlekstrand.net>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Rob <robr.bensson@gmail.com>
Subject: Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.
Date: Mon, 16 Mar 2015 10:40:07 -0400 [thread overview]
Message-ID: <CAN+gG=HKGOc72RXTDefGJuHy=YTKQ_ZP3ux57_d-WyrbO-rH9w@mail.gmail.com> (raw)
In-Reply-To: <5506E8D2.60207@dell.com>
On Mon, Mar 16, 2015 at 10:29 AM, Mario Limonciello
<mario_limonciello@dell.com> wrote:
>
> On 03/14/2015 02:17 PM, Benjamin Tissoires wrote:
>>
>> [top posting, sorry]
>>
>> Jason made some interesting progress today:
>> with the patch in https://lkml.org/lkml/2015/3/12/149, the sound card
>> is not switched in the I2S mode and works while the touchpad keeps
>> using I2C.
>> It looks like suspend/resume is also fixed by that :)
>>
>> I thought it was worth mentioning to the people in this thread.
>>
>> Cheers,
>> Benjamin
>
> Benjamin,
>
> Thanks for reporting the progress to me.
>
> Jason,
>
> Are you sure upon the particulars of what's happening here? That patch only
> modifies the behavior of how the EC is configured.
> I'm not aware of any suspend/resume issues, especially related to the EC, so
> that really surprises me. My initial suspicion is a suspend/resume issue
> you encountered was rare enough that you just haven't hit it yet even with
> that patch applied. Maybe something in the out of kernel Broadcom wireless
> driver if you are still using the Broadcom card with it.
>
> I believe you are incorrect in the audio being put in HDA mode. It's more
> likely that it's operating closer to properly in I2S mode. Here's some
> background around what that patch is doing.
Regarding the I2S/HDA problem, I guess I must have interpreted too
much what Jason said. All he said was that the patch made his sound
card working.
[Adding Matthew to the thread, I am sure he will find it interesting]
Cheers,
Benjamin
> When this platform started development the Linux kernel didn't yet respond
> true to Windows 2013. All our validation for Linux happened on kernel 3.13.
>
> _OSI of Windows 2009 is supposed to set it for PS2 mouse, HDA device in ACPI
> and configure the EC to set up the Realtek codec for HDA mode. Linux was
> planned to mirror this behavior during development.
> _OSI of Windows 2013 is supposed to set it up for I2C mouse, I2S audio in
> ACPI and configure the EC to set up the Realtek codec for I2S mode.
>
> From when the platform was in development a _REV check was put in for
> Windows 2013 to make sure that in case the kernel started to respond to
> Windows 2013 we would still have it running in the intended modes for Linux.
> There was a mistake in this _REV check though that caused the I2S ACPI
> device but to misconfigure the EC. The reason _REV = 2 and _OSI = Windows
> 2013 you are getting working audio is the rt286 driver is starting to be
> used. You can validate this by looking at dmesg for lines about rt286.
> Realtek recently submitted some patches for this at Dell's request. There
> are still a variety of issues with the I2S driver including jack detection
> and some other microphone issues. Pulseaudio will possibly need some
> patches to work properly with this device too. Ideally we don't want
> customers to use I2S mode on Linux until it's solid.
>
> I don't believe this was in Linus' tree yet, so if you don't have it you can
> apply it and it should fix at least one microphone issue when in I2S mode.
> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-March/088724.html
>
> Whether or not that _REV patch gets applied to the kernel we are fixing this
> incorrect behavior for Windows 2013 _OSI and Linux in upcoming BIOS A02.
> In BIOS A02 there will still be a _REV check but it will do this:
> Windows 2013 _OSI, _REV 5: I2C mouse, HDA device in ACPI, configure EC for
> HDA mode.
> Windows 2013 _OSI, _REV 2: I2C mouse, I2S device in ACPI, configure EC for
> I2S mode.
>
>
>
next prev parent reply other threads:[~2015-03-16 14:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 1:43 [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode Mario Limonciello
2015-02-19 17:16 ` Dmitry Torokhov
2015-02-19 18:16 ` Mario Limonciello
2015-02-20 18:47 ` Dmitry Torokhov
2015-02-20 19:24 ` Pali Rohár
2015-02-20 19:56 ` Mario Limonciello
2015-02-20 20:41 ` Pali Rohár
2015-02-20 21:21 ` Mario Limonciello
2015-02-20 21:31 ` Benjamin Tissoires
2015-02-20 21:40 ` Mario Limonciello
2015-02-20 21:46 ` Pali Rohár
2015-02-20 21:54 ` Mario Limonciello
2015-02-22 16:55 ` Pali Rohár
2015-02-23 23:31 ` Mario Limonciello
2015-02-24 0:01 ` Pali Rohár
2015-02-25 18:16 ` [SUSPECT SPAM] " Mario Limonciello
2015-02-24 0:51 ` Dmitry Torokhov
2015-02-25 18:26 ` Mario Limonciello
2015-02-25 18:48 ` Mario Limonciello
2015-02-25 20:45 ` Pali Rohár
2015-03-14 19:17 ` Benjamin Tissoires
2015-03-16 14:29 ` Mario Limonciello
2015-03-16 14:40 ` Benjamin Tissoires [this message]
2015-03-16 17:10 ` Jason Ekstrand
2015-03-16 18:50 ` Mario Limonciello
2015-03-16 20:42 ` Jason Ekstrand
2015-03-16 20:50 ` Mario Limonciello
2015-03-16 20:57 ` Jason Ekstrand
2015-03-16 21:07 ` Benjamin Tissoires
2015-03-17 0:45 ` Mario Limonciello
2015-04-10 22:39 ` Pali Rohár
2015-04-10 23:07 ` Mario Limonciello
2015-04-10 23:14 ` Pali Rohár
2015-04-10 23:32 ` Mario Limonciello
2015-04-11 2:19 ` Ben Gamari
2015-04-13 18:55 ` Mario Limonciello
2015-03-21 17:21 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN+gG=HKGOc72RXTDefGJuHy=YTKQ_ZP3ux57_d-WyrbO-rH9w@mail.gmail.com' \
--to=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jason@jlekstrand.net \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario_limonciello@dell.com \
--cc=matthew.garrett@nebula.com \
--cc=pali.rohar@gmail.com \
--cc=robr.bensson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).