linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@gmail.com>
To: Jason Ekstrand <jason@jlekstrand.net>
Cc: "Mario Limonciello" <mario_limonciello@dell.com>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
	Rob <robr.bensson@gmail.com>
Subject: Re: [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode.
Date: Mon, 16 Mar 2015 17:07:09 -0400	[thread overview]
Message-ID: <CAN+gG=Hg7u27PXryAt37+dgvwr4SHG9Bf_woNNxd7=nQVvZDAA@mail.gmail.com> (raw)
In-Reply-To: <CAOFGe94xt0i-if+SP3Y7EtQ+0TkW4i41SXV1g3RyRQZW+ssDDg@mail.gmail.com>

On Mon, Mar 16, 2015 at 4:57 PM, Jason Ekstrand <jason@jlekstrand.net> wrote:
> On Mon, Mar 16, 2015 at 1:50 PM, Mario Limonciello
> <mario_limonciello@dell.com> wrote:
>>
>> On 03/16/2015 03:42 PM, Jason Ekstrand wrote:
>>>
>>> On Mon, Mar 16, 2015 at 11:50 AM, Mario Limonciello
>>> <mario_limonciello@dell.com> wrote:
>>> Thanks,
>>> I'm now running a hacked up kernel that's Torvalds' tree from Saturday
>>> morning (same as before) + a patch from Benjamin to fix the touchpad +
>>> the DSDT hack given above.  With that, I have HDA audio (not I2S)
>>> which is working.  Also, suspend/resume now works properly with this
>>> new cocktail.
>>> --Jason
>>
>> That's great to hear and definitely confirms that it was the sound card in
>> the funky state causing the suspend/resume issues.  Testing is ongoing with
>> that BIOS and if no issues crop up should be around soon.
>
> Thanks!  I look forwarding to *not* running a hacked-up kernel soon.
>
>> Is this the patch from Benjamin that you're running?
>> http://pkgs.fedoraproject.org/cgit/kernel.git/commit/?h=f21&id=d75cb059558345e47a13881512a1600e3e17ba21
>> I haven't yet run it myself.  I'm curious, what sort of behavior change do
>> you see with it?
>
> It reports as touchpad with a single button.  This makes the kernel
> report it as a "clickpad".  In particular, this means that libinput
> knows to make clicking in the lower-right turn into a right-click.
> With out that, there was no way to right-click since it reports as
> having a single button.  Benjamin could tell you more than me.

Yes, that's the gist of it.
Mario, you might not have seen the problem because you are not running
wayland and/or libinput. The xorg synaptics driver is much more
relaxed concerning what it received from the kernel and I think it
sets most of the time the right software button area if it sees only
one button.

Cheers,
Benjamin

  reply	other threads:[~2015-03-16 21:07 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19  1:43 [PATCH] Add a quirk for the Dell XPS 13 (2015) when in PS/2 mode Mario Limonciello
2015-02-19 17:16 ` Dmitry Torokhov
2015-02-19 18:16   ` Mario Limonciello
2015-02-20 18:47     ` Dmitry Torokhov
2015-02-20 19:24       ` Pali Rohár
2015-02-20 19:56         ` Mario Limonciello
2015-02-20 20:41           ` Pali Rohár
2015-02-20 21:21             ` Mario Limonciello
2015-02-20 21:31               ` Benjamin Tissoires
2015-02-20 21:40                 ` Mario Limonciello
2015-02-20 21:46                   ` Pali Rohár
2015-02-20 21:54                     ` Mario Limonciello
2015-02-22 16:55               ` Pali Rohár
2015-02-23 23:31                 ` Mario Limonciello
2015-02-24  0:01                   ` Pali Rohár
2015-02-25 18:16                     ` [SUSPECT SPAM] " Mario Limonciello
2015-02-24  0:51                 ` Dmitry Torokhov
2015-02-25 18:26                   ` Mario Limonciello
2015-02-25 18:48             ` Mario Limonciello
2015-02-25 20:45               ` Pali Rohár
2015-03-14 19:17                 ` Benjamin Tissoires
2015-03-16 14:29                   ` Mario Limonciello
2015-03-16 14:40                     ` Benjamin Tissoires
2015-03-16 17:10                     ` Jason Ekstrand
2015-03-16 18:50                       ` Mario Limonciello
2015-03-16 20:42                         ` Jason Ekstrand
2015-03-16 20:50                           ` Mario Limonciello
2015-03-16 20:57                             ` Jason Ekstrand
2015-03-16 21:07                               ` Benjamin Tissoires [this message]
2015-03-17  0:45                                 ` Mario Limonciello
2015-04-10 22:39                 ` Pali Rohár
2015-04-10 23:07                   ` Mario Limonciello
2015-04-10 23:14                     ` Pali Rohár
2015-04-10 23:32                       ` Mario Limonciello
2015-04-11  2:19                         ` Ben Gamari
2015-04-13 18:55                           ` Mario Limonciello
2015-03-21 17:21           ` Ben Gamari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN+gG=Hg7u27PXryAt37+dgvwr4SHG9Bf_woNNxd7=nQVvZDAA@mail.gmail.com' \
    --to=benjamin.tissoires@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jason@jlekstrand.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=pali.rohar@gmail.com \
    --cc=robr.bensson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).